[jira] [Commented] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831013#comment-17831013 ] Jacques Le Roux commented on OFBIZ-12962: - There is something I was wondering about. When you create a Java Class you need to have the same name for the file. But with the way we use Groovy (scripts), as so far we declare no classes, there is not this problem. > Convert PeriodServices.xml mini-lang to groovyDSL > - > > Key: OFBIZ-12962 > URL: https://issues.apache.org/jira/browse/OFBIZ-12962 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Jacques Le Roux >Priority: Minor > Labels: groovy, mini-lang > Fix For: Upcoming Branch > > > Migration of file PeriodServices.xml to groovy with service : > * findCustomTimePeriods > * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830921#comment-17830921 ] Nicolas Malin commented on OFBIZ-12962: --- Oh thanks Jacques for your fix ! > Convert PeriodServices.xml mini-lang to groovyDSL > - > > Key: OFBIZ-12962 > URL: https://issues.apache.org/jira/browse/OFBIZ-12962 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Jacques Le Roux >Priority: Minor > Labels: groovy, mini-lang > > Migration of file PeriodServices.xml to groovy with service : > * findCustomTimePeriods > * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830892#comment-17830892 ] ASF subversion and git services commented on OFBIZ-12962: - Commit 62ebc55ac0df605b7af08b79491438dfa73cef4e in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=62ebc55ac0 ] Fixed: Convert PeriodServices.xml mini lang to groovy (OFBIZ-12962) We have a Gradle redundant classes clash Because there is already a PeriodServices Java class and we compile also Groovy we can't create a PeriodServices.groovy class as pointed by GH actions, and clearly by BB https://ci2.apache.org/#/builders/49/builds/826/steps/2/logs/stdio Caused by: org.gradle.api.InvalidUserCodeException: Entry org/apache/ofbiz/accounting/period/PeriodServices.class is a duplicate but no duplicate handling strategy has been set. This is a workaround. We can use a better name for GPeriodServices.groovy And maybe use a duplicate handling strategy (complicated?) > Convert PeriodServices.xml mini-lang to groovyDSL > - > > Key: OFBIZ-12962 > URL: https://issues.apache.org/jira/browse/OFBIZ-12962 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Jacques Le Roux >Priority: Minor > Labels: groovy, mini-lang > > Migration of file PeriodServices.xml to groovy with service : > * findCustomTimePeriods > * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830835#comment-17830835 ] ASF subversion and git services commented on OFBIZ-12962: - Commit 0c24cb12bd973bc52d45206d210f34e6fe208da6 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0c24cb12bd ] Improved: Convert PeriodServices.xml mini lang to groovy (OFBIZ-12962) Finish to convert PeriodServices.xml with migrate service : * findCustomTimePeriods * getPreviousTimePeriod > Convert PeriodServices.xml mini-lang to groovyDSL > - > > Key: OFBIZ-12962 > URL: https://issues.apache.org/jira/browse/OFBIZ-12962 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > > Migration of file PeriodServices.xml to groovy with service : > * findCustomTimePeriods > * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
