[jira] [Commented] (OFBIZ-3894) Refactor Email handling
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267620#comment-16267620 ] Nicolas Malin commented on OFBIZ-3894: -- [~swapnilmmane] I agree with you proposal > Refactor Email handling > --- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: BJ Freeman >Assignee: Swapnil M Mane >Priority: Minor > Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch, > OFBIZ-3894.patch > > Original Estimate: 1,344h > Remaining Estimate: 1,344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order > component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger > project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-3894) Refactor Email handling
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265730#comment-16265730 ] Jacques Le Roux commented on OFBIZ-3894: Thanks Pierre for the reminder on http://ofbiz.markmail.org/search/?q=lifespan%20field which remembers me my conclusion at bottom of http://markmail.org/message/pqrmv5vpjgm6iigq > Refactor Email handling > --- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: BJ Freeman >Assignee: Swapnil M Mane >Priority: Minor > Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch, > OFBIZ-3894.patch > > Original Estimate: 1,344h > Remaining Estimate: 1,344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order > component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger > project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-3894) Refactor Email handling
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265707#comment-16265707 ] Swapnil M Mane commented on OFBIZ-3894: --- Thank you [~pfm.smits]! :-) > Refactor Email handling > --- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: BJ Freeman >Assignee: Erwan de FERRIERES >Priority: Minor > Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch, > OFBIZ-3894.patch > > Original Estimate: 1,344h > Remaining Estimate: 1,344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order > component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger > project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-3894) Refactor Email handling
[
https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265685#comment-16265685
]
Pierre Smits commented on OFBIZ-3894:
-
HI [~swapnilmmane], all,
All good suggestions.
{quote}I would suggest, we should go in baby steps for implementing this by
creating sub tickets. This will be helpful for reviewing and reduce the chances
of breaking anything.
We can follow proceed with these steps{quote}
Baby steps can be initiated, traced, and concluded through sub-tasks.
{quote}1.) Entity related changes
Update the existing entities by adding new required attributes.
(We will remove the unused fields in the 4rth step){quote}
Per entity a list of (intended) additions, and a list of (intended) removals
will help regarding communications about future release plans, releases,
impact, etc.
{quote}e.g. ProductStoreEmailSetting will have following more attributes
emailTemplateSettingId
fromDate
thruDate
{quote}
The discussion on adding lifespan fields (fromDate and thruDate) to various
entities was already started back in January /2015. It is good to see that it
is still alive. See:
* http://ofbiz.markmail.org/search/?q=lifespan%20field
* https://issues.apache.org/jira/issues/?jql=text%20~%20%22lifespan%22
{quote}4.) Will remove the unused fields from the entity. {quote}
See my comment regarding the quote #1
{quote}5.) Document the migration steps.{quote}
Great to see that this is an integral part of the total implementation. Would
love to see that in place, before mere entity and code changes are released to
adopters.
> Refactor Email handling
> ---
>
> Key: OFBIZ-3894
> URL: https://issues.apache.org/jira/browse/OFBIZ-3894
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: BJ Freeman
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch,
> OFBIZ-3894.patch
>
> Original Estimate: 1,344h
> Remaining Estimate: 1,344h
>
> with the addition of the Website for each component
> 1) create product store for Order entry, or use the B2C product store.
> 2) move the email widgets from ecommerce to order compontent.
> 3) modify the seed data so that Order entry has it own emails from order
> component.this would be to add emails to
> note: as I go through the different items this is turning out to be a bigger
> project than I first anticipated.
> so consider this so far just ideas.
> Maybe break down in to small tasks as I have time to do something.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-3894) Refactor Email handling
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265669#comment-16265669 ] Michael Brohl commented on OFBIZ-3894: -- Hi folks, thanks for your work on this. For better review, can someone please lay out the complete new mechanism/changes? From the past discussions, I'm not sure what the final plan will be. Thanks and regards, Michael > Refactor Email handling > --- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: BJ Freeman >Assignee: Erwan de FERRIERES >Priority: Minor > Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch, > OFBIZ-3894.patch > > Original Estimate: 1,344h > Remaining Estimate: 1,344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order > component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger > project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-3894) Refactor Email handling
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265653#comment-16265653 ] Swapnil M Mane commented on OFBIZ-3894: --- Thanks gentlemen for such a nice discussion and [~soledad] for the patch (very good work) I would suggest, we should go in baby steps for implementing this by creating sub tickets. This will be helpful for reviewing and reduce the chances of breaking anything. We can follow proceed with these steps 1.) Entity related changes Update the existing entities by adding new required attributes. (We will remove the unused fields in the 4rth step) e.g. ProductStoreEmailSetting will have following more attributes emailTemplateSettingId fromDate thruDate 2.) Create the new screens to manage the product store's mail setting as per our new model. 3.) Update the all the send mail services to honor our new model. 4.) Will remove the unused fields from the entity. 5.) Document the migration steps. The plan is first we will prepare all the things required for our implementation, which will not break anything. Then finally improve the send mail services code. Please let me know your thoughts this. Thanks! > Refactor Email handling > --- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: BJ Freeman >Assignee: Erwan de FERRIERES >Priority: Minor > Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch, > OFBIZ-3894.patch > > Original Estimate: 1,344h > Remaining Estimate: 1,344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order > component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger > project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
