[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071649#comment-17071649
]
Jacques Le Roux commented on OFBIZ-5426:
Thanks Guys!
> mysql: ERROR 1071 (42000): Specified key
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071180#comment-17071180
]
ASF subversion and git services commented on OFBIZ-5426:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071179#comment-17071179
]
ASF subversion and git services commented on OFBIZ-5426:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069327#comment-17069327
]
Pawan Verma commented on OFBIZ-5426:
Hello [~deepak]
Created a new PR for the suggested changes.
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064738#comment-17064738
]
Deepak Dixit commented on OFBIZ-5426:
-
Hi [~pawan],
Could you please update the
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064736#comment-17064736
]
ASF subversion and git services commented on OFBIZ-5426:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064735#comment-17064735
]
ASF subversion and git services commented on OFBIZ-5426:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064734#comment-17064734
]
ASF subversion and git services commented on OFBIZ-5426:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051818#comment-17051818
]
Pawan Verma commented on OFBIZ-5426:
I have created a new
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051334#comment-17051334
]
Pierre Smits commented on OFBIZ-5426:
-
@deepak,
I presume the PR tested successfully (without
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051322#comment-17051322
]
Deepak Dixit commented on OFBIZ-5426:
-
Hi [~pierresmits]
I added comments on PR, they are minor
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051315#comment-17051315
]
Pierre Smits commented on OFBIZ-5426:
-
Hi [~pawan], [~deepak],
Is there still something wrong with
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042477#comment-17042477
]
Pawan Verma commented on OFBIZ-5426:
I've created a
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036838#comment-17036838
]
Pawan Verma commented on OFBIZ-5426:
[^OFBIZ-5426.patch]
Thanks, [~pgil] for the review. I've
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036258#comment-17036258
]
Gil Portenseigne commented on OFBIZ-5426:
-
Hello [~pawan],
{{Please use :}}
{{ ./gradlew
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036244#comment-17036244
]
Pierre Smits commented on OFBIZ-5426:
-
Hi [~pawan],
Is this patch also somewhere implemented in a
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036240#comment-17036240
]
Pawan Verma commented on OFBIZ-5426:
Attached patch with the changes suggested by Deepak. Please have
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035397#comment-17035397
]
Pierre Smits commented on OFBIZ-5426:
-
It seems to me that, given that this ticket was created in
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035376#comment-17035376
]
Jacques Le Roux commented on OFBIZ-5426:
Looking forward :)
> mysql: ERROR 1071 (42000):
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035355#comment-17035355
]
Pawan Verma commented on OFBIZ-5426:
Again, Sorry Jacques, Will look into it this week only :)
>
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029035#comment-17029035
]
Jacques Le Roux commented on OFBIZ-5426:
Sorry Pawan to remind this you again :)
> mysql: ERROR
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929141#comment-16929141
]
Pawan Verma commented on OFBIZ-5426:
Hey [~jacques.le.roux],
Ahh, I forgot about this, I will have a
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929119#comment-16929119
]
Jacques Le Roux commented on OFBIZ-5426:
Hi Pawan,
Any chances with this?
> mysql: ERROR 1071
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827586#comment-16827586
]
Deepak Dixit commented on OFBIZ-5426:
-
Hi Pawan,
Your patch looks good to me, only one suggestion, I
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817650#comment-16817650
]
Jacques Le Roux commented on OFBIZ-5426:
Thanks Pawan,
Oh, it was not an inconvenience for me to
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817594#comment-16817594
]
Pawan Verma commented on OFBIZ-5426:
Thanks, [~jacques.le.roux] for the review and apology for the
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817015#comment-16817015
]
Jacques Le Roux commented on OFBIZ-5426:
Ah forgot to mention: please respect the 120 chars max
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817014#comment-16817014
]
Jacques Le Roux commented on OFBIZ-5426:
Thanks Pawan,
I reviewed and the patch looks good to
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815224#comment-16815224
]
Pawan Verma commented on OFBIZ-5426:
Attaching patch for the task.
Patch contains:
# Entity Name
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805845#comment-16805845
]
Pawan Verma commented on OFBIZ-5426:
I am working on this task. Will follow the defined best practice
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544950#comment-16544950
]
Jacques Le Roux commented on OFBIZ-5426:
Hi Deepak,
You wrote
bq. I think we can rename entity
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544278#comment-16544278
]
Jacques Le Roux commented on OFBIZ-5426:
Thanks Deepak,
Sounds good to me at 1st glance
>
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544206#comment-16544206
]
Deepak Dixit commented on OFBIZ-5426:
-
Attaching patch for reference. Still, data migration service
[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544205#comment-16544205
]
Deepak Dixit commented on OFBIZ-5426:
-
I think we can rename entity to ProductPromoCodeContactMech as
34 matches
Mail list logo