[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071649#comment-17071649
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Thanks Guys!

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071180#comment-17071180
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 3b86754e141a97076b0bf3fe84ef10f18d74c00d in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b86754 ]

Improved: Added new data model changes done under OFBIZ-5426 in DataModel 
changes file. (#55)

(OFBIZ-5426)

Thanks, Deepak Dixit for the report.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071179#comment-17071179
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 3b86754e141a97076b0bf3fe84ef10f18d74c00d in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b86754 ]

Improved: Added new data model changes done under OFBIZ-5426 in DataModel 
changes file. (#55)

(OFBIZ-5426)

Thanks, Deepak Dixit for the report.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-28 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069327#comment-17069327
 ] 

Pawan Verma commented on OFBIZ-5426:


Hello [~deepak]

Created a new PR for the suggested changes. Here: 
[https://github.com/apache/ofbiz-framework/pull/55]

If it looks good, we can merge it and close the ticket as well. Thanks!

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-23 Thread Deepak Dixit (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064738#comment-17064738
 ] 

Deepak Dixit commented on OFBIZ-5426:
-

Hi [~pawan],

Could you please update the `applications/datamodel/DATAMODEL_CHANGES.md` file 
as well?

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064736#comment-17064736
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 91673f1b419b8e87552ddc692ae904fd28cd29d4 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=91673f1 ]

Fixed: Specified key was too long; max key length is 767 bytes for 
ProductPromoCodeEmail entity.(OFBIZ-5426) (#44)

* Fixed: Specified key was too long; max key length is 767 bytes for 
ProductPromoCodeEmail entity.
(OFBIZ-5426)

The problem is in the entity model. An email address should not be used in the 
primary key - mainly because an email address is case-insensitive. A better 
design would be to use the email address contact mechanism ID in the primary 
key.

Done Following:
1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech
2. Related Changes for the entity name change
3. Migration service to migrate old data

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, 
Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.

* Improved: Added new line in service definition file and lincence in 
MigrationServices file.
(OFBIZ-5426)

Thanks, Jacopo for the review.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064735#comment-17064735
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 91673f1b419b8e87552ddc692ae904fd28cd29d4 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=91673f1 ]

Fixed: Specified key was too long; max key length is 767 bytes for 
ProductPromoCodeEmail entity.(OFBIZ-5426) (#44)

* Fixed: Specified key was too long; max key length is 767 bytes for 
ProductPromoCodeEmail entity.
(OFBIZ-5426)

The problem is in the entity model. An email address should not be used in the 
primary key - mainly because an email address is case-insensitive. A better 
design would be to use the email address contact mechanism ID in the primary 
key.

Done Following:
1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech
2. Related Changes for the entity name change
3. Migration service to migrate old data

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, 
Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.

* Improved: Added new line in service definition file and lincence in 
MigrationServices file.
(OFBIZ-5426)

Thanks, Jacopo for the review.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064734#comment-17064734
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 91673f1b419b8e87552ddc692ae904fd28cd29d4 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=91673f1 ]

Fixed: Specified key was too long; max key length is 767 bytes for 
ProductPromoCodeEmail entity.(OFBIZ-5426) (#44)

* Fixed: Specified key was too long; max key length is 767 bytes for 
ProductPromoCodeEmail entity.
(OFBIZ-5426)

The problem is in the entity model. An email address should not be used in the 
primary key - mainly because an email address is case-insensitive. A better 
design would be to use the email address contact mechanism ID in the primary 
key.

Done Following:
1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech
2. Related Changes for the entity name change
3. Migration service to migrate old data

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, 
Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.

* Improved: Added new line in service definition file and lincence in 
MigrationServices file.
(OFBIZ-5426)

Thanks, Jacopo for the review.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-04 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051818#comment-17051818
 ] 

Pawan Verma commented on OFBIZ-5426:


I have created a new 
[PR|[https://github.com/apache/ofbiz-framework/pull/44/files]] with suggested 
changes, Please have a look! 

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-04 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051334#comment-17051334
 ] 

Pierre Smits commented on OFBIZ-5426:
-

@deepak,

I presume the PR tested successfully (without flaws)... If so, current PR 
should be *good enough* to have it merged. And the suggestion can be taken into 
account the next time around.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-04 Thread Deepak Dixit (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051322#comment-17051322
 ] 

Deepak Dixit commented on OFBIZ-5426:
-

Hi [~pierresmits]

I added comments on PR, they are minor improvement.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-04 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051315#comment-17051315
 ] 

Pierre Smits commented on OFBIZ-5426:
-

Hi [~pawan], [~deepak],

Is there still something wrong with the PR that prevents it from being 
incorporated/merged into the repo?

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-22 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042477#comment-17042477
 ] 

Pawan Verma commented on OFBIZ-5426:


I've created a [PR|[https://github.com/apache/ofbiz-framework/pull/21]]

[~deepak], Please have a look when you get a chance. Thanks!

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-14 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036838#comment-17036838
 ] 

Pawan Verma commented on OFBIZ-5426:


[^OFBIZ-5426.patch]

Thanks, [~pgil] for the review. I've updated the patch.

[~pierresmits], Yes, I'll create a git PR soon.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-13 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036258#comment-17036258
 ] 

Gil Portenseigne commented on OFBIZ-5426:
-

Hello [~pawan],

{{Please use :}}

{{ ./gradlew checkstyleMain}}

{{to detect style warnings of your added code, i see some 120+ lines length in 
java.}}

{{There is also unused import : HashedMap}}

{{Thanks for the work}}

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036244#comment-17036244
 ] 

Pierre Smits commented on OFBIZ-5426:
-

Hi [~pawan],

Is this patch also somewhere implemented in a development/feature branch in a 
publicly available git repo (e.g. on Github)?

If so, it may be beneficial to fellow community members to use that for review 
(and other collaboration) purposes. And if everything checks out, the project 
can/may decide to use a pull request to establish an officially endorsed 'OFBiz 
feature branch' to make it available to the entire community, or directly merge 
it into another branch (trunk and or release branch).

IMO, providing enhancement contributions (bug fixes, improvements and new 
features) through development branches in public git repos is more favourable 
as it leverages key feature(s) of git.

It avoids you to upload additional enhancements to the solution to this 
tickets, but also to have reviewing community members to download these 
enhancements  and apply them to their review branch.

See 
also:https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=145724011

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-13 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036240#comment-17036240
 ] 

Pawan Verma commented on OFBIZ-5426:


Attached patch with the changes suggested by Deepak. Please have a look, thanks!

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-12 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035397#comment-17035397
 ] 

Pierre Smits commented on OFBIZ-5426:
-

It seems to me that, given that this ticket was created in 2013, it is 
applicable to the active release branches (as well as past release branches and 
releases). The 'Affects Version(s) field should reflect that, as this 
information is not only valuable to contributors, but also adopters working 
with implementations on those (past) branches and releases.

See also: 
https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+For+Using+JIRA

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-12 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035376#comment-17035376
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Looking forward :)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-12 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035355#comment-17035355
 ] 

Pawan Verma commented on OFBIZ-5426:


Again, Sorry Jacques, Will look into it this week only :)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-02-03 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029035#comment-17029035
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Sorry Pawan to remind this you again :)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-09-13 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929141#comment-16929141
 ] 

Pawan Verma commented on OFBIZ-5426:


Hey [~jacques.le.roux],

Ahh, I forgot about this, I will have a look shortly :)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-09-13 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929119#comment-16929119
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Hi Pawan,

Any chances with this?

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-04-27 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827586#comment-16827586
 ] 

Deepak Dixit commented on OFBIZ-5426:
-

Hi Pawan,

Your patch looks good to me, only one suggestion, I think we can remove the 
createProductPromoCodeEmail this is not used anywhere in the code. 
We can mark this service as deprecated 

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-04-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817650#comment-16817650
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Thanks Pawan,

Oh, it was not an inconvenience for me to review, just to keep our code aligned 
on the rules :)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-04-15 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817594#comment-16817594
 ] 

Pawan Verma commented on OFBIZ-5426:


Thanks, [~jacques.le.roux] for the review and apology for the inconvenience. I 
have updated patch. Thanks! 

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-04-13 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817015#comment-16817015
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Ah forgot to mention: please respect the 120 chars max per line rule in Java 
files ;)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-04-13 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817014#comment-16817014
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Thanks Pawan,

I reviewed and the patch looks good to me: +1

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-04-11 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815224#comment-16815224
 ] 

Pawan Verma commented on OFBIZ-5426:


Attaching patch for the task. 

Patch contains:
 # Entity Name change
 # Related Changes for the entity name change
 # Migration service

I will update the Migration document when the changes committed into the 
repository.

Please let me know if any modification or correction is needed.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2019-03-30 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805845#comment-16805845
 ] 

Pawan Verma commented on OFBIZ-5426:


I am working on this task. Will follow the defined best practice for Rename 
Entity, proper detail in document and migration service for migration. Will add 
updated patch soon. Thanks!

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2018-07-16 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544950#comment-16544950
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Hi Deepak,

You wrote
bq. I think we can rename entity to ProductPromoCodeContactMech as well. 
Yes, why not?

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2018-07-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544278#comment-16544278
 ] 

Jacques Le Roux commented on OFBIZ-5426:


Thanks Deepak,

Sounds good to me at 1st glance

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2018-07-14 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544206#comment-16544206
 ] 

Deepak Dixit commented on OFBIZ-5426:
-

Attaching patch for reference. Still, data migration service is pending. Will 
update patch soon. 
In this patch, I did not change the entity name, only updated the fieldname and 
made changes accordingly. 



> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2018-07-14 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544205#comment-16544205
 ] 

Deepak Dixit commented on OFBIZ-5426:
-

I think we can rename entity to ProductPromoCodeContactMech as well. 

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)