[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739795#comment-15739795
]
Jacques Le Roux commented on OFBIZ-8203:
Thanks Florian, I confirm this behaviour. Since this works, now there are 2
possibilities.
* We fix all the existing cases by adding missing value-field values
* We no longer make the value-field attribute required and document this
possibility in the XSD
Both solutions are easy and can be done one after the other. I'd prefer the 2nd
because having a default value is always welcome (conventions over
configuration). But because of consistency, I'd have to check that entity-one
in Minilang behaves the same. If it does not then there are again 2
possibilities.
* We only fix all the existing cases by adding missing value-field values in
widgets actions
* After doing the 2nd point above we also make the value-field attribute no
longer required and document this possibility in the XSD.
Since I don't know what doing the same in Minilang entails. I'll simply doing
the 1s point and will ask the community what they think about it.
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477059#comment-15477059
]
Montalbano Florian commented on OFBIZ-8203:
---
>From what I saw, the attributes were put directly in the context map. For
>example, I tried to entity-one a WorkEffort from an chosen workEffortId and I
>could retrieve information about the result with ${context.workEffortId} or
>${context.workEffortName} (from a form).
So it is not put in some map named with the entity name.
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477018#comment-15477018
]
Jacques Le Roux commented on OFBIZ-8203:
bq. but the result is put directly in the context map
You mean as you suggested above with the entity name, Capitalised?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476506#comment-15476506
]
Montalbano Florian commented on OFBIZ-8203:
---
So, it somehow works without value-field but the result is put directly in the
context map (Stack 2 ?).
It seems to be an non-controlled behaviour so we should always put the
'value-field' to improve both the code reviewing and the security (maybe it can
override some context value).
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476410#comment-15476410
]
Jacques Le Roux commented on OFBIZ-8203:
Also else the value-field would not have been made required
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476404#comment-15476404
]
Jacques Le Roux commented on OFBIZ-8203:
Since this is not documented in the XSD I suppose it does not work like that,
but could please check?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476278#comment-15476278
]
Pierre Smits commented on OFBIZ-8203:
-
Maybe it is an adopter's problem the project should not care about?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476234#comment-15476234
]
Montalbano Florian commented on OFBIZ-8203:
---
Where does the result of the entity-one is stored if there is no "value-field" ?
If it's not required, maybe we should update the DTDs ?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476207#comment-15476207
]
Pierre Smits commented on OFBIZ-8203:
-
I see that a lot.
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
> process error. Line: 235. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> process error. Line: 217. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process error. Line: 27. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error. Line: 65. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
