[jira] [Commented] (OFBIZ-8853) Unit test case for service - CheckReturnComplete

2019-05-25 Thread Suraj Khurana (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848245#comment-16848245
 ] 

Suraj Khurana commented on OFBIZ-8853:
--

Done at rev#1860003

> Unit test case for service - CheckReturnComplete
> 
>
> Key: OFBIZ-8853
> URL: https://issues.apache.org/jira/browse/OFBIZ-8853
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8853.patch, OFBIZ-8853.patch
>
>
> Unit test case for service - CheckReturnComplete



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-8853) Unit test case for service - CheckReturnComplete

2019-05-25 Thread Mathieu Lirzin (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848238#comment-16848238
 ] 

Mathieu Lirzin commented on OFBIZ-8853:
---

Like what I said in OFBIZ-8858, I would recommend using more declarative style 
for the context map, meaning preferring map literals over imperative map 
mutation instructions.

Thanks

> Unit test case for service - CheckReturnComplete
> 
>
> Key: OFBIZ-8853
> URL: https://issues.apache.org/jira/browse/OFBIZ-8853
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8853.patch, OFBIZ-8853.patch
>
>
> Unit test case for service - CheckReturnComplete



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-8853) Unit test case for service - CheckReturnComplete

2019-05-25 Thread Yogesh Naroliya (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848054#comment-16848054
 ] 

Yogesh Naroliya commented on OFBIZ-8853:


Hello team,
I have updated patch for the unit test of createProductFeatureType service from 
XML to DSL. 
Also verified the patch using following command:
./gradlew "ofbiz --test component=order --test suitename=ordertests"
Please have a look and let me know in case of any concerns.
Thanks in advance !!

> Unit test case for service - CheckReturnComplete
> 
>
> Key: OFBIZ-8853
> URL: https://issues.apache.org/jira/browse/OFBIZ-8853
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Yogesh Naroliya
>Priority: Major
> Attachments: OFBIZ-8853.patch, OFBIZ-8853.patch
>
>
> Unit test case for service - CheckReturnComplete



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)