[jira] [Commented] (OFBIZ-8972) OFBIZ-7520: Consistency and Readability improvements for include-menu tag
[ https://issues.apache.org/jira/browse/OFBIZ-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665923#comment-16665923 ] Devanshu Vyas commented on OFBIZ-8972: -- Updated the ofbiz-framework patch. > OFBIZ-7520: Consistency and Readability improvements for include-menu tag > - > > Key: OFBIZ-8972 > URL: https://issues.apache.org/jira/browse/OFBIZ-8972 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay >Priority: Major > Attachments: OFBIZ-8972.patch, OFBIZ-8972.patch, OFBIZ-8972.patch, > OFBIZ-8972_plugins.patch > > > Code written in Minilang for the if-compare tag is not consistent throughout > the application. The correct pattern to write is > location="component://marketing/widget/sfa/SfaMenus.xml"/> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8972) OFBIZ-7520: Consistency and Readability improvements for include-menu tag
[ https://issues.apache.org/jira/browse/OFBIZ-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079930#comment-16079930 ] Deepak Dixit commented on OFBIZ-8972: - Hi Rishi, Code committed under this ticket generated issue reported in OFBIZ-9114, So I reverted commit done under this ticket. So OFBIZ-8953 is not completed. OFBIZ-9114 is simply linked with this ticket for reference. > OFBIZ-7520: Consistency and Readability improvements for include-menu tag > - > > Key: OFBIZ-8972 > URL: https://issues.apache.org/jira/browse/OFBIZ-8972 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay > Attachments: OFBIZ-8972.patch > > > Code written in Minilang for the if-compare tag is not consistent throughout > the application. The correct pattern to write is > location="component://marketing/widget/sfa/SfaMenus.xml"/> -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-8972) OFBIZ-7520: Consistency and Readability improvements for include-menu tag
[ https://issues.apache.org/jira/browse/OFBIZ-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079557#comment-16079557 ] Rishi Solanki commented on OFBIZ-8972: -- Can we resolve this one as OFBIZ-9114 is closed. > OFBIZ-7520: Consistency and Readability improvements for include-menu tag > - > > Key: OFBIZ-8972 > URL: https://issues.apache.org/jira/browse/OFBIZ-8972 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay > Attachments: OFBIZ-8972.patch > > > Code written in Minilang for the if-compare tag is not consistent throughout > the application. The correct pattern to write is > location="component://marketing/widget/sfa/SfaMenus.xml"/> -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-8972) OFBIZ-7520: Consistency and Readability improvements for include-menu tag
[ https://issues.apache.org/jira/browse/OFBIZ-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639055#comment-15639055 ] Ankush Upadhyay commented on OFBIZ-8972: Improved consistency and readability improvements for the tag as suggested. > OFBIZ-7520: Consistency and Readability improvements for include-menu tag > - > > Key: OFBIZ-8972 > URL: https://issues.apache.org/jira/browse/OFBIZ-8972 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay > Attachments: OFBIZ-8972.patch > > > Code written in Minilang for the if-compare tag is not consistent throughout > the application. The correct pattern to write is > location="component://marketing/widget/sfa/SfaMenus.xml"/> -- This message was sent by Atlassian JIRA (v6.3.4#6332)
