[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942334#comment-15942334 ] Shi Jinghai commented on OFBIZ-9123: Thank you Jacques for the reopen, and thanks Pierre and Michael for the code review and suggestion! I submitted the changes in rev. 1788744, please check if it's ok now. Kind Regards, > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941683#comment-15941683 ] Jacques Le Roux commented on OFBIZ-9123: Hi Jinghai, We missed a point Pierre made: bq. Following up on this the freemarker templates are not in the correct place. As per recently revisited best practices these should not reside in the WEB-INF sub folder. So pricat\webapp\pricat\ftl should be pricat\template Are there other points we missed Pierre, Michael? > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756948#comment-15756948 ] Jacques Le Roux commented on OFBIZ-9123: Forever I don't know, but thanks :) > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748401#comment-15748401 ] Shi Jinghai commented on OFBIZ-9123: Thank you Jacques! You are my mentor forever :) No, I haven't installed the client configuration file. I'm installing it now. Have a nice day, > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747927#comment-15747927 ] Jacques Le Roux commented on OFBIZ-9123: Hi Jinghai, I have just changed the Java files you committed for pricat to use the svn:native option. I guess you don't use the "official OFBIZ Subversion client configuration file" as requested here https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-CommittingChanges Please install it on your machine/s and remember to have it on new machines when necessary, thanks. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732036#comment-15732036 ] Jacques Le Roux commented on OFBIZ-9123: Agreed Michael, this has already been started in the "[DISCUSSION] Defining an OFBiz Project Strategy" thread http://markmail.org/message/nc2sm7k5s3hlay33 but we need a new separate [DISCUSSION] thread to clarify the community's decision about it. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732012#comment-15732012 ] Michael Brohl commented on OFBIZ-9123: -- This discussion has nothing to do with the issue, please move it to the dev ML. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732002#comment-15732002 ] Jacques Le Roux commented on OFBIZ-9123: Pierre, I guess they are updated regularly (automatically) from the official OFBiz GitHub repo? BTW, what is the purpose? Does this not risk to introduce more entropy and confusion in the project? > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731949#comment-15731949 ] Pierre Smits commented on OFBIZ-9123: - Hi [~shi.jinghai], The following components are already available on github: * Solr - https://github.com/OFBizCI/solr * LDAP - https://github.com/OFBizCI/ldap * Passport - https://github.com/OFBizCI/passport All straight from trunk. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731930#comment-15731930 ] Shi Jinghai commented on OFBIZ-9123: Ha, finally I got the feeling of what you are worrying about. When plugin done, I can take back the LDAP, Passport, Pricat and Solr components, move them to github. :) > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731925#comment-15731925 ] Pierre Smits commented on OFBIZ-9123: - Huh? Committers are required to commit changes for the various OFBiz products > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731880#comment-15731880 ] Jacques Le Roux commented on OFBIZ-9123: Just for what is already OOTB, like pricat in specialpurpose. So would be all or most of specialpurpose components. They would be available as plugins and not in the svn repo. They would be maintained by their contributors. It opens more possibilities for contributors wanting to donate their code to OFBiz while not putting all the burden on the committers shoulders once donated. More an idea still needing discussion for now... > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731872#comment-15731872 ] Jacques Le Roux commented on OFBIZ-9123: Thanks for the explanation Jinghai. So let's wait Microsoft :) > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731687#comment-15731687 ] Shi Jinghai commented on OFBIZ-9123: Hi Jacques, Here's the test case on OFBizPricatUtil: 1. Import the sample pricat file and download it; 2. Comment out the OFBizPricatUtil.formatCommentShape method used in pricat; 3. Rebuild and import the sample pricat file; 4. Download the commented pricat file; 5. Open it in Microsoft Excel, the style of comments is not readable. 6. Open it in OpenOffice or WPS, the style of comments is correct. Unzip the commented pricat file (.xlsx), compare the files with/without running OFBizPricatUtil.formatCommentShape, the difference is in xl/drawings/vmlDrawing1.vml file. According to POI document: In Excel 2007 VML drawings are used to describe properties of cell comments, although the spec says that VML is deprecated: The VML format is a legacy format originally introduced with Office 2000 and is included and fully defined in this Standard for backwards compatibility reasons. The DrawingML format is a newer and richer format created with the goal of eventually replacing any uses of VML in the Office Open XML formats. VML should be considered a deprecated format included in Office Open XML for legacy reasons only and new applications that need a file format for drawings are strongly encouraged to use preferentially DrawingML Warning - Excel is known to put invalid XML into these files! For example, >br< without being closed or escaped crops up. See 6.4 VML - SpreadsheetML Drawing in Office Open XML Part 4 - Markup Language Reference.pdf By putting OFBizPricatUtil under POI path, I can call the protected method XSSFVMLDrawing.findCommentShape and build the comments look right in Microsoft Excel. This is the reason. I'm sure there's a better way to do this. Kind Regards, > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731581#comment-15731581 ] Pierre Smits commented on OFBIZ-9123: - Following up on this the freemarker templates are not in the correct place. As per recently revisited best practices these should not reside in the WEB-INF sub folder. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731577#comment-15731577 ] Pierre Smits commented on OFBIZ-9123: - Jacques, I wonder where you want to have the project having control over. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731560#comment-15731560 ] Jacques Le Roux commented on OFBIZ-9123: Hi Jinghai, IIRW it has been already discussed but I can't find where (maybe in HipChat where history is not the best part). Could you please refresh my mind about why OFBizPricatUtil class must be in org.apache.poi.xssf.usermodel package? Thanks :) > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690657#comment-15690657 ] Jacques Le Roux commented on OFBIZ-9123: Thanks for the tip Jinghai. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690317#comment-15690317 ] Shi Jinghai commented on OFBIZ-9123: Hi Jacques, I submitted a simple readme and replaced some (many) tabs with spaces. BTW, Apache Archiva is a good tool to build a maven repo. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689339#comment-15689339 ] Jacques Le Roux commented on OFBIZ-9123: Hi Jinghai, My proposition is to create a Maven repository in our demo server (ie at https://ofbiz-vm2.apache.org). We will certainly need to ask for more RAM (we run the 3 demos in 4GB) but I expect the infra to agree. The idea is to have something centralised that we can check, control and recommend. I thought about my question to Pierre, maybe something like that is not needed (at least for now) and a simple page in wiki linked from main site would be enough. There we would list the available plugins with simple (and possibly more elaborate) explanations about what they add and on how to proceed to install them from the (hopefully to come) OFBiz Maven repo. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688517#comment-15688517 ] Shi Jinghai commented on OFBIZ-9123: Hi Jacques, Thanks for your review! I'll add a readme asap, and remove tabs in the source code. :) I'm eager to see the plugin model works in OFBiz. I have publish right of central maven repository but it's not allowed to publish any artifacts of Apache as Apache has ourown repository server, my question is where to publish our plugins? Love you, > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683155#comment-15683155 ] Pierre Smits commented on OFBIZ-9123: - I already did a cursory review and found that the component is not in line with recent established best practices. Please revert, and upload as patch files to this issue. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683125#comment-15683125 ] Michael Brohl commented on OFBIZ-9123: -- Maybe I have not expressed myself well enough. If I got it right, you have added a new component under specialpurpose and I cannot see that it was there before or that it was moved from the applications to specialpurpose. My point is not that you've added a new component but the chosen process of doing so. As far as I can see you created this Jira and immediately committed your work to trunk without any discussion or review before. In my opinion the process should be: 1. create a Jira with a good description of the contribution, what does it do, why should it be added etc. 2. provide a patch and ask for review 3. review and discussion by the community 4. if the community wants to add the contribution, it can be committed. Even if we as committers have direct access to the repository, we should still follow the process of contribute - discuss - review - commit as any other contributor. To be clear, I have not reviewed the contribution yet so I have currently no opinion if we should add it to the repository. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683037#comment-15683037 ] Shi Jinghai commented on OFBIZ-9123: Hi Michael, Honestly, this piece of pricat component has been there over 10 years, not new concept. Sorry, my English is not good enough, what's "slim down" mean? Personally, I thought the gradle effort is done for the slim purpose. > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683006#comment-15683006 ] Michael Brohl commented on OFBIZ-9123: -- Hi Jinghai, thanks for your contribution. It's appreciated and I am not against putting it into the repository but I think we should at least 1. have a discussion if it should be added and 2. let someone review it before it is added. We want to stabilize and slim down the codebase so we should follow some review process. Maybe I missed some discussion about it but cannot find some under the keyword "pricat". > Add a PriCat component under specialpurpose > --- > > Key: OFBIZ-9123 > URL: https://issues.apache.org/jira/browse/OFBIZ-9123 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Trivial > Fix For: Trunk > > > Add a PriCat component to view excel import with html report and download > excel output with errors commented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
