[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315404#comment-16315404 ] Michael Brohl commented on OFBIZ-9147: -- It was closed because the only provided solution during more than a year was disabling the automatic loading of the exampleext component. No other solution was provided and the current state of the codebase has the same impact as the provided patch: the component is not loaded automatically with the framework. So closing was the obvious action and the resolution is correct. Removing the component was a different topic brought up later, after closing. Who can foresee that? If you want the plugin to be removed, which is a valid proposal, you can always file a new issue for it. Be sure that I will not remove a component/plugin from the codebase without a consensus in the community, so you will have to start a discussion about it in the dev list. If there is a majority of voices who want to remove this plugin, I'm happy to do it as with every other issue. > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315402#comment-16315402 ] Pierre Smits commented on OFBIZ-9147: - Anyway, it goes to show that this ticket was closed prematurely and unnecessary noise was created by the one who did that that. With the words of Jacques: 'you're not deciding alone'. > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315399#comment-16315399 ] Michael Brohl commented on OFBIZ-9147: -- Then the issue should read "Remove the exampleext plugin from the codebase" or "Move examplext functionality to example" or similar. The original intent of the provided patch (don't load exampleext OOTB ) is outdated/already solved and there is no other solution provided. Please discuss the removal in the dev list and we will take action according to the consensus, thank you. > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315398#comment-16315398 ] Jacques Le Roux commented on OFBIZ-9147: Example components (both) are there to explain/show how things works. The exampleext component is *only * there to demonstrate the extension mechanisms. It as much as simply possible does that. So usage of extension mechanisms are not blurred with other features. That's why it exists and I think it's a good thing. We previsouly had the same idea with the ecomclone component. It was removed because it was redundant with exampleext, and even more locally with ecomseo which demonstrates other usages of extension mechanisms. Now what we could do is creating an .md file where things would be more explained. This file could be used in a wiki page as an import after a Pandoc conversion to HTML, as I suggested many times and lastly today in OFBIZ-9190 > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315391#comment-16315391 ] Pierre Smits commented on OFBIZ-9147: - A cursory review of both the ofbiz-framework and ofbiz-plugins code bases will reveal that extending widgets with/from other widgets is already implemented in numerous places. Which functionality available in the exampleext component is so unique that it needs to be retained there (and can't be implemented in the example component) warranting its existence? > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315147#comment-16315147 ] Michael Brohl commented on OFBIZ-9147: -- The exampleext component is there for demo purposes, like example and should be available OOTB. Looking at it, this seems to be an example on how to *extend* another component's widgets and forms and therefore has it's meaning to be a separate component. I think this should be closed as "Won't do". What do others think? > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315111#comment-16315111 ] Pierre Smits commented on OFBIZ-9147: - This patch addresses the automatically loading of the component. What the plan of the project is regarding the component is not up to me. As soon as there is a clarity I can, and if time permits, further actions. > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9147) Disentangle ExampleExt from the codebase
[ https://issues.apache.org/jira/browse/OFBIZ-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314974#comment-16314974 ] Michael Brohl commented on OFBIZ-9147: -- The patch simply disables the component. Do you plan to provide a patch for the integration of the examplext into the example component? If not, I think we should close this as incomplete. > Disentangle ExampleExt from the codebase > > > Key: OFBIZ-9147 > URL: https://issues.apache.org/jira/browse/OFBIZ-9147 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: refactoring > Attachments: OFBIZ-9147-component-load.xml.patch > > > Currently the functionality of the ExampleExt component brings nothing more > than a few widgets that extend the examples in the Example component. These > ExampleExt widgets can as easily exist in the Example component. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
