[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740398#comment-16740398 ] Jacques Le Roux commented on OFBIZ-9376: +1, I see no reasons why it's still open > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Nicolas Malin >Priority: Minor > Attachments: JIRA_9376.patch, quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740365#comment-16740365 ] Deepak Dixit commented on OFBIZ-9376: - I think we can close this issue. > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Nicolas Malin >Priority: Minor > Attachments: JIRA_9376.patch, quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374367#comment-16374367 ] Gaudin Pierre commented on OFBIZ-9376: -- Hi Nicolas, Sorry for the very long delay, Here is a new patch that fix test issue. thanks > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Nicolas Malin >Priority: Minor > Attachments: JIRA_9376.patch, quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098312#comment-16098312 ] Gaudin Pierre commented on OFBIZ-9376: -- Hi Nicolas, I have missed this test ... I'll provide a new patch as soon as possible. Thanks, Pierre > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Nicolas Malin >Priority: Minor > Attachments: quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[
https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097418#comment-16097418
]
Nicolas Malin commented on OFBIZ-9376:
--
Hi Pierre, after apply you patch :
{code}
junit.framework.AssertionFailedError: ERROR: Could not complete the Test create
an order using a configurable service product
[file:/home/mnicolas/workspace/apache-svn/ofbiz-trunk-commit/applications/order/minilang/test/ShoppingCartTests.xml#testCreateOrderConfigurableServiceProduct]
process [problem invoking the [quickShipEntireOrder] service with the map
named [quickShipEntireOrderMap] containing
[{userLogin=[GenericEntity:UserLogin][createdStamp,2017-07-22
21:52:03.109(java.sql.Timestamp)][createdTxStamp,2017-07-22
21:52:02.849(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2017-07-22
21:52:14.374(java.sql.Timestamp)][lastUpdatedTxStamp,2017-07-22
21:52:13.936(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
orderId=WSCO10043, locale=en}]: Outgoing result (in runSync :
quickShipEntireOrder) does not match expected requirements (Unknown parameter
found: [quickShipEntireOrder.shipmentIds])]
{code}
Maybe they missing something ;)
> Add shipmentId list to quickshippurchaseorder return parameters
> ---
>
> Key: OFBIZ-9376
> URL: https://issues.apache.org/jira/browse/OFBIZ-9376
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Attachments: quickShipPurchaseOrder.patch
>
>
> The method " quickshippurchaseorder " allows to create a reception for every
> ship group of a purchasing order. This method works correctly but it does not
> return id of the receptions which it creates. The purpose of this patch is to
> modify the service so that it returns the list of the receptions which it
> creates
> To test this patch:
> - Create a purchase order with several ships groups
> - approve it
> - from webtools execute the service " quickshippurchaseorder " with the
> parameters: order Id: reference of order facilityId: WebStoreWarehouse
> results :
> The service returns the parameter shipmentIds
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
