[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042790#comment-16042790 ] Renuka Srishti commented on OFBIZ-9390: --- Thanks Shi and Thanks Jacques for the honor. > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042649#comment-16042649 ] Jacques Le Roux commented on OFBIZ-9390: Thanks to both, We now need to close the issue. Renuka would you like the honor :) ? > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042345#comment-16042345 ] Shi Jinghai commented on OFBIZ-9390: Thanks Renuka! I agree with you, your patch is in rev. 1798029. Please check if it's right. > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040896#comment-16040896 ] Renuka Srishti commented on OFBIZ-9390: --- Thanks Jacques, I think simply removing PassportEntityLabels is fine, as I have gone through all these entities and there is no need of PassportUiLabels.xml. > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040741#comment-16040741 ] Jacques Le Roux commented on OFBIZ-9390: Thanks Renuka, Should we not use PassportUiLabels.xml rather than simply removing PassportEntityLabels (or maybe add a PassportEntityLabels file)? [~shi.jinghai] ? > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
