[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201732#comment-16201732 ] Michael Brohl commented on OFBIZ-9829: -- [~shi.jinghai], it seems that you did not get my points completely, so I will try it once again. We should *first* have a discussion and approval before any new plugin is committed to the code base. You have chosen to commit it first and I kindly ask you to correct it by reverting the commit. I will provide some initial questions on the mailing list discussion (https://lists.apache.org/thread.html/ad4fbcb7461e955e3ebeb475ed835683dc7dc937b765edd7fecf2453@%3Cdev.ofbiz.apache.org%3E) Thanks, Michael > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201303#comment-16201303 ] Shi Jinghai commented on OFBIZ-9829: Thank you Michael, got it. I'll start a thread on whether it's OK to add this redis plugin to codebase. > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200973#comment-16200973 ] Michael Brohl commented on OFBIZ-9829: -- [~shi.jinghai], my concern is not about Redis and it does not matter if I personally like it or not. In fact, I have no strong opinion about it at the moment, because I had not the chance to think about it. My concern is about the way you commit a new plugin to the codebase without asking the community. Apache OFBiz is a community project. Architectural changes, refactorings, changes of business logic and also the introduction of new functionality and enhancements should be explained, discussed, reviewed and approved with a consensus. I kindly ask you to revert the commit and start a proposal to introduce a Redis integration for OFBiz. If you have good arguments for adding it and if the solution does fit in the sense of quality, user benefit and documentation, I'm pretty sure it will find it's way to the codebase. Thanks, Michael > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200456#comment-16200456 ] Shi Jinghai commented on OFBIZ-9829: Hi Michael, Thank you for your concern! Redis is a key-value db in memory, which makes it's the fastest way to get/set info. In CRM, we can get the customer info when a call in by phone number as Redis key, a chat in by openid and etc. In ecommerce systems of China, Redis is heavily used in Alibaba, JingDong, 12306, Qunar and many others to support rush-hour requests on products, tickets, caches and etc. I think a Redis plugin would be very helpful to OFBiz. Please see Redis project on https://github.com/antirez/redis, it's very popular, over 25,000 stars and almost 10,000 forks. Redis has become an important part of modern infrastructures, Amazon, Azure, Twitter, Youtube, SAP, I have to say, almost everybody are supporting it. I'm sure you'll like it. Kind Regards, > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200406#comment-16200406 ] Michael Brohl commented on OFBIZ-9829: -- [~shi.jinghai], this might be a useful addition to our codebase but I really do think that we should discuss the addition first before adding it to the official OFBiz plugins repository. This issue lacks an introduction how it is of use to the project, what should be achieved, how it is implemented and used within OFBiz. We are trying hard to stabilize our codebase and assure good quality. The addition of a new plugin in the official codebase is nothing we should do on the go. It needs review, discussion and a consensus. Please be patient. Until we decide the addition, please revert the commit. Thanks and regards, Michael > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200352#comment-16200352 ] Shi Jinghai commented on OFBIZ-9829: Thank you Haipeng (代海鹏)! This redis component is in trunk rev. 1811826. I changed the READ.md to include some introductions on the Redis, Codis and Redisson. And I changed redis port from 19000 to 6379 as well. BTW, would you please modify the getRedisInfo and setRedisInfo to allow empty redis.encrypt.password and plain text values in Redis? Regards, > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
