[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762714#comment-16762714
]
amit cahanovich commented on OFBIZ-9833:
thanks a lot!
> Token Based Authentication
>
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762695#comment-16762695
]
Jacques Le Roux commented on OFBIZ-9833:
Hi Amit,
This has been modified by OFBIZ-10814, please
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762678#comment-16762678
]
amit cahanovich commented on OFBIZ-9833:
Hi,
I was trying to test the same from the latest
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664666#comment-16664666
]
Deepak Dixit commented on OFBIZ-9833:
-
Thanks Jacques.
> Token Based Authentication
>
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663875#comment-16663875
]
Jacques Le Roux commented on OFBIZ-9833:
If nobody disagree I'll commit Deepak's patch tomorrow
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649467#comment-16649467
]
Jacques Le Roux commented on OFBIZ-9833:
While reviewing things for OFBIZ-10307, I stumbled upon
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595952#comment-16595952
]
Jacques Le Roux commented on OFBIZ-9833:
Hi Nicolas,
Thanks for your review, which confirms mine
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594702#comment-16594702
]
Nicolas Malin commented on OFBIZ-9833:
--
Hello,
I reviewed the path and this solution take a good
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551008#comment-16551008
]
Jacques Le Roux commented on OFBIZ-9833:
Hi Deepak, Jacopo,
My solution at OFBIZ-10307 now
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512622#comment-16512622
]
Jacques Le Roux commented on OFBIZ-9833:
OK, the work is now ready to be reviewed at OFBIZ-10307.
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415242#comment-16415242
]
Jacques Le Roux commented on OFBIZ-9833:
To clarify here, the problem is not Tomcat SSO, but
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411059#comment-16411059
]
Jacques Le Roux commented on OFBIZ-9833:
Jacopo,
bq. Apart from jokes, Jacques Le Roux, it is
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411057#comment-16411057
]
Jacques Le Roux commented on OFBIZ-9833:
OK Michael,
I understand your worries, I'll revert the
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411012#comment-16411012
]
Michael Brohl commented on OFBIZ-9833:
--
> I forgot another reason why I can't revert the rest: I need
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411010#comment-16411010
]
Jacques Le Roux commented on OFBIZ-9833:
Deepak, Jacopo,
Forgot a question: what are the
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410944#comment-16410944
]
Jacques Le Roux commented on OFBIZ-9833:
Jacopo, All,
There is one think that we still need to
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410937#comment-16410937
]
Jacques Le Roux commented on OFBIZ-9833:
Michael,
I think I explained why:
bq. The rest of what I
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410340#comment-16410340
]
Michael Brohl commented on OFBIZ-9833:
--
Jacques,
my understanding was that you agreed to revert
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410303#comment-16410303
]
Jacques Le Roux commented on OFBIZ-9833:
I created OFBIZ-10307 as a Jira replacement for the
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410297#comment-16410297
]
Jacques Le Roux commented on OFBIZ-9833:
I reverted all (apart ContextFilter which was alreasy
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410245#comment-16410245
]
Jacques Le Roux commented on OFBIZ-9833:
Forgot one thing, as it's a new feature I'll revert all
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409781#comment-16409781
]
Jacques Le Roux commented on OFBIZ-9833:
Yes thanks to ask Michael, I indeed intended to clarify
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409655#comment-16409655
]
Michael Brohl commented on OFBIZ-9833:
--
I'm a bit lost with this issue. Can you give us a short
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408576#comment-16408576
]
Jacques Le Roux commented on OFBIZ-9833:
I reverted the wrong change committed with 1813679 in
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408540#comment-16408540
]
Jacques Le Roux commented on OFBIZ-9833:
I found the reason:
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405959#comment-16405959
]
Jacques Le Roux commented on OFBIZ-9833:
Forgot to say that when I checked with r1806036 reverted
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405337#comment-16405337
]
Jacques Le Roux commented on OFBIZ-9833:
Weirdly, when I apply the {{OFBIZ-9833-revert.patch}}
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401138#comment-16401138
]
Michael Brohl commented on OFBIZ-9833:
--
This is a very unfortunate and, frankly speaking, annoying
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400971#comment-16400971
]
Jacques Le Roux commented on OFBIZ-9833:
I agree to revert but I face 2 problems at the moment.
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400622#comment-16400622
]
Michael Brohl commented on OFBIZ-9833:
--
+1 for reverting, please do, Jacques.
> Token Based
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400586#comment-16400586
]
Jacopo Cappellato commented on OFBIZ-9833:
--
As we agreed, please revert your work and save all
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400481#comment-16400481
]
Jacques Le Roux commented on OFBIZ-9833:
Hi Jacopo, I'm working on it but I don't want to lose
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396817#comment-16396817
]
Jacopo Cappellato commented on OFBIZ-9833:
--
[~jacques.le.roux] before you continue to work on
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396802#comment-16396802
]
Jacques Le Roux commented on OFBIZ-9833:
BTW, I'll create a Jira for that, while working on the
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396785#comment-16396785
]
Jacques Le Roux commented on OFBIZ-9833:
Hi Jacopo,
I made an architectural mistake.
My mistake
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396697#comment-16396697
]
Jacopo Cappellato commented on OFBIZ-9833:
--
[~jacques.le.roux] will you have time this week to
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375398#comment-16375398
]
Deepak Dixit commented on OFBIZ-9833:
-
Added a patch that we can used for generic way.
Added
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370265#comment-16370265
]
Jacques Le Roux commented on OFBIZ-9833:
Hi Jacopo,
bq. it is really a bad idea to store a secret
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370127#comment-16370127
]
Jacopo Cappellato commented on OFBIZ-9833:
--
[~jacques.le.roux] it is really a bad idea to store a
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353815#comment-16353815
]
Jacques Le Roux commented on OFBIZ-9833:
I have created OFBIZ-10206 to fix a small security issue
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353794#comment-16353794
]
Jacques Le Roux commented on OFBIZ-9833:
At r1822882 in trunk and r1823316 in R17.12 I Changed to
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353791#comment-16353791
]
Jacques Le Roux commented on OFBIZ-9833:
At r1821600 in trunk and r1823311 in R17.12 As reported
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328955#comment-16328955
]
Jacques Le Roux commented on OFBIZ-9833:
At r1821230 in trunk and r1821231 I fixed a bug in
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241690#comment-16241690
]
Jacques Le Roux commented on OFBIZ-9833:
BTW, as it can help, here is the sed syntax I used to
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241590#comment-16241590
]
Jacques Le Roux commented on OFBIZ-9833:
Something I want to note here, and will maybe create a
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239652#comment-16239652
]
Jacques Le Roux commented on OFBIZ-9833:
I have tested the Token Based Authentication between my
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223951#comment-16223951
]
Jacques Le Roux commented on OFBIZ-9833:
At r1813679, I have committed my proposition.
I have
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206296#comment-16206296
]
Jacques Le Roux commented on OFBIZ-9833:
This afternoon I discussed with [~soledad] about the
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205575#comment-16205575
]
Jacques Le Roux commented on OFBIZ-9833:
Forgot also to say (it's obvious in the patch) that I
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205045#comment-16205045
]
Jacques Le Roux commented on OFBIZ-9833:
Forgot to say that the purpose of this work is mostly to
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202382#comment-16202382
]
Deepak Dixit commented on OFBIZ-9833:
-
Thanks Jacques for valuable inputs, I also used JJWT to handle
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200420#comment-16200420
]
Jacques Le Roux commented on OFBIZ-9833:
This is a quite interesting article even if it should be
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199330#comment-16199330
]
Jacques Le Roux commented on OFBIZ-9833:
I forgot to say that I picked
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198528#comment-16198528
]
Jacques Le Roux commented on OFBIZ-9833:
What I did is more like externalLoginKey but between 2
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198364#comment-16198364
]
Jacopo Cappellato commented on OFBIZ-9833:
--
Thank you Jacques.
Deepak, I know you have also
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198308#comment-16198308
]
Jacques Le Roux commented on OFBIZ-9833:
Thanks Deepak,
I have done something for a custom
56 matches
Mail list logo
