[jira] [Commented] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity

2017-11-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265693#comment-16265693
 ] 

Jacques Le Roux commented on OFBIZ-9998:


I agree, a small summary would be   appreciated

> Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
> 
>
> Key: OFBIZ-9998
> URL: https://issues.apache.org/jira/browse/OFBIZ-9998
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Vaibhav Jain
>Assignee: Ayushi Rathod
>
> As per the discussion int respective mail thread
> [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity

2017-11-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265688#comment-16265688
 ] 

Pierre Smits commented on OFBIZ-9998:
-

I feel it is a pity that the gist of the discussions is not captured in the 
description of this ticket. And that a reference to a thread seems to be 
sufficient. So, it is expected that 
# the developer will 
## go through the discussion(s),
## extract the final actionable items (that have the consensus of the 
community),
## implement the changes;
# any reviewer will
## go through the discussions(s), 
## extract the final actionable items (that have the consensus of the community)
## review the implemented changes

This will introduce a lot of of risk points leading failure.

> Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
> 
>
> Key: OFBIZ-9998
> URL: https://issues.apache.org/jira/browse/OFBIZ-9998
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Vaibhav Jain
>Assignee: Ayushi Rathod
>
> As per the discussion int respective mail thread
> [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)