Devanshu Vyas created OFBIZ-9303:
------------------------------------
Summary: Remove hard-coded success/error message variables set in
service output
Key: OFBIZ-9303
URL: https://issues.apache.org/jira/browse/OFBIZ-9303
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Devanshu Vyas
Priority: Minor
I found that certain services in OFBiz set error/success message values in o
hard-codedly like:
{code}
result.put("errorMessage", errMsg);
result.put("successMessage", message);
{code}
I think it shouldn't be set like this, as we have constants in ModelService
class for this purpose. ModelService.ERROR_MESSAGE/ModelService.SUCCESS_MESSAGE
should be used to set the error and success messages, for in case we want to
change the constant's value, no services will be affected.
{code}
result.put(ModelService.ERROR_MESSAGE, errMsg);
result.put(ModelService.SUCCESS_MESSAGE, errMsg);
{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
