[jira] [Updated] (OFBIZ-9457) Improvements in OrderHeader entity definition and services

2017-07-08 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-9457:
-
Attachment: OFBIZ-9457.patch

Updating patch with correct naming pattern.


> Improvements in OrderHeader entity definition and services
> --
>
> Key: OFBIZ-9457
> URL: https://issues.apache.org/jira/browse/OFBIZ-9457
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-9457.diff, OFBIZ-9457.patch
>
>
> Fix entity definition of OrderHeader and do the following changes in the 
> implementation;
> - Remove relations with OrderHeaderNoteView and OrderItemAndShipGroupAssoc 
> from the entity definition.
> - Check for the both views used at any place as getRelated() generic value 
> methods on OrderHeader then change them with appropriate EntityQuery method 
> or delegaor or other script as applicable.
> - Few find areas are;
> -- AddItemsFromOrder.groovy
> -- ReceiveInventoryAgainstPurchaseOrder.groovy
> Note: As we are removing relation from OrderHeader so only need to work on 
> the items where we are trying to get related data by using the relations. We 
> need to rewrite only those lines of code. Reverse in not true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9457) Improvements in OrderHeader entity definition and services

2017-07-08 Thread Aishwary Shrivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aishwary Shrivastava updated OFBIZ-9457:

Attachment: OFBIZ-9457.diff

Here is the patch for the Improvement.
Thanks to Devanshu Vyas, Amit Gadaley, Vaibhav Jain and Rishi Solanki for the 
guidance.

Steps to verify the changes of AddItemFromOrder: 
1. Login
2.Go to Facility.
3.Go to Shipments.
4.Find an Outgoing - Sales type shipment.
5.Select the shipment.
6.Click on Order Items


Steps to verify the changes of ReceiveInventoryAgainstPurchaseOrder: 
1. Login
2.Go to Facility.
3.Go to Shipments.
4.Find an Incoming - Purchase type shipment.
5.Select the shipment.
6.Click on Receive against PO.


The data show on the screens remains same before and after applying the patch.


> Improvements in OrderHeader entity definition and services
> --
>
> Key: OFBIZ-9457
> URL: https://issues.apache.org/jira/browse/OFBIZ-9457
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-9457.diff
>
>
> Fix entity definition of OrderHeader and do the following changes in the 
> implementation;
> - Remove relations with OrderHeaderNoteView and OrderItemAndShipGroupAssoc 
> from the entity definition.
> - Check for the both views used at any place as getRelated() generic value 
> methods on OrderHeader then change them with appropriate EntityQuery method 
> or delegaor or other script as applicable.
> - Few find areas are;
> -- AddItemsFromOrder.groovy
> -- ReceiveInventoryAgainstPurchaseOrder.groovy
> Note: As we are removing relation from OrderHeader so only need to work on 
> the items where we are trying to get related data by using the relations. We 
> need to rewrite only those lines of code. Reverse in not true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)