[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...
Github user joshelser commented on the issue: https://github.com/apache/incubator-rya/pull/274 Hrm, maybe worth it to send a note to the Giraph mailing lists? If this really is an LGPL dependency, then Apache Giraph shouldn't be depending on it either. ---
[GitHub] incubator-rya pull request #106: RYA-204 Added the Rya Jena Sesame adapter w...
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/106#discussion_r86241465 --- Diff: NOTICE --- @@ -4,3 +4,25 @@ Copyright 2016 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +-- +SOFTWARE DISTRIBUTED WITH RYA: --- End diff -- This blurb (between your horizontal lines) is unnecessary. Remove it, please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #106: RYA-204 Added the Rya Jena Sesame adapter w...
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/106#discussion_r86242245
--- Diff: extras/rya.jena.sesame/NOTICE ---
@@ -0,0 +1,11 @@
+Apache Jena - ARQ module
+Copyright 2011, 2012 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Portions of this software were originally based on the following:
+ - Copyright 2004, 2005, 2006, 2007, 2008, 2009 Hewlett-Packard
Development Company, LP
+ - Copyright 2010, 2011 Epimorphics Ltd.
+ - Copyright 2010 Talis Systems Ltd.
+These have been licensed to the Apache Software Foundation under a
software grant.
--- End diff --
Not sure why this is here. The top-level NOTICE file covers the
source-release. You *do* need to make sure that the rya.jena.sesame's JAR file
does contain the correct `META-INF/{LICENSE,NOTICE}` files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #106: RYA-204 Added the Rya Jena Sesame adapter w...
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/106#discussion_r86241962 --- Diff: extras/rya.jena.sesame/Copyright.txt --- @@ -0,0 +1,25 @@ + + (c) Copyright 2009 Talis Information Ltd. + All rights reserved. + + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions + are met: + 1. Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + 2. Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in the + documentation and/or other materials provided with the distribution. + 3. The name of the author may not be used to endorse or promote products + derived from this software without specific prior written permission. + + THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR + IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES + OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. + IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, + INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT + NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. --- End diff -- Yeah I don't know why you would need this COPYRIGHT file. Application of the ASL at the ASF does not state anything about a COPYRIGHT file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #106: RYA-204 Added the Rya Jena Sesame adapter w...
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/106#discussion_r86241601 --- Diff: NOTICE --- @@ -4,3 +4,25 @@ Copyright 2016 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +-- +SOFTWARE DISTRIBUTED WITH RYA: + +The Apache Rya software includes a number of subcomponents with +separate copyright notices and license terms. Your use of the source +code for the these subcomponents is subject to the terms and +conditions of the following licenses. + +-- +For the extras/rya.jena.sesame/src/main/java/org/apache/rya/jena/jenasesame/ components: + +Apache Jena - ARQ module +Copyright 2011, 2012 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). --- End diff -- These four lines about copyright from the ASF is unnecessary. See LEGAL-234. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #106: RYA-204 Added the Rya Jena Sesame adapter w...
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/106#discussion_r86241337 --- Diff: LICENSE --- @@ -200,3 +200,42 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + + -- + SOFTWARE DISTRIBUTED WITH RYA: + + The Apache Rya software includes a number of subcomponents with + separate copyright notices and license terms. Your use of the source + code for the these subcomponents is subject to the terms and + conditions of the following licenses. + + -- + For the extras/rya.jena.sesame/src/main/java/org/apache/rya/jena/jenasesame/ components: --- End diff -- It may be more sustainable to invert this. For the 3-clause BSD license, we include the following components, the license . Nit-picky for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #106: RYA-204 Added the Rya Jena Sesame adapter w...
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/106#discussion_r86243323 --- Diff: extras/rya.jena.sesame/src/main/java/org/apache/rya/jena/jenasesame/impl/Convert.java --- @@ -0,0 +1,209 @@ +/* --- End diff -- Please refer to https://www.apache.org/legal/src-headers.html#3party --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Github user joshelser commented on the issue: https://github.com/apache/incubator-rya/pull/115 Not sure about ParametersAreNonNullByDefault, curiously, it's mentioned https://github.com/stephenc/findbugs-annotations/blob/master/src/spec/javadoc/edu/umd/cs/findbugs/annotations/DefaultAnnotationForParameters.html#L87-L91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Github user joshelser commented on the issue: https://github.com/apache/incubator-rya/pull/115 ThreadSafe and Immutable are available in https://github.com/stephenc/jcip-annotations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #101: RYA-177 adding optional geoindexing profile
Github user joshelser commented on the issue: https://github.com/apache/incubator-rya/pull/101 Looks reasonable enough. I'll try to pull down the changes and take a look tmrw with fresh eyes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
