[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2362: {dataSource-1} inited takes a long time when use ORA12c

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2362: {dataSource-1} inited takes a long time when use ORA12c URL: https://github.com/apache/incubator-shardingsphere/issues/2362#issuecomment-492076265 @fdlzp sorry for the late reply, please show your Sharding-configuration to us.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2379: delete from user where id=“xx” parse error in shading-jdbc 4.0.0-RC1

2019-05-13 Thread GitBox
terrymanu commented on issue #2379: delete from user where id=“xx” parse error in shading-jdbc 4.0.0-RC1 URL: https://github.com/apache/incubator-shardingsphere/issues/2379#issuecomment-492067923 The problem is not caused by `id=“xx” parse error` The problem is table name is `user` by

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2379: delete from user where id=“xx” parse error in shading-jdbc 4.0.0-RC1

2019-05-13 Thread GitBox
terrymanu closed issue #2379: delete from user where id=“xx” parse error in shading-jdbc 4.0.0-RC1 URL: https://github.com/apache/incubator-shardingsphere/issues/2379 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] AlbertTao closed issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
AlbertTao closed issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-492065300 Thanks very much for your reply. This is an

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1966: Insert data to all sharding table when the value of sharing column is null.

2019-05-13 Thread GitBox
terrymanu commented on issue #1966: Insert data to all sharding table when the value of sharing column is null. URL: https://github.com/apache/incubator-shardingsphere/issues/1966#issuecomment-492064499 throw exception from shardingsphere maybe not a good idea. shardingsphere should

[GitHub] [incubator-shardingsphere-doc] Harper0122 opened a new pull request #175: Sharding-Other Features

2019-05-13 Thread GitBox
Harper0122 opened a new pull request #175: Sharding-Other Features URL: https://github.com/apache/incubator-shardingsphere-doc/pull/175 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2050: Should add a method in HintManager to hint only use default datasource and none SQL rewrite

2019-05-13 Thread GitBox
terrymanu commented on issue #2050: Should add a method in HintManager to hint only use default datasource and none SQL rewrite URL: https://github.com/apache/incubator-shardingsphere/issues/2050#issuecomment-492063832 Can I close this issue?

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2235: Support Information Functions for MySQL

2019-05-13 Thread GitBox
terrymanu commented on issue #2235: Support Information Functions for MySQL URL: https://github.com/apache/incubator-shardingsphere/issues/2235#issuecomment-492063607 FYI: https://dev.mysql.com/doc/refman/8.0/en/information-functions.html

[GitHub] [incubator-shardingsphere] wenweibin opened a new issue #2379: delete from user where id=“xx” parse error in shading-jdbc 4.0.0-RC1

2019-05-13 Thread GitBox
wenweibin opened a new issue #2379: delete from user where id=“xx” parse error in shading-jdbc 4.0.0-RC1 URL: https://github.com/apache/incubator-shardingsphere/issues/2379 When I upgrade sharding-jdbc version to 4.0.0-RC1, the SQL: `delete from user where id=“xx” `cannot execute

[GitHub] [incubator-shardingsphere] tuohai666 removed a comment on issue #2240: Feature/bug fix

2019-05-13 Thread GitBox
tuohai666 removed a comment on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485376975 Let's talk in that issue instead of this place. This is an automated

[GitHub] [incubator-shardingsphere] Moriadry removed a comment on issue #2240: Feature/bug fix

2019-05-13 Thread GitBox
Moriadry removed a comment on issue #2240: Feature/bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/2240#issuecomment-485367410 @tuohai666 one more thing, I'm trying to help with some sharding-proxy bug like this:

[GitHub] [incubator-shardingsphere] bigkun commented on issue #2378: In single project, how to realize using sharding-jdbc in sharding scenario, but don't use sharding-jdbc in none sharding scenario.

2019-05-13 Thread GitBox
bigkun commented on issue #2378: In single project, how to realize using sharding-jdbc in sharding scenario, but don't use sharding-jdbc in none sharding scenario. URL: https://github.com/apache/incubator-shardingsphere/issues/2378#issuecomment-492061777 We use mybatis in our springboot

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2345: sharding-proxy 1046 - No database selected

2019-05-13 Thread GitBox
terrymanu commented on issue #2345: sharding-proxy 1046 - No database selected URL: https://github.com/apache/incubator-shardingsphere/issues/2345#issuecomment-492061646 I will close this issue soon if no response any more

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2359: shardingproxy 4.0.0-RC2:insert error

2019-05-13 Thread GitBox
terrymanu commented on issue #2359: shardingproxy 4.0.0-RC2:insert error URL: https://github.com/apache/incubator-shardingsphere/issues/2359#issuecomment-492060963 Obviously, the title is mistake because not all insert SQL are caused error. So can you change the title to let it for

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2361: about 11000000 data insertion,just find 21000data success,there is no any errors i could find.

2019-05-13 Thread GitBox
terrymanu commented on issue #2361: about 1100 data insertion,just find 21000data success,there is no any errors i could find. URL: https://github.com/apache/incubator-shardingsphere/issues/2361#issuecomment-492060691 If no response **more than 7 days** and we cannot reproduce it on

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #1910: blob column insert exception: Unknown exception: INSERT INTO column size mismatch value size

2019-05-13 Thread GitBox
tuohai666 commented on issue #1910: blob column insert exception: Unknown exception: INSERT INTO column size mismatch value size URL: https://github.com/apache/incubator-shardingsphere/issues/1910#issuecomment-492060587 > Duplicate with #1567. > Will be fixed together. Not the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-492059940 Can you close the issue if problem is resolved?

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
terrymanu commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-492059830 Can you close the issue if problem is resolved?

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2341: How to dynamic table in v3.1?

2019-05-13 Thread GitBox
terrymanu closed issue #2341: How to dynamic table in v3.1? URL: https://github.com/apache/incubator-shardingsphere/issues/2341 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2341: How to dynamic table in v3.1?

2019-05-13 Thread GitBox
terrymanu commented on issue #2341: How to dynamic table in v3.1? URL: https://github.com/apache/incubator-shardingsphere/issues/2341#issuecomment-492059549 Closed cause by no response any more This is an automated message

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2378: In single project, how to realize using sharding-jdbc in sharding scenario, but don't use sharding-jdbc in none sharding scenari

2019-05-13 Thread GitBox
terrymanu commented on issue #2378: In single project, how to realize using sharding-jdbc in sharding scenario, but don't use sharding-jdbc in none sharding scenario. URL: https://github.com/apache/incubator-shardingsphere/issues/2378#issuecomment-492059245 You can create more than one

[GitHub] [incubator-shardingsphere] wenweibin commented on issue #2378: In single project, how to realize using sharding-jdbc in sharding scenario, but don't use sharding-jdbc in none sharding scenari

2019-05-13 Thread GitBox
wenweibin commented on issue #2378: In single project, how to realize using sharding-jdbc in sharding scenario, but don't use sharding-jdbc in none sharding scenario. URL: https://github.com/apache/incubator-shardingsphere/issues/2378#issuecomment-492053252 You can get connection from

[GitHub] [incubator-shardingsphere] KevinQian commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
KevinQian commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-492046572 > we'd like to move it after `sharding-transaction-spring-boot` is statable. currently it depends

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2155: optimize performance for DAL SQL like show tables

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2155: optimize performance for DAL SQL like show tables URL: https://github.com/apache/incubator-shardingsphere/issues/2155#issuecomment-492036758 we have provided a DataSourceGroupBroadcastRoutingEngine to resolve this issue, see more at #2376

[GitHub] [incubator-shardingsphere] cherrylzhao closed issue #2155: optimize performance for DAL SQL like show tables

2019-05-13 Thread GitBox
cherrylzhao closed issue #2155: optimize performance for DAL SQL like show tables URL: https://github.com/apache/incubator-shardingsphere/issues/2155 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2301: sharding-proxy doesn't has some tables in the config default datasource, why?

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2301: sharding-proxy doesn't has some tables in the config default datasource,why? URL: https://github.com/apache/incubator-shardingsphere/issues/2301#issuecomment-492036259 @tianyijushi I have fixed this issue, you can verify it again.

[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2331: While using database, it will select a random database!!!

2019-05-13 Thread GitBox
cherrylzhao edited a comment on issue #2331: While using database,it will select a random database!!! URL: https://github.com/apache/incubator-shardingsphere/issues/2331#issuecomment-491135463 enhance task is below. - [x] add DataSourceGroupBroadcastRoutingEngine for show xxx - [ ]

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2331: While using database, it will select a random database!!!

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2331: While using database,it will select a random database!!! URL: https://github.com/apache/incubator-shardingsphere/issues/2331#issuecomment-492035852 @tianyijushi I have fixed this issue, you can verify it again.

[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2331: While using database, it will select a random database!!!

2019-05-13 Thread GitBox
cherrylzhao edited a comment on issue #2331: While using database,it will select a random database!!! URL: https://github.com/apache/incubator-shardingsphere/issues/2331#issuecomment-491135463 enhance task is below. - [x] add DataSourceGroupBroadcastRoutingEngine for show xxx - [x]

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2191: MySQL encrypt test

2019-05-13 Thread GitBox
terrymanu closed issue #2191: MySQL encrypt test URL: https://github.com/apache/incubator-shardingsphere/issues/2191 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2376: for #2331 add DataSourceGroupBroadcastRoutingEngine.

2019-05-13 Thread GitBox
coveralls commented on issue #2376: for #2331 add DataSourceGroupBroadcastRoutingEngine. URL: https://github.com/apache/incubator-shardingsphere/pull/2376#issuecomment-491828095 ## Pull Request Test Coverage Report for [Build 8040](https://coveralls.io/builds/23350192) * **34** of

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2376: for #2331 add DataSourceGroupBroadcastRoutingEngine.

2019-05-13 Thread GitBox
terrymanu merged pull request #2376: for #2331 add DataSourceGroupBroadcastRoutingEngine. URL: https://github.com/apache/incubator-shardingsphere/pull/2376 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2377: #2191 for encrypt test

2019-05-13 Thread GitBox
terrymanu merged pull request #2377: #2191 for encrypt test URL: https://github.com/apache/incubator-shardingsphere/pull/2377 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2377: #2191 for encrypt test

2019-05-13 Thread GitBox
coveralls commented on issue #2377: #2191 for encrypt test URL: https://github.com/apache/incubator-shardingsphere/pull/2377#issuecomment-491819245 ## Pull Request Test Coverage Report for [Build 8049](https://coveralls.io/builds/23349610) * **0** of **5** **(0.0%)** changed or

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2375: #1910, blob column insert exception

2019-05-13 Thread GitBox
terrymanu merged pull request #2375: #1910, blob column insert exception URL: https://github.com/apache/incubator-shardingsphere/pull/2375 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2375: #1910, blob column insert exception

2019-05-13 Thread GitBox
coveralls edited a comment on issue #2375: #1910, blob column insert exception URL: https://github.com/apache/incubator-shardingsphere/pull/2375#issuecomment-491767483 ## Pull Request Test Coverage Report for [Build 8042](https://coveralls.io/builds/23348562) * **0** of **0**

[GitHub] [incubator-shardingsphere] codefairy08 opened a new pull request #2377: #2191 for encrypt test

2019-05-13 Thread GitBox
codefairy08 opened a new pull request #2377: #2191 for encrypt test URL: https://github.com/apache/incubator-shardingsphere/pull/2377 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2375: #1910, blob column insert exception

2019-05-13 Thread GitBox
coveralls commented on issue #2375: #1910, blob column insert exception URL: https://github.com/apache/incubator-shardingsphere/pull/2375#issuecomment-491767483 ## Pull Request Test Coverage Report for [Build 8037](https://coveralls.io/builds/23346486) * **0** of **0** changed

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #2376: for #2331 add DataSourceGroupBroadcastRoutingEngine.

2019-05-13 Thread GitBox
cherrylzhao opened a new pull request #2376: for #2331 add DataSourceGroupBroadcastRoutingEngine. URL: https://github.com/apache/incubator-shardingsphere/pull/2376 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2374: Reconstruct SchemaToken and IndexToken

2019-05-13 Thread GitBox
terrymanu merged pull request #2374: Reconstruct SchemaToken and IndexToken URL: https://github.com/apache/incubator-shardingsphere/pull/2374 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2363: #2191 MySQL encrypt test

2019-05-13 Thread GitBox
terrymanu merged pull request #2363: #2191 MySQL encrypt test URL: https://github.com/apache/incubator-shardingsphere/pull/2363 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2374: Reconstruct SchemaToken and IndexToken

2019-05-13 Thread GitBox
coveralls commented on issue #2374: Reconstruct SchemaToken and IndexToken URL: https://github.com/apache/incubator-shardingsphere/pull/2374#issuecomment-491739274 ## Pull Request Test Coverage Report for [Build 8035](https://coveralls.io/builds/23344827) * **10** of **20**

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2374: Reconstruct SchemaToken and IndexToken

2019-05-13 Thread GitBox
tristaZero opened a new pull request #2374: Reconstruct SchemaToken and IndexToken URL: https://github.com/apache/incubator-shardingsphere/pull/2374 #2275 - [x] Question in EncryptWhereColumnPlaceholder, between should not supported - [x] Should not call SQLUtil.getExactlyValue on

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
tristaZero edited a comment on issue #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373#issuecomment-491688473 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x]

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491715108 You can take a look at `org.apache.shardingsphere.core.parse.ShardingSQLParseEngine`

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2287: Weekly Report of ShardingSphere (2019.4.8 to 2019.4.12)

2019-05-13 Thread GitBox
terrymanu closed issue #2287: Weekly Report of ShardingSphere (2019.4.8 to 2019.4.12) URL: https://github.com/apache/incubator-shardingsphere/issues/2287 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491703075 we'd like to move it after `sharding-transaction-spring-boot` is statable. currently id depends

[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
cherrylzhao edited a comment on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491703075 we'd like to move it after `sharding-transaction-spring-boot` is statable. currently it

[GitHub] [incubator-shardingsphere] KevinQian commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
KevinQian commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491701523 > please see https://github.com/sharding-sphere/shardingsphere-spi-impl thanks, cherry. I

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491701233 Is there an interface to load sql or warm-up parsing engine now?

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2363: #2191 MySQL encrypt test

2019-05-13 Thread GitBox
coveralls commented on issue #2363: #2191 MySQL encrypt test URL: https://github.com/apache/incubator-shardingsphere/pull/2363#issuecomment-491697869 ## Pull Request Test Coverage Report for [Build 8022](https://coveralls.io/builds/23342503) * **0** of **6** **(0.0%)** changed

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
terrymanu merged pull request #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
coveralls commented on issue #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373#issuecomment-491692613 ## Pull Request Test Coverage Report for [Build 8021](https://coveralls.io/builds/23342155) * **15** of **28**

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-13 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-13 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-13 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491690111 please see https://github.com/sharding-sphere/shardingsphere-spi-impl

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
tristaZero edited a comment on issue #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373#issuecomment-491688473 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x]

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
tristaZero opened a new pull request #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373 #2275 This is an automated message from the Apache Git Service. To respond to