[GitHub] [incubator-shardingsphere] harry-lianghairui removed a comment on issue #3041: Can not find the table while the sharding key not transmit

2019-09-15 Thread GitBox
harry-lianghairui removed a comment on issue #3041: Can not find the table while the sharding key not transmit URL: https://github.com/apache/incubator-shardingsphere/issues/3041#issuecomment-531631390 Thank you so much! I have solve the proble by the follow way: it must config the

[GitHub] [incubator-shardingsphere] yanickxia commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops

2019-09-15 Thread GitBox
yanickxia commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#discussion_r324516708 ## File path:

[GitHub] [incubator-shardingsphere] yanyzy commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops

2019-09-15 Thread GitBox
yanyzy commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#discussion_r324513917 ## File path:

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops

2019-09-15 Thread GitBox
tuohai666 commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#discussion_r324511936 ## File path:

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops

2019-09-15 Thread GitBox
tuohai666 commented on a change in pull request #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#discussion_r324511229 ## File path:

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on issue #174: Fix issues 173

2019-09-15 Thread GitBox
cherrylzhao commented on issue #174: Fix issues 173 URL: https://github.com/apache/incubator-shardingsphere-example/pull/174#issuecomment-531635371 I have reviewed the `application-local-zookeeper-sharding-databases-tables.properties`, it's OK

[GitHub] [incubator-shardingsphere-example] cherrylzhao closed issue #171: Seata example can't run.

2019-09-15 Thread GitBox
cherrylzhao closed issue #171: Seata example can't run. URL: https://github.com/apache/incubator-shardingsphere-example/issues/171 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere-example] cherrylzhao merged pull request #177: Fix issues 171

2019-09-15 Thread GitBox
cherrylzhao merged pull request #177: Fix issues 171 URL: https://github.com/apache/incubator-shardingsphere-example/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on issue #177: Fix issues 171

2019-09-15 Thread GitBox
cherrylzhao commented on issue #177: Fix issues 171 URL: https://github.com/apache/incubator-shardingsphere-example/pull/177#issuecomment-531634634 thanks for contribution ! This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere-example] harvies commented on issue #174: Fix issues 173

2019-09-15 Thread GitBox
harvies commented on issue #174: Fix issues 173 URL: https://github.com/apache/incubator-shardingsphere-example/pull/174#issuecomment-531633722 Example "orchestration-spring-boot-example" already edited,Others have tested resubmitted later.

[GitHub] [incubator-shardingsphere-example] harvies commented on issue #177: Fix issues 171

2019-09-15 Thread GitBox
harvies commented on issue #177: Fix issues 171 URL: https://github.com/apache/incubator-shardingsphere-example/pull/177#issuecomment-531633443 already edited This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] yanyzy commented on issue #3034: Optimize performance, reduce unnecessary loops

2019-09-15 Thread GitBox
yanyzy commented on issue #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#issuecomment-531631589 @tuohai666 I tested it locally using the following code ```java @Test public void valueOfBenchmark() {

[GitHub] [incubator-shardingsphere] Erzhoumu commented on issue #2962: when the tables in the DB is too much, the sharding init so slow

2019-09-15 Thread GitBox
Erzhoumu commented on issue #2962: when the tables in the DB is too much, the sharding init so slow URL: https://github.com/apache/incubator-shardingsphere/issues/2962#issuecomment-531631485 4.0.0-RC1 This is an automated

[GitHub] [incubator-shardingsphere] harry-lianghairui commented on issue #3041: Can not find the table while the sharding key not transmit

2019-09-15 Thread GitBox
harry-lianghairui commented on issue #3041: Can not find the table while the sharding key not transmit URL: https://github.com/apache/incubator-shardingsphere/issues/3041#issuecomment-531631390 Thank you so much! I have solve the proble by the follow way: it must config the attribute

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2947: Distributed transaction Seata

2019-09-15 Thread GitBox
cherrylzhao commented on issue #2947: Distributed transaction Seata URL: https://github.com/apache/incubator-shardingsphere/issues/2947#issuecomment-531628741 close it since it is no response for a long time This is an

[GitHub] [incubator-shardingsphere] cherrylzhao closed issue #2947: Distributed transaction Seata

2019-09-15 Thread GitBox
cherrylzhao closed issue #2947: Distributed transaction Seata URL: https://github.com/apache/incubator-shardingsphere/issues/2947 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere-example] cherrylzhao merged pull request #176: Fix issues 175

2019-09-15 Thread GitBox
cherrylzhao merged pull request #176: Fix issues 175 URL: https://github.com/apache/incubator-shardingsphere-example/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere-example] cherrylzhao closed issue #175: Example 'sharding-proxy-boot-mybatis-example' can't run.

2019-09-15 Thread GitBox
cherrylzhao closed issue #175: Example 'sharding-proxy-boot-mybatis-example' can't run. URL: https://github.com/apache/incubator-shardingsphere-example/issues/175 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on issue #176: Fix issues 175

2019-09-15 Thread GitBox
cherrylzhao commented on issue #176: Fix issues 175 URL: https://github.com/apache/incubator-shardingsphere-example/pull/176#issuecomment-531626329 thanks for contribution. This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on issue #174: Fix issues 173

2019-09-15 Thread GitBox
cherrylzhao commented on issue #174: Fix issues 173 URL: https://github.com/apache/incubator-shardingsphere-example/pull/174#issuecomment-531625830 it is better to add a default-datasource-name instead of adding sharding-rule for t_user, since we don't use this table directly except

[GitHub] [incubator-shardingsphere] harry-lianghairui opened a new issue #3041: Can not find the table while the sharding key not transmit

2019-09-15 Thread GitBox
harry-lianghairui opened a new issue #3041: Can not find the table while the sharding key not transmit URL: https://github.com/apache/incubator-shardingsphere/issues/3041 the table user_buy is shared into 16 tables as user_buy_{0..15}, sharding key is uid, the version:4.0.0-RC1 can not

[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on issue #177: Fix issues 171

2019-09-15 Thread GitBox
cherrylzhao commented on issue #177: Fix issues 171 URL: https://github.com/apache/incubator-shardingsphere-example/pull/177#issuecomment-531623548 thanks for contribution, first please set your idea editor like this

[GitHub] [incubator-shardingsphere] taojintianxia edited a comment on issue #2962: when the tables in the DB is too much, the sharding init so slow

2019-09-15 Thread GitBox
taojintianxia edited a comment on issue #2962: when the tables in the DB is too much, the sharding init so slow URL: https://github.com/apache/incubator-shardingsphere/issues/2962#issuecomment-531618142 > > dude, I tried to create 20,000 tables on my poor Mac, even it becomes so slowly

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3020: Add Config Center

2019-09-15 Thread GitBox
coveralls edited a comment on issue #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#issuecomment-530290587 ## Pull Request Test Coverage Report for [Build 343](https://coveralls.io/builds/25719503) * **40** of **141** **(28.37%)**

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3023: fix bug 2193

2019-09-15 Thread GitBox
coveralls edited a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530365060 ## Pull Request Test Coverage Report for [Build 329](https://coveralls.io/builds/25669988) * **0** of **4** **(0.0%)** changed or

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-15 Thread GitBox
coveralls commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-531618898 ## Pull Request Test Coverage Report for [Build 325](https://coveralls.io/builds/25651951) * **43** of **95**

[GitHub] [incubator-shardingsphere] taojintianxia commented on issue #2962: when the tables in the DB is too much, the sharding init so slow

2019-09-15 Thread GitBox
taojintianxia commented on issue #2962: when the tables in the DB is too much, the sharding init so slow URL: https://github.com/apache/incubator-shardingsphere/issues/2962#issuecomment-531618142 > > dude, I tried to create 20,000 tables on my poor Mac, even it becomes so slowly when I

[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #3035: run sql "select * from pp"....exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist"

2019-09-15 Thread GitBox
KomachiSion edited a comment on issue #3035: run sql "select * from pp"exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist" URL: https://github.com/apache/incubator-shardingsphere/issues/3035#issuecomment-531617054 @beijing-penguin , Please add actualNodes

[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #3035: run sql "select * from pp"....exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist"

2019-09-15 Thread GitBox
KomachiSion edited a comment on issue #3035: run sql "select * from pp"exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist" URL: https://github.com/apache/incubator-shardingsphere/issues/3035#issuecomment-531617054 @beijing-penguin , Please add actualNodes

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3035: run sql "select * from pp"....exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist"

2019-09-15 Thread GitBox
KomachiSion commented on issue #3035: run sql "select * from pp"exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist" URL: https://github.com/apache/incubator-shardingsphere/issues/3035#issuecomment-531617054 @beijing-penguin , Please add actualNodes to

[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #3035: run sql "select * from pp"....exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist"

2019-09-15 Thread GitBox
KomachiSion edited a comment on issue #3035: run sql "select * from pp"exception is "java.sql.SQLSyntaxErrorException: Table 'test.pp' doesn't exist" URL: https://github.com/apache/incubator-shardingsphere/issues/3035#issuecomment-531617054 @beijing-penguin , Please add actualNodes

[GitHub] [incubator-shardingsphere] harvies opened a new issue #3040: Mysql Workbench cannot connect to sharding-proxy.

2019-09-15 Thread GitBox
harvies opened a new issue #3040: Mysql Workbench cannot connect to sharding-proxy. URL: https://github.com/apache/incubator-shardingsphere/issues/3040 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: -

[GitHub] [incubator-shardingsphere-example] harvies closed pull request #172: Fixes #171.

2019-09-15 Thread GitBox
harvies closed pull request #172: Fixes #171. URL: https://github.com/apache/incubator-shardingsphere-example/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere-example] harvies opened a new pull request #177: Fix issues 171

2019-09-15 Thread GitBox
harvies opened a new pull request #177: Fix issues 171 URL: https://github.com/apache/incubator-shardingsphere-example/pull/177 Fixes #171. Changes proposed in this pull request: - - - This is an automated

[GitHub] [incubator-shardingsphere-example] harvies opened a new pull request #176: Fix issues 175

2019-09-15 Thread GitBox
harvies opened a new pull request #176: Fix issues 175 URL: https://github.com/apache/incubator-shardingsphere-example/pull/176 Fixes #175. Changes proposed in this pull request: - - - This is an automated

[GitHub] [incubator-shardingsphere-example] harvies opened a new issue #175: Example 'sharding-proxy-boot-mybatis-example' can't run.

2019-09-15 Thread GitBox
harvies opened a new issue #175: Example 'sharding-proxy-boot-mybatis-example' can't run. URL: https://github.com/apache/incubator-shardingsphere-example/issues/175 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have:

[GitHub] [incubator-shardingsphere-example] harvies commented on issue #175: Example 'sharding-proxy-boot-mybatis-example' can't run.

2019-09-15 Thread GitBox
harvies commented on issue #175: Example 'sharding-proxy-boot-mybatis-example' can't run. URL: https://github.com/apache/incubator-shardingsphere-example/issues/175#issuecomment-531564359 I will submit a pr request. This is

[GitHub] [incubator-shardingsphere] siweizuse commented on issue #2962: when the tables in the DB is too much, the sharding init so slow

2019-09-15 Thread GitBox
siweizuse commented on issue #2962: when the tables in the DB is too much, the sharding init so slow URL: https://github.com/apache/incubator-shardingsphere/issues/2962#issuecomment-531556727 > dude, I tried to create 20,000 tables on my poor Mac, even it becomes so slowly when I execute

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3039: sharding-ui-frontend add unit test

2019-09-15 Thread GitBox
coveralls commented on issue #3039: sharding-ui-frontend add unit test URL: https://github.com/apache/incubator-shardingsphere/pull/3039#issuecomment-531553139 ## Pull Request Test Coverage Report for [Build 347](https://coveralls.io/builds/25720891) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3037: Refactor and simplify insert optimized engine

2019-09-15 Thread GitBox
terrymanu merged pull request #3037: Refactor and simplify insert optimized engine URL: https://github.com/apache/incubator-shardingsphere/pull/3037 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] wqzwh opened a new pull request #3039: sharding-ui-frontend add unit test

2019-09-15 Thread GitBox
wqzwh opened a new pull request #3039: sharding-ui-frontend add unit test URL: https://github.com/apache/incubator-shardingsphere/pull/3039 Fixes #3038 . sharding-ui-frontend add unit test - [x] componet unit test - [x] pages unit test add packages: - "karma":

[GitHub] [incubator-shardingsphere-example] harvies opened a new pull request #174: fix "org.hibernate.tool.hbm2ddl.SchemaExport : Cannot find table rul…

2019-09-15 Thread GitBox
harvies opened a new pull request #174: fix "org.hibernate.tool.hbm2ddl.SchemaExport : Cannot find table rul… URL: https://github.com/apache/incubator-shardingsphere-example/pull/174 …e and default data source with logic table: 't_user'" Fixes #173. Changes proposed in this

[GitHub] [incubator-shardingsphere-example] harvies opened a new issue #173: The example runs error.

2019-09-15 Thread GitBox
harvies opened a new issue #173: The example runs error. URL: https://github.com/apache/incubator-shardingsphere-example/issues/173 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3020: Add Config Center

2019-09-15 Thread GitBox
coveralls edited a comment on issue #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#issuecomment-530290587 ## Pull Request Test Coverage Report for [Build 346](https://coveralls.io/builds/25720114) * **40** of **141** **(28.37%)**

[GitHub] [incubator-shardingsphere] wqzwh opened a new issue #3038: sharding-ui-frontend add unit test

2019-09-15 Thread GitBox
wqzwh opened a new issue #3038: sharding-ui-frontend add unit test URL: https://github.com/apache/incubator-shardingsphere/issues/3038 sharding-ui-frontend add unit test - [ ] componet unit test - [ ] pages unit test add packages: - "karma": "^4.3.0" -