[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #4198: Remove empty test cases for VisitorParameterizedParsingTest

2020-02-06 Thread GitBox
KomachiSion merged pull request #4198: Remove empty test cases for VisitorParameterizedParsingTest URL: https://github.com/apache/incubator-shardingsphere/pull/4198 This is an automated message from the Apache Git Service.

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4198: Remove empty test cases for VisitorParameterizedParsingTest

2020-02-06 Thread GitBox
terrymanu opened a new pull request #4198: Remove empty test cases for VisitorParameterizedParsingTest URL: https://github.com/apache/incubator-shardingsphere/pull/4198 For #3947. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #4188: sharding +encrypt rewrite for SQL `select with `OR` and `AND`` cause StringIndexOutOfBoundsException.

2020-02-06 Thread GitBox
xiyelife commented on issue #4188: sharding +encrypt rewrite for SQL `select with `OR` and `AND`` cause StringIndexOutOfBoundsException. URL: https://github.com/apache/incubator-shardingsphere/issues/4188#issuecomment-583270289 where's predicate contains `OR` operator that makes encrypt

[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #4188: sharding +encrypt rewrite for SQL `select with `OR` and `AND`` cause StringIndexOutOfBoundsException.

2020-02-06 Thread GitBox
xiyelife edited a comment on issue #4188: sharding +encrypt rewrite for SQL `select with `OR` and `AND`` cause StringIndexOutOfBoundsException. URL: https://github.com/apache/incubator-shardingsphere/issues/4188#issuecomment-583270289 where predicate contains `OR` operator that makes

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4197: Travis config

2020-02-06 Thread GitBox
tuohai666 merged pull request #4197: Travis config URL: https://github.com/apache/incubator-shardingsphere/pull/4197 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4197: Travis config

2020-02-06 Thread GitBox
kimmking commented on a change in pull request #4197: Travis config URL: https://github.com/apache/incubator-shardingsphere/pull/4197#discussion_r376240759 ## File path: .travis.yml ## @@ -1,15 +1,21 @@ -sudo: required -cache: - directories: -- "$HOME/.m2" -

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4197: Travis config

2020-02-06 Thread GitBox
tuohai666 commented on issue #4197: Travis config URL: https://github.com/apache/incubator-shardingsphere/pull/4197#issuecomment-583259296 Please add labels and milestone. I think this pr is also applicable for 4.0.1 branch.

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4197: Travis config

2020-02-06 Thread GitBox
tuohai666 commented on a change in pull request #4197: Travis config URL: https://github.com/apache/incubator-shardingsphere/pull/4197#discussion_r376237092 ## File path: .travis.yml ## @@ -1,15 +1,21 @@ -sudo: required -cache: - directories: -- "$HOME/.m2" -

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4195: Remove SQLVisitor

2020-02-06 Thread GitBox
tristaZero merged pull request #4195: Remove SQLVisitor URL: https://github.com/apache/incubator-shardingsphere/pull/4195 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] tristaZero closed issue #3914: Optimization for Sharing Parser with Antlr Visitor

2020-02-06 Thread GitBox
tristaZero closed issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4195: Remove SQLVisitor

2020-02-06 Thread GitBox
coveralls commented on issue #4195: Remove SQLVisitor URL: https://github.com/apache/incubator-shardingsphere/pull/4195#issuecomment-583236419 ## Pull Request Test Coverage Report for [Build 9355](https://coveralls.io/builds/28582499) * **0** of **1** **(0.0%)** changed or added

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4196: old DCL set default role test unit dose not pass

2020-02-06 Thread GitBox
terrymanu commented on issue #4196: old DCL set default role test unit dose not pass URL: https://github.com/apache/incubator-shardingsphere/issues/4196#issuecomment-583234268 This is not bug, it is a normal assert. The failure reason just like the error message said: ``` The

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4196: old DCL set default role test unit dose not pass

2020-02-06 Thread GitBox
terrymanu closed issue #4196: old DCL set default role test unit dose not pass URL: https://github.com/apache/incubator-shardingsphere/issues/4196 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] beijing-penguin opened a new issue #4196: set default role old test dose not pass

2020-02-06 Thread GitBox
beijing-penguin opened a new issue #4196: set default role old test dose not pass URL: https://github.com/apache/incubator-shardingsphere/issues/4196 i add set-default-role.xml to incubator-shardingsphere\shardingsphere-sql-parser\shardingsphere-sql-parser-test\src\test\resources\sql,but

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4195: Remove SQLVisitor

2020-02-06 Thread GitBox
terrymanu opened a new pull request #4195: Remove SQLVisitor URL: https://github.com/apache/incubator-shardingsphere/pull/4195 Fixes #3914. Use ParseTreeVisitor instead of SQLVisitor. Avoid create a new interface to increase complexity.

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #4037: sharding+encrypt when sql contains "\n",sql rewrite error for mybatis. (in)

2020-02-06 Thread GitBox
xiyelife commented on issue #4037: sharding+encrypt when sql contains "\n",sql rewrite error for mybatis. (in) URL: https://github.com/apache/incubator-shardingsphere/issues/4037#issuecomment-583221283 @SteNicholas I add parse logic of the IN operator bracket's index for encrypt

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3914: Optimization for Sharing Parser with Antlr Visitor

2020-02-06 Thread GitBox
tristaZero commented on issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-583220969 Here are some remaining task from my position, MySQL visitor progress: - DAL **(In charge of

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4191: set role and set default role visit parse

2020-02-06 Thread GitBox
tristaZero commented on a change in pull request #4191: set role and set default role visit parse URL: https://github.com/apache/incubator-shardingsphere/pull/4191#discussion_r376197916 ## File path:

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4190: Add mysql grant visitor for DCLStatement

2020-02-06 Thread GitBox
tristaZero commented on a change in pull request #4190: Add mysql grant visitor for DCLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4190#discussion_r376194678 ## File path:

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4194: Rename ListValue to CollectionValue

2020-02-06 Thread GitBox
tristaZero merged pull request #4194: Rename ListValue to CollectionValue URL: https://github.com/apache/incubator-shardingsphere/pull/4194 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`

2020-02-06 Thread GitBox
xiyelife commented on a change in pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r` URL: https://github.com/apache/incubator-shardingsphere/pull/4193#discussion_r376192010 ## File path:

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4166: refactor orchestration config for apollo.

2020-02-06 Thread GitBox
dongzl commented on issue #4166: refactor orchestration config for apollo. URL: https://github.com/apache/incubator-shardingsphere/pull/4166#issuecomment-583190548 /run ci This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4166: refactor orchestration config for apollo.

2020-02-06 Thread GitBox
dongzl removed a comment on issue #4166: refactor orchestration config for apollo. URL: https://github.com/apache/incubator-shardingsphere/pull/4166#issuecomment-583190548 /run ci This is an automated message from the

[incubator-shardingsphere-benchmark] branch master updated: for performance

2020-02-06 Thread zhaoyanan
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new 2548fa9 for

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4194: Rename ListValue to CollectionValue

2020-02-06 Thread GitBox
coveralls edited a comment on issue #4194: Rename ListValue to CollectionValue URL: https://github.com/apache/incubator-shardingsphere/pull/4194#issuecomment-583033596 ## Pull Request Test Coverage Report for [Build 9350](https://coveralls.io/builds/28573084) * **0** of **11**

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4194: Rename ListValue to CollectionValue

2020-02-06 Thread GitBox
coveralls commented on issue #4194: Rename ListValue to CollectionValue URL: https://github.com/apache/incubator-shardingsphere/pull/4194#issuecomment-583033596 ## Pull Request Test Coverage Report for [Build 1627](https://coveralls.io/builds/28572284) * **0** of **11**

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`

2020-02-06 Thread GitBox
terrymanu commented on a change in pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r` URL: https://github.com/apache/incubator-shardingsphere/pull/4193#discussion_r375971137 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4194: Rename ListValue to CollectionValue

2020-02-06 Thread GitBox
terrymanu opened a new pull request #4194: Rename ListValue to CollectionValue URL: https://github.com/apache/incubator-shardingsphere/pull/4194 For #3914. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r`

2020-02-06 Thread GitBox
xiyelife opened a new pull request #4193: Fixes #4037. IN operator contains space and `\n` `\t` `\r` URL: https://github.com/apache/incubator-shardingsphere/pull/4193 Fixes #4037. Changes proposed in this pull request: - parse the IN operator bracket's index for encrypt rewirte

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4190: Add mysql grant visitor for DCLStatement

2020-02-06 Thread GitBox
coveralls commented on issue #4190: Add mysql grant visitor for DCLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4190#issuecomment-582924391 ## Pull Request Test Coverage Report for [Build 9348](https://coveralls.io/builds/28567283) * **0** of **19**

[GitHub] [incubator-shardingsphere] lklkxcxc opened a new issue #4192: insert float type vaule report "10002 - 2Unknown exception"

2020-02-06 Thread GitBox
lklkxcxc opened a new issue #4192: insert float type vaule report "10002 - 2Unknown exception" URL: https://github.com/apache/incubator-shardingsphere/issues/4192 Sharding-proxy version: 4.0.0-RC1 Problems encountered: mysql import sql found insert and delete loat type vaule

[GitHub] [incubator-shardingsphere] beijing-penguin opened a new pull request #4191: set role and set default role visit parse

2020-02-06 Thread GitBox
beijing-penguin opened a new pull request #4191: set role and set default role visit parse URL: https://github.com/apache/incubator-shardingsphere/pull/4191 Changes proposed in this pull request: - add set default role grammar visit and xml test - fix set role sql grammar error

[GitHub] [incubator-shardingsphere] tianbin1001 opened a new pull request #4190: Add mysql grant visitor for DCLStatement

2020-02-06 Thread GitBox
tianbin1001 opened a new pull request #4190: Add mysql grant visitor for DCLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4190 Add mysql grant visitor for DCLStatement This is an automated message

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4186: modify createInSegment() for select

2020-02-06 Thread GitBox
coveralls edited a comment on issue #4186: modify createInSegment() for select URL: https://github.com/apache/incubator-shardingsphere/pull/4186#issuecomment-582874056 ## Pull Request Test Coverage Report for [Build 9343](https://coveralls.io/builds/28565665) * **0** of **24**

[GitHub] [incubator-shardingsphere] cielswift opened a new issue #3993: Start error with yml

2020-02-06 Thread GitBox
cielswift opened a new issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993 spring boot version 2.2 jdk 13 sharding 4.0.0-RC3 I searched most of the cases and configured them with properties But I used yml, but something went

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3993: Start error with yml

2020-02-06 Thread GitBox
terrymanu commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-582879925 Any update? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3993: Start error with yml

2020-02-06 Thread GitBox
terrymanu closed issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3971: Why does the encrypted table only judge the first one, maybe left join encrypt table, and then judge that there is no encrypted

2020-02-06 Thread GitBox
terrymanu commented on issue #3971: Why does the encrypted table only judge the first one, maybe left join encrypt table, and then judge that there is no encrypted table URL: https://github.com/apache/incubator-shardingsphere/issues/3971#issuecomment-582879471 Can you provide your SQL

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection - chec

2020-02-06 Thread GitBox
terrymanu closed issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection - check your data for consistency URL: https://github.com/apache/incubator-shardingsphere/issues/3970

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3927: Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing the norm

2020-02-06 Thread GitBox
terrymanu closed issue #3927: Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing the normal operation of other SQL URL: https://github.com/apache/incubator-shardingsphere/issues/3927

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3919: config datasource dynamic by program or outside order?

2020-02-06 Thread GitBox
terrymanu closed issue #3919: config datasource dynamic by program or outside order? URL: https://github.com/apache/incubator-shardingsphere/issues/3919 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3927: Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing th

2020-02-06 Thread GitBox
terrymanu commented on issue #3927: Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing the normal operation of other SQL URL: https://github.com/apache/incubator-shardingsphere/issues/3927#issuecomment-582878606

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3886: Can we consider sharing the pool of sharded data source connections?

2020-02-06 Thread GitBox
terrymanu closed issue #3886: Can we consider sharing the pool of sharded data source connections? URL: https://github.com/apache/incubator-shardingsphere/issues/3886 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4008: The insert statement reported an error

2020-02-06 Thread GitBox
terrymanu commented on issue #4008: The insert statement reported an error URL: https://github.com/apache/incubator-shardingsphere/issues/4008#issuecomment-582877975 Closed for no response anymore. This is an automated

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4008: The insert statement reported an error

2020-02-06 Thread GitBox
terrymanu closed issue #4008: The insert statement reported an error URL: https://github.com/apache/incubator-shardingsphere/issues/4008 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4031: Duplicate entry '425919356283650049' for key 'PRIMARY'

2020-02-06 Thread GitBox
terrymanu commented on issue #4031: Duplicate entry '425919356283650049' for key 'PRIMARY' URL: https://github.com/apache/incubator-shardingsphere/issues/4031#issuecomment-582877756 Closed for no response anymore. This is

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4053: default-data-source-name

2020-02-06 Thread GitBox
terrymanu closed issue #4053: default-data-source-name URL: https://github.com/apache/incubator-shardingsphere/issues/4053 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4031: Duplicate entry '425919356283650049' for key 'PRIMARY'

2020-02-06 Thread GitBox
terrymanu closed issue #4031: Duplicate entry '425919356283650049' for key 'PRIMARY' URL: https://github.com/apache/incubator-shardingsphere/issues/4031 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4180: Inline strategy cannot support range sharding

2020-02-06 Thread GitBox
terrymanu commented on issue #4180: Inline strategy cannot support range sharding URL: https://github.com/apache/incubator-shardingsphere/issues/4180#issuecomment-582877391 No, Inline strategy cannot support range sharding. More details please reference document and example

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4186: modify createInSegment() for select

2020-02-06 Thread GitBox
coveralls commented on issue #4186: modify createInSegment() for select URL: https://github.com/apache/incubator-shardingsphere/pull/4186#issuecomment-582874056 ## Pull Request Test Coverage Report for [Build 1625](https://coveralls.io/builds/28564985) * **0** of **24**

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4178: Only run literal SQL parser test cases if parameter absent

2020-02-06 Thread GitBox
tristaZero closed issue #4178: Only run literal SQL parser test cases if parameter absent URL: https://github.com/apache/incubator-shardingsphere/issues/4178 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4189: Fixes #4178

2020-02-06 Thread GitBox
tristaZero merged pull request #4189: Fixes #4178 URL: https://github.com/apache/incubator-shardingsphere/pull/4189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-shardingsphere] xiyelife opened a new issue #4188: sharding +encrypt rewrite for SQL `select with `OR` and `AND`` cause StringIndexOutOfBoundsException.

2020-02-06 Thread GitBox
xiyelife opened a new issue #4188: sharding +encrypt rewrite for SQL `select with `OR` and `AND`` cause StringIndexOutOfBoundsException. URL: https://github.com/apache/incubator-shardingsphere/issues/4188 ### Which version of ShardingSphere did you use? 4.0.0 ### Which project did

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4186: modify createInSegment() for select

2020-02-06 Thread GitBox
tristaZero opened a new pull request #4186: modify createInSegment() for select URL: https://github.com/apache/incubator-shardingsphere/pull/4186 #3914 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4185: Rename result variable

2020-02-06 Thread GitBox
tuohai666 merged pull request #4185: Rename result variable URL: https://github.com/apache/incubator-shardingsphere/pull/4185 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4184: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
tuohai666 merged pull request #4184: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4184 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4184: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
coveralls commented on issue #4184: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4184#issuecomment-582826846 ## Pull Request Test Coverage Report for [Build 9341](https://coveralls.io/builds/28562988) * **6** of **6**

[GitHub] [incubator-shardingsphere] plazmdk opened a new pull request #4185: Rename result variable

2020-02-06 Thread GitBox
plazmdk opened a new pull request #4185: Rename result variable URL: https://github.com/apache/incubator-shardingsphere/pull/4185 Changes proposed in this pull request: - Fixed naming issue in https://github.com/apache/incubator-shardingsphere/pull/4173

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4173: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
tuohai666 commented on issue #4173: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4173#issuecomment-582806703 You are right, the return value should named result.

[GitHub] [incubator-shardingsphere] plazmdk edited a comment on issue #4173: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
plazmdk edited a comment on issue #4173: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4173#issuecomment-582804090 I believe the code convensions are followed now - and another pr have been made for master Unless I

[GitHub] [incubator-shardingsphere] plazmdk commented on issue #4173: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
plazmdk commented on issue #4173: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4173#issuecomment-582804090 I believe the code convensions are followed now - and another pr have been made for master

[GitHub] [incubator-shardingsphere] plazmdk opened a new pull request #4184: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
plazmdk opened a new pull request #4184: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4184 Changes proposed in this pull request: - Set wasNull field which had wrong value when doing a LEFT JOIN FETCH via Hibernate resulting

[GitHub] [incubator-shardingsphere] avalon566 merged pull request #4183: Fix can't find job error

2020-02-06 Thread GitBox
avalon566 merged pull request #4183: Fix can't find job error URL: https://github.com/apache/incubator-shardingsphere/pull/4183 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4183: Fix can't find job error

2020-02-06 Thread GitBox
KomachiSion opened a new pull request #4183: Fix can't find job error URL: https://github.com/apache/incubator-shardingsphere/pull/4183 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4181: modify createInSegment() for select

2020-02-06 Thread GitBox
coveralls edited a comment on issue #4181: modify createInSegment() for select URL: https://github.com/apache/incubator-shardingsphere/pull/4181#issuecomment-582790749 ## Pull Request Test Coverage Report for [Build 1622](https://coveralls.io/builds/28561887) * **0** of **9**

[GitHub] [incubator-shardingsphere] avalon566 merged pull request #4181: modify createInSegment() for select

2020-02-06 Thread GitBox
avalon566 merged pull request #4181: modify createInSegment() for select URL: https://github.com/apache/incubator-shardingsphere/pull/4181 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4173: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
tuohai666 commented on issue #4173: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4173#issuecomment-582791411 @plazmdk You are right. GroupByStreamMergedResult overwrite the getValue() method but miss set the wasNull value.

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4181: modify createInSegment() for select

2020-02-06 Thread GitBox
coveralls commented on issue #4181: modify createInSegment() for select URL: https://github.com/apache/incubator-shardingsphere/pull/4181#issuecomment-582790749 ## Pull Request Test Coverage Report for [Build 9338](https://coveralls.io/builds/28561623) * **0** of **9** **(0.0%)**

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4173: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
tuohai666 commented on a change in pull request #4173: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4173#discussion_r375692472 ## File path:

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4173: Call setWasNull in GroupByStreamMergedResult

2020-02-06 Thread GitBox
tuohai666 commented on a change in pull request #4173: Call setWasNull in GroupByStreamMergedResult URL: https://github.com/apache/incubator-shardingsphere/pull/4173#discussion_r375692251 ## File path:

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #4180: Inline strategy cannot support range sharding

2020-02-06 Thread GitBox
KomachiSion commented on issue #4180: Inline strategy cannot support range sharding URL: https://github.com/apache/incubator-shardingsphere/issues/4180#issuecomment-582785368 You should code a `RangeShardingAlgorithm` and configure it as your range algorithm. example like :

[GitHub] [incubator-shardingsphere] succeo commented on issue #4180: Inline strategy cannot support range sharding

2020-02-06 Thread GitBox
succeo commented on issue #4180: Inline strategy cannot support range sharding URL: https://github.com/apache/incubator-shardingsphere/issues/4180#issuecomment-582782882 config: shardingColumn: f_id If you have a query for the range of columns in a separate table, how will it