TaoZhiMLND opened a new pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945 Fixes #1977. Changes proposed in this pull request: - [✓] change `shardingNamespace.xml` configuration. - [✓] create class `KeyGeneratorFactoryBean` extends `TypeBasedSPIConfiguration` implements `FactoryBean<ShardingKeyGenerator>`,leverage `FactoryBean` to create KeyGenerator. - [✓] modify class `KeyGeneratorConfiguration`~~extends TypeBasedSPIConfiguration~~，add member variables `ShardingKeyGenerator keyGenerator`. - [✓] modify class `KeyGeneratorBeanDefinitionParser` addConstructorArgReference with `KeyGenerator` by using TAG `generator-ref`. - [✓] modify class `TableRule`, shardingKeyGenerator=tableRuleConfig.getKeyGeneratorConfig().getKeyGenerator(). - [✓] modify class `ShardingRule`, use keyGeneratorConfiguration.getKeyGenerator() instead of create by ShardingKeyGeneratorServiceLoader. - [✓] modify correlative tests, add test on `ShardingKeyGenerator` Bean.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
