[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-11 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-530271720 If your codes are right, you'd better modify test cases instead of modify existing codes.

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-08 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-529278083 Sounds good. I'd like to see your pr to judge whether there's performance issue.

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-06 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-528775516 Look forward to you pr. This is an automated message

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-06 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-528736791 This prompt is OK. But please go through #2597 first, and find out can we recognize the exception is caused by an

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-08-01 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-517557000 I thinks you can study groovy script first and try to use the script to calculate the routing result.

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-07-29 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-515938472 @sunbufu Would you still like to enhance the verification of the shardingRule? The #2597 is mainly about routing to a

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-07-07 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-509058928 Of course, please go through #2597 first, after that let's discuss the rules.