[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2406: select Range determination of dynamic tables

2019-05-20 Thread GitBox
terrymanu commented on issue #2406: select Range determination of dynamic tables URL: https://github.com/apache/incubator-shardingsphere/issues/2406#issuecomment-493853194 > What do I need to do if I want to achieve >=, <=, or other conditions? Not support for now, if you are

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2362: {dataSource-1} inited takes a long time when use ORA12c

2019-05-20 Thread GitBox
cherrylzhao commented on issue #2362: {dataSource-1} inited takes a long time when use ORA12c URL: https://github.com/apache/incubator-shardingsphere/issues/2362#issuecomment-493856436 so I saw some tables don't contains "$", I think this is the reason. logic of loading metadata is here

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2410: Support encrypt for other databases

2019-05-20 Thread GitBox
terrymanu closed issue #2410: Support encrypt for other databases URL: https://github.com/apache/incubator-shardingsphere/issues/2410 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2411: Optimize parameterBuilder from rewriteEngine

2019-05-20 Thread GitBox
tristaZero opened a new pull request #2411: Optimize parameterBuilder from rewriteEngine URL: https://github.com/apache/incubator-shardingsphere/pull/2411 Fixes #2405.. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2409: Split parameterBuilder from rewriteEngine

2019-05-20 Thread GitBox
coveralls commented on issue #2409: Split parameterBuilder from rewriteEngine URL: https://github.com/apache/incubator-shardingsphere/pull/2409#issuecomment-493929106 ## Pull Request Test Coverage Report for [Build 8128](https://coveralls.io/builds/23487922) * **57** of **74**

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #2408: Refactor parse rule module

2019-05-20 Thread GitBox
terrymanu opened a new issue #2408: Refactor parse rule module URL: https://github.com/apache/incubator-shardingsphere/issues/2408 - [ ] Unify name: parsing, parser to parse This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2409: Split parameterBuilder from rewriteEngine

2019-05-20 Thread GitBox
terrymanu merged pull request #2409: Split parameterBuilder from rewriteEngine URL: https://github.com/apache/incubator-shardingsphere/pull/2409 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2411: Optimize parameterBuilder from rewriteEngine

2019-05-20 Thread GitBox
coveralls commented on issue #2411: Optimize parameterBuilder from rewriteEngine URL: https://github.com/apache/incubator-shardingsphere/pull/2411#issuecomment-493979124 ## Pull Request Test Coverage Report for [Build 8140](https://coveralls.io/builds/23490986) * **13** of **18**

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #2410: Support encrypt for other databases

2019-05-20 Thread GitBox
terrymanu opened a new issue #2410: Support encrypt for other databases URL: https://github.com/apache/incubator-shardingsphere/issues/2410 - [ ] PostgreSQL - [ ] Oracle - [ ] SQLServer This is an automated message from

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #2408: Refactor parse rule module

2019-05-20 Thread GitBox
terrymanu opened a new issue #2408: Refactor parse rule module URL: https://github.com/apache/incubator-shardingsphere/issues/2408 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2409: Split parameterBuilder from rewriteEngine

2019-05-20 Thread GitBox
tristaZero opened a new pull request #2409: Split parameterBuilder from rewriteEngine URL: https://github.com/apache/incubator-shardingsphere/pull/2409 Ref #2405. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2393: Error when use "spring.jpa.hibernate.naming.physical-strategy"

2019-05-20 Thread GitBox
KomachiSion commented on issue #2393: Error when use "spring.jpa.hibernate.naming.physical-strategy" URL: https://github.com/apache/incubator-shardingsphere/issues/2393#issuecomment-493876846 > @KomachiSion,Thanks > I see the reason for the problem. it works! > > but,I've used

[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2393: Error when use "spring.jpa.hibernate.naming.physical-strategy"

2019-05-20 Thread GitBox
KomachiSion closed issue #2393: Error when use "spring.jpa.hibernate.naming.physical-strategy" URL: https://github.com/apache/incubator-shardingsphere/issues/2393 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2084: Use 3rd generation parse engine instead of 2nd generation parse engine

2019-05-20 Thread GitBox
terrymanu closed issue #2084: Use 3rd generation parse engine instead of 2nd generation parse engine URL: https://github.com/apache/incubator-shardingsphere/issues/2084 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2362: {dataSource-1} inited takes a long time when use ORA12c

2019-05-20 Thread GitBox
cherrylzhao commented on issue #2362: {dataSource-1} inited takes a long time when use ORA12c URL: https://github.com/apache/incubator-shardingsphere/issues/2362#issuecomment-493866724 if there are huge of tables that need to be cached into ShardingMetaData, it would take a lot of time

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2154: hikari datasource connection-test-query become useless

2019-05-20 Thread GitBox
KomachiSion commented on issue #2154: hikari datasource connection-test-query become useless URL: https://github.com/apache/incubator-shardingsphere/issues/2154#issuecomment-493882667 The process of execute sql is `Application --> ShardingDataSource(parse, route) --> printSQL if

[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2154: hikari datasource connection-test-query become useless

2019-05-20 Thread GitBox
KomachiSion closed issue #2154: hikari datasource connection-test-query become useless URL: https://github.com/apache/incubator-shardingsphere/issues/2154 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2411: Optimize parameterBuilder from rewriteEngine

2019-05-20 Thread GitBox
terrymanu merged pull request #2411: Optimize parameterBuilder from rewriteEngine URL: https://github.com/apache/incubator-shardingsphere/pull/2411 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] TheRealHaui opened a new pull request #2412: New Unit Tests added

2019-05-20 Thread GitBox
TheRealHaui opened a new pull request #2412: New Unit Tests added URL: https://github.com/apache/incubator-shardingsphere/pull/2412 Added new Unit Tests to increase code coverage. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2412: New Unit Tests added

2019-05-20 Thread GitBox
coveralls commented on issue #2412: New Unit Tests added URL: https://github.com/apache/incubator-shardingsphere/pull/2412#issuecomment-494096529 ## Pull Request Test Coverage Report for [Build 8157](https://coveralls.io/builds/23497712) * **0** of **0** changed or added relevant

[GitHub] [incubator-shardingsphere] TheRealHaui commented on issue #2403: Small minor performance improvements

2019-05-20 Thread GitBox
TheRealHaui commented on issue #2403: Small minor performance improvements URL: https://github.com/apache/incubator-shardingsphere/pull/2403#issuecomment-494062788 You're welcome. This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2413: Delete schemaToken

2019-05-20 Thread GitBox
tristaZero opened a new pull request #2413: Delete schemaToken URL: https://github.com/apache/incubator-shardingsphere/pull/2413 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2413: Delete schemaToken

2019-05-20 Thread GitBox
terrymanu merged pull request #2413: Delete schemaToken URL: https://github.com/apache/incubator-shardingsphere/pull/2413 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2413: Delete schemaToken

2019-05-20 Thread GitBox
coveralls commented on issue #2413: Delete schemaToken URL: https://github.com/apache/incubator-shardingsphere/pull/2413#issuecomment-494224478 ## Pull Request Test Coverage Report for [Build 8158](https://coveralls.io/builds/23506126) * **2** of **7** **(28.57%)** changed or

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2336: Incorrect integer value: 'null' for column 'xxx' at row 1

2019-05-20 Thread GitBox
tristaZero commented on issue #2336: Incorrect integer value: 'null' for column 'xxx' at row 1 URL: https://github.com/apache/incubator-shardingsphere/issues/2336#issuecomment-494212640 Please pay attention on issues you submitted, because we maybe need more details. If no response

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2336: Incorrect integer value: 'null' for column 'xxx' at row 1

2019-05-20 Thread GitBox
tristaZero closed issue #2336: Incorrect integer value: 'null' for column 'xxx' at row 1 URL: https://github.com/apache/incubator-shardingsphere/issues/2336 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2397: MasterSlaveDatasource and shardingDatasource could be used together in shardingproxy?

2019-05-20 Thread GitBox
terrymanu commented on issue #2397: MasterSlaveDatasource and shardingDatasource could be used together in shardingproxy? URL: https://github.com/apache/incubator-shardingsphere/issues/2397#issuecomment-494222087 FYI:

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2412: New Unit Tests added

2019-05-20 Thread GitBox
terrymanu merged pull request #2412: New Unit Tests added URL: https://github.com/apache/incubator-shardingsphere/pull/2412 This is an automated message from the Apache Git Service. To respond to the message, please log on