[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-575017307 > Add a field? like `private boolean enabled;` Not a good idea, the NoneStrategy already means do nothing. If set a sub field `enabled`, Is it means a true switch when `enabled=true`? I think it will confuse users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-575014564 I find the problem is caused by springboot. springboot parse yaml and transfer to propertySource. At this time, springboot would ignore some item. I'm not sure whether there are some configuration so that springboot do not ignore them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #434: Add company to user list
haetao opened a new pull request #434: Add company to user list URL: https://github.com/apache/incubator-shardingsphere-doc/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #3997: carry pr#3863 from dev to 4.0.1
tuohai666 opened a new pull request #3997: carry pr#3863 from dev to 4.0.1 URL: https://github.com/apache/incubator-shardingsphere/pull/3997 Fixes #3861. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #3996: carry pr#3969 from dev to 4.0.1
tuohai666 opened a new pull request #3996: carry pr#3969 from dev to 4.0.1 URL: https://github.com/apache/incubator-shardingsphere/pull/3996 Fixes #3968. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on issue #3993: Start error with yml
haetao commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575009767 To be exact, ShardingSphere's compatibility with MySQL 8 is not good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #433: Correct orchestration configuration of java
haetao opened a new pull request #433: Correct orchestration configuration of java URL: https://github.com/apache/incubator-shardingsphere-doc/pull/433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue #3994: PostgreSQL current user
SteNicholas removed a comment on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-574999262 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on a change in pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on a change in pull request #3988: Using
multithreading make loadDefaultTables faster and remove repeat load
tableMetaData
URL:
https://github.com/apache/incubator-shardingsphere/pull/3988#discussion_r367245631
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java
##
@@ -206,19 +207,46 @@ public TableMetas loadAll(final ShardingRule
shardingRule) throws SQLException {
return result;
}
-private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
+private Map loadDefaultTables(final ShardingRule
shardingRule, final Map result) throws SQLException {
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (!actualDefaultDataSourceName.isPresent()) {
return Collections.emptyMap();
}
Collection tableNames =
loadAllTableNames(actualDefaultDataSourceName.get());
-Map result = new HashMap<>(tableNames.size(),
1);
-for (String each : tableNames) {
-result.put(each, load(each, shardingRule));
+removeRepeatTable(tableNames, result);
+List metaList =
executorEngine.execute(getTableNamesInput(tableNames), new
GroupedCallback() {
+@Override
+public Collection execute(final Collection
inputs, final boolean isTrunkThread, final Map dataMap) throws
SQLException {
+String logicTableName = inputs.iterator().next();
+Collection result = new LinkedList<>();
+result.add(load(logicTableName, shardingRule));
+return result;
+}
+});
+Object[] tableNameArr = tableNames.toArray();
+for (int i = 0, size = tableNames.size(); i < size; i++) {
Review comment:
> Why not `for (int i = 0; i < tableNames.size(); i++) `?
Avoid size() method multiple computations,,,for performance
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on a change in pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on a change in pull request #3988: Using
multithreading make loadDefaultTables faster and remove repeat load
tableMetaData
URL:
https://github.com/apache/incubator-shardingsphere/pull/3988#discussion_r367245267
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java
##
@@ -206,19 +207,46 @@ public TableMetas loadAll(final ShardingRule
shardingRule) throws SQLException {
return result;
}
-private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
+private Map loadDefaultTables(final ShardingRule
shardingRule, final Map result) throws SQLException {
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (!actualDefaultDataSourceName.isPresent()) {
return Collections.emptyMap();
}
Collection tableNames =
loadAllTableNames(actualDefaultDataSourceName.get());
-Map result = new HashMap<>(tableNames.size(),
1);
-for (String each : tableNames) {
-result.put(each, load(each, shardingRule));
+removeRepeatTable(tableNames, result);
Review comment:
> Why did you remove repeat table? For performance or anything else?
For performance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3994: PostgreSQL current user
SteNicholas commented on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-574999262 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on a change in pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on a change in pull request #3988: Using
multithreading make loadDefaultTables faster and remove repeat load
tableMetaData
URL:
https://github.com/apache/incubator-shardingsphere/pull/3988#discussion_r367245008
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java
##
@@ -206,19 +207,46 @@ public TableMetas loadAll(final ShardingRule
shardingRule) throws SQLException {
return result;
}
-private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
+private Map loadDefaultTables(final ShardingRule
shardingRule, final Map result) throws SQLException {
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (!actualDefaultDataSourceName.isPresent()) {
return Collections.emptyMap();
}
Collection tableNames =
loadAllTableNames(actualDefaultDataSourceName.get());
-Map result = new HashMap<>(tableNames.size(),
1);
-for (String each : tableNames) {
-result.put(each, load(each, shardingRule));
+removeRepeatTable(tableNames, result);
Review comment:
> If there are two tables with the same name `t1` and different structures
in ds0 and default ds seperately, do you think removeRepeatTable() could return
correct result list?
yes, load() methed will be get out the same as tableMetaData by table
name...loadShardingTables or loadDefaultTables execute load() method and only
first parameter table name is different.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #3991: Support scaling PostgreSQL
KomachiSion merged pull request #3991: Support scaling PostgreSQL URL: https://github.com/apache/incubator-shardingsphere/pull/3991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3994: PostgreSQL current user
tuohai666 commented on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-574990441 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cielswift commented on issue #3993: Start error with yml
cielswift commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-574990293 4.0 version does not support mysql8? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao closed pull request #432: update community/content/poweredby doc
haetao closed pull request #432: update community/content/poweredby doc URL: https://github.com/apache/incubator-shardingsphere-doc/pull/432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #432: update community/content/poweredby doc
haetao opened a new pull request #432: update community/content/poweredby doc URL: https://github.com/apache/incubator-shardingsphere-doc/pull/432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3991: Support scaling PostgreSQL
KomachiSion commented on issue #3991: Support scaling PostgreSQL URL: https://github.com/apache/incubator-shardingsphere/pull/3991#issuecomment-574982957 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on issue #3993: Start error with yml
haetao commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-574982247 Hi! ShardingSphere supports mysql5 at this version! Your driver is mysql8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin opened a new issue #3995: logicTable of ShardingSphereMetaData don't contain encrypt field in sharding-proxy when testing 'sharding+encrypt'
geomonlin opened a new issue #3995: logicTable of ShardingSphereMetaData don't contain encrypt field in sharding-proxy when testing 'sharding+encrypt' URL: https://github.com/apache/incubator-shardingsphere/issues/3995 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? **dev(5.0)** ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-Proxy ### Expected behavior tableMetaData contain encrypt field. ### Actual behavior tableMetaData don't contain encrypt field in MetaData. ### Reason analyze (If you can)   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas edited a comment on issue #3990: Parse engine rejects CURRENT_USER in 4.0.0
SteNicholas edited a comment on issue #3990: Parse engine rejects CURRENT_USER in 4.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/3990#issuecomment-574947143 @encodeering 4.0.0 PostgreSQLParser doesn't support `SELECT CURRENT_USER`, I would like to add the keyword to `simpleExpr`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on a change in pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
SteNicholas commented on a change in pull request #3988: Using multithreading
make loadDefaultTables faster and remove repeat load tableMetaData
URL:
https://github.com/apache/incubator-shardingsphere/pull/3988#discussion_r367220680
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java
##
@@ -206,19 +207,46 @@ public TableMetas loadAll(final ShardingRule
shardingRule) throws SQLException {
return result;
}
-private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
+private Map loadDefaultTables(final ShardingRule
shardingRule, final Map result) throws SQLException {
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (!actualDefaultDataSourceName.isPresent()) {
return Collections.emptyMap();
}
Collection tableNames =
loadAllTableNames(actualDefaultDataSourceName.get());
-Map result = new HashMap<>(tableNames.size(),
1);
-for (String each : tableNames) {
-result.put(each, load(each, shardingRule));
+removeRepeatTable(tableNames, result);
Review comment:
Why did you remove repeat table? For performance or anything else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on a change in pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
SteNicholas commented on a change in pull request #3988: Using multithreading
make loadDefaultTables faster and remove repeat load tableMetaData
URL:
https://github.com/apache/incubator-shardingsphere/pull/3988#discussion_r367220920
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java
##
@@ -206,19 +207,46 @@ public TableMetas loadAll(final ShardingRule
shardingRule) throws SQLException {
return result;
}
-private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
+private Map loadDefaultTables(final ShardingRule
shardingRule, final Map result) throws SQLException {
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (!actualDefaultDataSourceName.isPresent()) {
return Collections.emptyMap();
}
Collection tableNames =
loadAllTableNames(actualDefaultDataSourceName.get());
-Map result = new HashMap<>(tableNames.size(),
1);
-for (String each : tableNames) {
-result.put(each, load(each, shardingRule));
+removeRepeatTable(tableNames, result);
+List metaList =
executorEngine.execute(getTableNamesInput(tableNames), new
GroupedCallback() {
+@Override
+public Collection execute(final Collection
inputs, final boolean isTrunkThread, final Map dataMap) throws
SQLException {
+String logicTableName = inputs.iterator().next();
+Collection result = new LinkedList<>();
+result.add(load(logicTableName, shardingRule));
+return result;
+}
+});
+Object[] tableNameArr = tableNames.toArray();
+for (int i = 0, size = tableNames.size(); i < size; i++) {
Review comment:
Why not `for (int i = 0; i < tableNames.size(); i++) `?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3994: PostgreSQL current user
SteNicholas opened a new pull request #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994 Fixes #3990. PostgreSQLParser doesn't support `SELECT CURRENT_USER`, because `simpleExpr` of select statment lack of `CURRENT_USER` keyword. Changes proposed in this pull request: - add `CURRENT_USER` to `simpleExpr`, not `functionCall`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] leego86 commented on issue #3992: Sharding-JDBC lost insertValuesContexts when insert
leego86 commented on issue #3992: Sharding-JDBC lost insertValuesContexts when insert URL: https://github.com/apache/incubator-shardingsphere/issues/3992#issuecomment-574964370 sql parse exception  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] avalon566 commented on issue #3991: Support scaling PostgreSQL
avalon566 commented on issue #3991: Support scaling PostgreSQL URL: https://github.com/apache/incubator-shardingsphere/pull/3991#issuecomment-574961967 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cielswift opened a new issue #3993: Start error with yml
cielswift opened a new issue #3993: Start error with yml
URL: https://github.com/apache/incubator-shardingsphere/issues/3993
spring boot version 2.2
jdk 13
sharding 4.0.0-RC3
I searched most of the cases and configured them with properties
But I used yml, but something went wrong
Failed to configure a DataSource: 'url' attribute is not specified and no
embedded datasource could be configured.
Reason: Failed to determine a suitable driver class
This is my configuration
shardingsphere:
datasource:
names: ds0,ds1
ds0:
type: com.alibaba.druid.pool.DruidDataSource
driverClassName: com.mysql.cj.jdbc.Driver
url:
jdbc:mysql://mysql.ciel.cl:1600/ds0?seUnicode=true=UTF-8=false=Asia/Shanghai
username: root
password: ciel
ds1:
type: com.alibaba.druid.pool.DruidDataSource
driverClassName: com.mysql.cj.jdbc.Driver
url:
jdbc:mysql://mysql.ciel.cl:1601/ds1?seUnicode=true=UTF-8=false=Asia/Shanghai
username: root
password: ciel
sharding:
default-database-strategy:
inline:
sharding-column: id
algorithm-expression: ds$->{id % 2}
tables:
t_order:
actual-data-nodes: ds$->{0..1}.t_order$->{0..2}
table-strategy:
inline:
sharding-column: id
algorithm-expression: t_order$->{id % 2}
key-generator: #
column: id
type: SNOWFLAKE
#t_order_item:
# actual-data-nodes: ds$->{0..1}.t_order_item$->{0..1}
# table-strategy:
#inline:
# sharding-column: order_id
# algorithm-expression: t_order_item$->{order_id % 2}
props:
sql:
show: true #
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] leego86 opened a new issue #3992: Sharding-JDBC lost insertValuesContexts when insert
leego86 opened a new issue #3992: Sharding-JDBC lost insertValuesContexts when insert URL: https://github.com/apache/incubator-shardingsphere/issues/3992 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? 4.0.0 ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-JDBC ### Expected behavior insert table success ### Actual behavior sql not use route, products all table sql and mybatis exception ### Reason analyze (If you can) I guess columns is too many(89) couse sql analysis exception when structuring sqlStatementContext，shardingConditions is empty because there is no insertValueContexts in sqlStatementContext,so not use table rule and setting parameters exception debug:  exception: ``` org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: java.lang.IllegalStateException ### The error may involve defaultParameterMap ### The error occurred while setting parameters ### SQL: INSERT INTO orders ( id, orderId, outOrderId, orderType, state, createDate, paymentDate, issueDate, orderpayment, paymentStatus, splitTag, orderCategory, mergeDate, isSysMerge, mergeNumber, liangpinTag, logisticStatus, logisticVendorType, logisticVendor, paidAmount, isUrgent, username, baseStore, paymentType, shad_phoneNumber, shad_mobilephone, shad_countrySubentity, shad_cityName, shad_name, shad_addressLine1, shad_addressLine2, shippingFirstName, shad_postalZone, shad_latitudeValue, shad_longitudeValue, shad_countryIso3166Alpha2Code, shad_countryName, discount, carriageFee, serviceCharge, providerCode, version, source, buyerMemo, sellerMemo, invoicecontact_channelCode, invoicecontact_electronicMail, invoicecontact_name, invoicecontact_note, invoicecontact_telefax, invoicecontact_telephone, invoicecontact_value, invoicecontact_buyer, invoicecontact_taxpayernum, needinvoice, createdstate, prioritylevelcode, shippingtaxcategory, financeMemo, modifiedtime, reissuereason, storememo, scheduledshippingdate, oriorderid, lastname, reissuetype, contact_channelCode, contact_electronicMail, contact_name, contact_note, contact_telefax, contact_telephone, contact_value, parentorder, invoicetype, emailid, shippingandhandling, invoicecontent, shippinglastname, customerlocale, currencycode, employeeid, shippingmethod, firstname, creationtime, invoicetitle, expressSend, typecode, tenant, alipay_no ) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 1, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 'OrderData', 'single', ? ) , ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 1, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 'OrderData', 'single', ? ) , ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 1, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 'OrderData', 'single', ? ) , (
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhaoyanan pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new dd73fe8 for performance
dd73fe8 is described below
commit dd73fe864d5ca1e8bb8da2ac6c8349da097094c7
Author: nancyzrh
AuthorDate: Thu Jan 16 10:22:30 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index c3351f4..c936e95 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 8ccfead..5d88667 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 32238e1..47528fd 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index afff937..f1f4890 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type":
[GitHub] [incubator-shardingsphere] tmjGitAccount commented on issue #3964: Hintmanager databaseShardingOnly problem
tmjGitAccount commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-574947233 @KomachiSion spring: shardingsphere: props: sql: show: true sharding: default-database-strategy: hint: algorithm-class-name: com.a.b.c.OrderShardingAlgorithm datasource: names: dsa,dsb dsa: pool-name: dsa type: com.zaxxer.hikari.HikariDataSource driverClassName: com.mysql.jdbc.Driver jdbcUrl: xxx username: xxx password: xxx dsb: pool-name: dsb type: com.zaxxer.hikari.HikariDataSource driverClassName: com.mysql.jdbc.Driver jdbcUrl: xxx username: xxx password: xxx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3990: Parse engine rejects CURRENT_USER in 4.0.0
SteNicholas commented on issue #3990: Parse engine rejects CURRENT_USER in 4.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/3990#issuecomment-574947143 @encodeering 4.0.0 doesn't support this function call, I will add to parse rules. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] 54czp commented on issue #2652: Sharding-Proxy4.0.0-RC1 Not available 。The download address is http://mirrors.tuna.tsinghua.edu.cn/apache/incubator/shardingsphere
54czp commented on issue #2652: Sharding-Proxy4.0.0-RC1 Not available 。The download address is http://mirrors.tuna.tsinghua.edu.cn/apache/incubator/shardingsphere/4.0.0-RC1/apache-shardingsphere-incubating-4.0.0-RC1-sharding-proxy-bin.tar.gz URL: https://github.com/apache/incubator-shardingsphere/issues/2652#issuecomment-574946478 > download Sharding-Proxy4.0.0-RC1 ，and tar 。 > According to the official website， > start bin/start.bat , > it tells me 错误:找不到或无法加载主类 org.apache.shardingshpere.shardingproxy.Bootstrap > > and i fond in Sharding-Proxy4.0.0-RC1 the jar was lost . > > The download address is http://mirrors.tuna.tsinghua.edu.cn/apache/incubator/shardingsphere/4.0.0-RC1/apache-shardingsphere-incubating-4.0.0-RC1-sharding-proxy-bin.tar.gz Unzip-tar.gz.com is a free online service that allows you to convert any.tar.gz file into a.zip file that you can open with the default tools of your operating system.Just like you can access all the data stored in these files without installing special software. https://unzip-tar-gz.com/cn/ Unzip-tar.gz.com是一个免费的在线服务，它允许你任何.tar.gz文件转换成一个.zip文件，您可以与您的操作系统的默认工具打开。就像您可以访问存储在这些文件中的所有数据，而无需安装专用软件。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunyinhui commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)
sunyinhui commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-574946223 聚励云机械 https://www.cloudm.com This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3973: 4.0.0 dosen't support LocalDateTime
dongzl commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574941239 The 4.0.0 stable version was released just now, and 5.x is in development. There is no exact release time yet. You can stay focused on ShardingSphere community. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] avalon566 opened a new pull request #3991: Support scaling PostgreSQL
avalon566 opened a new pull request #3991: Support scaling PostgreSQL URL: https://github.com/apache/incubator-shardingsphere/pull/3991 For #3961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] encodeering opened a new issue #3990: Parse engine rejects CURRENT_USER in 4.0.0
encodeering opened a new issue #3990: Parse engine rejects CURRENT_USER in 4.0.0
URL: https://github.com/apache/incubator-shardingsphere/issues/3990
## Bug Report
### Which version of ShardingSphere did you use?
4.0.0
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
### Expected behavior
Update from 3.1.0 to 4.0.0 would not change the parser rules.
### Actual behavior
Integration tests fail because flyway can't perform a migration when
executing `select CURRENT_USER`
### Reason analyze (If you can)
```
org.postgresql:postgresql:42.2.6
org.flywaydb:flyway-core:5.2.4
org.testcontainers:postgresql:1.12.0
sql = "SELECT CURRENT_USER"
parseEngine = {SQLParseEngine@4966}
databaseTypeName = "PostgreSQL"
line 1:7 mismatched input 'CURRENT_USER' expecting {'U', 'u', '!', '~', '+',
'-', '*', '(', '{', '?', INSERT, UPDATE, DELETE, ALTER, DROP, TRUNCATE, SCHEMA,
REVOKE, ADD, SET, INDEX, KEY, FUNCTION, TRIGGER, PROCEDURE, DISTINCT, CASE,
CAST, IF, NOT, NULL, TRUE, FALSE, EXISTS, ALL, BEGIN, COMMIT, ROLLBACK,
SAVEPOINT, BOOLEAN, CHAR, INTERVAL, TIME, TIMESTAMP, LOCALTIME, LOCALTIMESTAMP,
YEAR, MONTH, DAY, HOUR, MINUTE, SECOND, MAX, MIN, SUM, COUNT, AVG, CURRENT,
ENABLE, DISABLE, INSTANCE, PRESERVE, DEFINER, SQL, CASCADED, LOCAL, CLOSE,
OPEN, NEXT, NAME, NAMES, INTEGER, REAL, DECIMAL, TYPE, ADMIN, BINARY, ESCAPE,
EXCLUDE, PARTITION, ROW, UNKNOWN, ALWAYS, CASCADE, GENERATED, ISOLATION, LEVEL,
OPTION, PRIVILEGES, READ, ROLE, ROWS, START, TRANSACTION, ACTION, CACHE,
CHARACTERISTICS, CLUSTER, COMMENTS, CONSTRAINTS, CURRENT_TIMESTAMP, CYCLE,
DATA, DATABASE, DEFAULTS, DEFERRED, DEPENDS, DOMAIN, EXCLUDING, EXECUTE,
EXTENDED, EXTENSION, EXTERNAL, EXTRACT, FILTER, FIRST, FOLLOWING, FORCE,
GLOBAL, IDENTITY, IMMEDIATE, INCLUDING, INCREMENT, INDEXES, INHERIT, INHERITS,
INCLUDE, LANGUAGE, LARGE, LAST, LOGGED, MAIN, MATCH, MAXVALUE, MINVALUE,
NOTHING, NULLS, OBJECT, OIDS, OVER, OWNED, OWNER, PARTIAL, PLAIN, PRECEDING,
RANGE, RENAME, REPLICA, RESET, RESTART, RESTRICT, ROUTINE, RULE, SECURITY,
SEQUENCE, SESSION, SHOW, SIMPLE, STATISTICS, STORAGE, TABLESPACE, TEMP,
TEMPORARY, UNBOUNDED, UNLOGGED, USAGE, VALID, VALIDATE, WITHIN, WITHOUT, ZONE,
OF, GROUPS, RECURSIVE, IDENTIFIER_, STRING_, NUMBER_, HEX_DIGIT_, BIT_NUM_}
java.lang.IllegalStateException
at
com.google.common.base.Preconditions.checkState(Preconditions.java:429)
at
org.apache.shardingsphere.sql.parser.core.extractor.util.ExtractorUtils.getFirstChildNode(ExtractorUtils.java:48)
at
org.apache.shardingsphere.sql.parser.core.extractor.impl.dml.select.SelectItemsExtractor.extract(SelectItemsExtractor.java:54)
at
org.apache.shardingsphere.sql.parser.core.extractor.SQLSegmentsExtractorEngine.extract(SQLSegmentsExtractorEngine.java:47)
at
org.apache.shardingsphere.sql.parser.core.SQLParseKernel.parse(SQLParseKernel.java:59)
at
org.apache.shardingsphere.sql.parser.SQLParseEngine.parse0(SQLParseEngine.java:70)
at
org.apache.shardingsphere.sql.parser.SQLParseEngine.parse(SQLParseEngine.java:52)
at
org.apache.shardingsphere.core.route.router.masterslave.MasterSlaveRouter.route(MasterSlaveRouter.java:56)
at
org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.MasterSlavePreparedStatement.(MasterSlavePreparedStatement.java:68)
at
org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.MasterSlavePreparedStatement.(MasterSlavePreparedStatement.java:53)
at
org.apache.shardingsphere.shardingjdbc.jdbc.core.connection.MasterSlaveConnection.prepareStatement(MasterSlaveConnection.java:76)
at
org.flywaydb.core.internal.jdbc.JdbcTemplate.prepareStatement(JdbcTemplate.java:333)
at
org.flywaydb.core.internal.jdbc.JdbcTemplate.queryForString(JdbcTemplate.java:190)
at
org.flywaydb.core.internal.database.postgresql.PostgreSQLConnection.(PostgreSQLConnection.java:48)
at
org.flywaydb.core.internal.database.postgresql.PostgreSQLDatabase.getConnection(PostgreSQLDatabase.java:56)
at
org.flywaydb.core.internal.database.postgresql.PostgreSQLDatabase.getConnection(PostgreSQLDatabase.java:31)
at
org.flywaydb.core.internal.database.base.Database.getMainConnection(Database.java:366)
at org.flywaydb.core.Flyway.prepareSchemas(Flyway.java:1773)
at org.flywaydb.core.Flyway.execute(Flyway.java:1678)
at org.flywaydb.core.Flyway.migrate(Flyway.java:1356)
```
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
Should be reproducible if the mentioned statement is executed with the
PostgreSQL SQLParseEngine
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3989: Add table owner and delimiter assertion
tristaZero merged pull request #3989: Add table owner and delimiter assertion URL: https://github.com/apache/incubator-shardingsphere/pull/3989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
coveralls commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-574639874 ## Pull Request Test Coverage Report for [Build 1381](https://coveralls.io/builds/28123225) * **0** of **20** **(0.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.06%**) to **65.893%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java](https://coveralls.io/builds/28123225/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fmetadata%2Floader%2FShardingTableMetaDataLoader.java#L198) | 0 | 20 | 0.0% | Totals | [](https://coveralls.io/builds/28123225) | | :-- | --: | | Change from base [Build 689](https://coveralls.io/builds/28117346): | -0.06% | | Covered Lines: | 10815 | | Relevant Lines: | 16413 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] devefx commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
devefx commented on issue #3977: The sharding-JDBC non-sharding policy,
NoneShardingStrategy, does not work in yml
URL:
https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574639640
This my configuration
```yml
shardingsphere:
datasource:
names: default, marketdata
default:
marketdata:
xxx
props:
sql:
show: true
sharding:
default-data-source-name: default
default-database-strategy:
standard:
sharding-column: uid
precise-algorithm-class-name:
my.shardingsphere.strategy.DatabasePreciseShardingAlgorithm
default-table-strategy:
standard:
sharding-column: uid
precise-algorithm-class-name:
my.shardingsphere.strategy.TablePreciseShardingAlgorithm
tables:
price_index:
actual-data-nodes: marketdata.price_index
database-strategy:
none: {}
table-strategy:
none: {}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3989: Add table owner and delimiter assertion
terrymanu opened a new pull request #3989: Add table owner and delimiter assertion URL: https://github.com/apache/incubator-shardingsphere/pull/3989 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] devefx commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
devefx commented on issue #3977: The sharding-JDBC non-sharding policy,
NoneShardingStrategy, does not work in yml
URL:
https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574638367
```java
package org.apache.shardingsphere.core.yaml.config.sharding.strategy;
import lombok.Data;
@Data
public final class YamlNoneShardingStrategyConfiguration implements
YamlBaseShardingStrategyConfiguration {
private boolean enabled;
}
```
This is me override
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574638323 Sorry, picture is not full configuration and quite inconvenient. Please paste congfiguration as a text to comment. You can remove some important data like username,password,url and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] devefx commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
devefx commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574636807  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy,
NoneShardingStrategy, does not work in yml
URL:
https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574635787
For my test,
```yaml
my_table:
database-strategy:
none: {}
```
This configuration can work.
Can you provide your full sharding configuration? Or example code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
tristaZero commented on a change in pull request #3988: Using multithreading
make loadDefaultTables faster and remove repeat load tableMetaData
URL:
https://github.com/apache/incubator-shardingsphere/pull/3988#discussion_r366844620
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java
##
@@ -206,19 +207,46 @@ public TableMetas loadAll(final ShardingRule
shardingRule) throws SQLException {
return result;
}
-private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
+private Map loadDefaultTables(final ShardingRule
shardingRule, final Map result) throws SQLException {
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (!actualDefaultDataSourceName.isPresent()) {
return Collections.emptyMap();
}
Collection tableNames =
loadAllTableNames(actualDefaultDataSourceName.get());
-Map result = new HashMap<>(tableNames.size(),
1);
-for (String each : tableNames) {
-result.put(each, load(each, shardingRule));
+removeRepeatTable(tableNames, result);
Review comment:
If there are two tables with the same name `t1` and different structures in
ds0 and default ds seperately, do you think removeRepeatTable() could return
correct result list?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] devefx commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
devefx commented on issue #3977: The sharding-JDBC non-sharding policy,
NoneShardingStrategy, does not work in yml
URL:
https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574633976
> @devefx Can you try to use?
>
> ```yaml
> my_table:
> database-strategy:
> none: {}
> ```
Still not working, a field must be included
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
tristaZero commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-574626422 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-574592977 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin opened a new pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat
beijing-penguin opened a new pull request #3988: Using multithreading make loadDefaultTables faster and remove repeat URL: https://github.com/apache/incubator-shardingsphere/pull/3988 Fixes #3979. Changes proposed in this pull request: - Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem
KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-574584713 @tmjGitAccount , Can you provide your full sharding configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ette9844 closed issue #3987: How to handle JNDI datasource in spring namespace?
ette9844 closed issue #3987: How to handle JNDI datasource in spring namespace? URL: https://github.com/apache/incubator-shardingsphere/issues/3987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy,
NoneShardingStrategy, does not work in yml
URL:
https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574545912
@devefx Can you try to use?
```yaml
my_table:
database-strategy:
none: {}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] joewee commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error
joewee commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error URL: https://github.com/apache/incubator-shardingsphere/issues/3856#issuecomment-574542715 > > Hi, is there any update about this issue ? @SteNicholas @terrymanu > > Sorry for the delay, and today I would validate the SQL. Thank you！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
