[GitHub] [shardingsphere] kimmking commented on issue #5714: shardingsphere框架的数据脱敏，SQL中不支持lower，trim等方法和 case when等语句吗
kimmking commented on issue #5714: URL: https://github.com/apache/shardingsphere/issues/5714#issuecomment-631433378 English only. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu opened a new pull request #5717: Create replica module & define replica rule
terrymanu opened a new pull request #5717: URL: https://github.com/apache/shardingsphere/pull/5717 For #5712. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5717: Create replica module & define replica rule
codecov-commenter commented on pull request #5717: URL: https://github.com/apache/shardingsphere/pull/5717#issuecomment-631580043 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=h1) Report > Merging [#5717](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ec2e4da6073b55668e337c7c0323fe4b929a9c02=desc) will **decrease** coverage by `0.10%`. > The diff coverage is `7.14%`. [](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5717 +/- ## - Coverage 53.48% 53.38% -0.11% Complexity 428 428 Files 1155 1161 +6 Lines 2044220481 +39 Branches 3680 3684 +4 Hits 1093410934 - Misses 8844 8883 +39 Partials664 664 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ica/api/config/ReplicaDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9hcGkvY29uZmlnL1JlcGxpY2FEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...pache/shardingsphere/replica/rule/ReplicaRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9ydWxlL1JlcGxpY2FSdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...hardingsphere/replica/rule/ReplicaRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9ydWxlL1JlcGxpY2FSdWxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...aml/config/YamlReplicaDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL2NvbmZpZy9ZYW1sUmVwbGljYURhdGFTb3VyY2VDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lica/yaml/config/YamlReplicaRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL2NvbmZpZy9ZYW1sUmVwbGljYVJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...l/swapper/ReplicaRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL3N3YXBwZXIvUmVwbGljYVJ1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...api/config/MasterSlaveDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtbWFzdGVyLXNsYXZlL3NoYXJkaW5nc3BoZXJlLW1hc3Rlci1zbGF2ZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL2FwaS9jb25maWcvTWFzdGVyU2xhdmVEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...config/YamlMasterSlaveDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtbWFzdGVyLXNsYXZlL3NoYXJkaW5nc3BoZXJlLW1hc3Rlci1zbGF2ZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL3lhbWwvY29uZmlnL1lhbWxNYXN0ZXJTbGF2ZURhdGFTb3VyY2VDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree-more) | | -- [Continue to review full
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5717: Create replica module & define replica rule
codecov-commenter edited a comment on pull request #5717: URL: https://github.com/apache/shardingsphere/pull/5717#issuecomment-631580043 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=h1) Report > Merging [#5717](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ec2e4da6073b55668e337c7c0323fe4b929a9c02=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `7.14%`. [](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5717 +/- ## - Coverage 53.48% 53.37% -0.12% Complexity 428 428 Files 1155 1160 +5 Lines 2044220475 +33 Branches 3680 3684 +4 - Hits 1093410928 -6 - Misses 8844 8883 +39 Partials664 664 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5717?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ica/api/config/ReplicaDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9hcGkvY29uZmlnL1JlcGxpY2FEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...pache/shardingsphere/replica/rule/ReplicaRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9ydWxlL1JlcGxpY2FSdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...hardingsphere/replica/rule/ReplicaRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9ydWxlL1JlcGxpY2FSdWxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...aml/config/YamlReplicaDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL2NvbmZpZy9ZYW1sUmVwbGljYURhdGFTb3VyY2VDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lica/yaml/config/YamlReplicaRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL2NvbmZpZy9ZYW1sUmVwbGljYVJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...l/swapper/ReplicaRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL3N3YXBwZXIvUmVwbGljYVJ1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...api/config/MasterSlaveDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtbWFzdGVyLXNsYXZlL3NoYXJkaW5nc3BoZXJlLW1hc3Rlci1zbGF2ZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL2FwaS9jb25maWcvTWFzdGVyU2xhdmVEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...config/YamlMasterSlaveDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtbWFzdGVyLXNsYXZlL3NoYXJkaW5nc3BoZXJlLW1hc3Rlci1zbGF2ZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL3lhbWwvY29uZmlnL1lhbWxNYXN0ZXJTbGF2ZURhdGFTb3VyY2VDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/5717/diff?src=pr=tree-more) | | -- [Continue to review
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5715: Sharding-Proxy Parse PostgreSQL SQLXML column type protocol.
codecov-commenter commented on pull request #5715: URL: https://github.com/apache/shardingsphere/pull/5715#issuecomment-631462754 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5715?src=pr=h1) Report > Merging [#5715](https://codecov.io/gh/apache/shardingsphere/pull/5715?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6b63077cebb55ad2b03373b0d80999465161d025=desc) will **decrease** coverage by `0.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/shardingsphere/pull/5715?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5715 +/- ## - Coverage 53.82% 53.46% -0.37% Complexity 428 428 Files 1150 1155 +5 Lines 2024920452 +203 Branches 3660 3681 +21 + Hits 1090010934 +34 - Misses 8686 8854 +168 - Partials663 664 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5715?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ocol/postgresql/constant/PostgreSQLColumnType.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9jb25zdGFudC9Qb3N0Z3JlU1FMQ29sdW1uVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...et/command/query/text/PostgreSQLDataRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS90ZXh0L1Bvc3RncmVTUUxEYXRhUm93UGFja2V0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...caling/postgresql/PostgreSQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC9Qb3N0Z3JlU1FMRGF0YVNvdXJjZUNoZWNrZXIuamF2YQ==) | `73.33% <0.00%> (-5.24%)` | `1.00% <0.00%> (ø%)` | | | [...ardingsphere/scaling/mysql/client/MySQLClient.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NsaWVudC9NeVNRTENsaWVudC5qYXZh) | `60.24% <0.00%> (-1.49%)` | `0.00% <0.00%> (ø%)` | | | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `67.32% <0.00%> (-0.66%)` | `1.00% <0.00%> (ø%)` | | | [...ngsphere/scaling/mysql/MySQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMRGF0YVNvdXJjZUNoZWNrZXIuamF2YQ==) | `84.09% <0.00%> (-0.29%)` | `1.00% <0.00%> (ø%)` | | | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...hardingsphere/scaling/mysql/MySQLBinlogDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/5715/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMQmlubG9nRHVtcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [shardingsphere] kimmking closed issue #5714: Are lower, trim and other methods and case... when... and other statements not supported in SQL?
kimmking closed issue #5714: URL: https://github.com/apache/shardingsphere/issues/5714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking edited a comment on issue #5714: Are lower, trim and other methods and case... when... and other statements not supported in SQL?
kimmking edited a comment on issue #5714: URL: https://github.com/apache/shardingsphere/issues/5714#issuecomment-631433378 English only. Not support yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] wubingting edited a comment on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)
wubingting edited a comment on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-630646492 ### 文章汇总 *** 已合并到第一个post This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #5544: Range from 0 to more than Integer.MAX_VALUE occur exception
strongduanmu commented on issue #5544:
URL: https://github.com/apache/shardingsphere/issues/5544#issuecomment-631467600
Hi, I reproduced the problem. I found that when ANTLR parses numeric values,
it will parse text into different numeric types based on its value. The parsing
code is as follows:
```java
private Number getNumber(final String value) {
try {
return getBigInteger(value);
} catch (final NumberFormatException ex) {
// TODO make sure with double and float
return new BigDecimal(value);
}
}
private static Number getBigInteger(final String value) {
BigInteger result = new BigInteger(value);
if (result.compareTo(new BigInteger(String.valueOf(Integer.MIN_VALUE)))
>= 0 && result.compareTo(new BigInteger(String.valueOf(Integer.MAX_VALUE))) <=
0) {
return result.intValue();
}
if (result.compareTo(new BigInteger(String.valueOf(Long.MIN_VALUE))) >=
0 && result.compareTo(new BigInteger(String.valueOf(Long.MAX_VALUE))) <= 0) {
return result.longValue();
}
return result;
}
```
When the user executes the range query sql, multiple ranges will be merged
by the mergeRouteValues method. Because the different types, the intersection
method will report a ClassCastException exception. the code is as follows:
```java
private Range> mergeRangeRouteValues(final
Range> value1, final Range> value2) {
return null == value2 ? value1 : value1.intersection(value2);
}
```
For better compatibility, can I use BigInteger to parse all numeric values?
I need some help to fix this issue. @kimmking @tristaZero
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] dongzl opened a new pull request #5715: Sharding-Proxy Parse PostgreSQL SQLXML column type protocol.
dongzl opened a new pull request #5715: URL: https://github.com/apache/shardingsphere/pull/5715 Fixes #5308 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhangyonglun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new ff55f90 for performance
ff55f90 is described below
commit ff55f902dc48f1fc336cb96a269cfd8446efb1da
Author: tuohai666
AuthorDate: Wed May 20 22:33:14 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 4ffee3c..bca1365 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index afc364b..c67f6ae 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 24acd9c..9cab18f 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index ea5394a..c626ec0 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_3.1"},
[GitHub] [shardingsphere] hhj-cmd opened a new issue #5714: shardingsphere框架的数据脱敏，SQL中不支持lower，trim等方法和 case when等语句吗
hhj-cmd opened a new issue #5714: URL: https://github.com/apache/shardingsphere/issues/5714 ## Question **For English only**, other languages will not accept. Before asking a question, make sure you have: - Googled your question. - Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking opened a new issue #5716: Improve ShardingSphere-UI
kimmking opened a new issue #5716: URL: https://github.com/apache/shardingsphere/issues/5716 After recently refactoring, it's time to improve ShardingSphere-UI to complete i18n and some bug fixes. - [ ] fix yaml parse in VUE with new rule config @menghaoranss - [ ] check and complete i18n text in UI - [ ] show metadata in UI - [ ] show cluster topology state graph in UI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl merged pull request #5717: Create replica module & define replica rule
dongzl merged pull request #5717: URL: https://github.com/apache/shardingsphere/pull/5717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #5713: Initialize heart beat module #control-panel-cluster
dongzl commented on a change in pull request #5713:
URL: https://github.com/apache/shardingsphere/pull/5713#discussion_r428396991
##
File path:
shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/org/apache/shardingsphere/cluster/heartbeat/event/AbstractHeartBeatEvent.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.event;
+
+import lombok.Getter;
+
+/**
+ * Abstract heart beat event.
+ */
+@Getter
+public class AbstractHeartBeatEvent implements HeartBeatEvent{
Review comment:
Need a blank character before `{` at end of line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #5713: Initialize heart beat module #control-panel-cluster
dongzl commented on a change in pull request #5713:
URL: https://github.com/apache/shardingsphere/pull/5713#discussion_r428399496
##
File path:
shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/org/apache/shardingsphere/cluster/heartbeat/task/HeartBeatTaskManager.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.task;
+
+import com.google.common.base.Preconditions;
+
+import java.util.Timer;
+
+/**
+ * Heart beat task manager.
+ */
+public final class HeartBeatTaskManager {
+
+private static final String TIMER_NAME =
"ShardingSphere-Cluster-HeartBeat";
+
+private Integer interval;
+
+private final Timer timer;
Review comment:
Is `Executors.newSingleThreadScheduledExecutor()` a good way?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #5357: agg function must include an alias stmt instead of exeucte it directly
tristaZero commented on issue #5357: URL: https://github.com/apache/shardingsphere/issues/5357#issuecomment-631868584 BTW, `./incubator-shardingsphere/shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSphereStatementTest.java` is recommended as a test entry for the `master branch`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gfYaya commented on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya commented on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631847505 > remove druid-spring-boot-starter and try again. It does not work... emmm. I guess, the matter is in the Sharding-jdbc datasource proxy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking closed pull request #5695: Fix5486
kimmking closed pull request #5695: URL: https://github.com/apache/shardingsphere/pull/5695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao opened a new pull request #5721: update mysql & postgresql version for proxy
cherrylzhao opened a new pull request #5721: URL: https://github.com/apache/shardingsphere/pull/5721 update mysql & postgresql version for proxy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #5719: Fix yaml parse in VUE
kimmking merged pull request #5719: URL: https://github.com/apache/shardingsphere/pull/5719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #5718: optimize spring boot datasource config.
kimmking merged pull request #5718: URL: https://github.com/apache/shardingsphere/pull/5718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on issue #5357: agg function must include an alias stmt instead of exeucte it directly
tristaZero edited a comment on issue #5357:
URL: https://github.com/apache/shardingsphere/issues/5357#issuecomment-631867252
Hi @xiaoma20082008
Thanks for your feedback. I tried the SQL `select
max(order_id),min(order_id) from t_order` in the `master branch` and there is
no exception, see this,
```
[INFO ] 12:02:50.003 [ShardingSphere-Command-1] ShardingSphere-SQL - Logic
SQL: show tables
[INFO ] 12:02:50.003 [ShardingSphere-Command-1] ShardingSphere-SQL -
SQLStatement:
CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.ShowTablesStatement@1977d221,
tablesContext=TablesContext(tables=[]))
[INFO ] 12:02:50.003 [ShardingSphere-Command-1] ShardingSphere-SQL - Actual
SQL: ds_0 ::: show tables
[INFO ] 12:02:50.118 [ShardingSphere-Command-2] ShardingSphere-SQL - Logic
SQL: SHOW COLUMNS FROM t_order_item FROM sharding_db
[INFO ] 12:02:50.118 [ShardingSphere-Command-2] ShardingSphere-SQL -
SQLStatement:
CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.ShowColumnsStatement@6b8dfa7c,
tablesContext=TablesContext(tables=[SimpleTableSegment(tableName=TableNameSegment(startIndex=18,
stopIndex=29, identifier=IdentifierValue(value=t_order_item,
quoteCharacter=NONE)), owner=Optional.empty, alias=Optional.empty)]))
[INFO ] 12:02:50.118 [ShardingSphere-Command-2] ShardingSphere-SQL - Actual
SQL: ds_0 ::: SHOW COLUMNS FROM t_order_item_0
[INFO ] 12:02:50.358 [ShardingSphere-Command-3] ShardingSphere-SQL - Logic
SQL: select max(order_id),min(order_id) from t_order
[INFO ] 12:02:50.358 [ShardingSphere-Command-3] ShardingSphere-SQL -
SQLStatement:
SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@18ddab5a,
tablesContext=TablesContext(tables=[SimpleTableSegment(tableName=TableNameSegment(startIndex=40,
stopIndex=46, identifier=IdentifierValue(value=t_order, quoteCharacter=NONE)),
owner=Optional.empty, alias=Optional.empty)])),
tablesContext=TablesContext(tables=[SimpleTableSegment(tableName=TableNameSegment(startIndex=40,
stopIndex=46, identifier=IdentifierValue(value=t_order, quoteCharacter=NONE)),
owner=Optional.empty, alias=Optional.empty)]),
projectionsContext=ProjectionsContext(startIndex=7, stopIndex=33,
distinctRow=false, projections=[AggregationProjection(type=MAX,
innerExpression=(order_id), alias=Optional.empty,
derivedAggregationProjections=[], index=-1), AggregationProjection(type=MIN,
innerExpression=(order_id), alias=Optional.empty,
derivedAggregationProjections=[], index=-1)]),
groupByContext=org.apache.shardingsphere.sql.parser.binder.segment.select.groupby.GroupByContext@6b5f856b,
orderByContext=org.apache.shardingsphere.sql.parser.binder.segment.select.orderby.OrderByContext@1dd18185,
paginationContext=org.apache.shardingsphere.sql.parser.binder.segment.select.pagination.PaginationContext@6532edb3,
containsSubquery=false)
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_0 ::: select max(order_id),min(order_id) from t_order_0
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_0 ::: select max(order_id),min(order_id) from t_order_1
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_1 ::: select max(order_id),min(order_id) from t_order_0
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_1 ::: select max(order_id),min(order_id) from t_order_1
```
My configuration is,
```yaml
schemaName: sharding_db
dataSources:
ds_0:
url:
jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC=false
username: root
password:
connectionTimeoutMilliseconds: 3
idleTimeoutMilliseconds: 6
maxLifetimeMilliseconds: 180
maxPoolSize: 50
ds_1:
url:
jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC=false
username: root
password:
connectionTimeoutMilliseconds: 3
idleTimeoutMilliseconds: 6
maxLifetimeMilliseconds: 180
maxPoolSize: 50
rules:
- !SHARDING
tables:
t_order:
actualDataNodes: ds_${0..1}.t_order_${0..1}
tableStrategy:
standard:
shardingColumn: order_id
shardingAlgorithm:
type: INLINE
props:
algorithm.expression: t_order_${order_id % 2}
keyGenerator:
type: SNOWFLAKE
column: order_id
t_order_item:
actualDataNodes: ds_${0..1}.t_order_item_${0..1}
tableStrategy:
standard:
shardingColumn: order_id
shardingAlgorithm:
type: INLINE
props:
algorithm.expression: t_order_item_${order_id % 2}
[GitHub] [shardingsphere] cherrylzhao opened a new pull request #5720: update mysql and postgresql server version
cherrylzhao opened a new pull request #5720: URL: https://github.com/apache/shardingsphere/pull/5720 mysql 5.6.4 => 8.0.20 postgresql 8.4 => 12.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5719: Fix yaml parse in VUE
codecov-commenter commented on pull request #5719: URL: https://github.com/apache/shardingsphere/pull/5719#issuecomment-631880189 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5719?src=pr=h1) Report > Merging [#5719](https://codecov.io/gh/apache/shardingsphere/pull/5719?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ce9163b4be008ff40659f8ae4d6de4a5fa7c8c7b=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/shardingsphere/pull/5719?src=pr=tree) ```diff @@Coverage Diff@@ ## master#5719 +/- ## = Coverage 53.37% 53.37% Complexity 428 428 = Files 1160 1160 Lines 2047520475 Branches 3684 3684 = Hits 1092810928 Misses 8883 8883 Partials664 664 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5719?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5719?src=pr=footer). Last update [ce9163b...5961be4](https://codecov.io/gh/apache/shardingsphere/pull/5719?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #5713: Initialize heart beat module #control-panel-cluster
dongzl commented on a change in pull request #5713:
URL: https://github.com/apache/shardingsphere/pull/5713#discussion_r428397538
##
File path:
shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/org/apache/shardingsphere/cluster/heartbeat/task/HeartBeatTaskManager.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.task;
+
+import com.google.common.base.Preconditions;
+
+import java.util.Timer;
+
+/**
+ * Heart beat task manager.
+ */
+public final class HeartBeatTaskManager {
+
+private static final String TIMER_NAME =
"ShardingSphere-Cluster-HeartBeat";
+
+private Integer interval;
+
+private final Timer timer;
+
+public HeartBeatTaskManager(final Integer interval) {
+this.interval = interval;
+timer = new Timer(TIMER_NAME);
+}
+
+/**
+ * Start heart beat task.
+ *
+ * @param heartBeatTask heart beat task
+ */
+public void start(final HeartBeatTask heartBeatTask) {
+Preconditions.checkNotNull(heartBeatTask, "task can not be null");
+timer.schedule(heartBeatTask, interval*1000, interval*1000);
Review comment:
Need a blank character at `*` left and right.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #5713: Initialize heart beat module #control-panel-cluster
dongzl commented on a change in pull request #5713:
URL: https://github.com/apache/shardingsphere/pull/5713#discussion_r428397179
##
File path:
shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/org/apache/shardingsphere/cluster/heartbeat/event/HeartBeatDetectNoticeEvent.java
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.event;
+
+/**
+ * Heart beat detect notice event.
+ */
+public final class HeartBeatDetectNoticeEvent extends AbstractHeartBeatEvent{
Review comment:
Need a blank character before `{` at end of line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] yu199195 opened a new pull request #5718: optimize spring boot datasource config.
yu199195 opened a new pull request #5718: URL: https://github.com/apache/shardingsphere/pull/5718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #5357: agg function must include an alias stmt instead of exeucte it directly
tristaZero commented on issue #5357:
URL: https://github.com/apache/shardingsphere/issues/5357#issuecomment-631867252
Hi @xiaoma20082008
Thanks for your feedback. I tried the SQL `select
max(order_id),min(order_id) from t_order` in the `master branch` and there is
no exception, see this,
```
[INFO ] 12:02:50.003 [ShardingSphere-Command-1] ShardingSphere-SQL - Logic
SQL: show tables
[INFO ] 12:02:50.003 [ShardingSphere-Command-1] ShardingSphere-SQL -
SQLStatement:
CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.ShowTablesStatement@1977d221,
tablesContext=TablesContext(tables=[]))
[INFO ] 12:02:50.003 [ShardingSphere-Command-1] ShardingSphere-SQL - Actual
SQL: ds_0 ::: show tables
[INFO ] 12:02:50.118 [ShardingSphere-Command-2] ShardingSphere-SQL - Logic
SQL: SHOW COLUMNS FROM t_order_item FROM sharding_db
[INFO ] 12:02:50.118 [ShardingSphere-Command-2] ShardingSphere-SQL -
SQLStatement:
CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.ShowColumnsStatement@6b8dfa7c,
tablesContext=TablesContext(tables=[SimpleTableSegment(tableName=TableNameSegment(startIndex=18,
stopIndex=29, identifier=IdentifierValue(value=t_order_item,
quoteCharacter=NONE)), owner=Optional.empty, alias=Optional.empty)]))
[INFO ] 12:02:50.118 [ShardingSphere-Command-2] ShardingSphere-SQL - Actual
SQL: ds_0 ::: SHOW COLUMNS FROM t_order_item_0
[INFO ] 12:02:50.358 [ShardingSphere-Command-3] ShardingSphere-SQL - Logic
SQL: select max(order_id),min(order_id) from t_order
[INFO ] 12:02:50.358 [ShardingSphere-Command-3] ShardingSphere-SQL -
SQLStatement:
SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@18ddab5a,
tablesContext=TablesContext(tables=[SimpleTableSegment(tableName=TableNameSegment(startIndex=40,
stopIndex=46, identifier=IdentifierValue(value=t_order, quoteCharacter=NONE)),
owner=Optional.empty, alias=Optional.empty)])),
tablesContext=TablesContext(tables=[SimpleTableSegment(tableName=TableNameSegment(startIndex=40,
stopIndex=46, identifier=IdentifierValue(value=t_order, quoteCharacter=NONE)),
owner=Optional.empty, alias=Optional.empty)]),
projectionsContext=ProjectionsContext(startIndex=7, stopIndex=33,
distinctRow=false, projections=[AggregationProjection(type=MAX,
innerExpression=(order_id), alias=Optional.empty,
derivedAggregationProjections=[], index=-1), AggregationProjection(type=MIN,
innerExpression=(order_id), alias=Optional.empty,
derivedAggregationProjections=[], index=-1)]),
groupByContext=org.apache.shardingsphere.sql.parser.binder.segment.select.groupby.GroupByContext@6b5f856b,
orderByContext=org.apache.shardingsphere.sql.parser.binder.segment.select.orderby.OrderByContext@1dd18185,
paginationContext=org.apache.shardingsphere.sql.parser.binder.segment.select.pagination.PaginationContext@6532edb3,
containsSubquery=false)
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_0 ::: select max(order_id),min(order_id) from t_order_0
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_0 ::: select max(order_id),min(order_id) from t_order_1
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_1 ::: select max(order_id),min(order_id) from t_order_0
[INFO ] 12:02:50.359 [ShardingSphere-Command-3] ShardingSphere-SQL - Actual
SQL: ds_1 ::: select max(order_id),min(order_id) from t_order_1
```
My configuration is,
```yaml
schemaName: sharding_db
dataSources:
ds_0:
url:
jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC=false
username: root
password:
connectionTimeoutMilliseconds: 3
idleTimeoutMilliseconds: 6
maxLifetimeMilliseconds: 180
maxPoolSize: 50
ds_1:
url:
jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC=false
username: root
password:
connectionTimeoutMilliseconds: 3
idleTimeoutMilliseconds: 6
maxLifetimeMilliseconds: 180
maxPoolSize: 50
rules:
- !SHARDING
tables:
t_order:
actualDataNodes: ds_${0..1}.t_order_${0..1}
tableStrategy:
standard:
shardingColumn: order_id
shardingAlgorithm:
type: INLINE
props:
algorithm.expression: t_order_${order_id % 2}
keyGenerator:
type: SNOWFLAKE
column: order_id
t_order_item:
actualDataNodes: ds_${0..1}.t_order_item_${0..1}
tableStrategy:
standard:
shardingColumn: order_id
shardingAlgorithm:
type: INLINE
props:
algorithm.expression: t_order_item_${order_id % 2}
[GitHub] [shardingsphere] menghaoranss opened a new pull request #5719: Fix yaml parse in VUE
menghaoranss opened a new pull request #5719: URL: https://github.com/apache/shardingsphere/pull/5719 For #5716 . Changes proposed in this pull request: - fix yaml parse errors in VUE - fix load menus errors This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #5713: Initialize heart beat module #control-panel-cluster
menghaoranss commented on a change in pull request #5713:
URL: https://github.com/apache/shardingsphere/pull/5713#discussion_r428449167
##
File path:
shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/org/apache/shardingsphere/cluster/heartbeat/task/HeartBeatTaskManager.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.task;
+
+import com.google.common.base.Preconditions;
+
+import java.util.Timer;
+
+/**
+ * Heart beat task manager.
+ */
+public final class HeartBeatTaskManager {
+
+private static final String TIMER_NAME =
"ShardingSphere-Cluster-HeartBeat";
+
+private Integer interval;
+
+private final Timer timer;
Review comment:
Yes, threadpool is better, i will fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on issue #5663: Upgrade nacos-client to 1.2.1 version, support more accurate watch event.
dongzl commented on issue #5663: URL: https://github.com/apache/shardingsphere/issues/5663#issuecomment-631894303 Although nacos enhance to monitor the key's change, but it doesn't meet ShardingSphere's configcenter's requirement. It will support in the future, so I close this issue now, and will reopen it in the future when nacos meet this requirement. ref: https://github.com/alibaba/nacos/issues/2836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl closed issue #5663: Upgrade nacos-client to 1.2.1 version, support more accurate watch event.
dongzl closed issue #5663: URL: https://github.com/apache/shardingsphere/issues/5663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] xiaoma20082008 commented on issue #5357: agg function must include an alias stmt instead of exeucte it directly
xiaoma20082008 commented on issue #5357: URL: https://github.com/apache/shardingsphere/issues/5357#issuecomment-631895092 ok,I'll try it later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl removed a comment on issue #5663: Upgrade nacos-client to 1.2.1 version, support more accurate watch event.
dongzl removed a comment on issue #5663: URL: https://github.com/apache/shardingsphere/issues/5663#issuecomment-631893063 ref: #2836 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on issue #5663: Upgrade nacos-client to 1.2.1 version, support more accurate watch event.
dongzl commented on issue #5663: URL: https://github.com/apache/shardingsphere/issues/5663#issuecomment-631893063 ref: #2836 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] yanyzy closed issue #5163: Add examples for shadow
yanyzy closed issue #5163: URL: https://github.com/apache/shardingsphere/issues/5163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5691: Initialize cluster state module
codecov-commenter edited a comment on pull request #5691: URL: https://github.com/apache/shardingsphere/pull/5691#issuecomment-631175202 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5691?src=pr=h1) Report > Merging [#5691](https://codecov.io/gh/apache/shardingsphere/pull/5691?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e0c3345461690b8c4f46b8148765f5c831cc3652=desc) will **decrease** coverage by `1.98%`. > The diff coverage is `47.05%`. [](https://codecov.io/gh/apache/shardingsphere/pull/5691?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5691 +/- ## - Coverage 55.66% 53.68% -1.99% + Complexity 430 428 -2 Files 1137 1154 +17 Lines 2020720309 +102 Branches 3665 3663 -2 - Hits 1124910903 -346 - Misses 8286 8743 +457 + Partials672 663 -9 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5691?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...dingsphere/cluster/state/ClusterStateInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItc3RhdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2NsdXN0ZXIvc3RhdGUvQ2x1c3RlclN0YXRlSW5zdGFuY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../shardingsphere/cluster/state/enums/NodeState.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItc3RhdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2NsdXN0ZXIvc3RhdGUvZW51bXMvTm9kZVN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ation/core/facade/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvZmFjYWRlL1NoYXJkaW5nT3JjaGVzdHJhdGlvbkZhY2FkZS5qYXZh) | `94.44% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ter/configuration/config/ClusterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2x1c3Rlci9jb25maWd1cmF0aW9uL2NvbmZpZy9DbHVzdGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...r/configuration/config/HeartBeatConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2x1c3Rlci9jb25maWd1cmF0aW9uL2NvbmZpZy9IZWFydEJlYXRDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ation/swapper/ClusterConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2x1c3Rlci9jb25maWd1cmF0aW9uL3N3YXBwZXIvQ2x1c3RlckNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [...r/configuration/yaml/YamlClusterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2x1c3Rlci9jb25maWd1cmF0aW9uL3lhbWwvWWFtbENsdXN0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...configuration/yaml/YamlHeartBeatConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5691/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2x1c3Rlci9jb25maWd1cmF0aW9uL3lhbWwvWWFtbEhlYXJ0QmVhdENvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00>
[GitHub] [shardingsphere] gfYaya removed a comment on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya removed a comment on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631273798  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #5701: Fix ClassCastException in ShardingSpherePreparedStatement and add spring namespace example for shadow
terrymanu merged pull request #5701: URL: https://github.com/apache/shardingsphere/pull/5701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhangyonglun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 0ea85d8 for performance
0ea85d8 is described below
commit 0ea85d8f4f99c487c3e23f6d7f1b989c2db221c2
Author: tuohai666
AuthorDate: Wed May 20 14:28:05 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index f40c3e7..4ffee3c 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 076438c..afc364b 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 0e7f4e6..24acd9c 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index b7b6f45..ea5394a 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_3.1"},
[GitHub] [shardingsphere] gfYaya edited a comment on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya edited a comment on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631273798  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gfYaya commented on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya commented on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631273798  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] yanyzy opened a new pull request #5701: Fix ClassCastException in ShardingSpherePreparedStatement and add spring namespace example for shadow
yanyzy opened a new pull request #5701: URL: https://github.com/apache/shardingsphere/pull/5701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gfYaya commented on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya commented on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631282266  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #5614: Use YAML file instead of inline string in ConfigCenterTest.java
terrymanu commented on pull request #5614: URL: https://github.com/apache/shardingsphere/pull/5614#issuecomment-631294912 @sukumaar Hi, any update? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gfYaya opened a new issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya opened a new issue #5700:
URL: https://github.com/apache/shardingsphere/issues/5700
I build my sharding-jdbc project according to this
page:https://shardingsphere.apache.org/document/current/cn/manual/shardingsphere-jdbc/configuration/config-spring-boot/
.
It's only effective in the 'properties' suffix configuration file, and the
console prints these exception info as the project with a 'yml' suffix
configuration file.
Exception info:
2020-05-20 14:16:01.114 [main] INFO com.alibaba.druid.pool.DruidDataSource -
{dataSource-1} inited
2020-05-20 14:16:01.132 [Druid-ConnectionPool-Create-730935981] ERROR
com.alibaba.druid.pool.DruidDataSource -
create connection SQLException, url: null,
errorCode 0, state 08001
java.sql.SQLNonTransientConnectionException: Cannot load connection class
because of underlying exception:
com.mysql.cj.exceptions.WrongArgumentException: The database URL cannot be null.
at
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:110)
at
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
at
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
at
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
at
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
at
com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:79)
at
com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:131)
at
com.mysql.cj.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:219)
at
com.alibaba.druid.pool.DruidAbstractDataSource.createPhysicalConnection(DruidAbstractDataSource.java:1596)
at
com.alibaba.druid.pool.DruidAbstractDataSource.createPhysicalConnection(DruidAbstractDataSource.java:1662)
at
com.alibaba.druid.pool.DruidDataSource$CreateConnectionThread.run(DruidDataSource.java:2601)
Caused by: com.mysql.cj.exceptions.UnableToConnectException: Cannot load
connection class because of underlying exception:
com.mysql.cj.exceptions.WrongArgumentException: The database URL cannot be null.
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:61)
at
com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:105)
... 4 common frames omitted
Caused by: com.mysql.cj.exceptions.WrongArgumentException: The database URL
cannot be null.
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:61)
at
com.mysql.cj.conf.ConnectionUrlParser.isConnectionStringSupported(ConnectionUrlParser.java:149)
at com.mysql.cj.conf.ConnectionUrl.acceptsUrl(ConnectionUrl.java:258)
at
com.mysql.cj.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:187)
... 3 common frames omitted
The same exception printed recursively.
This is my 'yml' configuration:
spring:
#spring sharding jdbc 配置
shardingsphere:
datasource:
names: dataaudit
dataaudit:
type: com.alibaba.druid.pool.DruidDataSource
driver-class-name: com.mysql.jdbc.Driver
jdbc-url:
jdbc:mysql://rm-uf6hnc20q03xba0l0ao.mysql.rds.aliyuncs.com:3306/jiaanpei_dataudit?allowMultiQueries=true=true=UTF-8
username: uatroot
password: Jiaanpei123Uat
sharding:
tables:
# janpb_goods_supp_standard_snapshot表分片策略
janpb_goods_supp_standard_snapshot:
table-strategy:
inline:
# 根据companyCode 进行分片
sharding-column: companyCode
algorithm-expression:
dataaudit.janpb_goods_supp_standard_snapshot_$->{companyCode % 32}
###分表的总数 0到31 janpb_goods_supp_standard_snapshot_0,
janpb_goods_supp_standard_snapshot_31
actual-data-nodes:
dataaudit.janpb_goods_supp_standard_snapshot_$->{0..31}
props:
sql:
### 开启分片日志
[GitHub] [shardingsphere] gfYaya removed a comment on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya removed a comment on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631281189  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gfYaya commented on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
gfYaya commented on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631281189  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu opened a new pull request #5702: Unify orchestration:data-source for spring namespace
terrymanu opened a new pull request #5702: URL: https://github.com/apache/shardingsphere/pull/5702 For #5508. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tuohai666 merged pull request #5702: Unify orchestration:data-source for spring namespace
tuohai666 merged pull request #5702: URL: https://github.com/apache/shardingsphere/pull/5702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #5700: What's the matter with this configuration in my 'yml' suffix file?
kimmking commented on issue #5700: URL: https://github.com/apache/shardingsphere/issues/5700#issuecomment-631306277 remove druid-spring-boot-starter and try again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] sukumaar commented on pull request #5614: Use YAML file instead of inline string in ConfigCenterTest.java
sukumaar commented on pull request #5614: URL: https://github.com/apache/shardingsphere/pull/5614#issuecomment-631321730 @terrymanu I have replied to your comment above and waiting for your reply. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] sukumaar commented on a change in pull request #5614: Use YAML file instead of inline string in ConfigCenterTest.java
sukumaar commented on a change in pull request #5614:
URL: https://github.com/apache/shardingsphere/pull/5614#discussion_r427829642
##
File path:
sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/test/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenterTest.java
##
@@ -552,4 +465,13 @@ private void
assertDataSourceConfigurationWithConnectionInitSqls(final DataSourc
assertThat(actual.getProperties().get("password"),
is(expected.getProperties().get("password")));
assertThat(actual.getProperties().get("connectionInitSqls"),
is(expected.getProperties().get("connectionInitSqls")));
}
+
+private static String readYamlFileIntoString(final String fileName) {
+try {
+return (new
String(Files.readAllBytes(Paths.get(ClassLoader.getSystemResource(fileName).toURI().replaceAll("#.*\n",
"");
Review comment:
@terrymanu could you please reply??
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #5691: Initialize cluster state module
kimmking merged pull request #5691: URL: https://github.com/apache/shardingsphere/pull/5691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #5627: [DISCUSS] ClusterState feature design
menghaoranss commented on issue #5627: URL: https://github.com/apache/shardingsphere/issues/5627#issuecomment-631338056 Because the zookeeper EPHEMERAL node does not support child nodes，so，we will persist Datasource state to `instance` node： ``` instanceState: DISABLE datasources: sharding_db.ds_1: state: Node state lastConnect: Timestamp retryCount: RetryCount sharding_db.ds_2: state: Node state lastConnect: Timestamp retryCount: RetryCount ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero opened a new pull request #5703: extend schemaContexts
tristaZero opened a new pull request #5703: URL: https://github.com/apache/shardingsphere/pull/5703 Ref #5593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #5703: extend schemaContexts
terrymanu merged pull request #5703: URL: https://github.com/apache/shardingsphere/pull/5703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] Lucas-307 opened a new pull request #5705: Update mysql datasource checker
Lucas-307 opened a new pull request #5705: URL: https://github.com/apache/shardingsphere/pull/5705 Fixes #5688. Changes proposed in this pull request: - update mysql datasource checker - add check variable in datasource checker This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #5705: Update mysql datasource checker
terrymanu merged pull request #5705: URL: https://github.com/apache/shardingsphere/pull/5705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #5688: ShardingSphere-Scaling Mysql datasource checker is incomplete
terrymanu closed issue #5688: URL: https://github.com/apache/shardingsphere/issues/5688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero opened a new pull request #5706: Create ProxySchemaContexts
tristaZero opened a new pull request #5706: URL: https://github.com/apache/shardingsphere/pull/5706 Ref #5593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5704: Add shadow spring boot example and shadow spring namespace example to orchestration
codecov-commenter commented on pull request #5704: URL: https://github.com/apache/shardingsphere/pull/5704#issuecomment-631388503 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=h1) Report > Merging [#5704](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7eec8e615cf14fe114ee5114caffcff8b2f194f7=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5704 +/- ## - Coverage 53.67% 53.59% -0.09% Complexity 428 428 Files 1154 1155 +1 Lines 2030720339 +32 Branches 3665 3667 +2 Hits 1090010900 - Misses 8743 8775 +32 Partials664 664 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5704/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...ngsphere/kernal/context/SchemaContextsBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5704/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0c0J1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...re/kernal/context/schema/ShardingSphereSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5704/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...e/shardingsphere/kernal/context/SchemaContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5704/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=footer). Last update [7eec8e6...ce82154](https://codecov.io/gh/apache/shardingsphere/pull/5704?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] yanyzy opened a new pull request #5704: Add shadow spring boot example and shadow spring namespace example to orchestration
yanyzy opened a new pull request #5704: URL: https://github.com/apache/shardingsphere/pull/5704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] yanyzy merged pull request #5706: Create ProxySchemaContexts
yanyzy merged pull request #5706: URL: https://github.com/apache/shardingsphere/pull/5706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] jingshanglu opened a new pull request #5707: Fix 5565
jingshanglu opened a new pull request #5707: URL: https://github.com/apache/shardingsphere/pull/5707 Fixes #5565 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gu-yan opened a new issue #5708: jpaQueryFactory.selectDistinct
gu-yan opened a new issue #5708: URL: https://github.com/apache/shardingsphere/issues/5708 ## Bug Report ShardingSphere-JDBC sharding-jdbc-spring-boot-starter:4.1.0 sharding-jdbc-spring-namespace:4.1.0 env is ### Expected behavior ### Actual behavior ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gu-yan closed issue #5708: jpaQueryFactory.selectDistinct
gu-yan closed issue #5708: URL: https://github.com/apache/shardingsphere/issues/5708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] yu199195 opened a new pull request #5709: Optimize user configuration of datasource.
yu199195 opened a new pull request #5709: URL: https://github.com/apache/shardingsphere/pull/5709 this pr can optimize user configuration of datasource. Typically configured datasource has a lot of duplicate properties old : ```yaml spring.shardingsphere.datasource.ds.type=org.apache.commons.dbcp2.BasicDataSource spring.shardingsphere.datasource.ds.driver-class-name=org.h2.Driver spring.shardingsphere.datasource.ds.url=jdbc:h2:mem:ds;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MYSQL spring.shardingsphere.datasource.ds.username=sa spring.shardingsphere.datasource.ds.password= spring.shardingsphere.datasource.ds_0.type=org.apache.commons.dbcp2.BasicDataSource spring.shardingsphere.datasource.ds_0.driver-class-name=org.h2.Driver spring.shardingsphere.datasource.ds_0.url=jdbc:h2:mem:ds_0;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MYSQL spring.shardingsphere.datasource.ds_0.username=sa spring.shardingsphere.datasource.ds_0.password= ``` now : ```yaml spring.shardingsphere.datasource.common.type=org.apache.commons.dbcp2.BasicDataSource spring.shardingsphere.datasource.common.driver-class-name=org.h2.Driver spring.shardingsphere.datasource.common.username=sa spring.shardingsphere.datasource.common.password= spring.shardingsphere.datasource.ds.url=jdbc:h2:mem:ds;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MYSQL spring.shardingsphere.datasource.ds_0.url=jdbc:h2:mem:ds_0;DB_CLOSE_DELAY=-1;DATABASE_TO_U ``` Of course, you can also customize to override common properties. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #5704: Add shadow spring boot example and shadow spring namespace example to orchestration
terrymanu merged pull request #5704: URL: https://github.com/apache/shardingsphere/pull/5704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] wangjing112 opened a new issue #5710: InlineShardingAlgorithm add property LogicTableName
wangjing112 opened a new issue #5710:
URL: https://github.com/apache/shardingsphere/issues/5710
in most time table's sharding rule is same like:
`
defaultTableStrategy:
standard:
shardingColumn: id
shardingAlgorithm:
type: INLINE
props:
algorithm.expression: ${LogicTableName}${id % 2}
`
so if algorithm.expression include LogicTableName ,most of table can use
defaultTableStrategy
just add code in InlineShardingAlgorithm like this:
`
@Override
public String doSharding(final Collection availableTargetNames,
final PreciseShardingValue> shardingValue) {
Preconditions.checkNotNull(properties.get(ALGORITHM_EXPRESSION),
"Inline sharding algorithm expression cannot be null.");
String algorithmExpression =
InlineExpressionParser.handlePlaceHolder(properties.get(ALGORITHM_EXPRESSION).toString().trim());
Closure closure = new
InlineExpressionParser(algorithmExpression).evaluateClosure();
Closure result = closure.rehydrate(new Expando(), null, null);
result.setResolveStrategy(Closure.DELEGATE_ONLY);
result.setProperty(shardingValue.getColumnName(),
shardingValue.getValue());
result.setProperty("LogicTableName",
shardingValue.getLogicTableName());
return result.call().toString();
}
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #5709: Optimize user configuration of datasource.
terrymanu merged pull request #5709: URL: https://github.com/apache/shardingsphere/pull/5709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu opened a new pull request #5711: Merge spi: and sharding: namespace
terrymanu opened a new pull request #5711: URL: https://github.com/apache/shardingsphere/pull/5711 For #5508. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] dongzl merged pull request #5711: Merge spi: and sharding: namespace
dongzl merged pull request #5711: URL: https://github.com/apache/shardingsphere/pull/5711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] gu-yan commented on issue #5708: jpaQueryFactory.selectDistinct error with SQL Error: 1064, SQLState: 42000
gu-yan commented on issue #5708: URL: https://github.com/apache/shardingsphere/issues/5708#issuecomment-631409405 but program below is ok : ``` List existRiskPlaceTypeIds = jpaQueryFactory.select(qBaseRecord.riskPlaceTypeId) .from(qBaseRecord) .fetch(); ``` I think the reason is jpa convert selectDistinct to `select distinct` with some special info, sharding-jdbc cannot understand the convert result This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu opened a new issue #5712: SupooirtMultiple replications
terrymanu opened a new issue #5712: URL: https://github.com/apache/shardingsphere/issues/5712 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy? ### Expected behavior ### Actual behavior ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss opened a new pull request #5713: Initialize heart beat module #control-panel-cluster
menghaoranss opened a new pull request #5713: URL: https://github.com/apache/shardingsphere/pull/5713 For #5666 . Changes proposed in this pull request: - Init heart beat instance & start heart beat task This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on a change in pull request #5713: Initialize heart beat module #control-panel-cluster
kimmking commented on a change in pull request #5713:
URL: https://github.com/apache/shardingsphere/pull/5713#discussion_r427933323
##
File path:
shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/org/apache/shardingsphere/cluster/heartbeat/event/AbstractHeartBeatEvent.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.event;
+
+import lombok.Getter;
+
+/**
+ * Abstract heart beat event.
+ */
+@Getter
+public class AbstractHeartBeatEvent implements HeartBeatEvent{
Review comment:
miss abstract?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #5708: jpaQueryFactory.selectDistinct got exception with: SQL Error: 1064, SQLState: 42000
kimmking commented on issue #5708: URL: https://github.com/apache/shardingsphere/issues/5708#issuecomment-631417763 duplicated with #5486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5707: Fix 5565
codecov-commenter commented on pull request #5707: URL: https://github.com/apache/shardingsphere/pull/5707#issuecomment-631418455 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5707?src=pr=h1) Report > Merging [#5707](https://codecov.io/gh/apache/shardingsphere/pull/5707?src=pr=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/555eb8376ff913080852cb1c3587237f6e3374f6=desc) will **decrease** coverage by `0.25%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/shardingsphere/pull/5707?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5707 +/- ## - Coverage 53.74% 53.48% -0.26% Complexity 428 428 Files 1152 1156 +4 Lines 2027920443 +164 Branches 3664 3680 +16 + Hits 1089910934 +35 - Misses 8716 8845 +129 Partials664 664 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5707?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...gsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL015U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...caling/postgresql/PostgreSQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC9Qb3N0Z3JlU1FMRGF0YVNvdXJjZUNoZWNrZXIuamF2YQ==) | `73.33% <0.00%> (-5.24%)` | `1.00% <0.00%> (ø%)` | | | [...ardingsphere/scaling/mysql/client/MySQLClient.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NsaWVudC9NeVNRTENsaWVudC5qYXZh) | `60.24% <0.00%> (-1.49%)` | `0.00% <0.00%> (ø%)` | | | [...ngsphere/scaling/mysql/MySQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMRGF0YVNvdXJjZUNoZWNrZXIuamF2YQ==) | `84.09% <0.00%> (-0.29%)` | `1.00% <0.00%> (ø%)` | | | [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...hardingsphere/scaling/mysql/MySQLBinlogDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMQmlubG9nRHVtcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...ngsphere/kernal/context/SchemaContextsBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0c0J1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...re/kernal/context/schema/ShardingSphereSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/5707/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [shardingsphere] kimmking commented on issue #5710: InlineShardingAlgorithm add property LogicTableName
kimmking commented on issue #5710: URL: https://github.com/apache/shardingsphere/issues/5710#issuecomment-631422469 Thanks for your suggestion, but IMO it's unneccessary now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] kimmking closed issue #5710: InlineShardingAlgorithm add property LogicTableName
kimmking closed issue #5710: URL: https://github.com/apache/shardingsphere/issues/5710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
