[GitHub] [shardingsphere] codecov-commenter commented on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-04 Thread GitBox


codecov-commenter commented on pull request #10253:
URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-832413337


   # 
[Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10253?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#10253](https://codecov.io/gh/apache/shardingsphere/pull/10253?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (126726f) into 
[master](https://codecov.io/gh/apache/shardingsphere/commit/16aef56ae33fa71ebd47ef112dbb9e83bf91b47f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (16aef56) will **decrease** coverage by `0.07%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/shardingsphere/pull/10253/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10253?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #10253  +/-   ##
   
   - Coverage 68.00%   67.92%   -0.08% 
 Complexity  683  683  
   
 Files  1704 1706   +2 
 Lines 2925729261   +4 
 Branches   5263 5263  
   
   - Hits  1989619876  -20 
   - Misses 7828 7853  +25 
   + Partials   1533 1532   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/shardingsphere/pull/10253?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...sql/common/statement/ddl/AlterSystemStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/10253/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvQWx0ZXJTeXN0ZW1TdGF0ZW1lbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...atement/oracle/ddl/OracleAlterSystemStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/10253/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVBbHRlclN5c3RlbVN0YXRlbWVudC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...r/statement/impl/OracleDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10253/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh)
 | `84.42% <100.00%> (+0.12%)` | `1.00 <0.00> (ø)` | |
   | 
[...sphere/sql/parser/core/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/10253/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/10253/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=)
 | `22.22% <0.00%> (-29.63%)` | `0.00% <0.00%> (ø%)` | |
   | 

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-04 Thread GitBox


ThanoshanMV opened a new pull request #10253:
URL: https://github.com/apache/shardingsphere/pull/10253


   relates #10111 
   
   Hi @tristaZero, @wgy8283335. I've added SQL definition for [ALTER 
SYSTEM](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-SYSTEM.html#GUID-2C638517-D73A-41CA-9D8E-A62D1A0B7ADB).
 Please check it.
   
   Changes proposed in this pull request:
   - Added SQL definition for `ALTER SYSTEM`
   - Added test cases for `ALTER SYSTEM`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere-elasticjob] branch 3.0.0-release created (now 1151766)

2021-05-04 Thread wuweijie
This is an automated email from the ASF dual-hosted git repository.

wuweijie pushed a change to branch 3.0.0-release
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git.


  at 1151766  Update release notes for 3.0.0 (#1887)

No new revisions were added by this update.


[shardingsphere-benchmark] branch master updated: update benchmark result

2021-05-04 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository.

zhangyonglun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-benchmark.git


The following commit(s) were added to refs/heads/master by this push:
 new 9d5af7f  update benchmark result
9d5af7f is described below

commit 9d5af7f195bc98faf5b202101aeeb8e92fd1d963
Author: tuohai666 
AuthorDate: Wed May 5 08:00:23 2021 +0800

update benchmark result
---
 .../report/shardingsphere-benchmark-avg.xls| Bin 114176 -> 114176 bytes
 .../resources/report/shardingsphere-benchmark.xls  | Bin 87552 -> 88064 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
index 0506e5c..39789f0 100755
Binary files 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
 and 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
 differ
diff --git 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
index 9f6b9eb..f614953 100755
Binary files 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
 and 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
 differ


[GitHub] [shardingsphere] huanghao495430759 commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-04 Thread GitBox


huanghao495430759 commented on issue #10252:
URL: 
https://github.com/apache/shardingsphere/issues/10252#issuecomment-831800710


   > @huanghao495430759 Hey, could you comment something here so that I can 
assign this one for you.
   
   OK, Let me try this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-04 Thread GitBox


tristaZero commented on issue #10252:
URL: 
https://github.com/apache/shardingsphere/issues/10252#issuecomment-831764894


   @huanghao495430759 Hey, could you comment something here so that I can 
assign this one for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-04 Thread GitBox


tristaZero commented on issue #10251:
URL: 
https://github.com/apache/shardingsphere/issues/10251#issuecomment-831764599


   @zhujunx Hey, welcome.
   @huanghao495430759 I will assign #10252 to you. Since you have done 
something to do with that, I suppose that issue will become simpler for you. :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] zhujunxxxxx commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-04 Thread GitBox


zhujunx commented on issue #10251:
URL: 
https://github.com/apache/shardingsphere/issues/10251#issuecomment-831755519


   I want to try #10251.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Liangda-w commented on pull request #10214: Support alter database grammar

2021-05-04 Thread GitBox


Liangda-w commented on pull request #10214:
URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-831856366


   > Hi @Liangda-w Please give this one a double-checking.
   
   Looks good it's time to merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org