[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement.
tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981#issuecomment-528715322 Waiting for your pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-528711468 @yangjwInRiver I am sorry to give feedback so late, which column is your primary key? You not add any annotation(Primary key) in entity parameters, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-528711099 @gholly Hi, `insert into dd_bank_2 (application_number, company_id, id) values (?, ?, ?)` There is no id column in your actual Database, you mean, ss creates a column named id, and give it a value? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement.
sunbufu commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981#issuecomment-528709012 Yes, I'd like to do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2601: Verify the shardingRule at the beginning
sunbufu commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-528708601 I think the difficulty is not on groovy script, It's on how to get the case to prove sharding rule is wrong, but we can not try with each case. Maybe we can change the way of thinking, just let user input the case, like developer write unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement.
tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981#issuecomment-528703047 @sunbufu Are u interested in this, so easy. As i said [here](https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528702306) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero commented on issue #2923: when using EncryptPreparedStatement to
savebatch occours error
URL:
https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528702306
@xiyelife Hi, if first one is done, the second one, i think, there is a
easier way to do.
As we said before, it is needed to cache the value of `setQueryTime()` and
when call execute(), this operation will be really performed.
Currently, `setQueryTime()` in AbstractStatementAdapter.java has cached the
value, here it is,
```
@SuppressWarnings("unchecked")
@Override
public final void setQueryTimeout(final int seconds) throws SQLException
{
// cache the value
recordMethodInvocation(targetClass, "setQueryTimeout", new Class[]
{int.class}, new Object[] {seconds});
forceExecuteTemplate.execute((Collection) getRoutedStatements(), new
ForceExecuteCallback() {
@Override
public void execute(final Statement statement) throws
SQLException {
statement.setQueryTimeout(seconds);
}
});
}
```
So, we just call `replayMethodsInvocation()` in EncryptPreparedStatement
when call execute() or executeUpdate().
That's all, how about you?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] StHsiang commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam
StHsiang commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam URL: https://github.com/apache/incubator-shardingsphere/issues/2860#issuecomment-528697249 When I connectted to a sharding proxy 4.0.0-RC2 server with navicat 10.1.7,I can get the schema the one I configured in the configuration file config-sharding.yml and open the schema successfully. Howerer, when I connected the sharding proxy with navicat 12.1.7, I cannot get the schema and when I tried to open anyone of presented schemas, I got the error "1049 - Unknown database ''". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2926: mysql page limit Long parameter type error
terrymanu commented on issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926#issuecomment-528696510 @sunbufu Welcome This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2092: Update sharding key is allowed but not work
betterjava commented on issue #2092: Update sharding key is allowed but not work URL: https://github.com/apache/incubator-shardingsphere/issues/2092#issuecomment-528695006 Ok,I got it.I will try do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2932: Cannot obtained Data from multiple data sources when integrating MyBatis with HitManager
terrymanu closed issue #2932: Cannot obtained Data from multiple data sources when integrating MyBatis with HitManager URL: https://github.com/apache/incubator-shardingsphere/issues/2932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2716: Optimization for OptimizedStatement
terrymanu closed issue #2716: Optimization for OptimizedStatement URL: https://github.com/apache/incubator-shardingsphere/issues/2716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam
terrymanu commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam URL: https://github.com/apache/incubator-shardingsphere/issues/2860#issuecomment-528693631 Closed for no response anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam
terrymanu closed issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam URL: https://github.com/apache/incubator-shardingsphere/issues/2860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation.
terrymanu commented on issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation. URL: https://github.com/apache/incubator-shardingsphere/issues/2910#issuecomment-528692543 Closed for no response anymore This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation.
terrymanu closed issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation. URL: https://github.com/apache/incubator-shardingsphere/issues/2910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2927: Use JavaAgent introducing Sharding-JDBC
tuohai666 commented on issue #2927: Use JavaAgent introducing Sharding-JDBC URL: https://github.com/apache/incubator-shardingsphere/issues/2927#issuecomment-528691594 We don't have to replace the DataSource if you have better idea. There's no demo yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2092: Update sharding key is allowed but not work
terrymanu commented on issue #2092: Update sharding key is allowed but not work URL: https://github.com/apache/incubator-shardingsphere/issues/2092#issuecomment-528691261 @betterjava Welcome to discuss this issue. For this issue, we should judge the SQL is update sharding key or not, if sharding key updated, should throw an exception. We'd better add judge logic on `optimized` module, the class should be in `ShardingUpdateOptimizeEngine` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #1899: Decide SQLs that need a default schema
tuohai666 commented on issue #1899: Decide SQLs that need a default schema URL: https://github.com/apache/incubator-shardingsphere/issues/1899#issuecomment-528690740 Duplicate with #2673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 closed issue #1899: Decide SQLs that need a default schema
tuohai666 closed issue #1899: Decide SQLs that need a default schema URL: https://github.com/apache/incubator-shardingsphere/issues/1899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #1858: Add TransactionalDataSource to encapsulation distribute transaction.
terrymanu closed issue #1858: Add TransactionalDataSource to encapsulation distribute transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/1858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1858: Add TransactionalDataSource to encapsulation distribute transaction.
terrymanu commented on issue #1858: Add TransactionalDataSource to encapsulation distribute transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/1858#issuecomment-528690207 Close for expired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #1423: config error and unsupport error throw on routing phase
terrymanu closed issue #1423: config error and unsupport error throw on routing phase URL: https://github.com/apache/incubator-shardingsphere/issues/1423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1423: config error and unsupport error throw on routing phase
terrymanu commented on issue #1423: config error and unsupport error throw on routing phase URL: https://github.com/apache/incubator-shardingsphere/issues/1423#issuecomment-528689725 Close for expired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1234: Proxy overload protection
terrymanu commented on issue #1234: Proxy overload protection URL: https://github.com/apache/incubator-shardingsphere/issues/1234#issuecomment-528689644 Expired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #1234: Proxy overload protection
terrymanu closed issue #1234: Proxy overload protection URL: https://github.com/apache/incubator-shardingsphere/issues/1234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change.
terrymanu closed issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change. URL: https://github.com/apache/incubator-shardingsphere/issues/2827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change.
terrymanu commented on issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change. URL: https://github.com/apache/incubator-shardingsphere/issues/2827#issuecomment-528688562 It is really too long time for waiting response. I just close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2915: sharding-proxy mysql varchar can not complete display
terrymanu commented on issue #2915: sharding-proxy mysql varchar can not complete display URL: https://github.com/apache/incubator-shardingsphere/issues/2915#issuecomment-528688181 > i find the answer。when use navicat 11.1.13 Enterprise Edition，some field can not complete display。but when i use navicat 12.0.29 Enterprise Edition, it complete display . Is it a navicat's issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2911: 4.0.0-RC2 does not support Oracle 12C connection configuration
terrymanu commented on issue #2911: 4.0.0-RC2 does not support Oracle 12C connection configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2911#issuecomment-528687688 For english only @timchan1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on issue #238: Add leaf key generator related content
terrymanu commented on issue #238: Add leaf key generator related content URL: https://github.com/apache/incubator-shardingsphere-doc/pull/238#issuecomment-528686660 Cloud you remove company name from Chinese document? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #239: replace travis build status with jenkins
terrymanu merged pull request #239: replace travis build status with jenkins URL: https://github.com/apache/incubator-shardingsphere-doc/pull/239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] taojintianxia commented on issue #2948: My database table names are all uppercase , how to config ?
taojintianxia commented on issue #2948: My database table names are all uppercase , how to config ? URL: https://github.com/apache/incubator-shardingsphere/issues/2948#issuecomment-528685527 > In MySQL, databases correspond to directories within the data directory. Each table within a database corresponds to at least one file within the database directory (and possibly more, depending on the storage engine). Triggers also correspond to files. Consequently, the case sensitivity of the underlying operating system plays a part in the case sensitivity of database, table, and trigger names. This means such names are not case-sensitive in Windows, but are case-sensitive in most varieties of Unix. One notable exception is macOS, which is Unix-based but uses a default file system type (HFS+) that is not case-sensitive. However, macOS also supports UFS volumes, which are case-sensitive just as on any Unix. https://dev.mysql.com/doc/refman/5.7/en/identifier-case-sensitivity.html maybe just for ignoring the negative effects of case sensitive This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] pitymonkey commented on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
pitymonkey commented on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-528681409 > for this issue, there are 2 point you should know. > > 1. enhance DataSourceUtils to support constructing DataSource from spring-boot yaml config file. > 2. enhance DataSourceConfiguration to support constructing DataSource from register center(zk). > > you have only fixed the 1. I see. Now,I have fix both of them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] pitymonkey commented on a change in pull request #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
pitymonkey commented on a change in pull request #2967: Fixes #2010 :fix bug do
not support connectionInitSqls config of druid
URL:
https://github.com/apache/incubator-shardingsphere/pull/2967#discussion_r321553959
##
File path:
sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/test/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/util/DataSourceUtilTest.java
##
@@ -119,4 +120,12 @@ public void assertDataSourceForLongValue() throws
ReflectiveOperationException {
assertThat(actual.getTimeBetweenEvictionRunsMillis(), is(16L));
assertThat(actual.getMinEvictableIdleTimeMillis(), is(4000L));
}
+
+@Test
+public void assertDataSourceForCollectionValue() throws
ReflectiveOperationException {
+Map dataSourceProperties = new HashMap<>(2, 1);
+dataSourceProperties.put("connectionInitSqls", "[set names utf8mb4]");
Review comment:
I have make it support "," only
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu edited a comment on issue #2926: mysql page limit Long parameter type error
sunbufu edited a comment on issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926#issuecomment-528610020 I agree with KomachiSion, can i submit a PR ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2926: mysql page limit Long parameter type error
sunbufu commented on issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926#issuecomment-528610020 I agree with KomachiSion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2927: Use JavaAgent introducing Sharding-JDBC
sunbufu commented on issue #2927: Use JavaAgent introducing Sharding-JDBC URL: https://github.com/apache/incubator-shardingsphere/issues/2927#issuecomment-528608582 Sorry, Why should we replace the DataSource in connection pool? Can you give me some examples? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #2985: Fixes #2923.
coveralls commented on issue #2985: Fixes #2923. URL: https://github.com/apache/incubator-shardingsphere/pull/2985#issuecomment-528432384 ## Pull Request Test Coverage Report for [Build 303](https://coveralls.io/builds/25549469) * **5** of **6** **(83.33%)** changed or added relevant lines in **3** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.01%**) to **65.138%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/EncryptPreparedStatement.java](https://coveralls.io/builds/25549469/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FEncryptPreparedStatement.java#L224) | 1 | 2 | 50.0% | Totals | [](https://coveralls.io/builds/25549469) | | :-- | --: | | Change from base [Build 323](https://coveralls.io/builds/25547190): | 0.01% | | Covered Lines: | 9234 | | Relevant Lines: | 14176 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #2985: Fixes #2923.
xiyelife opened a new pull request #2985: Fixes #2923. URL: https://github.com/apache/incubator-shardingsphere/pull/2985 Fixes #2923. Changes proposed in this pull request: First, if preparedStatemnt == null in getRoutedStatements(), emptyList will be returned. This step will stop NPE, but set queryTime() actually is not executed, for there is no preparedStatement. Second, we may cache the value of queryTime() in AbstractStatementAdapter.java. When executeUpdate() or execute() is called, at this time, we relay the action, i.e, setQueryTime(). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife closed pull request #2984: Fix for #2923
xiyelife closed pull request #2984: Fix for #2923 URL: https://github.com/apache/incubator-shardingsphere/pull/2984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #2984: Fix for #2923
xiyelife opened a new pull request #2984: Fix for #2923 URL: https://github.com/apache/incubator-shardingsphere/pull/2984 Fixes #2923 First, if preparedStatemnt == null in getRoutedStatements(), emptyList will be returned. This step will stop NPE, but set queryTime() actually is not executed, for there is no preparedStatement. Second, we may cache the value of queryTime() in AbstractStatementAdapter.java. When executeUpdate() or execute() is called, at this time, we relay the action, i.e, setQueryTime(). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] nancyzrh opened a new pull request #239: replace travis build status with jenkins
nancyzrh opened a new pull request #239: replace travis build status with jenkins URL: https://github.com/apache/incubator-shardingsphere-doc/pull/239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] copyshop commented on issue #2948: My database table names are all uppercase , how to config ?
copyshop commented on issue #2948: My database table names are all uppercase , how to config ? URL: https://github.com/apache/incubator-shardingsphere/issues/2948#issuecomment-528382517 for example broadcastTables: - t_config - T_TEST it can run correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] copyshop commented on issue #2948: My database table names are all uppercase , how to config ?
copyshop commented on issue #2948: My database table names are all uppercase , how to config ? URL: https://github.com/apache/incubator-shardingsphere/issues/2948#issuecomment-528381560 I guess it doesn't mean much. it's only ignore case-sensitive. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2978: Filter out incorrect table which with only alias.
terrymanu merged pull request #2978: Filter out incorrect table which with only alias. URL: https://github.com/apache/incubator-shardingsphere/pull/2978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2961: Delete with alias error
terrymanu closed issue #2961: Delete with alias error URL: https://github.com/apache/incubator-shardingsphere/issues/2961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-527423607 ## Pull Request Test Coverage Report for [Build 299](https://coveralls.io/builds/25546790) * **16** of **16** **(100.0%)** changed or added relevant lines in **3** files are covered. * **79** unchanged lines in **14** files lost coverage. * Overall coverage increased (+**0.2%**) to **65.132%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L125) | 1 | 97.83% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertQueryAndPlainNamesTokenGenerator.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertQueryAndPlainNamesTokenGenerator.java#L68) | 1 | 92.31% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertSetQueryAndPlainColumnsTokenGenerator.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertSetQueryAndPlainColumnsTokenGenerator.java#L72) | 1 | 97.06% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/pojo/InsertSetQueryAndPlainColumnsToken.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fpojo%2FInsertSetQueryAndPlainColumnsToken.java#L61) | 1 | 90.91% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/StatementExecutor.java](https://coveralls.io/builds/25546790/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FStatementExecutor.java#L192) | 1 | 98.08% | | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/core/merge/dal/DALMergeEngine.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmerge%2Fdal%2FDALMergeEngine.java#L69) | 2 | 85.71% | | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/api/segment/InsertValue.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fapi%2Fsegment%2FInsertValue.java#L147) | 2 | 88.64% | | [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/util/DataSourceUtil.java](https://coveralls.io/builds/25546790/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fboot%2Futil%2FDataSourceUtil.java#L95) | 2 | 93.75% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/SelectEncryptItemTokenGenerator.java](https://coveralls.io/builds/25546790/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FSelectEncryptItemTokenGenerator.java#L68) | 3 | 90.63% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/PreparedStatementExecutor.java](https://coveralls.io/builds/25546790/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FPreparedStatementExecutor.java#L73) | 6 | 72.97% | | Totals | [](https://coveralls.io/builds/25546790) | | :-- | --: | | Change from base [Build 307](https://coveralls.io/builds/25469379): | 0.2% | | Covered Lines: | 9235 | | Relevant Lines: | 14179 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-527423607 ## Pull Request Test Coverage Report for [Build 296](https://coveralls.io/builds/25546749) * **13** of **16** **(81.25%)** changed or added relevant lines in **3** files are covered. * **81** unchanged lines in **15** files lost coverage. * Overall coverage increased (+**0.2%**) to **65.109%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/config/DataSourceConfiguration.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fconfig%2FDataSourceConfiguration.java#L113) | 3 | 6 | 50.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L125) | 1 | 97.83% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertQueryAndPlainNamesTokenGenerator.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertQueryAndPlainNamesTokenGenerator.java#L68) | 1 | 92.31% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertSetQueryAndPlainColumnsTokenGenerator.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertSetQueryAndPlainColumnsTokenGenerator.java#L72) | 1 | 97.06% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/pojo/InsertSetQueryAndPlainColumnsToken.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fpojo%2FInsertSetQueryAndPlainColumnsToken.java#L61) | 1 | 90.91% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/StatementExecutor.java](https://coveralls.io/builds/25546749/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FStatementExecutor.java#L192) | 1 | 98.08% | | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/core/merge/dal/DALMergeEngine.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmerge%2Fdal%2FDALMergeEngine.java#L69) | 2 | 85.71% | | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/api/segment/InsertValue.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fapi%2Fsegment%2FInsertValue.java#L147) | 2 | 88.64% | | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/util/DataSourceUtil.java](https://coveralls.io/builds/25546749/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2Futil%2FDataSourceUtil.java#L95) | 2 | 93.75% | | [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/util/DataSourceUtil.java](https://coveralls.io/builds/25546749/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fboot%2Futil%2FDataSourceUtil.java#L95) | 2 | 93.75% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/SelectEncryptItemTokenGenerator.java](https://coveralls.io/builds/25546749/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FSelectEncryptItemTokenGenerator.java#L68)
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-527423607 ## Pull Request Test Coverage Report for [Build 295](https://coveralls.io/builds/25546711) * **18** of **18** **(100.0%)** changed or added relevant lines in **3** files are covered. * **91** unchanged lines in **16** files lost coverage. * Overall coverage increased (+**0.2%**) to **65.117%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L125) | 1 | 97.83% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertQueryAndPlainNamesTokenGenerator.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertQueryAndPlainNamesTokenGenerator.java#L68) | 1 | 92.31% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertSetQueryAndPlainColumnsTokenGenerator.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertSetQueryAndPlainColumnsTokenGenerator.java#L72) | 1 | 97.06% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/pojo/InsertSetQueryAndPlainColumnsToken.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fpojo%2FInsertSetQueryAndPlainColumnsToken.java#L61) | 1 | 90.91% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/StatementExecutor.java](https://coveralls.io/builds/25546711/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FStatementExecutor.java#L192) | 1 | 98.08% | | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/core/merge/dal/DALMergeEngine.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmerge%2Fdal%2FDALMergeEngine.java#L69) | 2 | 85.71% | | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/api/segment/InsertValue.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fapi%2Fsegment%2FInsertValue.java#L147) | 2 | 88.64% | | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/util/DataSourceUtil.java](https://coveralls.io/builds/25546711/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2Futil%2FDataSourceUtil.java#L95) | 2 | 93.75% | | [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/util/DataSourceUtil.java](https://coveralls.io/builds/25546711/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fboot%2Futil%2FDataSourceUtil.java#L95) | 2 | 93.75% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/SelectEncryptItemTokenGenerator.java](https://coveralls.io/builds/25546711/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FSelectEncryptItemTokenGenerator.java#L68) | 3 | 90.63% | | Totals | [](https://coveralls.io/builds/25546711) | | :-- | --: | | Change from base [Build 307](https://coveralls.io/builds/25469379): | 0.2% | | Covered Lines: | 9233 | | Relevant Lines: | 14179 | --- # - [Coveralls](https://coveralls.io) This is an automated
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528351057 yeah, I think so, we can deal with the remaining parameters by your way, i.e maxRows,fetchSize and so on. @tristaZero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2979: support hint in sharding-proxy
betterjava commented on issue #2979: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/issues/2979#issuecomment-528350394 I think the pivotal problem is how the shardingEngine get hint value.Because different BackendConnection may in the same thread,so the ThradLoacal can not use. Can we use parameters to transport hint value or make every BackendConnection in a single Thread? Maybe Both solutions are not suitable. I think we can discuss here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528332022 Got it, maybe we can split this task to two small ones. First, if preparedStatemnt == null in getRoutedStatements(), emptyList will be returned. This step will stop NPE, but `set queryTime()` actually is not executed, for there is no preparedStatement. Second, we may cache the value of `queryTime()` in AbstractStatementAdapter.java. When executeUpdate() or execute() is called, at this time, we relay the action, i.e, setQueryTime(). What's your opinion? we can do first one, i think. @xiyelife This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528332022 Got it, maybe we can split this task to two small ones. First, if preparedStatemnt == null in getRoutedStatements(), emptyList will be returned. This step will stop NPE, but `set queryTime()` actually is not executed, for there is no preparedStatement. Second, we may cache the value of `queryTime()` in AbstractStatementAdapter.java. When executeUpdate() or execute() is called, at this time, we relay the action, i.e, setQueryTime(). What's your opinion? we can do first one, i think. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2978: Filter out incorrect table which with only alias.
coveralls edited a comment on issue #2978: Filter out incorrect table which with only alias. URL: https://github.com/apache/incubator-shardingsphere/pull/2978#issuecomment-528205522 ## Pull Request Test Coverage Report for [Build 294](https://coveralls.io/builds/25545046) * **11** of **11** **(100.0%)** changed or added relevant lines in **1** file are covered. * **55** unchanged lines in **5** files lost coverage. * Overall coverage increased (+**0.07%**) to **65.124%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertSetQueryAndPlainColumnsTokenGenerator.java](https://coveralls.io/builds/25545046/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertSetQueryAndPlainColumnsTokenGenerator.java#L72) | 1 | 97.06% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/InsertQueryAndPlainNamesTokenGenerator.java](https://coveralls.io/builds/25545046/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FInsertQueryAndPlainNamesTokenGenerator.java#L57) | 2 | 92.31% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/SelectEncryptItemTokenGenerator.java](https://coveralls.io/builds/25545046/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ftoken%2Fgenerator%2FSelectEncryptItemTokenGenerator.java#L68) | 3 | 90.63% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/EncryptTable.java](https://coveralls.io/builds/25545046/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fencrypt%2FEncryptTable.java#L117) | 14 | 0.0% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/EncryptRule.java](https://coveralls.io/builds/25545046/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FEncryptRule.java#L61) | 35 | 8.2% | | Totals | [](https://coveralls.io/builds/25545046) | | :-- | --: | | Change from base [Build 317](https://coveralls.io/builds/25539429): | 0.07% | | Covered Lines: | 9228 | | Relevant Lines: | 14170 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #2983: fix Bug 2972
coveralls commented on issue #2983: fix Bug 2972 URL: https://github.com/apache/incubator-shardingsphere/pull/2983#issuecomment-528312869 ## Pull Request Test Coverage Report for [Build 293](https://coveralls.io/builds/25544265) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.03%**) to **65.129%** --- | Totals | [](https://coveralls.io/builds/25544265) | | :-- | --: | | Change from base [Build 322](https://coveralls.io/builds/25543877): | 0.03% | | Covered Lines: | 9219 | | Relevant Lines: | 14155 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #2983: fix Bug 2972
betterjava opened a new pull request #2983: fix Bug 2972 URL: https://github.com/apache/incubator-shardingsphere/pull/2983 Fixes #2972. Changes proposed in this pull request: - We should not return original ResultSet for ShardingStatement or ShardingPreparedStatement.Because if we have a EncryptRule for this ResultSet,it will do nothing when need decrypt value to user. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528303029 @tristaZero Hi, there are no incoming parameters to bind at the time of construction, which can cause the generation of EncryptInsertOptimizedStatement failed:  I think the problem should be more complicated.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2982: rm travis && and jenkins badge
terrymanu merged pull request #2982: rm travis && and jenkins badge URL: https://github.com/apache/incubator-shardingsphere/pull/2982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #2982: rm travis && and jenkins badge
coveralls commented on issue #2982: rm travis && and jenkins badge URL: https://github.com/apache/incubator-shardingsphere/pull/2982#issuecomment-528289353 ## Pull Request Test Coverage Report for [Build 292](https://coveralls.io/builds/25543187) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **65.051%** --- | Totals | [](https://coveralls.io/builds/25543187) | | :-- | --: | | Change from base [Build 320](https://coveralls.io/builds/25542920): | 0.0% | | Covered Lines: | 9219 | | Relevant Lines: | 14172 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528284417 @betterjava 3.1.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] nancyzrh opened a new pull request #2982: rm travis && and jenkins badge
nancyzrh opened a new pull request #2982: rm travis && and jenkins badge URL: https://github.com/apache/incubator-shardingsphere/pull/2982 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2980: The Long type parameters of Pagination are incompatible
KomachiSion commented on issue #2980: The Long type parameters of Pagination are incompatible URL: https://github.com/apache/incubator-shardingsphere/issues/2980#issuecomment-528280631 duplicate with #2926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2980: The Long type parameters of Pagination are incompatible
KomachiSion closed issue #2980: The Long type parameters of Pagination are incompatible URL: https://github.com/apache/incubator-shardingsphere/issues/2980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528278742 @xiyelife Hi, after my investigation, the similar problem also happens in ShardingPreparedStatement. If you're interested in it, can u consider [this issue](https://github.com/apache/incubator-shardingsphere/issues/2981). Don't worry, it does not have deadline. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
betterjava commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528272468 @Keanhua which mybatis-plus version you used? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528268487 @betterjava thank you so much This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
betterjava edited a comment on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528267545 It seems like problem will happen when use mybatis-plus. I will check it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
betterjava commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528267545 it seems like problem will happen when use mybatis-plus. I will check it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528265133 @betterjava it looks like no problem  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #2981: It doesn't work when set properties for ShardingPreparedStatement.
tristaZero opened a new issue #2981: It doesn't work when set properties for
ShardingPreparedStatement.
URL: https://github.com/apache/incubator-shardingsphere/issues/2981
## Bug Report
**For English only**, other languages will not accept.
Before report a bug, make sure you have:
- Searched open and closed [GitHub
issues](https://github.com/apache/incubator-shardingsphere/issues).
- Read documentation: [ShardingSphere
Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more
details.
If no response **more than 7 days** and we cannot reproduce it on current
information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Which version of ShardingSphere did you use?
> 4.0.0.RC3
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
> Sharding-JDBC
### Expected behavior
### Actual behavior
When set queryTimeout properties for ShardingPreparedStatement, it doesn't
work.
### Reason analyze (If you can)
> Because when ShardingPreparedStatement is created, there is no actual
PreparedStatement in ShardingPreparedStatement. Only when you call execute() or
executeQuery(), PreparedStatement is created. So before execute() is called,
any assignment for PreparedStatement will not work.
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
> One solution is to create PreparedStatement once PreparedStatement is
created. You need to split function of initPreparedStatementExecutor() in
ShardingPreparedStatement.
Here are related codes in ShardingPreparedStatement:
```
public ShardingPreparedStatement(final ShardingConnection connection, final
String sql) {
this(connection, sql, ResultSet.TYPE_FORWARD_ONLY,
ResultSet.CONCUR_READ_ONLY, ResultSet.HOLD_CURSORS_OVER_COMMIT, false);
}
---
@Override
public ResultSet executeQuery() throws SQLException {
ResultSet result;
try {
clearPrevious();
shard();
initPreparedStatementExecutor();
MergeEngine mergeEngine =
MergeEngineFactory.newInstance(connection.getRuntimeContext().getDatabaseType(),
connection.getRuntimeContext().getRule(),
sqlRouteResult, connection.getRuntimeContext().getMetaData().getTables(),
preparedStatementExecutor.executeQuery());
result = getResultSet(mergeEngine);
} finally {
clearBatch();
}
currentResultSet = result;
return result;
}
---
private void initPreparedStatementExecutor() throws SQLException {
preparedStatementExecutor.init(sqlRouteResult);
setParametersForStatements();
}
---
In PreparedStatementExecutor.javaa
public void init(final SQLRouteResult routeResult) throws SQLException {
setOptimizedStatement(routeResult.getShardingStatement());
getExecuteGroups().addAll(obtainExecuteGroups(routeResult.getRouteUnits()));
cacheStatements();
}
```
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] liaoxianrong opened a new issue #2980: The Long type parameters of Pagination are incompatible
liaoxianrong opened a new issue #2980: The Long type parameters of Pagination
are incompatible
URL: https://github.com/apache/incubator-shardingsphere/issues/2980
When I using Mybatis-plus PaginationInterceptor plugin, shardingsphere does
not work, something wrong has happend. Track it down and find an error at here:
org.apache.shardingsphere.core.optimize.sharding.segment.select.pagination.Pagination
```
private int getValue(final PaginationValueSegment paginationValueSegment,
final List parameters) {
return paginationValueSegment instanceof
ParameterMarkerPaginationValueSegment
? (int)
parameters.get(((ParameterMarkerPaginationValueSegment)
paginationValueSegment).getParameterIndex())
: ((NumberLiteralPaginationValueSegment)
paginationValueSegment).getValue();
}
```
The Long type parameters of Pagination, such as Long total, Long pageNum,
Long pageSize. and then throw an exception at "(int)
parameters.get(((ParameterMarkerPaginationValueSegment) ".
Can someone help with that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528250990 @betterjava yes ,the table name is wrong... this is mycode by use mybatis plus！  you can see the detail in https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528167681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife closed pull request #2977: Fixes #2923 when using EncryptPreparedStatement to savebatch occours error
xiyelife closed pull request #2977: Fixes #2923 when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/pull/2977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528244617 The problem of interchanged column was solved at [#2975](https://github.com/apache/incubator-shardingsphere/pull/2975) yesterday. Thanks, and wait for your pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528244617 The problem of interchanged column is solved at [#2975](https://github.com/apache/incubator-shardingsphere/pull/2975) yesterday. Thanks, and wait for your pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528240055 @tristaZero ok ，that's what I thought at first. I'll try to modify my pr later. And I found that the latest version of the code（RC3-SNAPSHOT） would incorrectly insert my original column like this: **SQLRewriteEngine Pre：** columnNames=[name, ident, is_mobile_authed, mobile, modify_time, password, reg_device_info, reg_source, time_inst, time_upd, mobile, ident, name] parameters=[闵姐, 600xxx756, 1, 1xxx4, 11, jpaxsdsewrwe123123f, jpatest, 111, 2019-09-05 15:27:47.77, 2019-09-05 15:27:47.77])] > name=闵姐 > mobile=1xxx4 **atfter SQLRewriteEngine:** SQLUnit(sql=insert into user_info (name_encrypt, ident_encrypt, is_mobile_authed, mobile_encrypt, modify_time, password, reg_device_info, reg_source, time_inst, time_upd, mobile, ident, name) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?), parameters=[*n/w+WpRwyeiTYgpM59dyF9g==, *i4sLpmagWmoLIiHZ5h7bt1kTeFpBZrxX8jgy/M8y0fU0=, 1, *mN6+s/ObMX0ZTcWp7pl9T6g==, 11, jpaxsdsewrwe123123f, jpatest, 111, 2019-09-05 15:27:47.77, 2019-09-05 15:27:47.77, 闵姐, 600xxx756, 1xxx4]) > name=1xxx4 > mobile=闵姐 **the two columns are interchanged!!** The data stored in the database are also interchanged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement
to savebatch occours error
URL:
https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286
@xiyelife Thanks for [your kind
pr](https://github.com/apache/incubator-shardingsphere/pull/2977) as well.
Moreover, can you make this pr become better?
Actually, the solution in this pr can just stop NPE, but it is necessary to
sovle it completely, so we should change our mind to stop NPE at beginning.
I suggest we can create a preparedStatement upon EncryptPreparedStatement is
created, i.e, we should move `preparedStatement =
preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());` from
execute() or executeUpdate() to all the constructors of
EncryptPreparedStatement.
Therefore once EncryptPreparedStatement is created, the preparedStatement
will be created as well, then NPE will never happen.
If you have other advices, please contact me, or maybe you can modify [your
kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) to
perfect it.
Here are the related code
```
public EncryptPreparedStatement(final EncryptConnection connection, final
String sql) {
this.sql = sql;
preparedStatementGenerator = new
EncryptPreparedStatementGenerator(connection);
}
---
@Override
public int executeUpdate() throws SQLException {
try {
SQLUnit sqlUnit = getSQLUnit(sql);
preparedStatement =
preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());
replaySetParameter(preparedStatement, sqlUnit.getParameters());
return preparedStatement.executeUpdate();
} finally {
clearParameters();
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement
to savebatch occours error
URL:
https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286
@xiyelife Thanks for [your kind
pr](https://github.com/apache/incubator-shardingsphere/pull/2977) as well.
Moreover, can you make this pr become better?
Actually, the solution in this pr can just stop NPE, but it is necessary to
sovle it completely, so we should change our mind to stop NPE at beginning.
I suggest we can create a preparedStatement upon EncryptPreparedStatement is
created, i.e, we should move `preparedStatement =
preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());` from
execute() or executeUpdate() to all the constructors of
EncryptPreparedStatement.
Therefore once EncryptPreparedStatement is created, the preparedStatement
will be created as well, then NPE will never happen.
If you have other advices, please contact me, or maybe you can modify [your
kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) to
perfect it.
Here are the related codes
```
public EncryptPreparedStatement(final EncryptConnection connection, final
String sql) {
this.sql = sql;
preparedStatementGenerator = new
EncryptPreparedStatementGenerator(connection);
}
---
@Override
public int executeUpdate() throws SQLException {
try {
SQLUnit sqlUnit = getSQLUnit(sql);
preparedStatement =
preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());
replaySetParameter(preparedStatement, sqlUnit.getParameters());
return preparedStatement.executeUpdate();
} finally {
clearParameters();
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2957: sharding-proxy could not support hint strategy
cherrylzhao edited a comment on issue #2957: sharding-proxy could not support hint strategy URL: https://github.com/apache/incubator-shardingsphere/issues/2957#issuecomment-528234303 created another hint enhance issue in #2979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) as well. Moreover, can you make this pr become better? Actually, the solution in this pr can just stop NPE, but it is necessary to sovle it completely, so we should change our mind to stop NPE at beginning. I suggest we can create a preparedStatement upon EncryptPreparedStatement is created, i.e, we should move `preparedStatement = preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());` from execute() or executeUpdate() to all the constructors of EncryptPreparedStatement. Therefore once EncryptPreparedStatement is created, the preparedStatement will be created as well, then NPE will never happen. If you have other advices, please contact me, or maybe you can modify [your kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) to perfect it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) as well. Moreover, can you make this pr become better? Actually, the solution in this pr can just stop NPE, but it is necessary to sovle it completely, so we should change our mind to stop NPE at beginning. --- I suggest we can create a preparedStatement upon EncryptPreparedStatement is created, i.e, we should move `preparedStatement = preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());` from execute() or executeUpdate() to all the constructors of EncryptPreparedStatement. --- Therefore once EncryptPreparedStatement is created, the preparedStatement will be created as well, then NPE will never happen. --- If you have other advices, please contact me, or maybe you can modify [your kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) to perfect it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977) as well. Moreover, can you make this pr become better? Actually, the solution in this pr can just stop NPE, but it is necessary to stop it completely, sowe should change our mind to stop NPE at beginning. I suggest we can create a preparedStatement upon EncryptPreparedStatement is created, i.e, we can move `preparedStatement = preparedStatementGenerator.createPreparedStatement(sqlUnit.getSql());` from execute() or executeUpdate() to all the constructors of EncryptPreparedStatement. Therefore once EncryptPreparedStatement is created, the preparedStatement will be created as well, then NPE will never happen. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528229523 @xiyelife Thanks for your particular description. So great, i guess i get the point! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] wgy8283335 opened a new pull request #238: Add leaf key generator related content
wgy8283335 opened a new pull request #238: Add leaf key generator related content URL: https://github.com/apache/incubator-shardingsphere-doc/pull/238 Add leaf key generator related content This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement
to savebatch occours error
URL:
https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411
not only batch insert，the sigle insert occured too ，here is my sql:
**encrypted columns**: name,ident,mobile
t.mybatis.mapper.UserInfoMapper.insert : ==> Preparing: insert into
user_info (cust_id, unique_id, name, ident, mobile, password, reg_time,
modify_time, reg_source, reg_app_channel, reg_device_info, status,
is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked) values
(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now() , ?, ?)
ShardingSphere-SQL : SQL: insert into user_info (cust_id, unique_id,
name_encrypt,
ident_encrypt, mobile_encrypt, password,
reg_time, modify_time, reg_source,
reg_app_channel, reg_device_info, status,
is_mobile_authed, complate_cust_info, time_inst,
time_upd, has_checked, mobile, ident, name)
values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now(), ?, ?, ?, ?, ?)
**code is:**
UserInfo record = new UserInfo();
record.setMobile(mobile);
record.setName(TestLocalKmssdk.createName());
record.setPassword(oldPass);
int num = new Double(Math.random() * 100).intValue();
record.setIdent(ident + num);
record.setRegDeviceInfo(oldDev);
record.setModifyTime("11");
record.setTimeInst(new Date());
record.setTimeUpd(new Date());
record.setRegSource("111");
record.setIsMobileAuthed("1");
userInfoMapper.insert(record);
@tristaZero
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement
to savebatch occours error
URL:
https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411
not only batch insert，the sigle insert occured too ，here is my sql:
encrypted columns: name,ident,mobile
t.mybatis.mapper.UserInfoMapper.insert : ==> Preparing: insert into
user_info (cust_id, unique_id, name, ident, mobile, password, reg_time,
modify_time, reg_source, reg_app_channel, reg_device_info, status,
is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked) values
(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now() , ?, ?)
ShardingSphere-SQL : SQL: insert into user_info (cust_id, unique_id,
name_encrypt,
ident_encrypt, mobile_encrypt, password,
reg_time, modify_time, reg_source,
reg_app_channel, reg_device_info, status,
is_mobile_authed, complate_cust_info, time_inst,
time_upd, has_checked, mobile, ident, name)
values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now(), ?, ?, ?, ?, ?)
code is:
UserInfo record = new UserInfo();
record.setMobile(mobile);
record.setName(TestLocalKmssdk.createName());
record.setPassword(oldPass);
int num = new Double(Math.random() * 100).intValue();
record.setIdent(ident + num);
record.setRegDeviceInfo(oldDev);
record.setModifyTime("11");
record.setTimeInst(new Date());
record.setTimeUpd(new Date());
record.setRegSource("111");
record.setIsMobileAuthed("1");
userInfoMapper.insert(record);
@tristaZero
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert，the sigle insert occured too ，here is my sql: encrypted columns: name 、ident、mobile t.mybatis.mapper.UserInfoMapper.insert : ==> Preparing: insert into user_info (cust_id, unique_id, name, ident, mobile, password, reg_time, modify_time, reg_source, reg_app_channel, reg_device_info, status, is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now() , ?, ?) ShardingSphere-SQL : SQL: insert into user_info (cust_id, unique_id, name_encrypt, ident_encrypt, mobile_encrypt, password, reg_time, modify_time, reg_source, reg_app_channel, reg_device_info, status, is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked, mobile, ident, name) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now(), ?, ?, ?, ?, ?) @tristaZero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert，the sigle insert occured too ，here is my sql: encrypted columns: name,ident,mobile t.mybatis.mapper.UserInfoMapper.insert : ==> Preparing: insert into user_info (cust_id, unique_id, name, ident, mobile, password, reg_time, modify_time, reg_source, reg_app_channel, reg_device_info, status, is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now() , ?, ?) ShardingSphere-SQL : SQL: insert into user_info (cust_id, unique_id, name_encrypt, ident_encrypt, mobile_encrypt, password, reg_time, modify_time, reg_source, reg_app_channel, reg_device_info, status, is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked, mobile, ident, name) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now(), ?, ?, ?, ?, ?) @tristaZero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert，the sigle insert occured too ，here is mysql: encrypted columns: name 、ident、mobile t.mybatis.mapper.UserInfoMapper.insert : ==> Preparing: insert into user_info (cust_id, unique_id, name, ident, mobile, password, reg_time, modify_time, reg_source, reg_app_channel, reg_device_info, status, is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now() , ?, ?) ShardingSphere-SQL : SQL: insert into user_info (cust_id, unique_id, name_encrypt, ident_encrypt, mobile_encrypt, password, reg_time, modify_time, reg_source, reg_app_channel, reg_device_info, status, is_mobile_authed, complate_cust_info, time_inst, time_upd, has_checked, mobile, ident, name) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, now(), ?, ?, ?, ?, ?) @tristaZero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2673: Support query for `DB.TBL` in ShardingProxy
tuohai666 commented on issue #2673: Support query for `DB.TBL` in ShardingProxy URL: https://github.com/apache/incubator-shardingsphere/issues/2673#issuecomment-528222593 @benkris1 @xuanergg Let's discuss in english please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2978: Filter out incorrect table which with only alias.
terrymanu commented on issue #2978: Filter out incorrect table which with only alias. URL: https://github.com/apache/incubator-shardingsphere/pull/2978#issuecomment-528216649 Can you add test case for sql `delete xxx from tbl AS xxx WHERE xxx`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528210958 @betterjava this is the tablename. have anything wrong? **when i insert data ,the column i config can encrypt to the table but when i query data, the column i config can not decrypt**  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
