[GitHub] [incubator-shardingsphere] betterjava commented on issue #2979: support hint in sharding-proxy

2019-09-06 Thread GitBox
betterjava commented on issue #2979: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/issues/2979#issuecomment-529077000 I agree with you. We can make every frontendConnection in a single thread by default or wen can provide a hint switch to user,i

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2999: Replay for ShardingPreparedStatement when execute.

2019-09-06 Thread GitBox
coveralls commented on issue #2999: Replay for ShardingPreparedStatement when execute. URL: https://github.com/apache/incubator-shardingsphere/pull/2999#issuecomment-529076591 ## Pull Request Test Coverage Report for [Build 310](https://coveralls.io/builds/25582471) * **5** of **5*

[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #2999: Replay for ShardingPreparedStatement when execute.

2019-09-06 Thread GitBox
sunbufu opened a new pull request #2999: Replay for ShardingPreparedStatement when execute. URL: https://github.com/apache/incubator-shardingsphere/pull/2999 Fixes https://github.com/apache/incubator-shardingsphere/issues/2981. Changes proposed in this pull request: 1. add replayM

[GitHub] [incubator-shardingsphere] erstens commented on issue #2997: cpu load 100% when using sqlstatement cache

2019-09-06 Thread GitBox
erstens commented on issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997#issuecomment-529073625 Trouble giving a source of relevant changes link?thanks

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
betterjava commented on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-529070842 @shuohao see #2972,I have pull a request #2983 ,but not have been merged.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2997: cpu load 100% when using sqlstatement cache

2019-09-06 Thread GitBox
terrymanu commented on issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997#issuecomment-529067936 Can you try version 4.0.0-RC2? This is an automated me

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2969: Will the follow-up sharding-proxy support Oracle?

2019-09-06 Thread GitBox
terrymanu commented on issue #2969: Will the follow-up sharding-proxy support Oracle? URL: https://github.com/apache/incubator-shardingsphere/issues/2969#issuecomment-529067804 No plan and oracle protocol may cause license issue. So we won't do it. ---

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2969: Will the follow-up sharding-proxy support Oracle?

2019-09-06 Thread GitBox
terrymanu closed issue #2969: Will the follow-up sharding-proxy support Oracle? URL: https://github.com/apache/incubator-shardingsphere/issues/2969 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2965: SQLParseResultCache what behavior if gc happen, may cause sql route wrong

2019-09-06 Thread GitBox
terrymanu edited a comment on issue #2965: SQLParseResultCache what behavior if gc happen, may cause sql route wrong URL: https://github.com/apache/incubator-shardingsphere/issues/2965#issuecomment-527509705 Can you try to 4.0.0-RC2? --

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2920: When association query,table name of join table is changed to lowercase, but the first is not unchanged

2019-09-06 Thread GitBox
terrymanu commented on issue #2920: When association query,table name of join table is changed to lowercase, but the first is not unchanged URL: https://github.com/apache/incubator-shardingsphere/issues/2920#issuecomment-529067531 Could you submit a pull request to fix it? ---

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2996: Feature#2926 replace int with long for limit parameter.

2019-09-06 Thread GitBox
coveralls edited a comment on issue #2996: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2996#issuecomment-529058983 ## Pull Request Test Coverage Report for [Build 309](https://coveralls.io/builds/25581877) * *

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常

2019-09-06 Thread GitBox
terrymanu closed issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常 URL: https://github.com/apache/incubator-shardingsphere/issues/2998 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常

2019-09-06 Thread GitBox
terrymanu commented on issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常 URL: https://github.com/apache/incubator-shardingsphere/issues/2998#issuecomment-529067088 **For English only**, other languages will not accept. This is an a

[GitHub] [incubator-shardingsphere] liboyan1992 opened a new issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常

2019-09-06 Thread GitBox
liboyan1992 opened a new issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常 URL: https://github.com/apache/incubator-shardingsphere/issues/2998 您使用的是哪个版本的ShardingSphere? org.apache.shardingsphere sharding-jdbc-spring-boot-starter

[GitHub] [incubator-shardingsphere] erstens opened a new issue #2997: cpu load 100% when using sqlstatement cache

2019-09-06 Thread GitBox
erstens opened a new issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997 **jstack** `"DubboServerHandler-172.16.42.151:9503-thread-483" #734 daemon prio=5 os_prio=0 tid=0x7f36bc17e000 nid=0x4c92 runnable [0x

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2995: version 3.1.0 may cause memory leak when tomcat start ( a sql route wrong to 1002 table )

2019-09-06 Thread GitBox
terrymanu commented on issue #2995: version 3.1.0 may cause memory leak when tomcat start ( a sql route wrong to 1002 table ) URL: https://github.com/apache/incubator-shardingsphere/issues/2995#issuecomment-529063401 Can you try version 4.0.0-RC2?

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2996: Feature#2926 replace int with long for limit parameter.

2019-09-06 Thread GitBox
coveralls commented on issue #2996: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2996#issuecomment-529058983 ## Pull Request Test Coverage Report for [Build 308](https://coveralls.io/builds/25581156) * **2** of

[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #2996: Feature#2926 replace int with long for limit parameter.

2019-09-06 Thread GitBox
sunbufu opened a new pull request #2996: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2996 Fixes https://github.com/apache/incubator-shardingsphere/issues/2926. Changes proposed in this pull request: - replace

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2985: Fixes #2923.

2019-09-06 Thread GitBox
coveralls edited a comment on issue #2985: Fixes #2923. URL: https://github.com/apache/incubator-shardingsphere/pull/2985#issuecomment-528432384 ## Pull Request Test Coverage Report for [Build 307](https://coveralls.io/builds/25580941) * **5** of **6** **(83.33%)** changed or add

[GitHub] [incubator-shardingsphere] xiyelife closed pull request #2985: Fixes #2923.

2019-09-06 Thread GitBox
xiyelife closed pull request #2985: Fixes #2923. URL: https://github.com/apache/incubator-shardingsphere/pull/2985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-06 Thread GitBox
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-529054549 @tristaZero yeah, it would be better, and it would solve the ShardingPreparedStatement problem. s

[GitHub] [incubator-shardingsphere] Ah39 opened a new issue #2995: version 3.1.0 two datasources may memory leak when tomcat init

2019-09-06 Thread GitBox
Ah39 opened a new issue #2995: version 3.1.0 two datasources may memory leak when tomcat init URL: https://github.com/apache/incubator-shardingsphere/issues/2995 100 druid connection 1002 tables in a DB ![image](https://user-images.githubusercontent.com/2367243/64446073-81426100-d1

[GitHub] [incubator-shardingsphere] Ah39 closed issue #2994: 3.1.0 two datasources may memory leak

2019-09-06 Thread GitBox
Ah39 closed issue #2994: 3.1.0 two datasources may memory leak URL: https://github.com/apache/incubator-shardingsphere/issues/2994 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-shardingsphere] Ah39 opened a new issue #2994: 3.1.0 wo datasources may memory leak

2019-09-06 Thread GitBox
Ah39 opened a new issue #2994: 3.1.0 wo datasources may memory leak URL: https://github.com/apache/incubator-shardingsphere/issues/2994 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] sunbufu closed pull request #2991: Feature#2926 replace int with long for limit parameter.

2019-09-06 Thread GitBox
sunbufu closed pull request #2991: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2991 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-shardingsphere] shuohao commented on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
shuohao commented on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-528876301 > @shuohao is that your complete shardingsphere config? if not,please show your complete shardingsphere config. ![image](https://user-i

[GitHub] [incubator-shardingsphere] shuohao removed a comment on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
shuohao removed a comment on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-528874509 > @shuohao is that your complete shardingsphere config? if not,please show your complete shardingsphere config. spring: pro

[GitHub] [incubator-shardingsphere] shuohao commented on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
shuohao commented on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-528874509 > @shuohao is that your complete shardingsphere config? if not,please show your complete shardingsphere config. spring: profiles:

[GitHub] [incubator-shardingsphere] shuohao removed a comment on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
shuohao removed a comment on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-528873946 spring: profiles: active: test shardingsphere: datasource: names: master,slave master:

[GitHub] [incubator-shardingsphere] shuohao commented on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
shuohao commented on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-528873946 spring: profiles: active: test shardingsphere: datasource: names: master,slave master: type

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2993: fix bug 2092 check update shard key

2019-09-06 Thread GitBox
coveralls commented on issue #2993: fix bug 2092 check update shard key URL: https://github.com/apache/incubator-shardingsphere/pull/2993#issuecomment-528868252 ## Pull Request Test Coverage Report for [Build 306](https://coveralls.io/builds/25569466) * **16** of **17** **(94.12%)

[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #2993: Bug 2092 check update shard key

2019-09-06 Thread GitBox
betterjava opened a new pull request #2993: Bug 2092 check update shard key URL: https://github.com/apache/incubator-shardingsphere/pull/2993 Fixes #2092 . Changes proposed in this pull request: - when update shard key then throw a UnsupportedOperationException. --

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
betterjava commented on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-528856427 @shuohao is that your complete shardingsphere config? if not,please show your complete shardingsphere config. -

[GitHub] [incubator-shardingsphere] shuohao opened a new issue #2992: Data does not decrypt

2019-09-06 Thread GitBox
shuohao opened a new issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992 encryptRule: encryptors: aes_encryptor: props: aes.key.value: zqAvW0yEdH type: AES tables: task: columns:

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2991: Feature#2926 replace int with long for limit parameter.

2019-09-06 Thread GitBox
coveralls commented on issue #2991: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2991#issuecomment-528822336 ## Pull Request Test Coverage Report for [Build 305](https://coveralls.io/builds/25567272) * **2** of

[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #2991: Feature#2926 replace int with long for limit parameter.

2019-09-06 Thread GitBox
sunbufu opened a new pull request #2991: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2991 Fixe https://github.com/apache/incubator-shardingsphere/issues/2926. Changes proposed in this pull request: - replace

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2092: Update sharding key is allowed but not work

2019-09-06 Thread GitBox
betterjava commented on issue #2092: Update sharding key is allowed but not work URL: https://github.com/apache/incubator-shardingsphere/issues/2092#issuecomment-528813063 Need I consider more than one table being updated in one UpdateStatement? I see when Encrypt value for UpdateStateme

[GitHub] [incubator-shardingsphere-example] cherrylzhao closed issue #168: Redesign domain of example

2019-09-06 Thread GitBox
cherrylzhao closed issue #168: Redesign domain of example URL: https://github.com/apache/incubator-shardingsphere-example/issues/168 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2990: Merge OpenShardingUI features

2019-09-06 Thread GitBox
coveralls commented on issue #2990: Merge OpenShardingUI features URL: https://github.com/apache/incubator-shardingsphere/pull/2990#issuecomment-528798657 ## Pull Request Test Coverage Report for [Build 304](https://coveralls.io/builds/25565981) * **0** of **336** **(0.0%)** chan

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2988: The design purpose of the defaultDatasourceName in `ShardingRuleConfiguration`

2019-09-06 Thread GitBox
cherrylzhao commented on issue #2988: The design purpose of the defaultDatasourceName in `ShardingRuleConfiguration` URL: https://github.com/apache/incubator-shardingsphere/issues/2988#issuecomment-528793834 ShardingSphere need `logicTable` configuration to do sharding, if tableName from

[GitHub] [incubator-shardingsphere] yjmyzz edited a comment on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)

2019-09-06 Thread GitBox
yjmyzz edited a comment on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-528779888 携程旅游信息技术(上海)有限公司 , https://www.ctrip.com, 在线旅游

[GitHub] [incubator-shardingsphere] beckhampu opened a new pull request #2990: Merge OpenShardingUI features

2019-09-06 Thread GitBox
beckhampu opened a new pull request #2990: Merge OpenShardingUI features URL: https://github.com/apache/incubator-shardingsphere/pull/2990 Fixes #2986 Changes proposed in this pull request: - Add sharding-ui module for code. - Add sharding-ui-distribution module for release,includi

[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-06 Thread GitBox
cherrylzhao edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-528782601 I think it can't work on a real [spring-boot-orchestration](https://github.com/apach

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-06 Thread GitBox
cherrylzhao commented on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-528782601 I think it can't work on a real [spring-boot-orchestration](https://github.com/apache/incub

[GitHub] [incubator-shardingsphere] yjmyzz commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)

2019-09-06 Thread GitBox
yjmyzz commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-528779888 携程旅行网 , https://www.ctrip.com, 在线旅游 T

[GitHub] [incubator-shardingsphere] pxchen opened a new issue #2989: SQLServer TOP + ROW_NUMBER() pagination SQL error

2019-09-06 Thread GitBox
pxchen opened a new issue #2989: SQLServer TOP + ROW_NUMBER() pagination SQL error URL: https://github.com/apache/incubator-shardingsphere/issues/2989 ## Bug Report ### Which version of ShardingSphere did you use? 4.0.0-RC2 ### Which project did you use? Sharding-JDBC or Shardi

[GitHub] [incubator-shardingsphere] NikoTung opened a new issue #2988: The design purpose of the defaultDatasourceName in `ShardingRuleConfiguration`

2019-09-06 Thread GitBox
NikoTung opened a new issue #2988: The design purpose of the defaultDatasourceName in `ShardingRuleConfiguration` URL: https://github.com/apache/incubator-shardingsphere/issues/2988 ## Question I recently started a new project and using shardingsphere to do the sharding job, table s

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-06 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-528775516 Look forward to you pr. This is an automated message from

[GitHub] [incubator-shardingsphere] pxchen opened a new issue #2987: SQLServer OFFSET FETCH pagination return wrong results.

2019-09-06 Thread GitBox
pxchen opened a new issue #2987: SQLServer OFFSET FETCH pagination return wrong results. URL: https://github.com/apache/incubator-shardingsphere/issues/2987 ## Bug Report ### Which version of ShardingSphere did you use? 4.0.0-RC2 ### Which project did you use? Sharding-JDBC

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2601: Verify the shardingRule at the beginning

2019-09-06 Thread GitBox
sunbufu commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-528769244 I think we should add judgment in `ShardingRouter.route()`.

[GitHub] [incubator-shardingsphere-doc] wgy8283335 commented on issue #238: Add leaf key generator related content

2019-09-06 Thread GitBox
wgy8283335 commented on issue #238: Add leaf key generator related content URL: https://github.com/apache/incubator-shardingsphere-doc/pull/238#issuecomment-528746700 @terrymanu .Ok, I've modified it. This is an automated mes