[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #3020: Add Config Center

2019-09-12 Thread GitBox
wgy8283335 commented on issue #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#issuecomment-531085448 > Any idea to increase testing coverage? @terrymanu. I'd like to add integration test for registry center and config center.

[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors

2019-09-12 Thread GitBox
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530997388 @Myshiner , OK, please let me know if you have the result. Thx! This is an

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3034: Optimize performance, reduce unnecessary loops

2019-09-12 Thread GitBox
coveralls commented on issue #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#issuecomment-530883246 ## Pull Request Test Coverage Report for [Build 334](https://coveralls.io/builds/25680066) * **8** of **8**

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
coveralls edited a comment on issue #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#issuecomment-530845718 ## Pull Request Test Coverage Report for [Build 333](https://coveralls.io/builds/25679448) * **8** of

[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #3034: Optimize performance, reduce unnecessary loops

2019-09-12 Thread GitBox
yanyzy opened a new pull request #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034 Optimize performance, reduce unnecessary loops for valueOf MySQLCommandPacketType

[GitHub] [incubator-shardingsphere] yanyzy closed pull request #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
yanyzy closed pull request #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] yanyzy commented on issue #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
yanyzy commented on issue #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#issuecomment-530864905 I will close this pr, try format code from original version

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3027: Return Wrong type for tinyint and smallint column

2019-09-12 Thread GitBox
terrymanu closed issue #3027: Return Wrong type for tinyint and smallint column URL: https://github.com/apache/incubator-shardingsphere/issues/3027 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3023: fix bug 2193

2019-09-12 Thread GitBox
terrymanu merged pull request #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2193: Table doesn't exist when sharding value in different datasource with in expression

2019-09-12 Thread GitBox
terrymanu closed issue #2193: Table doesn't exist when sharding value in different datasource with in expression URL: https://github.com/apache/incubator-shardingsphere/issues/2193 This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3032: Fixed missing mysql test cases for sharding-integration-test module

2019-09-12 Thread GitBox
terrymanu merged pull request #3032: Fixed missing mysql test cases for sharding-integration-test module URL: https://github.com/apache/incubator-shardingsphere/pull/3032 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#discussion_r323772508 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#discussion_r323772923 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3025: Fixed generic compilation errors

2019-09-12 Thread GitBox
terrymanu commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530850836 Is it your eclipse's problem? If maven command line is ok, the code should be compile success.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3030: sharding-proxy error log

2019-09-12 Thread GitBox
terrymanu commented on issue #3030: sharding-proxy error log URL: https://github.com/apache/incubator-shardingsphere/issues/3030#issuecomment-530849879 Can you change the title to make sense description for search friendly?

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3026: 配置分库分表时names包含空格导致找不到数据源

2019-09-12 Thread GitBox
terrymanu closed issue #3026: 配置分库分表时names包含空格导致找不到数据源 URL: https://github.com/apache/incubator-shardingsphere/issues/3026 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3026: 配置分库分表时names包含空格导致找不到数据源

2019-09-12 Thread GitBox
terrymanu commented on issue #3026: 配置分库分表时names包含空格导致找不到数据源 URL: https://github.com/apache/incubator-shardingsphere/issues/3026#issuecomment-530849295 **For English only**, other languages will not accept. This is an

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3029: 分片键不传的时候找不到表

2019-09-12 Thread GitBox
terrymanu closed issue #3029: 分片键不传的时候找不到表 URL: https://github.com/apache/incubator-shardingsphere/issues/3029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3029: 分片键不传的时候找不到表

2019-09-12 Thread GitBox
terrymanu commented on issue #3029: 分片键不传的时候找不到表 URL: https://github.com/apache/incubator-shardingsphere/issues/3029#issuecomment-530849402 **For English only**, other languages will not accept. This is an automated message

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
coveralls commented on issue #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#issuecomment-530845718 ## Pull Request Test Coverage Report for [Build 332](https://coveralls.io/builds/25678069) * **8** of **8**

[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #3033: Optimize performance reduce unnecessary loops

2019-09-12 Thread GitBox
yanyzy opened a new pull request #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033 Optimize performance reduce unnecessary loops for valueOf MySQLCommandPacketType

[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #3025: Fixed generic compilation errors

2019-09-12 Thread GitBox
beijing-penguin commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530833138 > Hi, before your pr, the compilation is successful. > Do you find compilation error? shardingsphere can be compiled

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3032: Fixed missing mysql test cases for sharding-integration-test module

2019-09-12 Thread GitBox
coveralls commented on issue #3032: Fixed missing mysql test cases for sharding-integration-test module URL: https://github.com/apache/incubator-shardingsphere/pull/3032#issuecomment-530774900 ## Pull Request Test Coverage Report for [Build 331](https://coveralls.io/builds/25674171)

[GitHub] [incubator-shardingsphere] haocao opened a new pull request #3032: Fixed missing mysql test cases for sharding-integration-test module

2019-09-12 Thread GitBox
haocao opened a new pull request #3032: Fixed missing mysql test cases for sharding-integration-test module URL: https://github.com/apache/incubator-shardingsphere/pull/3032 For #3018. Fixed missing mysql test cases for sharding-integration-test module

[GitHub] [incubator-shardingsphere] rimal opened a new issue #3031: Default setting for KeyGenerator ColumnName and algorithm

2019-09-12 Thread GitBox
rimal opened a new issue #3031: Default setting for KeyGenerator ColumnName and algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/3031 ## Question In my application, I am only doing database level sharding. There is no table level sharding. So, only setting

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3030: sharding-proxy error log

2019-09-12 Thread GitBox
Myshiner commented on issue #3030: sharding-proxy error log URL: https://github.com/apache/incubator-shardingsphere/issues/3030#issuecomment-530760775 2019-09-12 18:13:14.852 [main-EventThread] ERROR org.apache.curator.ConnectionState - Connection timed out for connection string

[GitHub] [incubator-shardingsphere] Myshiner opened a new issue #3030: sharding-proxy error log

2019-09-12 Thread GitBox
Myshiner opened a new issue #3030: sharding-proxy error log URL: https://github.com/apache/incubator-shardingsphere/issues/3030 project: sharding-proxy version: 3.1.0 #2172 Question I got many more warning and error logs as following. 2019-09-12 16:20:05.537 [

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-12 Thread GitBox
sunbufu commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530756003 OK, I will do this after mid-autumn festival. This is an automated

[GitHub] [incubator-shardingsphere] harry-lianghairui commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)

2019-09-12 Thread GitBox
harry-lianghairui commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-530751612 北京环球网校,http://www.hqwx.com/

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-12 Thread GitBox
tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530745839 The ckecker do affect the performance. One query stay only several microsecond in ShardingSphere. Any additional operation,

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-12 Thread GitBox
tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530743902 You can compare the performance (QPS) between checking and without checking routingResult. This work can be done by a

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-12 Thread GitBox
sunbufu commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530737714 Hello, I don't think the checker will affect performance. Because it only check routingResult with shardingRule and meteData. and I

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER

2019-09-12 Thread GitBox
coveralls commented on issue #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER URL: https://github.com/apache/incubator-shardingsphere/pull/3028#issuecomment-530733725 ## Pull Request Test Coverage Report for [Build 330](https://coveralls.io/builds/25671965) * **0** of **0**

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER

2019-09-12 Thread GitBox
KomachiSion opened a new pull request #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER URL: https://github.com/apache/incubator-shardingsphere/pull/3028 Fixes #3027 . This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] KomachiSion opened a new issue #3027: Return Wrong type for tinyint and smallint column

2019-09-12 Thread GitBox
KomachiSion opened a new issue #3027: Return Wrong type for tinyint and smallint column URL: https://github.com/apache/incubator-shardingsphere/issues/3027 ## Bug Report ### Which version of ShardingSphere did you use? 4.0.0-RC2 ### Which project did you use?

[GitHub] [incubator-shardingsphere] xyl1204 opened a new issue #3026: 配置分库分表时names包含空格导致找不到数据源

2019-09-12 Thread GitBox
xyl1204 opened a new issue #3026: 配置分库分表时names包含空格导致找不到数据源 URL: https://github.com/apache/incubator-shardingsphere/issues/3026 我在分库分表的配置中设置names时包含了空格,导致路由不到对就的数据源上。 This is an automated message from the Apache Git Service.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3025: Fixed generic compilation errors

2019-09-12 Thread GitBox
terrymanu commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530711741 Hi, before your pr, the compilation is successful. Do you find compilation error?

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3019: maven build errors

2019-09-12 Thread GitBox
Myshiner commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530708209 The previous process still running,and for now no error return, i will reply if get any error logs. Thx.

[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors

2019-09-12 Thread GitBox
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530692404 Hi @Myshiner , is there any progress ? This is an automated message from the

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version

2019-09-12 Thread GitBox
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-530691280 Sorry, i have no idea about your scenerio and problem, can you upload your example to gitHub, and

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2878: Fail to execute create dynamic table sql

2019-09-12 Thread GitBox
tristaZero commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-530689858 @yangjwInRiver Have you ever tried the 4.0.0.RC2 This

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3025: Fixed generic compilation errors

2019-09-12 Thread GitBox
coveralls commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530684147 ## Pull Request Test Coverage Report for [Build 328](https://coveralls.io/builds/25669845) * **1** of **1** **(100.0%)**

[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #3023: fix bug 2193

2019-09-12 Thread GitBox
KomachiSion edited a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530678798 > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > What do you think of creating an abstract

[GitHub] [incubator-shardingsphere] Pramy removed a comment on issue #3023: fix bug 2193

2019-09-12 Thread GitBox
Pramy removed a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530681723 @KomachiSion > > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > > What do you think of creating

[GitHub] [incubator-shardingsphere] Pramy commented on issue #3023: fix bug 2193

2019-09-12 Thread GitBox
Pramy commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530681723 @KomachiSion > > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > > What do you think of creating an

[GitHub] [incubator-shardingsphere] ningyu1 opened a new issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm

2019-09-12 Thread GitBox
ningyu1 opened a new issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2873 ## How to get the results of the database fragmentation algorithm in the table fragmentation

[GitHub] [incubator-shardingsphere] beijing-penguin opened a new pull request #3025: Fixed generic compilation errors

2019-09-12 Thread GitBox
beijing-penguin opened a new pull request #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025 In the jdk8,Fixed generic compilation errors Fixes #ISSUSE_ID. Changes proposed in this pull request: - - -

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3023: fix bug 2193

2019-09-12 Thread GitBox
KomachiSion commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530678798 > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > What do you think of creating an abstract strategy?