[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #3020: Add Config Center
wgy8283335 commented on issue #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#issuecomment-531085448 > Any idea to increase testing coverage? @terrymanu. I'd like to add integration test for registry center and config center.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530997388 @Myshiner , OK, please let me know if you have the result. Thx！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3034: Optimize performance, reduce unnecessary loops
coveralls commented on issue #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034#issuecomment-530883246 ## Pull Request Test Coverage Report for [Build 334](https://coveralls.io/builds/25680066) * **8** of **8** **(100.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.02%**) to **63.958%** --- | Totals | [](https://coveralls.io/builds/25680066) | | :-- | --: | | Change from base [Build 353](https://coveralls.io/builds/25679345): | 0.02% | | Covered Lines: | 9279 | | Relevant Lines: | 14508 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3033: Optimize performance reduce unnecessary loops
coveralls edited a comment on issue #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#issuecomment-530845718 ## Pull Request Test Coverage Report for [Build 333](https://coveralls.io/builds/25679448) * **8** of **8** **(100.0%)** changed or added relevant lines in **1** file are covered. * **16** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.006%**) to **63.958%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/inline/InlineShardingStrategy.java](https://coveralls.io/builds/25679448/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Froute%2Finline%2FInlineShardingStrategy.java#L63) | 16 | 21.21% | | Totals | [](https://coveralls.io/builds/25679448) | | :-- | --: | | Change from base [Build 350](https://coveralls.io/builds/25669240): | -0.006% | | Covered Lines: | 9279 | | Relevant Lines: | 14508 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #3034: Optimize performance, reduce unnecessary loops
yanyzy opened a new pull request #3034: Optimize performance, reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3034 Optimize performance, reduce unnecessary loops for valueOf MySQLCommandPacketType This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy closed pull request #3033: Optimize performance reduce unnecessary loops
yanyzy closed pull request #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy commented on issue #3033: Optimize performance reduce unnecessary loops
yanyzy commented on issue #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#issuecomment-530864905 I will close this pr, try format code from original version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3027: Return Wrong type for tinyint and smallint column
terrymanu closed issue #3027: Return Wrong type for tinyint and smallint column URL: https://github.com/apache/incubator-shardingsphere/issues/3027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3023: fix bug 2193
terrymanu merged pull request #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2193: Table doesn't exist when sharding value in different datasource with in expression
terrymanu closed issue #2193: Table doesn't exist when sharding value in different datasource with in expression URL: https://github.com/apache/incubator-shardingsphere/issues/2193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3032: Fixed missing mysql test cases for sharding-integration-test module
terrymanu merged pull request #3032: Fixed missing mysql test cases for sharding-integration-test module URL: https://github.com/apache/incubator-shardingsphere/pull/3032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops
terrymanu commented on a change in pull request #3033: Optimize performance
reduce unnecessary loops
URL:
https://github.com/apache/incubator-shardingsphere/pull/3033#discussion_r323772508
##
File path:
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/MySQLCommandPacketType.java
##
@@ -29,245 +32,256 @@
@RequiredArgsConstructor
@Getter
public enum MySQLCommandPacketType implements CommandPacketType {
-
+
Review comment:
Could you do not change the original code format?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops
terrymanu commented on a change in pull request #3033: Optimize performance
reduce unnecessary loops
URL:
https://github.com/apache/incubator-shardingsphere/pull/3033#discussion_r323772923
##
File path:
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/MySQLCommandPacketType.java
##
@@ -29,245 +32,256 @@
@RequiredArgsConstructor
@Getter
public enum MySQLCommandPacketType implements CommandPacketType {
-
+
/**
* COM_SLEEP.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-sleep.html;>COM_SLEEP
*/
COM_SLEEP(0x00),
-
+
/**
* COM_QUIT.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-quit.html;>COM_QUIT
*/
COM_QUIT(0x01),
-
+
/**
* COM_INIT_DB.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-init-db.html;>COM_INIT_DB
*/
COM_INIT_DB(0x02),
-
+
/**
* COM_QUERY.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_QUERY;>COM_QUERY
*/
COM_QUERY(0x03),
-
+
/**
* COM_FIELD_LIST.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_FIELD_LIST;>COM_FIELD_LIST
*/
COM_FIELD_LIST(0x04),
-
+
/**
* COM_CREATE_DB.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_CREATE_DB;>COM_CREATE_DB
*/
COM_CREATE_DB(0x05),
-
+
/**
* COM_DROP_DB.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-create-db.html;>COM_DROP_DB
*/
COM_DROP_DB(0x06),
-
+
/**
* COM_REFRESH.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-refresh.html;>COM_REFRESH
*/
COM_REFRESH(0x07),
-
+
/**
* COM_SHUTDOWN.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-shutdown.html;>COM_SHUTDOWN
*/
COM_SHUTDOWN(0x08),
-
+
/**
* COM_STATISTICS.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-statistics.html#packet-COM_STATISTICS;>COM_STATISTICS
*/
COM_STATISTICS(0x09),
-
+
/**
* COM_PROCESS_INFO.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-process-info.html;>COM_PROCESS_INFO
*/
COM_PROCESS_INFO(0x0a),
-
+
/**
* COM_CONNECT.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-connect.html;>COM_CONNECT
*/
COM_CONNECT(0x0b),
-
+
/**
* COM_PROCESS_KILL.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-process-kill.html;>COM_PROCESS_KILL
*/
COM_PROCESS_KILL(0x0c),
-
+
/**
* COM_DEBUG.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-debug.html;>COM_DEBUG
*/
COM_DEBUG(0x0d),
-
+
/**
* COM_PING.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-ping.html;>COM_PING
*/
COM_PING(0x0e),
-
+
/**
* COM_TIME.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-time.html;>COM_TIME
*/
COM_TIME(0x0f),
-
+
/**
* COM_DELAYED_INSERT.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-time.html;>COM_DELAYED_INSERT
*/
COM_DELAYED_INSERT(0x10),
-
+
/**
* COM_CHANGE_USER.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_CHANGE_USER;>COM_CHANGE_USER
*/
COM_CHANGE_USER(0x11),
-
+
/**
* COM_BINLOG_DUMP.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-change-user.html;>COM_BINLOG_DUMP
*/
COM_BINLOG_DUMP(0x12),
-
+
/**
* COM_TABLE_DUMP.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-table-dump.html;>COM_TABLE_DUMP
*/
COM_TABLE_DUMP(0x13),
-
+
/**
* COM_CONNECT_OUT.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-connect-out.html;>COM_CONNECT_OUT
*/
COM_CONNECT_OUT(0x14),
-
+
/**
* COM_REGISTER_SLAVE.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-register-slave.html;>COM_REGISTER_SLAVE
*/
COM_REGISTER_SLAVE(0x15),
-
+
/**
* COM_STMT_PREPARE.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-stmt-prepare.html;>COM_STMT_PREPARE
*/
COM_STMT_PREPARE(0x16),
-
+
/**
* COM_STMT_EXECUTE.
- *
+ *
* @see https://dev.mysql.com/doc/internals/en/com-stmt-execute.html;>COM_STMT_EXECUTE
*/
COM_STMT_EXECUTE(0x17),
-
+
/**
* COM_STMT_SEND_LONG_DATA.
- *
+ *
* @see
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3025: Fixed generic compilation errors
terrymanu commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530850836 Is it your eclipse's problem? If maven command line is ok, the code should be compile success. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3030: sharding-proxy error log
terrymanu commented on issue #3030: sharding-proxy error log URL: https://github.com/apache/incubator-shardingsphere/issues/3030#issuecomment-530849879 Can you change the title to make sense description for search friendly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3026: 配置分库分表时names包含空格导致找不到数据源
terrymanu closed issue #3026: 配置分库分表时names包含空格导致找不到数据源 URL: https://github.com/apache/incubator-shardingsphere/issues/3026 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3026: 配置分库分表时names包含空格导致找不到数据源
terrymanu commented on issue #3026: 配置分库分表时names包含空格导致找不到数据源 URL: https://github.com/apache/incubator-shardingsphere/issues/3026#issuecomment-530849295 **For English only**, other languages will not accept. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3029: 分片键不传的时候找不到表
terrymanu closed issue #3029: 分片键不传的时候找不到表 URL: https://github.com/apache/incubator-shardingsphere/issues/3029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3029: 分片键不传的时候找不到表
terrymanu commented on issue #3029: 分片键不传的时候找不到表 URL: https://github.com/apache/incubator-shardingsphere/issues/3029#issuecomment-530849402 **For English only**, other languages will not accept. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3033: Optimize performance reduce unnecessary loops
coveralls commented on issue #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033#issuecomment-530845718 ## Pull Request Test Coverage Report for [Build 332](https://coveralls.io/builds/25678069) * **8** of **8** **(100.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.01%**) to **63.976%** --- | Totals | [](https://coveralls.io/builds/25678069) | | :-- | --: | | Change from base [Build 350](https://coveralls.io/builds/25669240): | 0.01% | | Covered Lines: | 9281 | | Relevant Lines: | 14507 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #3033: Optimize performance reduce unnecessary loops
yanyzy opened a new pull request #3033: Optimize performance reduce unnecessary loops URL: https://github.com/apache/incubator-shardingsphere/pull/3033 Optimize performance reduce unnecessary loops for valueOf MySQLCommandPacketType This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #3025: Fixed generic compilation errors
beijing-penguin commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530833138 > Hi, before your pr, the compilation is successful. > Do you find compilation error? shardingsphere can be compiled by using "mvn clean install -DskipTests -Dmaven.javadoc.skip=true"...but when i use eclipse to open the shardingsphere's project and the pom.xml jdk version is "1.8"，Display compilation error。the error is "Type mismatch: cannot convert from Object to boolean". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3032: Fixed missing mysql test cases for sharding-integration-test module
coveralls commented on issue #3032: Fixed missing mysql test cases for sharding-integration-test module URL: https://github.com/apache/incubator-shardingsphere/pull/3032#issuecomment-530774900 ## Pull Request Test Coverage Report for [Build 331](https://coveralls.io/builds/25674171) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **63.964%** --- | Totals | [](https://coveralls.io/builds/25674171) | | :-- | --: | | Change from base [Build 350](https://coveralls.io/builds/25669240): | 0.0% | | Covered Lines: | 9276 | | Relevant Lines: | 14502 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haocao opened a new pull request #3032: Fixed missing mysql test cases for sharding-integration-test module
haocao opened a new pull request #3032: Fixed missing mysql test cases for sharding-integration-test module URL: https://github.com/apache/incubator-shardingsphere/pull/3032 For #3018. Fixed missing mysql test cases for sharding-integration-test module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] rimal opened a new issue #3031: Default setting for KeyGenerator ColumnName and algorithm
rimal opened a new issue #3031: Default setting for KeyGenerator ColumnName and algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/3031 ## Question In my application, I am only doing database level sharding. There is no table level sharding. So, only setting the `DefaultDatabaseShardingStrategyConfig` works fine. But, if I want to use `snowflake` for key generation for my tables, I need to add `TableRuleConfiguration` for all my tables to specify the algorithm and the column name. Is there anyway to set a default key generation config as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3030: sharding-proxy error log
Myshiner commented on issue #3030: sharding-proxy error log URL: https://github.com/apache/incubator-shardingsphere/issues/3030#issuecomment-530760775 2019-09-12 18:13:14.852 [main-EventThread] ERROR org.apache.curator.ConnectionState - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (6307) 2019-09-12 18:13:21.411 [Curator-Framework-0] ERROR org.apache.curator.ConnectionState - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (12865) 2019-09-12 18:13:28.246 [Curator-Framework-0] ERROR org.apache.curator.ConnectionState - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (19701) 2019-09-12 18:13:34.954 [Curator-Framework-0] ERROR org.apache.curator.ConnectionState - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (6699) 2019-09-12 18:13:14.852 [ main-EventThread ] - [ ERROR ] [ org.apache.curator.ConnectionState : 200 ] - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (6307) 2019-09-12 18:13:21.411 [ Curator-Framework-0 ] - [ ERROR ] [ org.apache.curator.ConnectionState : 200 ] - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (12865) 2019-09-12 18:13:28.246 [ Curator-Framework-0 ] - [ ERROR ] [ org.apache.curator.ConnectionState : 200 ] - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (19701) 2019-09-12 18:13:34.954 [ Curator-Framework-0 ] - [ ERROR ] [ org.apache.curator.ConnectionState : 200 ] - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (6699) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner opened a new issue #3030: sharding-proxy error log
Myshiner opened a new issue #3030: sharding-proxy error log URL: https://github.com/apache/incubator-shardingsphere/issues/3030 project: sharding-proxy version: 3.1.0 #2172 Question I got many more warning and error logs as following. 2019-09-12 16:20:05.537 [ HikariPool-56 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-56 - Thread starvation or clock leap detected (housekeeper delta=59s417ms235μs691ns). 2019-09-12 16:19:59.246 [ HikariPool-79 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-79 - Thread starvation or clock leap detected (housekeeper delta=48s692ms241μs156ns). 2019-09-12 16:19:59.247 [ HikariPool-29 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-29 - Thread starvation or clock leap detected (housekeeper delta=59s419ms184μs806ns). 2019-09-12 16:19:59.246 [ HikariPool-2 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-2 - Thread starvation or clock leap detected (housekeeper delta=54s154ms717μs822ns). 2019-09-12 16:20:06.183 [ ShardingSphere-Command-2 ] - [ INFO ] [ ShardingSphere-SQL : 71 ] - Rule Type: master-slave 2019-09-12 16:19:59.247 [ HikariPool-50 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-50 - Thread starvation or clock leap detected (housekeeper delta=1m36s197ms711μs788ns). 2019-09-12 16:19:59.247 [ HikariPool-40 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-40 - Thread starvation or clock leap detected (housekeeper delta=59s417ms250μs54ns). 2019-09-12 16:19:59.246 [ HikariPool-71 housekeeper ] - [ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-71 - Thread starvation or clock leap detected (housekeeper delta=54s154ms726μs716ns). 2019-09-12 16:19:59.246 [ HikariPool-15 housekeeper ] - **[ WARN ] [ com.zaxxer.hikari.pool.HikariPool : 668 ] - HikariPool-15 - Thread starvation or clock leap detected (housekeeper delta=54s154ms720μs555ns).** [ Curator-Framework-0 ] - **[ ERROR ] [ org.apache.curator.ConnectionState : 200 ] - Connection timed out for connection string (10.10.0.193:2182) and timeout (500) / elapsed (12457)** Any suggestions ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3021: Feature#2601 Check RoutingResult.
sunbufu commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530756003 OK, I will do this after mid-autumn festival. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] harry-lianghairui commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)
harry-lianghairui commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-530751612 北京环球网校，http://www.hqwx.com/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult.
tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530745839 The ckecker do affect the performance. One query stay only several microsecond in ShardingSphere. Any additional operation, especially String operation (There's String + String in your codes), will affect the performance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult.
tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530743902 You can compare the performance (QPS) between checking and without checking routingResult. This work can be done by a performance tool like jmeter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3021: Feature#2601 Check RoutingResult.
sunbufu commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530737714 Hello, I don't think the checker will affect performance. Because it only check routingResult with shardingRule and meteData. and I don't know how to prove it. Please give me some advice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER
coveralls commented on issue #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER URL: https://github.com/apache/incubator-shardingsphere/pull/3028#issuecomment-530733725 ## Pull Request Test Coverage Report for [Build 330](https://coveralls.io/builds/25671965) * **0** of **0** changed or added relevant lines in **0** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage decreased (**-0.01%**) to **63.952%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/TimeService.java](https://coveralls.io/builds/25671965/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fkeygen%2FTimeService.java#L33) | 1 | 0.0% | | Totals | [](https://coveralls.io/builds/25671965) | | :-- | --: | | Change from base [Build 350](https://coveralls.io/builds/25669240): | -0.01% | | Covered Lines: | 9273 | | Relevant Lines: | 14500 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER
KomachiSion opened a new pull request #3028: Fix #3027 get TINYINT and SMALLINT as INTEGER URL: https://github.com/apache/incubator-shardingsphere/pull/3028 Fixes #3027 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new issue #3027: Return Wrong type for tinyint and smallint column
KomachiSion opened a new issue #3027: Return Wrong type for tinyint and smallint column URL: https://github.com/apache/incubator-shardingsphere/issues/3027 ## Bug Report ### Which version of ShardingSphere did you use? 4.0.0-RC2 ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-JDBC ### Expected behavior Get `tinyint` type column value from results is `integer` type for MySQL ### Actual behavior Get `tinyint` type column value from results is `byte` type for MySQL ### Reason analyze (If you can) ShardingSphere will getByte in `QueryResultUtil` for tinyint type column, But the tinyint type get from native JDBC getObject is `Integet` type. Same as `small int` type. I also test `small int` type for DB2, PostgreSQL, all return `Integet` type from native JDBC getObject. ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xyl1204 opened a new issue #3026: 配置分库分表时names包含空格导致找不到数据源
xyl1204 opened a new issue #3026: 配置分库分表时names包含空格导致找不到数据源 URL: https://github.com/apache/incubator-shardingsphere/issues/3026 我在分库分表的配置中设置names时包含了空格，导致路由不到对就的数据源上。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3025: Fixed generic compilation errors
terrymanu commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530711741 Hi, before your pr, the compilation is successful. Do you find compilation error? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3019: maven build errors
Myshiner commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530708209 The previous process still running，and for now no error return, i will reply if get any error logs. Thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530692404 Hi @Myshiner , is there any progress ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-530691280 Sorry, i have no idea about your scenerio and problem, can you upload your example to gitHub, and tell us its url? Therefore i can learn more about your problem. @yangjwInRiver This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2878: Fail to execute create dynamic table sql
tristaZero commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-530689858 @yangjwInRiver Have you ever tried the 4.0.0.RC2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3025: Fixed generic compilation errors
coveralls commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530684147 ## Pull Request Test Coverage Report for [Build 328](https://coveralls.io/builds/25669845) * **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage decreased (**-0.007%**) to **63.957%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/TimeService.java](https://coveralls.io/builds/25669845/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fkeygen%2FTimeService.java#L33) | 1 | 0.0% | | Totals | [](https://coveralls.io/builds/25669845) | | :-- | --: | | Change from base [Build 350](https://coveralls.io/builds/25669240): | -0.007% | | Covered Lines: | 9275 | | Relevant Lines: | 14502 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #3023: fix bug 2193
KomachiSion edited a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530678798 > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > What do you think of creating an abstract strategy? it is no necessary to check `availableTargetName` in other strategies. Because other `ShardingStrategy` will call `ShardingAlgorithm` users implements, the `availableTargetName` will input to algorithm and users should return the route result according to the `availableTargetName `. What users return, what ShardingSphere will use. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Pramy removed a comment on issue #3023: fix bug 2193
Pramy removed a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530681723 @KomachiSion > > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > > What do you think of creating an abstract strategy? > > it is no necessary to check `availableTargetName` in other strategies. Because other `ShardingStrategy` will call `ShardingAlgorithm` users implements, the `availableTargetName` will input to algorithm and users will return the route result. What users return, what ShardingSphere will use. in 2193 case, how to finsh the task with other `ShardingStrategy`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Pramy commented on issue #3023: fix bug 2193
Pramy commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530681723 @KomachiSion > > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > > What do you think of creating an abstract strategy? > > it is no necessary to check `availableTargetName` in other strategies. Because other `ShardingStrategy` will call `ShardingAlgorithm` users implements, the `availableTargetName` will input to algorithm and users will return the route result. What users return, what ShardingSphere will use. in 2193 case, how to finsh the task with other `ShardingStrategy`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ningyu1 opened a new issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm
ningyu1 opened a new issue #2873: How to get the results of the database
sharding algorithm in the table sharding algorithm
URL: https://github.com/apache/incubator-shardingsphere/issues/2873
## How to get the results of the database fragmentation algorithm in the
table fragmentation algorithm
Partition key format: `MM`, for example: 201908
Database actualDataNodes: ds${2017..2019}
Table actualDataNodes: ds${2017..2019}
Now I am experiencing the following problem.
When implementing the RangeShardingAlgorithm interface, when the 'between
and' is processed, the condition is 'between 201801 and 201908'. In fact, you
should go to the order1 to order12 table of the ds2018 library and the order1
to order8 table of the ds2019 library for query.
In the algorithm class of the table, how to obtain the routedDataSources
value in the current loop, and determine whether to cross the year according to
routedDataSources, thereby determining the range of the table.
The current status quo is that the database algorithm returns 'ds2018,
ds2019', and then calls the table 'dosharding' method according to the number
of sub-database results, but the table 'dosharding' method cannot get the
routedDataSources of the current loop, so it is impossible to know. What
database is the current loop, so it is impossible to handle the exact range of
table values.
This problem is bothering me and I hope to get help.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin opened a new pull request #3025: Fixed generic compilation errors
beijing-penguin opened a new pull request #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025 In the jdk8，Fixed generic compilation errors Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3023: fix bug 2193
KomachiSion commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530678798 > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > What do you think of creating an abstract strategy? it is no necessary to check `availableTargetName` in other strategies. Because other `ShardingStrategy` will call `ShardingAlgorithm` users implements, the `availableTargetName` will input to algorithm and users will return the route result. What users return, what ShardingSphere will use. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
