[GitHub] [incubator-shardingsphere] RaigorJiang commented on issue #3663: Fixes #2884
RaigorJiang commented on issue #3663: Fixes #2884 URL: https://github.com/apache/incubator-shardingsphere/pull/3663#issuecomment-561997821 OK, I'll add some test cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye commented on issue #3662: Integrate sharding jdbc with sql server
EricLye commented on issue #3662: Integrate sharding jdbc with sql server URL: https://github.com/apache/incubator-shardingsphere/issues/3662#issuecomment-561997337 There is nothing I can do for it.At least give me a useful suggestion.please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3665: Decouple hook and route dependency for execute module
coveralls edited a comment on issue #3665: Decouple hook and route dependency for execute module URL: https://github.com/apache/incubator-shardingsphere/pull/3665#issuecomment-561987258 ## Pull Request Test Coverage Report for [Build 1074](https://coveralls.io/builds/27428511) * **16** of **17** **(94.12%)** changed or added relevant lines in **6** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.006%**) to **68.023%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/callback/ProxySQLExecuteCallback.java](https://coveralls.io/builds/27428511/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fcallback%2FProxySQLExecuteCallback.java#L73) | 0 | 1 | 0.0% | Totals | [![Coverage Status](https://coveralls.io/builds/27428511/badge)](https://coveralls.io/builds/27428511) | | :-- | --: | | Change from base [Build 590](https://coveralls.io/builds/27407816): | 0.006% | | Covered Lines: | 11415 | | Relevant Lines: | 16781 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu edited a comment on issue #3256: Provider Scaling out Interface
ssxlulu edited a comment on issue #3256: Provider Scaling out Interface URL: https://github.com/apache/incubator-shardingsphere/issues/3256#issuecomment-561922665 Talk about the response body: 1. Start action's reponse body: ``` { "message":"Start job success!", "content":{ "id":"0" } } ``` 2. Query progress's response body: ``` { "message": "Get progress of the job success!", "content": { "id": "0", "job_name": "", "data_node_progress": [ { "id": "{host}-{port}-{schema}", "stage": "prepare/history_data/realtime_data/stopped", "history_data_progress": [ { "id": "{schema}-{table}-split#0", "expected_rows": 0, "sycned_rows": 0 } ], "realtime_data_progress": { "id": "{schema}-realtime", "log_positon": 0, "delay_second": 0 } } ] } } ``` 3. Stop action's response body: ``` { "message":"Stop job success!", "content":"" } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3665: Decouple hook and route dependency for execute module
tristaZero merged pull request #3665: Decouple hook and route dependency for execute module URL: https://github.com/apache/incubator-shardingsphere/pull/3665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3644: shardingvalue cannot Null ?
terrymanu commented on issue #3644: shardingvalue cannot Null ? URL: https://github.com/apache/incubator-shardingsphere/issues/3644#issuecomment-561988500 Maybe we do not need talk about business logic here, we just make sure if we permit `null` for sharding value, which data node should the data inserted into? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3621: ping err
terrymanu closed issue #3621: ping err URL: https://github.com/apache/incubator-shardingsphere/issues/3621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3664: sharding 和mybatis存在sql分页不兼容
terrymanu commented on issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664#issuecomment-561988101 **For English only**, other languages will not accept. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3664: sharding 和mybatis存在sql分页不兼容
terrymanu closed issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3665: Decouple hook and route dependency for execute module
coveralls commented on issue #3665: Decouple hook and route dependency for execute module URL: https://github.com/apache/incubator-shardingsphere/pull/3665#issuecomment-561987258 ## Pull Request Test Coverage Report for [Build 1073](https://coveralls.io/builds/27428264) * **16** of **17** **(94.12%)** changed or added relevant lines in **6** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.006%**) to **68.023%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/callback/ProxySQLExecuteCallback.java](https://coveralls.io/builds/27428264/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fcallback%2FProxySQLExecuteCallback.java#L73) | 0 | 1 | 0.0% | Totals | [![Coverage Status](https://coveralls.io/builds/27428264/badge)](https://coveralls.io/builds/27428264) | | :-- | --: | | Change from base [Build 590](https://coveralls.io/builds/27407816): | 0.006% | | Covered Lines: | 11415 | | Relevant Lines: | 16781 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye commented on issue #3662: Integrate sharding jdbc with sql server
EricLye commented on issue #3662: Integrate sharding jdbc with sql server URL: https://github.com/apache/incubator-shardingsphere/issues/3662#issuecomment-561986728 Three is an important information: ``` line 3:0 no viable alternative at input '(id,name,count' ``` It is printed at org.antlr.v4.runtime.ConsoleErrorListener#syntaxError Is it a rule parse error? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye commented on issue #3662: Integrate sharding jdbc with sql server
EricLye commented on issue #3662: Integrate sharding jdbc with sql server URL: https://github.com/apache/incubator-shardingsphere/issues/3662#issuecomment-561984076 I think , it is my yaml ,maybe. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #3665: Decouple hook and route dependency for execute module
nancyzrh commented on issue #3665: Decouple hook and route dependency for execute module URL: https://github.com/apache/incubator-shardingsphere/pull/3665#issuecomment-561983579 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3665: Decouple hook and route dependency for execute module
terrymanu opened a new pull request #3665: Decouple hook and route dependency for execute module URL: https://github.com/apache/incubator-shardingsphere/pull/3665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3664: sharding 和mybatis存在sql分页不兼容
dongzl commented on issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664#issuecomment-561952325 Hi @wanghaipeng1205 , **For English only**, other languages will not accept. You can close this issue and submit a new issue in English again. and screenshot doesn't search friendly, can you submit a test project on github? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wanghaipeng1205 commented on issue #3664: sharding 和mybatis存在sql分页不兼容
wanghaipeng1205 commented on issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664#issuecomment-561951554 Rule Type: sharding [2019-12-05 11:16:08.410] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Logic SQL: SELECT COUNT(1) FROM order_return_goods WHERE mall_code = ? AND is_delete = ? [2019-12-05 11:16:08.410] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - SQLStatement: SelectStatement(super=DQLStatement(super=AbstractSQLStatement(type=DQL, tables=Tables(tables=[Table(name=order_return_goods, alias=Optional.absent())]), conditions=Conditions(orCondition=OrCondition(andConditions=[])), sqlTokens=[TableToken(beginPosition=21, skippedSchemaNameLength=0, originalLiterals=order_return_goods)], parametersIndex=2)), containStar=false, selectListLastPosition=16, groupByLastPosition=0, items=[AggregationSelectItem(type=COUNT, innerExpression=(1), alias=Optional.absent(), derivedAggregationSelectItems=[], index=1)], groupByItems=[], orderByItems=[], limit=null, subQueryStatement=null) [2019-12-05 11:16:08.410] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Actual SQL: shardingds ::: SELECT COUNT(1) FROM order_return_goods WHERE mall_code = ? AND is_delete = ? ::: [[0202A003, 0]] [2019-12-05 11:16:08.413] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Rule Type: sharding [2019-12-05 11:16:08.413] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Logic SQL: SELECT COUNT(1) FROM order_return_goods WHERE mall_code = ? AND is_delete = ? LIMIT ? OFFSET ? [2019-12-05 11:16:08.413] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - SQLStatement: SelectStatement(super=DQLStatement(super=AbstractSQLStatement(type=DQL, tables=Tables(tables=[Table(name=order_return_goods, alias=Optional.absent())]), conditions=Conditions(orCondition=OrCondition(andConditions=[])), sqlTokens=[TableToken(beginPosition=21, skippedSchemaNameLength=0, originalLiterals=order_return_goods)], parametersIndex=4)), containStar=false, selectListLastPosition=16, groupByLastPosition=0, items=[AggregationSelectItem(type=COUNT, innerExpression=(1), alias=Optional.absent(), derivedAggregationSelectItems=[], index=1)], groupByItems=[], orderByItems=[], limit=null, subQueryStatement=null) [2019-12-05 11:16:08.413] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Actual SQL: shardingds ::: SELECT COUNT(1) FROM order_return_goods WHERE mall_code = ? AND is_delete = ? LIMIT ? OFFSET ? ::: [[0202A003, 0, 0, 10]] [2019-12-05 11:16:08.415] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Rule Type: sharding [2019-12-05 11:16:08.415] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - Logic SQL: SELECT return_id,mall_code,return_state,approve_state,return_reason_type,return_reason,return_condition,order_no,order_sub_no,user_id,phone,real_name,order_type,commodity_name,commodity_type,pay_type,accounts_type,auto_point,return_quality,return_money,consume_id,consume_code,consume_time,consume_merchant_name,consume_merchant_code,consume_amount,create_by,create_source,complete_time,is_delete,create_time,update_time,consume_quality,return_trade_no FROM order_return_goods WHERE mall_code = ? AND is_delete = ? ORDER BY create_time DESC LIMIT ?,? [2019-12-05 11:16:08.415] [http-nio-8258-exec-6] INFO Sharding-Sphere-SQL - SQLStatement: SelectStatement(super=DQLStatement(super=AbstractSQLStatement(type=DQL, tables=Tables(tables=[Table(name=order_return_goods, alias=Optional.absent())]), conditions=Conditions(orCondition=OrCondition(andConditions=[])), sqlTokens=[TableToken(beginPosition=460, skippedSchemaNameLength=0, originalLiterals=order_return_goods)], parametersIndex=4)), containStar=false, selectListLastPosition=455, groupByLastPosition=0, items=[CommonSelectItem(expression=mall_code, alias=Optional.absent()), CommonSelectItem(expression=user_id, alias=Optional.absent()), CommonSelectItem(expression=consume_code, alias=Optional.absent()), CommonSelectItem(expression=consume_merchant_code, alias=Optional.absent()), CommonSelectItem(expression=approve_state, alias=Optional.absent()), CommonSelectItem(expression=order_sub_no, alias=Optional.absent()), CommonSelectItem(expression=create_by, alias=Optional.absent()), CommonSelectItem(expression=consume_quality, alias=Optional.absent()), CommonSelectItem(expression=real_name, alias=Optional.absent()), CommonSelectItem(expression=is_delete, alias=Optional.absent()), CommonSelectItem(expression=auto_point, alias=Optional.absent()), CommonSelectItem(expression=accounts_type, alias=Optional.absent()), CommonSelectItem(expression=complete_time, alias=Optional.absent()), CommonSelectItem(expression=commodity_name, alias=Optional.absent()), CommonSelectItem(expression=return_reason, alias=Optional.absent()), CommonSelectItem(expression=return_trade_no, alias=Optional.absent()), CommonSelectItem(expression=return_id,
[GitHub] [incubator-shardingsphere] wanghaipeng1205 commented on issue #3664: sharding 和mybatis存在sql分页不兼容
wanghaipeng1205 commented on issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664#issuecomment-561951372 ![image](https://user-images.githubusercontent.com/35290033/70201655-3dcfb100-1752-11ea-94a6-5b078bb779e2.png) 为什么会有2条统计的sql,导致我总数无法查出来 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wanghaipeng1205 opened a new issue #3664: sharding 和mybatis存在sql分页不兼容
wanghaipeng1205 opened a new issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? ### Which project did you use? Sharding-JDBC or Sharding-Proxy? ### Expected behavior ### Actual behavior ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wanghaipeng1205 commented on issue #3664: sharding 和mybatis存在sql分页不兼容
wanghaipeng1205 commented on issue #3664: sharding 和mybatis存在sql分页不兼容 URL: https://github.com/apache/incubator-shardingsphere/issues/3664#issuecomment-561951181 ![image](https://user-images.githubusercontent.com/35290033/70201623-2395d300-1752-11ea-8da3-b22483493319.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye commented on issue #3662: Integrate sharding jdbc with sql server
EricLye commented on issue #3662: Integrate sharding jdbc with sql server URL: https://github.com/apache/incubator-shardingsphere/issues/3662#issuecomment-561940653 I think I found something.In the shardingPreparedStatement,parameters are empty. ![微信图片_20191205102445](https://user-images.githubusercontent.com/38176256/70198325-8040c000-1749-11ea-9434-ee0971f26db0.png) But in org.apache.ibatis.mapping.MappedStatement,there are the parameters.Look at the picture below. ![微信图片_20191205103543](https://user-images.githubusercontent.com/38176256/70198927-3e187e00-174b-11ea-8f35-a956aaba630d.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] RaigorJiang commented on issue #2884: Repeated column when use encrypt with JPA + Springboot
RaigorJiang commented on issue #2884: Repeated column when use encrypt with JPA + Springboot URL: https://github.com/apache/incubator-shardingsphere/issues/2884#issuecomment-561939209 @KomachiSion I see, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye commented on issue #3662: Integrate sharding jdbc with sql server
EricLye commented on issue #3662: Integrate sharding jdbc with sql server URL: https://github.com/apache/incubator-shardingsphere/issues/3662#issuecomment-561934425 But all the parameters are set. Here is the Book. ``` @EqualsAndHashCode(callSuper = true) @Data @TableName("book") public class Book extends Model { @TableId(value = "id",type = IdType.INPUT) private Integer id; @TableField(value = "name") private String name; @TableField(value = "count") private Integer count; } ``` and my test code. ``` @Test public void saveBatch() { List bookList = new ArrayList<>(); for (int i = 0;i < 10;i ++) { Book book = new Book(); book.setId(i); book.setCount(i); book.setName("test" + i); bookList.add(book); } bookService.saveBatch(bookList); } ``` Besides,I tried druid + sqlserver,without sharding jdbc,and it works.So I blame this on sharding jdbc.Am I wrong? And I accept your suggestion,I will debug the sqlserver driver. Maybe this will force me to quit sqlserver ,to use mysql. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new b2f399b for performance b2f399b is described below commit b2f399b0d45c5fc6a39dff107e8a33d4f1a92259 Author: nancyzrh AuthorDate: Thu Dec 5 09:41:55 2019 +0800 for performance --- report/jtl_json/full_route_test.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/report/jtl_json/full_route_test.json b/report/jtl_json/full_route_test.json index 670d175..e88e37d 100644 --- a/report/jtl_json/full_route_test.json +++ b/report/jtl_json/full_route_test.json @@ -1 +1 @@ -{"INSERT+UPDATE+DELETE": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "50", "Min": "0", "Throughout": "15946.91", "Samples": 99, "Date": "2019.12.05 08:24:48 ", "Avg": "1"}], "type": "MySQL"}, {"data": [{"99.9th": "18", "Err": "0.0%", "95th": "2", "50th": "2", "Max": "42", "Min": "1", "Throughout": "10229.65", "Samples": 99, "Date": "2019.12.05 08:25:17 ", "Avg": "1"}], "type": "Sharding-Proxy"}, {"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", [...] \ No newline at end of file +{"INSERT+UPDATE+DELETE": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "50", "Min": "0", "Throughout": "15946.91", "Samples": 99, "Date": "2019.12.05 08:24:48 ", "Avg": "1"}], "type": "MySQL"}, {"data": [{"99.9th": "18", "Err": "0.0%", "95th": "2", "50th": "2", "Max": "42", "Min": "1", "Throughout": "10229.65", "Samples": 99, "Date": "2019.12.05 08:25:17 ", "Avg": "1"}], "type": "Sharding-Proxy"}, {"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", [...] \ No newline at end of file
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3256: Provider Scaling out Interface
ssxlulu commented on issue #3256: Provider Scaling out Interface URL: https://github.com/apache/incubator-shardingsphere/issues/3256#issuecomment-561922665 Talk about the response body: 1. Start action's reponse body: ``` { "message":"start job success!", "content":{ "id":"0" } } ``` 2. Query progress's response body: ``` { "message": "get progress of the job success!", "content": { "id": "0", "job_name": "", "data_node_progress": [ { "id": "{host}-{port}-{schema}", "stage": "prepare/history_data/realtime_data/stopped", "history_data_progress": [ { "id": "{schema}-{table}-split#0", "expected_rows": 0, "sycned_rows": 0 } ], "realtime_data_progress": { "id": "{schema}-realtime", "log_positon": 0, "delay_second": 0 } } ] } } ``` 3. Stop action's response body: ``` { "message":"stop job success!", "content":"" } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new baa2d2a for performance baa2d2a is described below commit baa2d2a1902019a697e6e68f71a88656e1cc58d6 Author: nancyzrh AuthorDate: Thu Dec 5 08:56:40 2019 +0800 for performance --- report/data/3.0_single_delete_merge.log_plot| 1 + report/data/3.0_single_insert_merge.log_plot| 1 + report/data/3.0_single_select_merge.log_plot| 1 + report/data/3.0_single_update_merge.log_plot| 1 + report/data/3.0_sp_delete_raw_merge.log_plot| 1 + report/data/3.0_sp_insert_raw_merge.log_plot| 1 + report/data/3.0_sp_select_raw_merge.log_plot| 1 + report/data/3.0_sp_update_raw_merge.log_plot| 1 + report/data/4.0_single_delete_merge.log_plot| 1 + report/data/4.0_single_insert_merge.log_plot| 1 + report/data/4.0_single_update_merge.log_plot| 1 + report/data/4.0_sp_delete_raw_merge.log_plot| 1 + report/data/4.0_sp_insert_raw_merge.log_plot| 1 + report/data/4.0_sp_update_raw_merge.log_plot| 1 + report/data/direct_delete_merge.log_plot| 1 + report/data/direct_insert_merge.log_plot| 1 + report/data/direct_update_merge.log_plot| 1 + report/data/encrypt/4.0_sp_delete_enc.log_plot | 1 + report/data/encrypt/4.0_sp_delete_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc_sharding.log_plot | 1 + report/data/jdbc/3.0_sj_ms_delete.log_plot | 1 + report/data/jdbc/3.0_sj_ms_insert.log_plot | 1 + report/data/jdbc/3.0_sj_ms_select.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_delete.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_insert.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_update.log_plot | 1 + report/data/jdbc/3.0_sj_sharding_delete.log_plot| 1 + report/data/jdbc/3.0_sj_sharding_insert.log_plot| 1 + report/data/jdbc/3.0_sj_sharding_update.log_plot| 1 + report/data/jdbc/4.0_sj_delete_raw.log_plot | 1 + report/data/jdbc/4.0_sj_enc_delete.log_plot | 1 + report/data/jdbc/4.0_sj_enc_delete_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_enc_insert.log_plot | 1 + report/data/jdbc/4.0_sj_enc_insert_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_enc_update.log_plot | 1 + report/data/jdbc/4.0_sj_enc_update_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_insert_raw.log_plot | 1 + report/data/jdbc/4.0_sj_ms_delete.log_plot | 1 + report/data/jdbc/4.0_sj_ms_insert.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_delete.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_insert.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_update.log_plot | 1 + report/data/jdbc/4.0_sj_ms_update.log_plot | 1 + report/data/jdbc/4.0_sj_sharding_delete.log_plot| 1 + report/data/jdbc/4.0_sj_sharding_insert.log_plot| 1 + report/data/jdbc/4.0_sj_sharding_update.log_plot| 1 + report/data/jdbc/4.0_sj_update_raw.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms_sharding.log_plot | 1 + report/jtl_json/full_route_test.json| 2 +- report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +- report/jtl_json/master_slave_test.json | 2 +-
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2884: Repeated column when use encrypt with JPA + Springboot
KomachiSion commented on issue #2884: Repeated column when use encrypt with JPA + Springboot URL: https://github.com/apache/incubator-shardingsphere/issues/2884#issuecomment-561916014 @RaigorJiang , I saw the version has been upgrade in 6 days ago. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3663: Fixes #2884
coveralls commented on issue #3663: Fixes #2884 URL: https://github.com/apache/incubator-shardingsphere/pull/3663#issuecomment-561712109 ## Pull Request Test Coverage Report for [Build 1072](https://coveralls.io/builds/27413405) * **20** of **25** **(80.0%)** changed or added relevant lines in **3** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.003%**) to **68.02%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/generator/impl/AssistQueryAndPlainInsertColumnsTokenGenerator.java](https://coveralls.io/builds/27413405/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Ftoken%2Fgenerator%2Fimpl%2FAssistQueryAndPlainInsertColumnsTokenGenerator.java#L62) | 2 | 3 | 66.67% | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptInsertValueParameterRewriter.java](https://coveralls.io/builds/27413405/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Fparameter%2Fimpl%2FEncryptInsertValueParameterRewriter.java#L102) | 9 | 11 | 81.82% | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/generator/impl/EncryptInsertValuesTokenGenerator.java](https://coveralls.io/builds/27413405/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Ftoken%2Fgenerator%2Fimpl%2FEncryptInsertValuesTokenGenerator.java#L144) | 9 | 11 | 81.82% | Totals | [![Coverage Status](https://coveralls.io/builds/27413405/badge)](https://coveralls.io/builds/27413405) | | :-- | --: | | Change from base [Build 590](https://coveralls.io/builds/27407816): | 0.003% | | Covered Lines: | 11424 | | Relevant Lines: | 16795 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] RaigorJiang edited a comment on issue #2884: Repeated column when use encrypt with JPA + Springboot
RaigorJiang edited a comment on issue #2884: Repeated column when use encrypt with JPA + Springboot URL: https://github.com/apache/incubator-shardingsphere/issues/2884#issuecomment-561698702 By the way, the property `` need to upgrade to '4.0.0-RC4-SNAPSHOT' in shardingsphere-example project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] RaigorJiang commented on issue #2884: Repeated column when use encrypt with JPA + Springboot
RaigorJiang commented on issue #2884: Repeated column when use encrypt with JPA + Springboot URL: https://github.com/apache/incubator-shardingsphere/issues/2884#issuecomment-561698702 By the way, he property `` need to upgrade to '4.0.0-RC4-SNAPSHOT' in shardingsphere-example project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] RaigorJiang opened a new pull request #3663: Fixes #2884
RaigorJiang opened a new pull request #3663: Fixes #2884 URL: https://github.com/apache/incubator-shardingsphere/pull/3663 Fixes #2884 Changes proposed in this pull request: - If there are related fields in the original SQL, do not add them; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3361: sharding-proxy is wrong to use nacos.
sunbufu commented on issue #3361: sharding-proxy is wrong to use nacos. URL: https://github.com/apache/incubator-shardingsphere/issues/3361#issuecomment-561667904 @huangjian888 hi, can i have your WeChat id? I have some other questions want to discuss with you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements
terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements URL: https://github.com/apache/incubator-shardingsphere-doc/pull/380#discussion_r353749658 ## File path: document/current/content/manual/sharding-jdbc/configuration/config-java.cn.md ## @@ -288,15 +288,49 @@ ShardingStrategyConfiguration的实现类,用于配置不分片的策略。 | *名称* | *数据类型*| *说明* | | - | | -- | | column| String | 自增列名称 | -| type | String | 自增列值生成器类型,可自定义或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT | -| props | Properties | 属性配置, 注意:使用SNOWFLAKE算法,需要配置worker.id与max.tolerate.time.difference.milliseconds属性使用LEAF_SEGMENT算法,需要配置:必填项serverList,leafKey和选填项initialValue,step,digest,registryCenterType使用LEAF_SNOWFLAKE算法,需要配置:必填项serverList,serviceId和选填项maxTimeDifference,digest,registryCenterType| +| type | String | 自增列值生成器类型,可自定义或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT | Review comment: missing type `LEAF_SNOWFLAKE ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements
terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements URL: https://github.com/apache/incubator-shardingsphere-doc/pull/380#discussion_r353750366 ## File path: document/current/content/manual/sharding-jdbc/configuration/config-java.cn.md ## @@ -288,15 +288,49 @@ ShardingStrategyConfiguration的实现类,用于配置不分片的策略。 | *名称* | *数据类型*| *说明* | | - | | -- | | column| String | 自增列名称 | -| type | String | 自增列值生成器类型,可自定义或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT | -| props | Properties | 属性配置, 注意:使用SNOWFLAKE算法,需要配置worker.id与max.tolerate.time.difference.milliseconds属性使用LEAF_SEGMENT算法,需要配置:必填项serverList,leafKey和选填项initialValue,step,digest,registryCenterType使用LEAF_SNOWFLAKE算法,需要配置:必填项serverList,serviceId和选填项maxTimeDifference,digest,registryCenterType| +| type | String | 自增列值生成器类型,可自定义或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT | +| props | Properties | SNOWFLAKE/LEAF_SEGMENT/LEAF_SNOWFLAKE自增列值生成器的相关属性配置 | + + PropertiesConstant + +属性配置项,可以为以下自增列值生成器的属性 + +# SNOWFLAKE + + | *名称* | *数据类型* |*配置级别* | *说明* | + | --- | --| | --- | + | worker.id(?)| long |选填 | 工作机器唯一id ,默认为0 | + | max.tolerate.time.difference.milliseconds(?)| long |选填 | 最大容忍时钟回退时间,单位:毫秒。默认为10毫秒 | + | max.vibration.offset(?) | int |选填 | 最大抖动上限值,范围[0 , 4096),默认为1。注:若使用此算法生成值作分片值,建议配置此属性。因为默认配置下,此算法在不同毫秒内所生成的key取模2^n (2^n一般为您的分库或分表数) 之后结果总为为0或1。为防止上述分片问题,建议您将此属性值配置为(2^n)-1 | Review comment: `[0 , 4096)` should be `[0, 4096)` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements
terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements URL: https://github.com/apache/incubator-shardingsphere-doc/pull/380#discussion_r353753216 ## File path: document/current/content/manual/sharding-jdbc/configuration/config-java.en.md ## @@ -283,7 +283,39 @@ The implementation class of `ShardingStrategyConfiguration`, used to configure n | - | | --- | | column| String | Column name of key generator| | type | String | Type of key generator,use user-defined ones or built-in ones, e.g. SNOWFLAKE, UUID | -| props | Properties | Property configuration, note:To use the SNOWFLAKE algorithm, you need to configure the `worker.id` and `max.tolerate.time.difference.milliseconds` properties To use the LEAF_SEGMENT algorithm, you need to configure: required `serverList`, `leafKey` and optional `initialValue`, `step`, `digest`, `registryCenterType` To use the LEAF_SNOWFLAKE algorithm, you need to configure: required `serverList`, `serviceId` and optional `maxTimeDifference`, `digest`, `registryCenterType`| +| props | Properties | The Property configuration of `SNOWFLAKE/LEAF_SEGMENT/LEAF_SNOWFLAKE` key generator| Review comment: The Property configuration of `SNOWFLAKE/LEAF_SEGMENT/LEAF_SNOWFLAKE` key generator should be: The Property configuration of key generator This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements
terrymanu commented on a change in pull request #380: Update the Snowflake, leafSnowflake, leafSegment property configuration requirements URL: https://github.com/apache/incubator-shardingsphere-doc/pull/380#discussion_r353751452 ## File path: document/current/content/manual/sharding-jdbc/configuration/config-java.cn.md ## @@ -288,15 +288,49 @@ ShardingStrategyConfiguration的实现类,用于配置不分片的策略。 | *名称* | *数据类型*| *说明* | | - | | -- | | column| String | 自增列名称 | -| type | String | 自增列值生成器类型,可自定义或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT | -| props | Properties | 属性配置, 注意:使用SNOWFLAKE算法,需要配置worker.id与max.tolerate.time.difference.milliseconds属性使用LEAF_SEGMENT算法,需要配置:必填项serverList,leafKey和选填项initialValue,step,digest,registryCenterType使用LEAF_SNOWFLAKE算法,需要配置:必填项serverList,serviceId和选填项maxTimeDifference,digest,registryCenterType| +| type | String | 自增列值生成器类型,可自定义或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT | +| props | Properties | SNOWFLAKE/LEAF_SEGMENT/LEAF_SNOWFLAKE自增列值生成器的相关属性配置 | + + PropertiesConstant + +属性配置项,可以为以下自增列值生成器的属性 + +# SNOWFLAKE + + | *名称* | *数据类型* |*配置级别* | *说明* | + | --- | --| | --- | + | worker.id(?)| long |选填 | 工作机器唯一id ,默认为0 | + | max.tolerate.time.difference.milliseconds(?)| long |选填 | 最大容忍时钟回退时间,单位:毫秒。默认为10毫秒 | + | max.vibration.offset(?) | int |选填 | 最大抖动上限值,范围[0 , 4096),默认为1。注:若使用此算法生成值作分片值,建议配置此属性。因为默认配置下,此算法在不同毫秒内所生成的key取模2^n (2^n一般为您的分库或分表数) 之后结果总为为0或1。为防止上述分片问题,建议您将此属性值配置为(2^n)-1 | + +# LEAF_SEGMENT + + | *名称*| *数据类型* |*配置级别* | *说明* | + | | -- | - | | + | server.list(?) | String |必填 | 连接注册中心服务器的列表,包括IP地址和端口号,多个地址用逗号分隔 如: host1:2181,host2:2181 | + | leaf.key(?) | String |必填 | 最大号段id所对应的key | + | leaf.segment.id.initial.value(?) | long|选填 | 号段id初始值,默认为1 | + | leaf.segment.step(?) | long|选填 | 每次分配的号段步长,默认为1| + | registry.center.digest(?)| String |选填 | 连接注册中心的权限令牌。缺省为不需要权限验证 | + | registry.center.type(?) | String |选填 | 注册中心类型,默认为"zookeeper" | Review comment: "zookeeper" should be `zookeeper` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #381: Test engine enhance
terrymanu merged pull request #381: Test engine enhance URL: https://github.com/apache/incubator-shardingsphere-doc/pull/381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3647: The data decrypt failure when I use mysql's blob field
terrymanu closed issue #3647: The data decrypt failure when I use mysql's blob field URL: https://github.com/apache/incubator-shardingsphere/issues/3647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #3656: #3256 Provider Scaling out Interface-Initialize netty related classes
KomachiSion merged pull request #3656: #3256 Provider Scaling out Interface-Initialize netty related classes URL: https://github.com/apache/incubator-shardingsphere/pull/3656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zhuyaoming edited a comment on issue #3644: shardingvalue cannot Null ?
zhuyaoming edited a comment on issue #3644: shardingvalue cannot Null ? URL: https://github.com/apache/incubator-shardingsphere/issues/3644#issuecomment-561604376 > Which data node should the data inserted into? i use ComplexShardingStrategy , tenant_id and consumer_id can known data, and tenant_id + consumer_id correspond only id_number. i save Map when insert have id_number. so i use tenant_id,consumer_id,id_number as sharding column, if where tenant_id=1 and consumer_id=* sharding is ok if where id_number=* first : find by map get tenant_id and consumer_id second: cal databases that my questions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huangjian888 commented on issue #3361: sharding-proxy is wrong to use nacos.
huangjian888 commented on issue #3361: sharding-proxy is wrong to use nacos. URL: https://github.com/apache/incubator-shardingsphere/issues/3361#issuecomment-561604996 Configure .orchestration_ds.config.schema field to Nacos configuration center such as:key->.orchestration_ds.config.schema value-> schemaName1, schemaName2, schemaName3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zhuyaoming commented on issue #3644: shardingvalue cannot Null ?
zhuyaoming commented on issue #3644: shardingvalue cannot Null ? URL: https://github.com/apache/incubator-shardingsphere/issues/3644#issuecomment-561604376 > Which data node should the data inserted into? i use ComplexShardingStrategy , tenant_id and consumer_id can known data, and tenant_id + consumer_id correspond only id_number. i save Map when insert have id_number. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huangjian888 commented on issue #3361: sharding-proxy is wrong to use nacos.
huangjian888 commented on issue #3361: sharding-proxy is wrong to use nacos. URL: https://github.com/apache/incubator-shardingsphere/issues/3361#issuecomment-561603241 Config-sharding.yaml ->schemaName: sharding_db schemaName field value needs to be configured to Nacos in advance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huangjian888 commented on issue #3361: sharding-proxy is wrong to use nacos.
huangjian888 commented on issue #3361: sharding-proxy is wrong to use nacos. URL: https://github.com/apache/incubator-shardingsphere/issues/3361#issuecomment-561601246 Sharding proxy needs to be configured in Nacos in advance.(#3354) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3361: sharding-proxy is wrong to use nacos.
sunbufu commented on issue #3361: sharding-proxy is wrong to use nacos. URL: https://github.com/apache/incubator-shardingsphere/issues/3361#issuecomment-561597657 @huangjian888 Hi, guy. I have some questions on nacos registry center, can you help me? This is my email . Waiting for your replay :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang opened a new issue #3647: The data decrypt failure when I use mysql's blob field
minghu-zhang opened a new issue #3647: The data decrypt failure when I use mysql's blob field URL: https://github.com/apache/incubator-shardingsphere/issues/3647 Sharding-encrypt doesn't work when I use Msql‘s blob field. There is a problem with the following code : StreamQueryResult.java private String getCiphertext(final Object value) { return null == value ? null : value.toString(); //Blob.toString() ? } Here is type convert code : QueryResultUtil.java private static Object getValueByColumnType(final ResultSet resultSet, final int columnIndex) throws SQLException { ResultSetMetaData metaData = resultSet.getMetaData(); switch (metaData.getColumnType(columnIndex)) { ... case Types.CLOB: return resultSet.getClob(columnIndex); case Types.BLOB: case Types.BINARY: case Types.VARBINARY: case Types.LONGVARBINARY: return resultSet.getBlob(columnIndex); default: return resultSet.getObject(columnIndex); } } This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #381: Test engine enhance
terrymanu commented on a change in pull request #381: Test engine enhance URL: https://github.com/apache/incubator-shardingsphere-doc/pull/381#discussion_r353668307 ## File path: document/current/content/features/test-engine/integration-test-engine.en.md ## @@ -5,7 +5,11 @@ title = "Integration Test Engine" weight = 2 +++ -## Configuration +## Process +The `Parameterized` in JUnit will collect all test data, and pass to test method to assert one by one. The process of handling test data is just like a leaking hourglass : Review comment: Should not have blank between word and symbol for `hourglass :` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #381: Test engine enhance
terrymanu commented on a change in pull request #381: Test engine enhance URL: https://github.com/apache/incubator-shardingsphere-doc/pull/381#discussion_r353668890 ## File path: document/current/content/features/test-engine/sql-case.en.md ## @@ -18,3 +18,9 @@ the SQL to be asserted in file `/sharding-sql-test/src/main/resources/sql/shardi ``` Developer setup the SQL for assertion and database type during on the configuration file. And these SQLs could share in different test engine, that's why we extract the `sharding-sql-test` as a stand alone module. + +### Process + +Following is the data handling process in sql case : Review comment: `SQL` should always upper case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in pull request #381: Test engine enhance
terrymanu commented on a change in pull request #381: Test engine enhance URL: https://github.com/apache/incubator-shardingsphere-doc/pull/381#discussion_r353668543 ## File path: document/current/content/features/test-engine/integration-test-engine.cn.md ## @@ -5,7 +5,12 @@ title = "整合测试引擎" weight = 2 +++ -## 配置 +## 流程 + +Junit 中的 `Parameterized` 会聚合起所有的测试数据,并将测试数据一一传递给测试方法进行断言。数据处理就像是沙漏中的流沙: +![](https://raw.githubusercontent.com/taojintianxia/incubator-shardingsphere-doc/master/community/static/image/integration-test.jpg) Review comment: Please do not use external picture, we need upload it into document repo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3644: shardingvalue cannot Null ?
terrymanu edited a comment on issue #3644: shardingvalue cannot Null ? URL: https://github.com/apache/incubator-shardingsphere/issues/3644#issuecomment-561482499 > > > some times i insert table only have customer_id,tenant_id. i hope insert normally > > > > > > So, I want to know what is the expected behaviour for insert normally? > > no error Which data node should the data inserted into? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3626: Best practice of using Sharding-Proxy for different business systems
terrymanu commented on issue #3626: Best practice of using Sharding-Proxy for different business systems URL: https://github.com/apache/incubator-shardingsphere/issues/3626#issuecomment-561583338 Good idea, we can talk about how to change the java config and yaml to make it can use `query.with.cipher.column` for each table This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3599: Can sharding strategy configuration files support Java?
terrymanu closed issue #3599: Can sharding strategy configuration files support Java? URL: https://github.com/apache/incubator-shardingsphere/issues/3599 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3618: Encryp-JDBC rewrite wrong sql when sql contain character '('
terrymanu commented on issue #3618: Encryp-JDBC rewrite wrong sql when sql contain character '(' URL: https://github.com/apache/incubator-shardingsphere/issues/3618#issuecomment-561582262 @SteNicholas Thank you, assigned This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang closed issue #3647: The data decrypt failure when I use mysql's blob field
minghu-zhang closed issue #3647: The data decrypt failure when I use mysql's blob field URL: https://github.com/apache/incubator-shardingsphere/issues/3647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang commented on issue #3647: The data decrypt failure when I use mysql's blob field
minghu-zhang commented on issue #3647: The data decrypt failure when I use mysql's blob field URL: https://github.com/apache/incubator-shardingsphere/issues/3647#issuecomment-561576715 > We have no plan to add encrypt feature to type blob, do you want add this feature? @minghu-zhang Thank you very much. These problems have been fixed when I download the latest code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3661: Remove QueryResult‘s fixture from merge test case
tristaZero merged pull request #3661: Remove QueryResult‘s fixture from merge test case URL: https://github.com/apache/incubator-shardingsphere/pull/3661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3565: Why are exceptions missing
terrymanu closed issue #3565: Why are exceptions missing URL: https://github.com/apache/incubator-shardingsphere/issues/3565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3658: java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()
terrymanu edited a comment on issue #3658: java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor() URL: https://github.com/apache/incubator-shardingsphere/issues/3658#issuecomment-561573875 Please resolve the conflict in your app scope. Maven can help you to analyze the conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3658: java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()
terrymanu commented on issue #3658: java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor() URL: https://github.com/apache/incubator-shardingsphere/issues/3658#issuecomment-561573875 Please resolve the conflict in your app scope. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3660: What is the best way to sharding just for a single key
terrymanu commented on issue #3660: What is the best way to sharding just for a single key URL: https://github.com/apache/incubator-shardingsphere/issues/3660#issuecomment-561573339 The exception is `[Inline strategy cannot support range sharding.]` So please do not use Inline strategy with range sharding, you can use java strategy for your range sharding. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3660: What is the best way to sharding just for a single key
terrymanu closed issue #3660: What is the best way to sharding just for a single key URL: https://github.com/apache/incubator-shardingsphere/issues/3660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3361: sharding-proxy is wrong to use nacos.
sunbufu commented on issue #3361: sharding-proxy is wrong to use nacos. URL: https://github.com/apache/incubator-shardingsphere/issues/3361#issuecomment-561570629 Hi, They are some PRs maybe can clear up your confusion. (https://github.com/apache/incubator-shardingsphere/pull/3354, https://github.com/apache/incubator-shardingsphere/pull/3150) As you know, Nacos registry center can not support proxy util now. Are you interest in this ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye opened a new issue #3662: Integrate sharding jdbc with sql server
EricLye opened a new issue #3662: Integrate sharding jdbc with sql server URL: https://github.com/apache/incubator-shardingsphere/issues/3662 ## Can anybody help me? I have worked on it for about 3 days,and it didnot work yet. Here is my yaml ``` server: port: 8081 spring: shardingsphere: sharding: default-database-strategy: inline: algorithm-expression: db$->{id % 3} sharding-column: id tables: book: #由数据源名 + 表名组成,以小数点分隔。 #多个表以逗号分隔,支持inline表达式。缺省表示使用已知数据源与逻辑表名称生成数据节点。 #用于广播表(即每个库中都需要一个同样的表用于关联查询,多为字典表)或只分库不分表且所有库的表结构完全一致的情况 actual-data-nodes: db$->{0..2}.book_$->{0..1} # key-generator: ##自增列名称,缺省表示不使用自增主键生成器 #column: id # #自增列值生成器类型,缺省表示使用默认自增列值生成器。可使用用户自定义的列值生成器或选择内置类型:SNOWFLAKE/UUID/LEAF_SEGMENT #type: SNOWFLAKE table-strategy: inline: algorithm-expression: book_$->{id % 2} sharding-column: id binding-tables: book datasource: db0: driver-class-name: com.microsoft.sqlserver.jdbc.SQLServerDriver url: jdbc:sqlserver://127.0.0.1:1433;DatabaseName=db0 password: type: com.alibaba.druid.pool.DruidDataSource username: sa db1: driver-class-name: com.microsoft.sqlserver.jdbc.SQLServerDriver url: jdbc:sqlserver://127.0.0.1:1433;DatabaseName=db1 password: type: com.alibaba.druid.pool.DruidDataSource username: sa db2: driver-class-name: com.microsoft.sqlserver.jdbc.SQLServerDriver url: jdbc:sqlserver://127.0.0.1:1433;DatabaseName=db2 password: type: com.alibaba.druid.pool.DruidDataSource username: sa dsmaster: '' names: db0,db1,db2 props: sql: show: true main: allow-bean-definition-overriding: true mybatis-plus: typeAliasesPackage: cn.wccy.sharding.shardingtest.entity mapper-locations: - classpath*:mapper/*.xml ``` And the maven pom is below:`mssql-jdbc 6.4.0.jre8`,`sharding-jdbc-spring-boot-starter 4.0.0-RC2` ``` org.apache.shardingsphere sharding-jdbc-spring-boot-starter 4.0.0-RC2 org.springframework.boot spring-boot-starter-web org.projectlombok lombok true com.baomidou mybatis-plus-boot-starter 3.1.1 com.microsoft.sqlserver mssql-jdbc 6.4.0.jre8 org.springframework.boot spring-boot-starter-test test org.junit.vintage junit-vintage-engine org.springframework.boot spring-boot-configuration-processor true junit junit 4.12 com.alibaba fastjson 1.2.58 com.alibaba druid-spring-boot-starter 1.1.18 ``` And I have tried mysql also.It works well.I do not know why. Here is the test code below ``` @Test public void saveBatch() { List bookList = new ArrayList<>(); for (int i = 0;i < 100;i ++) { Book book = new Book(); book.setId(i); book.setCount(i); book.setName("test" + i); bookList.add(book); } bookService.saveBatch(bookList); } ``` and the exception stack trace: ``` org.apache.ibatis.exceptions.PersistenceException: ### Error flushing statements. Cause: com.microsoft.sqlserver.jdbc.SQLServerException: The value is not set for the parameter number 1. ### Cause: com.microsoft.sqlserver.jdbc.SQLServerException: The value is not set for the parameter number 1. at org.apache.ibatis.exceptions.ExceptionFactory.wrapException(ExceptionFactory.java:30) at org.apache.ibatis.session.defaults.DefaultSqlSession.flushStatements(DefaultSqlSession.java:254) at com.baomidou.mybatisplus.extension.service.impl.ServiceImpl.saveBatch(ServiceImpl.java:132) at com.baomidou.mybatisplus.extension.service.IService.saveBatch(IService.java:58) at com.baomidou.mybatisplus.extension.service.IService$$FastClassBySpringCGLIB$$f8525d18.invoke() at
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3661: Remove QueryResult‘s fixture from merge test case
terrymanu opened a new pull request #3661: Remove QueryResult‘s fixture from merge test case URL: https://github.com/apache/incubator-shardingsphere/pull/3661 Use mock to instead of QueryResult‘s fixture. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3652: Update docker java version
terrymanu merged pull request #3652: Update docker java version URL: https://github.com/apache/incubator-shardingsphere/pull/3652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3527: Run sharding proxy to proxy postgresql through the official docker image startup failed
terrymanu closed issue #3527: Run sharding proxy to proxy postgresql through the official docker image startup failed URL: https://github.com/apache/incubator-shardingsphere/issues/3527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EricLye commented on issue #2987: SQLServer OFFSET FETCH pagination return wrong results.
EricLye commented on issue #2987: SQLServer OFFSET FETCH pagination return wrong results. URL: https://github.com/apache/incubator-shardingsphere/issues/2987#issuecomment-561563691 can you show your yaml?I have problems when i integrate sharding jdbc and sqlserver.It didnot work with sharding jdbc version 3.1.0 or 4.0.0-RC2. I tried mysql,and it works well.I do not know the reason.Maybe the reason is sqlserver? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lirengui commented on issue #3599: Can sharding strategy configuration files support Java?
lirengui commented on issue #3599: Can sharding strategy configuration files support Java? URL: https://github.com/apache/incubator-shardingsphere/issues/3599#issuecomment-561552949 > @lirengui, Hi, can we close this issue? sure,thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lightning-pro opened a new issue #3660: What is the best way to sharding just for a single key
lightning-pro opened a new issue #3660: What is the best way to sharding just for a single key URL: https://github.com/apache/incubator-shardingsphere/issues/3660 I used to have a sharding rule like this shardingRule: tables: CUSTOMER_SMS_NUM: actualDataNodes: SmsPubSign.CUSTOMER_SMS_NUM_${0..16} tableStrategy: inline: shardingColumn: SMS_NUM_ID algorithmExpression: CUSTOMER_SMS_NUM_${Math.abs(String.valueOf(SMS_NUM_ID).hashCode() % 17)} which is the best way I think for sharding only for one key like SMS_NUM_ID. when I select the record by the key, it work fine.but when I need to select like this `SELECT SMS_NUM_ID FROM CUSTOMER_SMS_NUM WHERE SMS_NUM_ID > 11 limit 0,20.` when in the version of 4.0.0-RC2,this work good. but now from RC3 to RC4 ,this will encounter an error SQL 错误 [10002] [C1000]: 2Unknown exception: [Inline strategy cannot support range sharding.] Any suggestion on this? what should I do for this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3256: Provider Scaling out Interface
ssxlulu commented on issue #3256: Provider Scaling out Interface URL: https://github.com/apache/incubator-shardingsphere/issues/3256#issuecomment-561530553 > In my opinion, the `stop` interface should not use DELETE method, because this interface only stop the scaling job. > > What's more all interface can add `/job/` prefix like > > ``` > /shardingscaling/job/start [POST] > /shardingscaling/job/progress/${jobId} [GET] > /shardingscaling/job/stop [POST] > ``` Agree. The apis will be these. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services