[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
tristaZero commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-575515321 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-575514607 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yexufeijun opened a new issue #4006: Execute insert SQL error，columnNames size is 0,java.util.NoSuchElementException
yexufeijun opened a new issue #4006: Execute insert SQL error，columnNames size is 0,java.util.NoSuchElementException URL: https://github.com/apache/incubator-shardingsphere/issues/4006 demo: https://github.com/yexufeijun/sharding-jdbc-test-demo.git error msg: ### Error updating database. Cause: java.util.NoSuchElementException ### The error may exist in com/example/sharding/mapper/TestShardingAMapper.java (best guess) ### The error may involve com.example.sharding.mapper.TestShardingAMapper.insert-Inline ### The error occurred while setting parameters ### SQL: INSERT INTO TEST_SHARDING_A ( id, sd_name ) VALUES ( ?, ? ) ### Cause: java.util.NoSuchElementException at org.apache.ibatis.exceptions.ExceptionFactory.wrapException(ExceptionFactory.java:30) at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:199) at org.apache.ibatis.session.defaults.DefaultSqlSession.insert(DefaultSqlSession.java:184) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:426) ... 69 more Caused by: java.util.NoSuchElementException at java.util.Collections$EmptyIterator.next(Collections.java:4189) at org.apache.shardingsphere.core.route.router.sharding.condition.engine.InsertClauseShardingConditionEngine.createShardingCondition(InsertClauseShardingConditionEngine.java:85) at org.apache.shardingsphere.core.route.router.sharding.condition.engine.InsertClauseShardingConditionEngine.createShardingConditions(InsertClauseShardingConditionEngine.java:64) at org.apache.shardingsphere.core.route.router.sharding.ShardingRouter.getShardingConditions(ShardingRouter.java:129) at org.apache.shardingsphere.core.route.router.sharding.ShardingRouter.route(ShardingRouter.java:106) at org.apache.shardingsphere.core.route.PreparedStatementRoutingEngine.route(PreparedStatementRoutingEngine.java:63) at org.apache.shardingsphere.core.PreparedQueryShardingEngine.route(PreparedQueryShardingEngine.java:59) at org.apache.shardingsphere.core.BaseShardingEngine.executeRoute(BaseShardingEngine.java:85) at org.apache.shardingsphere.core.BaseShardingEngine.shard(BaseShardingEngine.java:68) at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.shard(ShardingPreparedStatement.java:249) at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.execute(ShardingPreparedStatement.java:190) at org.apache.ibatis.executor.statement.PreparedStatementHandler.update(PreparedStatementHandler.java:47) at org.apache.ibatis.executor.statement.RoutingStatementHandler.update(RoutingStatementHandler.java:74) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.ibatis.plugin.Plugin.invoke(Plugin.java:63) at com.sun.proxy.$Proxy90.update(Unknown Source) at com.baomidou.mybatisplus.core.executor.MybatisSimpleExecutor.doUpdate(MybatisSimpleExecutor.java:54) at org.apache.ibatis.executor.BaseExecutor.update(BaseExecutor.java:117) at com.baomidou.mybatisplus.core.executor.MybatisCachingExecutor.update(MybatisCachingExecutor.java:83) at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:197) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 edited a comment on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 edited a comment on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575496502 > hi, you should exclude the `JtaAutoConfiguration ` in your project like this > > ``` > @SpringBootApplication(exclude = JtaAutoConfiguration.class) > ``` > > aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself Thank you for your patient reply. It finally worked when I excluded JtaAutoConfiguration from my project. The solution is to use DataSourceTransactionManager by default after excluded JtaAutoConfiguration ? The second question is, can I use 2PC XA transactions after excluding JtaAutoConfiguration? (Even if that means no JtaTransactionManager) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575505389 > hi, you should exclude the `JtaAutoConfiguration ` in your project like this > > ``` > @SpringBootApplication(exclude = JtaAutoConfiguration.class) > ``` > > aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself As for your statement that "@ShardingTransactionType doesn't work without sharding-transaction-jdbc-spring dependency", which version will be merged? Currently, do we have to develop the @ShardingTransactionType aspect by ourselves? Like this? https://github.com/OpenSharding/shardingsphere-spi-impl/blob/4.0.0-RC2/sharding-spring/sharding-transaction-spring/sharding-transaction-jdbc-spring/src/main/java/io/shardingsphere/transaction/aspect/ShardingTransactionJDBCAspect.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 edited a comment on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 edited a comment on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575496502 > hi, you should exclude the `JtaAutoConfiguration ` in your project like this > > ``` > @SpringBootApplication(exclude = JtaAutoConfiguration.class) > ``` > > aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself Thank you for your patient reply. It finally worked When I excluded JtaAutoConfiguration from my project. The solution is to Use DataSourceTransactionManager by default After excluded JtaAutoConfiguration ? The second question is, can I use 2PC XA transactions after excluding JtaAutoConfiguration? (Even if that means no JtaTransactionManager) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3993: Start error with yml
KomachiSion commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575501393 > @KomachiSion > Yes, I see 4 in the official documentation, I think 3 is no longer maintained > https://shardingsphere.apache.org/document/current/cn/manual/sharding-jdbc/usage/sharding/ Sorry, I mean can you have a try for 4.0.0 version, not 4.0.0-RC3. 4.0.0 version has release recently. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem
KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575500823 I have some ideas for this issue. I will reproduce and feedback as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-575500743 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-575499975 I will close this issue because create and describe in new issue#4005. If has more discussion or solution, please move to #4005. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion closed issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new issue #4005: sharding-jdbc-spring-boot-starter can't support NoneShardingStrategy
KomachiSion opened a new issue #4005: sharding-jdbc-spring-boot-starter can't
support NoneShardingStrategy
URL: https://github.com/apache/incubator-shardingsphere/issues/4005
## Bug Report
Related issue #3977 .
### Which version of ShardingSphere did you use?
4.0.0-RC1 ~ 4.0.0
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
### Expected behavior
```yaml
spring:
shardingsphere:
sharding:
tables:
t_order:
actualDataNodes: ds$->{0..1}.t_order
databaseStrategy:
inline:
shardingColumn: order_id
algorithmExpression: ds$->{order_id % 2}
tableStrategy:
none: {}
```
tableStrategy in shardingRule of `t_order` is NoneStrategy.
### Actual behavior
tableStrategy is null.
### Reason analyze (If you can)
spring-boot will process yaml parse result to properties.
So if the value is empty map or collection, it will ignore this propertries.
And then when instance bean, spring boot find there are no properties for
`tableStrategy`, and skip instance `tableStrategy`.
detail see `YamlProcessor` in `org.springframework.beans.factory.config` And
`ValueObjectBinder` in ` org.springframework.boot.context.properties.bind`.
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
configuration:
```yaml
spring:
shardingsphere:
datasource:
names: ds0, ds1
ds0:
type: org.apache.commons.dbcp2.BasicDataSource
driverClassName: com.mysql.jdbc.Driver
url: jdbc:mysql://localhost:3306/demo_ds_0?useUnicode=true
username: root
password:
ds1:
type: org.apache.commons.dbcp2.BasicDataSource
driverClassName: com.mysql.jdbc.Driver
url: jdbc:mysql://localhost:3306/demo_ds_1?useUnicode=true
username: root
password:
sharding:
tables:
t_order:
actualDataNodes: ds$->{0..1}.t_order
databaseStrategy:
inline:
shardingColumn: order_id
algorithmExpression: ds$->{order_id % 2}
tableStrategy:
none: {}
props:
sql:
show: true
```
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] stamhe commented on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed
stamhe commented on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed URL: https://github.com/apache/incubator-shardingsphere/issues/2712#issuecomment-575497056 官方这个问题在 4.0.0 还没有修复么？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575496502 > hi, you should exclude the `JtaAutoConfiguration ` in your project like this > > ``` > @SpringBootApplication(exclude = JtaAutoConfiguration.class) > ``` > > aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself Thank you for your patient reply. It finally worked When I excluded JtaAutoConfiguration from my project. The solution is to Use DataSourceTransactionManager by default After excluded JtaAutoConfiguration ? The second question is, whether XA transactions can be used after JtaAutoConfiguration is excluded? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 removed a comment on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 removed a comment on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575486520 Thank you for your patient reply. It finally worked When I excluded JtaAutoConfiguration from my project. The solution is to Use DataSourceTransactionManager by default After excluded JtaAutoConfiguration ? The second question is, whether XA transactions can be used after JtaAutoConfiguration is excluded? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cielswift commented on issue #3993: Start error with yml
cielswift commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575496207 @KomachiSion Yes, I see 4 in the official documentation, I think 3 is no longer maintained https://shardingsphere.apache.org/document/current/cn/manual/sharding-jdbc/usage/sharding/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cielswift commented on issue #3993: Start error with yml
cielswift commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575495337 @terrymanu 2020-01-17 14:34:43.348 ERROR 7196 --- [ restartedMain] o.s.b.web.embedded.tomcat.TomcatStarter : Error starting Tomcat context. Exception: org.springframework.beans.factory.BeanCreationException. Message: Error creating bean with name 'servletEndpointRegistrar' defined in class path resource [org/springframework/boot/actuate/autoconfigure/endpoint/web/ServletEndpointManagementContextConfiguration$WebMvcServletEndpointManagementContextConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.endpoint.web.ServletEndpointRegistrar]: Factory method 'servletEndpointRegistrar' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'healthEndpoint' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.class]: Unsatisfied dependency expressed through method 'healthEndpoint' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'healthContributorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.boot.actuate.autoconfigure.jdbc.DataSourceHealthContributorAutoConfiguration': Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataSource' defined in class path resource [com/alibaba/druid/spring/boot/autoconfigure/DruidDataSourceAutoConfigure.class]: Invocation of init method failed; nested exception is org.springframework.boot.autoconfigure.jdbc.DataSourceProperties$DataSourceBeanCreationException: Failed to determine a suitable driver class 2020-01-17 14:34:43.375 INFO 7196 --- [ restartedMain] o.apache.catalina.core.StandardService : Stopping service [Tomcat] 2020-01-17 14:34:43.388 WARN 7196 --- [ restartedMain] o.a.c.loader.WebappClassLoaderBase : The web application [producer] appears to have started a thread named [RxIoScheduler-1 (Evictor)] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: java.base@13.0.1/jdk.internal.misc.Unsafe.park(Native Method) java.base@13.0.1/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:235) java.base@13.0.1/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2123) java.base@13.0.1/java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1182) java.base@13.0.1/java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:899) java.base@13.0.1/java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1054) java.base@13.0.1/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1114) java.base@13.0.1/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) java.base@13.0.1/java.lang.Thread.run(Thread.java:830) 2020-01-17 14:34:43.389 WARN 7196 --- [ restartedMain] o.a.c.loader.WebappClassLoaderBase : The web application [producer] appears to have started a thread named [lettuce-eventExecutorLoop-1-1] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: java.base@13.0.1/jdk.internal.misc.Unsafe.park(Native Method) java.base@13.0.1/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:235) java.base@13.0.1/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2123) java.base@13.0.1/java.util.concurrent.LinkedBlockingQueue.poll(LinkedBlockingQueue.java:458) app//io.netty.util.concurrent.SingleThreadEventExecutor.takeTask(SingleThreadEventExecutor.java:289) app//io.netty.util.concurrent.DefaultEventExecutor.run(DefaultEventExecutor.java:64) app//io.netty.util.concurrent.SingleThreadEventExecutor$6.run(SingleThreadEventExecutor.java:1050) app//io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[GitHub] [incubator-shardingsphere] cielswift commented on issue #3993: Start error with yml
cielswift commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575494939 @terrymanu    This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4001: Try to fix spring access denied error in build.
SteNicholas merged pull request #4001: Try to fix spring access denied error in build. URL: https://github.com/apache/incubator-shardingsphere/pull/4001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575486520 Thank you for your patient reply. It finally worked When I excluded JtaAutoConfiguration from my project. The solution is to Use DataSourceTransactionManager by default After excluded JtaAutoConfiguration ? The second question is, whether XA transactions can be used after JtaAutoConfiguration is excluded? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #4004: #3968, carry pr#3999
tuohai666 opened a new pull request #4004: #3968, carry pr#3999 URL: https://github.com/apache/incubator-shardingsphere/pull/4004 Fixes #3968. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yexufeijun commented on issue #3930: sharding-jdbc4 scan some tables in all_tab_columns.but the current user does not have permission.then throws the Exception:Tabl
yexufeijun commented on issue #3930: sharding-jdbc4 scan some tables in all_tab_columns.but the current user does not have permission.then throws the Exception:Table or view does not exist URL: https://github.com/apache/incubator-shardingsphere/issues/3930#issuecomment-575478398 I have the same problem. I use ojdbc6.jar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 commented on a change in pull request #3999: #3968, Ambiguous
description of COM_STMT_EXECUTE in MySQL protocol
URL:
https://github.com/apache/incubator-shardingsphere/pull/3999#discussion_r367780624
##
File path:
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/execute/MySQLComStmtExecutePacket.java
##
@@ -86,7 +86,7 @@ public MySQLComStmtExecutePacket(final MySQLPacketPayload
payload) throws SQLExc
} else {
nullBitmap = null;
newParametersBoundFlag = null;
-parameters = null;
+parameters = new ArrayList<>(0);;
Review comment:
Yes, it's better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 commented on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/pull/3999#issuecomment-575475111 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3993: Start error with yml
KomachiSion commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575474939 @cielswift Try to use 4.0.0 release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #4001: Try to fix spring access denied error in build.
KomachiSion commented on issue #4001: Try to fix spring access denied error in build. URL: https://github.com/apache/incubator-shardingsphere/pull/4001#issuecomment-575472392 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas closed issue #4003: sharding use mysql8
SteNicholas closed issue #4003: sharding use mysql8 URL: https://github.com/apache/incubator-shardingsphere/issues/4003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #4003: sharding use mysql8
SteNicholas commented on issue #4003: sharding use mysql8 URL: https://github.com/apache/incubator-shardingsphere/issues/4003#issuecomment-575468458 Yes, please use 4.0.0 release version and then use version 8 of mysql-connector-java to connect MySQL8.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas edited a comment on issue #4003: sharding use mysql8
SteNicholas edited a comment on issue #4003: sharding use mysql8 URL: https://github.com/apache/incubator-shardingsphere/issues/4003#issuecomment-575468458 @zhouzhendao123456 Yes, please use 4.0.0 release version and then use version 8 of mysql-connector-java to connect MySQL8.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3992: Sharding-JDBC lost insertValuesContexts when insert
SteNicholas commented on issue #3992: Sharding-JDBC lost insertValuesContexts when insert URL: https://github.com/apache/incubator-shardingsphere/issues/3992#issuecomment-575468045 @leego86 Please remove \n and then test it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zhouzhendao123456 opened a new issue #4003: sharding use mysql8
zhouzhendao123456 opened a new issue #4003: sharding use mysql8 URL: https://github.com/apache/incubator-shardingsphere/issues/4003 sharding use mysql-connector-java version is too old,i hope use mysql 8.0.,mysql-connector-java need version 8 can i do it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575463054 hi, you should exclude the `JtaAutoConfiguration ` in your project like this ``` @SpringBootApplication(exclude = JtaAutoConfiguration.class) ``` aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 opened a new issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 opened a new issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? 4.0.0-RC2 ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-JDBC ### Expected behavior https://shardingsphere.apache.org/document/current/en/features/transaction/function/local-transaction/  ### Actual behavior 1, The insert is committed directly. 2, Local transaction cannot be rolled back after a null pointer exception is thrown. Example code:  ### Reason analyze (If you can) Distributed transactions are enabled after the sharding-transaction-xa-core package is imported into the project. The reason for the insert is directly committed is probably because the autoCommit property of the ShardingConnection class defaults to true and then returns false in the isHoldTransaction function of the ShardingConnection class. ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. Please see the sample code below. ### Example codes for reproduce this issue (such as a github link). https://github.com/Zze0/demo-sharding-jdbc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4001: Try to fix spring access denied error in build.
KomachiSion opened a new pull request #4001: Try to fix spring access denied error in build. URL: https://github.com/apache/incubator-shardingsphere/pull/4001 Try to fix spring access denied error in build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
tristaZero commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-575439676 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData
beijing-penguin commented on issue #3988: Using multithreading make loadDefaultTables faster and remove repeat load tableMetaData URL: https://github.com/apache/incubator-shardingsphere/pull/3988#issuecomment-575439077 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #435: Update asf-site(modify configuration, update user list)
haetao opened a new pull request #435: Update asf-site(modify configuration,update user list) URL: https://github.com/apache/incubator-shardingsphere-doc/pull/435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] happy89lgk commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable xxxx
happy89lgk commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable URL: https://github.com/apache/incubator-shardingsphere/issues/3963#issuecomment-575432580 I have this problem, too; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tmjGitAccount edited a comment on issue #3964: Hintmanager databaseShardingOnly problem
tmjGitAccount edited a comment on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-574947233 @KomachiSion ```yaml spring: shardingsphere: props: sql: show: true sharding: default-database-strategy: hint: algorithm-class-name: com.a.b.c.OrderShardingAlgorithm datasource: names: dsa,dsb dsa: pool-name: dsa type: com.zaxxer.hikari.HikariDataSource driverClassName: com.mysql.jdbc.Driver jdbcUrl: xxx username: xxx password: xxx dsb: pool-name: dsb type: com.zaxxer.hikari.HikariDataSource driverClassName: com.mysql.jdbc.Driver jdbcUrl: xxx username: xxx password: xxx ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4000: Rename IndexAssert to ParameterMarkerAssert
dongzl merged pull request #4000: Rename IndexAssert to ParameterMarkerAssert URL: https://github.com/apache/incubator-shardingsphere/pull/4000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3993: Start error with yml
terrymanu commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-575424916 Can you provide the exception info? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #433: Correct orchestration configuration of java
terrymanu merged pull request #433: Correct orchestration configuration of java URL: https://github.com/apache/incubator-shardingsphere-doc/pull/433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4000: Rename IndexAssert to ParameterMarkerAssert
terrymanu opened a new pull request #4000: Rename IndexAssert to ParameterMarkerAssert URL: https://github.com/apache/incubator-shardingsphere/pull/4000 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhaoyanan pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 4d4d6c2 for performance
4d4d6c2 is described below
commit 4d4d6c2f134be9c033a248f933be6faa7b1e141b
Author: nancyzrh
AuthorDate: Fri Jan 17 09:01:51 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index c936e95..d529458 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 5d88667..7abcefa 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 47528fd..8b60c21 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index f1f4890..6cbc85f 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type":
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3998: 4.0.0-RC1 join bug
SteNicholas commented on issue #3998: 4.0.0-RC1 join bug URL: https://github.com/apache/incubator-shardingsphere/issues/3998#issuecomment-575417660 @huweidada welcome to make any use issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error
SteNicholas commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error URL: https://github.com/apache/incubator-shardingsphere/issues/3856#issuecomment-575416627 @joewee Could you please provide small SQL to me for validation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huweidada closed issue #3998: 4.0.0-RC1 join bug
huweidada closed issue #3998: 4.0.0-RC1 join bug URL: https://github.com/apache/incubator-shardingsphere/issues/3998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huweidada commented on issue #3998: 4.0.0-RC1 join bug
huweidada commented on issue #3998: 4.0.0-RC1 join bug URL: https://github.com/apache/incubator-shardingsphere/issues/3998#issuecomment-575415479 switch 4.0.0 version，the bug disappear. thanks! @SteNicholas This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #434: Add company to user list
terrymanu merged pull request #434: Add company to user list URL: https://github.com/apache/incubator-shardingsphere-doc/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
terrymanu edited a comment on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/pull/3999#issuecomment-575185914 Please set milestone and label This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
terrymanu commented on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/pull/3999#issuecomment-575185914 Please set milestone and lable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
terrymanu commented on a change in pull request #3999: #3968, Ambiguous
description of COM_STMT_EXECUTE in MySQL protocol
URL:
https://github.com/apache/incubator-shardingsphere/pull/3999#discussion_r367459209
##
File path:
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/execute/MySQLComStmtExecutePacket.java
##
@@ -86,7 +86,7 @@ public MySQLComStmtExecutePacket(final MySQLPacketPayload
payload) throws SQLExc
} else {
nullBitmap = null;
newParametersBoundFlag = null;
-parameters = null;
+parameters = new ArrayList<>(0);;
Review comment:
How about use Collections.emptyList()?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3996: carry pr#3969 from dev to 4.0.1
terrymanu merged pull request #3996: carry pr#3969 from dev to 4.0.1 URL: https://github.com/apache/incubator-shardingsphere/pull/3996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3997: carry pr#3863 from dev to 4.0.1
terrymanu merged pull request #3997: carry pr#3863 from dev to 4.0.1 URL: https://github.com/apache/incubator-shardingsphere/pull/3997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3994: PostgreSQL current user
tristaZero merged pull request #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #3990: Parse engine rejects CURRENT_USER in 4.0.0
tristaZero closed issue #3990: Parse engine rejects CURRENT_USER in 4.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/3990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3994: PostgreSQL current user
tristaZero commented on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-575170635 /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 opened a new pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/pull/3999 Fixes #3968. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3998: 4.0.0-RC1 join bug
SteNicholas commented on issue #3998: 4.0.0-RC1 join bug URL: https://github.com/apache/incubator-shardingsphere/issues/3998#issuecomment-575109630 @huweidada Please use the latest version to confirm this bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huweidada commented on issue #3998: 4.0.0-RC1 join bug
huweidada commented on issue #3998: 4.0.0-RC1 join bug URL: https://github.com/apache/incubator-shardingsphere/issues/3998#issuecomment-575108669 SELECT COUNT(*) FROM sku INNER JOIN sku_code INNER JOIN sku_model INNER JOIN model INNER JOIN category ON sku.id = sku_code.sku_id AND sku.id = sku_model.sku_id AND sku_model.model_id = model.id AND model.category_id = category.id WHERE ( sku.owner_org_id = ? and sku_code.owner_org_id = ? and sku_model.owner_org_id = ? and model.owner_org_id = ? and category.owner_org_id = ? and sku.name like ? ) or( sku.owner_org_id = ? and sku_code.owner_org_id = ? and sku_model.owner_org_id = ? and model.owner_org_id = ? and category.owner_org_id = ? and sku_code.tenant_uuid_code like ? ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huweidada opened a new issue #3998: 4.0.0-RC1 join bug
huweidada opened a new issue #3998: 4.0.0-RC1 join bug URL: https://github.com/apache/incubator-shardingsphere/issues/3998 SELECT COUNT(*) FROM sku_25 INNER JOIN sku_code_25 INNER JOIN sku_model_25 INNER JOIN model_25 INNER JOIN category_25 ON sku_25.id = sku_code_25.sku_id AND sku_25.id = sku_model_25.sku_id AND sku_model_25.model_id = model_25.id AND model_25.category_id = category_25.id WHERE ( sku_25.owner_org_id = ? and sku_code_25.owner_org_id = ? and sku_model_25.owner_org_id = ? and model_25.owner_org_id = ? and category_25.owner_org_id = ? and sku.name like ? ) or( sku_25.owner_org_id = ? and sku_code_25.owner_org_id = ? and sku_model_25.owner_org_id = ? and model_25.owner_org_id = ? and category_25.owner_org_id = ? and sku_code.tenant_uuid_code like ? ) sku.name rewrite fail This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yesidu commented on issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常
yesidu commented on issue #2998: Sharding-JDBC 跨库查询合并结果数据类型转换异常 URL: https://github.com/apache/incubator-shardingsphere/issues/2998#issuecomment-575054682 我也遇到了这个问题 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on a change in pull request #3996: carry pr#3969 from dev to 4.0.1
SteNicholas commented on a change in pull request #3996: carry pr#3969 from dev to 4.0.1 URL: https://github.com/apache/incubator-shardingsphere/pull/3996#discussion_r367288017 ## File path: sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/execute/MySQLComStmtExecutePacket.java ## @@ -37,7 +37,7 @@ /** * COM_STMT_EXECUTE command packet for MySQL. - * + * Review comment: Recover to origin style. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3994: PostgreSQL current user
SteNicholas commented on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-575041661 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue #3994: PostgreSQL current user
SteNicholas removed a comment on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-575040177 run /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3994: PostgreSQL current user
SteNicholas commented on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-575040177 run /ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue #3994: PostgreSQL current user
SteNicholas removed a comment on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-575039703 /CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3994: PostgreSQL current user
SteNicholas commented on issue #3994: PostgreSQL current user URL: https://github.com/apache/incubator-shardingsphere/pull/3994#issuecomment-575039703 /CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3995: logicTable of ShardingSphereMetaData don't contain encrypt field in sharding-proxy when testing 'sharding+encrypt'
cherrylzhao commented on issue #3995: logicTable of ShardingSphereMetaData don't contain encrypt field in sharding-proxy when testing 'sharding+encrypt' URL: https://github.com/apache/incubator-shardingsphere/issues/3995#issuecomment-575033837 encrypt only store logic column in metadata, so actual column need to be converted to logic column using EncryptMetaData, we should resolve it in #3922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #3973: 4.0.0 dosen't support LocalDateTime
kimmking commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-575032874 @shuohao @shaoyifan Hi~ I think we can use util.Date instead of LocalDateTime class in your pojo, and conver it in your biz logic methods. or --- We also can use mybatis TypeHandler to process your specific type converted to another type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
