[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #4192: insert float type vaule report "10002 - 2Unknown exception"
SteNicholas commented on issue #4192: insert float type vaule report "10002 - 2Unknown exception" URL: https://github.com/apache/incubator-shardingsphere/issues/4192#issuecomment-584507943 @lklkxcxc The different between the above SQL is Biomaterials. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] mylyed opened a new issue #4236: sharing-proxy can't suport mysql 'longblob' data type
mylyed opened a new issue #4236: sharing-proxy can't suport mysql 'longblob'
data type
URL: https://github.com/apache/incubator-shardingsphere/issues/4236
### Which version of ShardingSphere did you use?
4.0.0-RC3
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
4.0.0-RC3
### Expected behavior
INSERT success
### Actual behavior
INSERT error
### Reason analyze (If you can)
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
the code
'''java
class JDBCTest {
public static void main(String[] args) {
//HikariConfig config2 = new HikariDataSource();
//config2.setUsername("root");
//config2.setPassword("root");
//config2.setJdbcUrl("jdbc:mysql://172.21.16.98:3307/sharding_db");
//config2.setDriverClassName("com.mysql.jdbc.Driver");
//HikariDataSource from = new HikariDataSource(config2);
HikariConfig config = new HikariDataSource();
config.username = "dev";
config.setPassword("21758E78331B20E4");
config.setJdbcUrl("jdbc:mysql://172.21.16.52:3306/kxl_invoice");
config.setDriverClassName("com.mysql.jdbc.Driver");
HikariDataSource from = new HikariDataSource(config);
new Sql(from.getConnection()).executeInsert("""
INSERT INTO `kxl_invoice`.`kxl_verify_batch` (
\t`id`,
\t`company_id`,
\t`user_id`,
\t`batch_num`,
\t`type`,
\t`status`,
\t`faild_desc`,
\t`action_duration`,
\t`retry_count`,
\t`execute_time`,
\t`is_deleted`,
\t`create_time`,
\t`update_time`
)
VALUES
\t(
\t\t'123',
\t\t'3180bdf1-a44f-4bd9-83a1-d49dff39f141',
\t\tNULL,
\t\t'789c4df3dd134d7e81977e038e108f3b',
\t\t'1',
\t\t'3',
\t\t'[Ã\u0083¦Ã\u0082Â\u009FÃ\u0082Â¥Ã\u0083©Ã\u0082ªÃ\u0082Â\u008CÃ\u0083Â¥Ã\u0082¤Ã\u0082±Ã\u0083¨Ã\u0082´Ã\u0082Â¥],[æÂ\u009F¥éªÂ\u008C失败],[æ
¡éª\u008Cç \u0081æ ¼å¼\u008Fæ\u009C\u0089误ï¼\u0081],[校验码格式有误！]',
\t\t'111.45',
\t\t'3',
\t\t'2020-01-10 18:28:26',
\t\t'0',
\t\t'2020-01-10 18:21:04',
\t\t'2020-01-10 18:28:26'
\t);
""");
}
}
'''
the table desc
'''sql
CREATE TABLE `kxl_verify_batch` (
`id` bigint(1) NOT NULL COMMENT '主键',
`company_id` varchar(36) DEFAULT NULL COMMENT '公司id',
`user_id` varchar(36) DEFAULT NULL COMMENT '用户id',
`batch_num` varchar(32) NOT NULL COMMENT '批次号',
`type` int(1) DEFAULT NULL COMMENT '查验类型，1-内部系统使用, 2-外部用户使用',
`status` int(1) DEFAULT NULL COMMENT '查验状态; 0-未查验, 1-查验中，2-查验成功，3-查验失败',
`faild_desc` longblob COMMENT '错误描述',
`action_duration` decimal(10,2) DEFAULT NULL COMMENT '操作耗时，单位-秒',
`retry_count` int(1) DEFAULT '0' COMMENT '重试次数, 最高3次',
`execute_time` datetime DEFAULT NULL COMMENT '任务执行时间',
`is_deleted` int(1) DEFAULT '0' COMMENT '是否删除, 0:未删除 1:已删除',
`create_time` datetime DEFAULT NULL COMMENT '创建时间',
`update_time` datetime DEFAULT NULL COMMENT '更新时间',
PRIMARY KEY (`id`),
KEY `pk_batch_num` (`batch_num`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='批量查验表';
'''
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly
lklkxcxc edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584493358 @terrymanu There is not much change ,I have used param:`serverTimezone=UTC=false=utf8=true=true` The test is faster to import directly into backend mysql database； This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4235: Revise DAL visitor
coveralls commented on issue #4235: Revise DAL visitor URL: https://github.com/apache/incubator-shardingsphere/pull/4235#issuecomment-584495468 ## Pull Request Test Coverage Report for [Build 1677](https://coveralls.io/builds/28648876) * **0** of **2** **(0.0%)** changed or added relevant lines in **1** file are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage remained the same at **64.663%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28648876/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L131) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28648876/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L132) | 1 | 0% | | Totals | [](https://coveralls.io/builds/28648876) | | :-- | --: | | Change from base [Build 816](https://coveralls.io/builds/28648409): | 0.0% | | Covered Lines: | 11016 | | Relevant Lines: | 17036 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly
lklkxcxc commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584493358 @terrymanu There is not much change ,I have used param:`serverTimezone=UTC=false=utf8=true=true` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly
terrymanu edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584490879 Because if you don't use PreparedStatement, it will parse SQL for every call which are very slow. ShardingSphere will cache parse result if using PreparedStatement. Please search `PreparedStatement` from google to get more information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly
terrymanu commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584490879 Because if you don't use PreparedStatement, it will parse SQL for every call which are very slow. ShardingSphere will cache parse result if using PreparedStatement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly
lklkxcxc edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584484024 @terrymanu : I didn't used PreparedStatement and ParameterMarker. What are PreparedStatement and ParameterMarker? database0?serverTimezone=UTC=false=utf8 use sql `insert into pku_influencing_factor VALUES (0,'test','test',123.00)` normal only 1 record This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #4235: Revise DAL visitor
KomachiSion merged pull request #4235: Revise DAL visitor URL: https://github.com/apache/incubator-shardingsphere/pull/4235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4235: Revise DAL visitor
terrymanu opened a new pull request #4235: Revise DAL visitor URL: https://github.com/apache/incubator-shardingsphere/pull/4235 For #3914. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly
lklkxcxc commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584488633 @terrymanu Do you know why insert is so slow? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4233: Revise #4228
coveralls commented on issue #4233: Revise #4228 URL: https://github.com/apache/incubator-shardingsphere/pull/4233#issuecomment-584487551 ## Pull Request Test Coverage Report for [Build 1676](https://coveralls.io/builds/28648493) * **0** of **3** **(0.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **64.663%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28648493/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L170) | 0 | 3 | 0.0% | Totals | [](https://coveralls.io/builds/28648493) | | :-- | --: | | Change from base [Build 815](https://coveralls.io/builds/28648104): | 0.0% | | Covered Lines: | 11016 | | Relevant Lines: | 17036 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly
lklkxcxc edited a comment on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584484024 @terrymanu : I didn't used PreparedStatement and ParameterMarker. What are PreparedStatement and ParameterMarker? database0?serverTimezone=UTC=false=utf8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly
lklkxcxc commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584484024 @terrymanu : I didn't used PreparedStatement and ParameterMarker. What are PreparedStatement and ParameterMarker? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly
terrymanu commented on issue #4231: mysqldump file import sharding-proxy insert speed slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231#issuecomment-584481790 Do you use PreparedStatement and ParameterMarker? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4228: add visitor for setVariable of mysql
terrymanu commented on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584481054 Please pay attention for #4233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4233: Revise #4228
tuohai666 merged pull request #4233: Revise #4228 URL: https://github.com/apache/incubator-shardingsphere/pull/4233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new issue #4234: The enhancement for the first version sharding-scaling-ui
KomachiSion opened a new issue #4234: The enhancement for the first version sharding-scaling-ui URL: https://github.com/apache/incubator-shardingsphere/issues/4234 Scaling-ui has almost done. But when I test, I found there are some problem need to fix and enhance. problem: 1. scaling-ui can't configure the host of scaling-server. 2. UI has cross-domain problem so that web browser which do not support cross-domain can't use scaling. enhancement: 1. History Task total progress only update when history task finished. 2. The detail progress of history task can't refresh automatically. For solve these problems, we should do follow thinks: - [ ] Add configure way for the host of scaling-server in `data-scaling` page. - [ ] Add gateway forwarding in shardingsphere-ui-backend to solve cross-domain problem. - [ ] Enhance progress show. - [ ] Update history task total progress. - [ ] Update detail progresses. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4233: Revise #4228
terrymanu opened a new pull request #4233: Revise #4228 URL: https://github.com/apache/incubator-shardingsphere/pull/4233 For #4228. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4232: Add sharding scaling UI
coveralls edited a comment on issue #4232: Add sharding scaling UI URL: https://github.com/apache/incubator-shardingsphere/pull/4232#issuecomment-584477054 ## Pull Request Test Coverage Report for [Build 9436](https://coveralls.io/builds/28648152) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **64.699%** --- | Totals | [](https://coveralls.io/builds/28648152) | | :-- | --: | | Change from base [Build 9434](https://coveralls.io/builds/28647751): | 0.0% | | Covered Lines: | 11015 | | Relevant Lines: | 17025 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4232: Add sharding scaling UI
codecov-io commented on issue #4232: Add sharding scaling UI URL: https://github.com/apache/incubator-shardingsphere/pull/4232#issuecomment-584479257 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`sharding-scaling-ui@583e9d0`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `61.33%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232?src=pr=tree) ```diff @@ Coverage Diff @@ ## sharding-scaling-ui #4232 +/- ## = Coverage ? 60.8% Complexity ? 352 = Files ?1012 Lines ? 17025 Branches ?3004 = Hits ? 10352 Misses ?6020 Partials ? 653 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...sphere/route/time/DatabaseTimeServiceDelegate.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9kYXRhYmFzZS10aW1lLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JvdXRlL3RpbWUvRGF0YWJhc2VUaW1lU2VydmljZURlbGVnYXRlLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [.../masterslave/LoadBalanceStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9tYXN0ZXJzbGF2ZS9Mb2FkQmFsYW5jZVN0cmF0ZWd5Q29uZmlndXJhdGlvbi5qYXZh) | `50% <ø> (ø)` | `1 <0> (?)` | | | [...dingsphere/route/time/impl/TimeServiceFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9kYXRhYmFzZS10aW1lLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JvdXRlL3RpbWUvaW1wbC9UaW1lU2VydmljZUZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...config/common/YamlAuthenticationConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbEF1dGhlbnRpY2F0aW9uQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [...ig/sharding/YamlShardingStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | | | [...yaml/config/common/YamlProxyUserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbFByb3h5VXNlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | | | [...config/sharding/YamlKeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [...config/sharding/YamlShardingRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sU2hhcmRpbmdSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [.../yaml/config/common/YamlRootRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4232/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbFJvb3RSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | |
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #4232: Add sharding scaling UI
KomachiSion merged pull request #4232: Add sharding scaling UI URL: https://github.com/apache/incubator-shardingsphere/pull/4232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #3848: Support data migration function
KomachiSion closed issue #3848: Support data migration function URL: https://github.com/apache/incubator-shardingsphere/issues/3848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4232: Add sharding scaling UI
coveralls commented on issue #4232: Add sharding scaling UI URL: https://github.com/apache/incubator-shardingsphere/pull/4232#issuecomment-584477054 ## Pull Request Test Coverage Report for [Build 1675](https://coveralls.io/builds/28648007) * **0** of **0** changed or added relevant lines in **0** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **64.705%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28648007/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/28648007) | | :-- | --: | | Change from base [Build 9434](https://coveralls.io/builds/28647751): | 0.006% | | Covered Lines: | 11016 | | Relevant Lines: | 17025 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4228: add visitor for setVariable of mysql
coveralls edited a comment on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584103954 ## Pull Request Test Coverage Report for [Build 9435](https://coveralls.io/builds/28647977) * **0** of **15** **(0.0%)** changed or added relevant lines in **3** files are covered. * **302** unchanged lines in **29** files lost coverage. * Overall coverage increased (+**0.2%**) to **64.657%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/SetStatement.java](https://coveralls.io/builds/28647977/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FSetStatement.java#L27) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/FromTableSegment.java](https://coveralls.io/builds/28647977/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdal%2FFromTableSegment.java#L39) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28647977/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L130) | 0 | 13 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java](https://coveralls.io/builds/28647977/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FAuthenticationChangedListener.java#L36) | 1 | 75.0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java](https://coveralls.io/builds/28647977/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FPropertiesChangedListener.java#L34) | 1 | 75.0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28647977/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L113) | 1 | 97.5% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java](https://coveralls.io/builds/28647977/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fstate%2Flistener%2FDataSourceStateChangedListener.java#L36) | 1 | 85.71% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java](https://coveralls.io/builds/28647977/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fstate%2Flistener%2FInstanceStateChangedListener.java#L35) | 1 | 75.0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/column/ColumnSegment.java](https://coveralls.io/builds/28647977/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdml%2Fcolumn%2FColumnSegment.java#L65) | 1 | 50.0% | |
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4228: add visitor for setVariable of mysql
codecov-io edited a comment on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584101450 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@ec7dde4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4228 +/- ## = Coverage ? 60.76% Complexity? 352 = Files ? 1013 Lines ?17036 Branches ? 3005 = Hits ?10352 Misses? 6031 Partials ? 653 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=footer). Last update [ec7dde4...9586ecb](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4228: add visitor for setVariable of mysql
terrymanu merged pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wqzwh opened a new pull request #4232: Ui 3848
wqzwh opened a new pull request #4232: Ui 3848 URL: https://github.com/apache/incubator-shardingsphere/pull/4232 Fixes #3848 . Changes proposed in this pull request: - Add sharding scaling UI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3973: 4.0.0 dosen't support LocalDateTime
tuohai666 commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-584468337 The result need to be converted to LocalDateTime in QueryResult. 4.x do not support this yet since it's based on JDK 7. Let's wait for 5.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 closed issue #3973: 4.0.0 dosen't support LocalDateTime
tuohai666 closed issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4228: add visitor for setVariable of mysql
terrymanu commented on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584466148 > > The comment `Fixes #3914` will close the #3914, but the issue is not finished yet. > > @terrymanu What should be written？ Maybe `For #3914` or just `#3914` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem
KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-584465029 @tmjGitAccount I will try again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tmjGitAccount commented on issue #3964: Hintmanager databaseShardingOnly problem
tmjGitAccount commented on issue #3964: Hintmanager databaseShardingOnly
problem
URL:
https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-584464879
> I have added, but I don't know your SQLs. I try my SQL, and it still is
unicast routing.
>
> So I need your SQLs and `OrderShardingAlgorithm`
Here is my OrderShardingAlorithm.java，the sql is just a very normal **select
* from table**
All I want is to route to different datasource by different header
for example
1. if the httpheader agency: a
i want this sql be excuted in datasource dsa
2. if the httpheader agency: b
i want this sql be excuted in datasource dsb
maybe could you please provide me an example config for the purpose i want ?
```
import lombok.NoArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.apache.shardingsphere.api.sharding.hint.HintShardingAlgorithm;
import org.apache.shardingsphere.api.sharding.hint.HintShardingValue;
import org.springframework.stereotype.Component;
import org.springframework.web.context.request.RequestAttributes;
import org.springframework.web.context.request.RequestContextHolder;
import org.springframework.web.context.request.ServletRequestAttributes;
import javax.servlet.http.HttpServletRequest;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Optional;
import java.util.stream.Collectors;
@Slf4j
@NoArgsConstructor
@Component("orderShardingAlgorithm")
public class OrderShardingAlgorithm implements HintShardingAlgorithm
{
@Override
public List doSharding(final Collection
availableTargetNames, final HintShardingValue shardingValue) {
RequestAttributes requestAttributes =
RequestContextHolder.getRequestAttributes();
HttpServletRequest request = ((ServletRequestAttributes)
requestAttributes).getRequest();
return Optional.ofNullable(request.getHeader("agency"))
.map(value -> availableTargetNames.stream().filter(v ->
v.equals(value)).collect(Collectors.toList()))
.filter(value -> !value.isEmpty())
.orElse(new ArrayList<>(availableTargetNames));
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem
KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-584457098 I have added, but I don't know your SQLs. I try my SQL, and it still is unicast routing. So I need your SQLs and `OrderShardingAlgorithm` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tmjGitAccount commented on issue #3964: Hintmanager databaseShardingOnly problem
tmjGitAccount commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-584456807 > @tmjGitAccount @darcydai > I try to reproduce problem by configuration you provided, and I found that there are no `tableRule` so that ShardingSphere use unicast routing instead of hint routing. May you provide more information makes me reproduce problem? > > If no more response, I will close this issue and think this is a usage issue add this config may reproduce ? default-table-strategy: hint: algorithm-class-name: com.a.b.c.OrderShardingAlgorithm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 closed issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy
tuohai666 closed issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy URL: https://github.com/apache/incubator-shardingsphere/issues/4146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy
tuohai666 commented on issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy URL: https://github.com/apache/incubator-shardingsphere/issues/4146#issuecomment-584456049 Duplicate with #3097. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc opened a new issue #4231: mysqldump import sharding-proxy slowly
lklkxcxc opened a new issue #4231: mysqldump import sharding-proxy slowly URL: https://github.com/apache/incubator-shardingsphere/issues/4231 Sharding-proxy version: `4.0.0-RC1` Problems encountered：`It took 24 hours to import 10 million records into sharding-proxy.` Sharding-proxy Config: `start.sh -Xmx8g -Xms8g -Xmn4g,server.yaml use default parm` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4229: Move process text and quote character from segment details to IdentifierValue
tristaZero merged pull request #4229: Move process text and quote character from segment details to IdentifierValue URL: https://github.com/apache/incubator-shardingsphere/pull/4229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yl1935 opened a new issue #4230: Has error when use orchestration and mybatis-plus with springboot
yl1935 opened a new issue #4230: Has error when use orchestration and mybatis-plus with springboot URL: https://github.com/apache/incubator-shardingsphere/issues/4230 ## Bug Report Project: Shading-JDBC Verson:4.0.0 I works well on local sharding config with mybatis-plus, and I think it will works well too on orchestration config with registry, but it won't. The error message is "Failed to configure a DataSource: 'url' attribute is not specified and no embedded datasource could be configured." The springboot version is 2.2.4 and I use mybatis-plus and sharding-jdbc-orchestration-spring-boot-starter com.baomidou mybatis-plus-boot-starter 3.3.1 org.apache.shardingsphere sharding-transaction-xa-core 4.0.0 org.apache.shardingsphere sharding-jdbc-orchestration-spring-boot-starter 4.0.0 org.apache.shardingsphere sharding-orchestration-reg-zookeeper-curator 4.0.0 I have read the source code and compared org.apache.shardingsphere.shardingjdbc.spring.boot.SpringBootConfiguration.java(works well) with org.apache.shardingsphere.shardingjdbc.orchestration.spring.boot.OrchestrationSpringBootConfiguration.java (can not work, throws error when startup project) I found @AutoConfigureBefore(DataSourceAutoConfiguration.class) is missing in OrchestrationSpringBootConfiguration.java, I think this is the real reason, I try to add @AutoConfigureBefore in OrchestrationSpringBootConfiguration.java and repackage and replace the local sharding-jdbc-orchestration-spring-boot-starter.jar with the jar I modified, then the error has gone. Because mybatis-plus include spring-boot-starter-jdbc.jar, I think its DataSourceAutoConfiguration loads config before OrchestrationSpringBootConfiguration so the error happened. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #4228: add visitor for setVariable of mysql
jingshanglu commented on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584448817 > The comment `Fixes #3914` will close the #3914, but the issue is not finished yet. @terrymanu What should be written？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem
KomachiSion commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-584441115 @tmjGitAccount @darcydai I try to reproduce problem by configuration you provided, and I found that there are no `tableRule` so that ShardingSphere use unicast routing instead of hint routing. May you provide more information makes me reproduce problem? If no more response, I will close this issue and think this is a usage issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4229: Move process text and quote character from segment details to IdentifierValue
coveralls edited a comment on issue #4229: Move process text and quote character from segment details to IdentifierValue URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584224825 ## Pull Request Test Coverage Report for [Build 9432](https://coveralls.io/builds/28635998) * **2** of **35** **(5.71%)** changed or added relevant lines in **10** files are covered. * **6** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.09%**) to **64.699%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ColumnProjectionSegment.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdml%2Fitem%2FColumnProjectionSegment.java#L40) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/schema/SchemaExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fschema%2FSchemaExtractor.java#L41) | 2 | 4 | 50.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L50) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L139) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L351) | 0 | 3 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/column/ColumnExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fcolumn%2FColumnExtractor.java#L47) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/index/IndexExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Findex%2FIndexExtractor.java#L40) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/table/TableExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Ftable%2FTableExtractor.java#L52) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/identifier/IdentifierValue.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fidentifier%2FIdentifierValue.java#L37) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L204) | 0 | 7 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | |
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4229: Move process text and quote character from segment details to IdentifierValue
codecov-io commented on issue #4229: Move process text and quote character from segment details to IdentifierValue URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584228152 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr=h1) Report > Merging [#4229](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ecf08f90f690d3e284001e8305aa864481d66c3f?src=pr=desc) will **increase** coverage by `0.22%`. > The diff coverage is `2.85%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4229 +/- ## === + Coverage 60.57% 60.8% +0.22% Complexity 352 352 === Files 10151012 -3 Lines 17000 17025 +25 Branches 30013004 +3 === + Hits 10298 10352 +54 + Misses 60506020 -30 - Partials652 653 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/sql/parser/sql/segment/generic/TableSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL1RhYmxlU2VnbWVudC5qYXZh) | `28.57% <ø> (-32.97%)` | `1 <0> (ø)` | | | [...l/parser/sql/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvY29sdW1uL0NvbHVtblNlZ21lbnQuamF2YQ==) | `50% <ø> (-37.5%)` | `0 <0> (ø)` | | | [...re/extractor/impl/common/index/IndexExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi9pbmRleC9JbmRleEV4dHJhY3Rvci5qYXZh) | `16.66% <0%> (-8.34%)` | `1 <0> (ø)` | | | [...select/item/impl/ShorthandProjectionExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9zZWxlY3QvaXRlbS9pbXBsL1Nob3J0aGFuZFByb2plY3Rpb25FeHRyYWN0b3IuamF2YQ==) | `7.14% <0%> (-0.55%)` | `1 <0> (ø)` | | | [...re/extractor/impl/common/table/TableExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi90YWJsZS9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.26% <0%> (-0.62%)` | `1 <0> (ø)` | | | [...l/parser/sql/value/identifier/IdentifierValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvaWRlbnRpZmllci9JZGVudGlmaWVyVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...apache/shardingsphere/sql/parser/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../sql/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9Db2x1bW5Qcm9qZWN0aW9uU2VnbWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | |
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4229: Move process text and quote character from segment details to IdentifierValue
coveralls commented on issue #4229: Move process text and quote character from segment details to IdentifierValue URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584224825 ## Pull Request Test Coverage Report for [Build 1674](https://coveralls.io/builds/28635639) * **2** of **35** **(5.71%)** changed or added relevant lines in **10** files are covered. * **3** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.08%**) to **64.705%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ColumnProjectionSegment.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdml%2Fitem%2FColumnProjectionSegment.java#L40) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/schema/SchemaExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fschema%2FSchemaExtractor.java#L41) | 2 | 4 | 50.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L50) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L139) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L351) | 0 | 3 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/column/ColumnExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fcolumn%2FColumnExtractor.java#L47) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/index/IndexExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Findex%2FIndexExtractor.java#L40) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/table/TableExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Ftable%2FTableExtractor.java#L52) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/identifier/IdentifierValue.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fidentifier%2FIdentifierValue.java#L37) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L204) | 0 | 7 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | |
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3993: Start error with yml
terrymanu commented on issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993#issuecomment-584203184 Closed because no response anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3993: Start error with yml
terrymanu closed issue #3993: Start error with yml URL: https://github.com/apache/incubator-shardingsphere/issues/3993 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4229: Move process text and quote character from segment details to IdentifierValue
terrymanu opened a new pull request #4229: Move process text and quote character from segment details to IdentifierValue URL: https://github.com/apache/incubator-shardingsphere/pull/4229 For #3914. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4228: add visitor for setVariable of mysql
coveralls edited a comment on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584103954 ## Pull Request Test Coverage Report for [Build 1673](https://coveralls.io/builds/28633553) * **0** of **15** **(0.0%)** changed or added relevant lines in **3** files are covered. * **94** unchanged lines in **18** files lost coverage. * Overall coverage increased (+**0.3%**) to **64.746%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/SetStatement.java](https://coveralls.io/builds/28633553/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FSetStatement.java#L22) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/FromTableSegment.java](https://coveralls.io/builds/28633553/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdal%2FFromTableSegment.java#L39) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28633553/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L130) | 0 | 13 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java](https://coveralls.io/builds/28633553/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FAuthenticationChangedListener.java#L36) | 1 | 75.0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java](https://coveralls.io/builds/28633553/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FPropertiesChangedListener.java#L34) | 1 | 75.0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28633553/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L113) | 1 | 97.5% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java](https://coveralls.io/builds/28633553/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fstate%2Flistener%2FDataSourceStateChangedListener.java#L36) | 1 | 85.71% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java](https://coveralls.io/builds/28633553/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fstate%2Flistener%2FInstanceStateChangedListener.java#L35) | 1 | 75.0% | | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/datasource/OrchestrationSpringEncryptDataSource.java](https://coveralls.io/builds/28633553/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-namespace%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fdatasource%2FOrchestrationSpringEncryptDataSource.java#L37) | 1 | 50.0% | |
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377099355
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.segment.dal;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.segment.SQLSegment;
+
+@RequiredArgsConstructor
+@Getter
+public class VariableExprSegment implements SQLSegment {
+
+private final int startIndex;
+
+private final int stopIndex;
+
+private final String variable;
+
+private final String expr;
+
Review comment:
Unnecessary blank lines
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377104688
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/segment/impl/set/ExpectedVariableExpr.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.set;
+
+import lombok.Getter;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.AbstractExpectedSQLSegment;
+
+import javax.xml.bind.annotation.XmlElement;
+
+/**
+ * Expected variable expr.
+ *
+ * @author lujingshang
+ */
+@Getter
+public final class ExpectedVariableExpr extends AbstractExpectedSQLSegment {
Review comment:
Please do not use abbreviation, please rename `ExpectedVariableExpr` to
`ExpectedVariableExpression`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377105096
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/segment/impl/set/ExpectedVariableExpr.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.set;
+
+import lombok.Getter;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.AbstractExpectedSQLSegment;
+
+import javax.xml.bind.annotation.XmlElement;
+
+/**
+ * Expected variable expr.
+ *
+ * @author lujingshang
+ */
+@Getter
+public final class ExpectedVariableExpr extends AbstractExpectedSQLSegment {
+
+@XmlElement(name = "variable")
+private String variable;
+
+@XmlElement(name = "expr")
+private String expr;
Review comment:
Please do not use abbreviation, please rename `expr` to `expression`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377099079
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.segment.dal;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.segment.SQLSegment;
+
+@RequiredArgsConstructor
+@Getter
+public class VariableExprSegment implements SQLSegment {
Review comment:
1. Missing java doc
2. Can the class be final?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377105269 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal; + +import lombok.Getter; +import lombok.Setter; +import org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.set.ExpectedVariableExpr; +import org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.SQLParserTestCase; + +import javax.xml.bind.annotation.XmlElement; +import java.util.LinkedList; +import java.util.List; + +/** + * set variable statement test case. Review comment: First letter of java doc should be upper case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377100027
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.segment.dal;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.segment.SQLSegment;
+
+@RequiredArgsConstructor
+@Getter
+public class VariableExprSegment implements SQLSegment {
Review comment:
We prefer do not use abbreviation.
Please rename `expr` to `expression`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377103089 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/SQLParserTestCases.java ## @@ -203,6 +205,9 @@ @XmlElement(name = "show-index") private final List showIndexTestCases = new LinkedList<>(); + +@XmlElement(name = "set-variable") +private final List setVariableStatementTestCases = new LinkedList<>(); Review comment: The variable name `setVariableStatementTestCases` should keep consist with others, it is better to rename as `setVariableTestCases` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377100102
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.segment.dal;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.segment.SQLSegment;
+
+@RequiredArgsConstructor
+@Getter
+public class VariableExprSegment implements SQLSegment {
+
+private final int startIndex;
+
+private final int stopIndex;
+
+private final String variable;
+
+private final String expr;
Review comment:
We prefer do not use abbreviation.
Please rename `expr` to `expression`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377106212
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/statement/dal/ShowColumnsStatementTestCase.java
##
@@ -17,12 +17,20 @@
package
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.table.ExpectedTable;
import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.SQLParserTestCase;
+import javax.xml.bind.annotation.XmlElement;
+
/**
* Show columns statement test case.
*
* @author zhangliang
*/
public final class ShowColumnsStatementTestCase extends SQLParserTestCase {
+
+@XmlElement
+private ExpectedTable table;
+
+
Review comment:
Please remove unnecessary blank lines.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377104832 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/segment/impl/set/ExpectedVariableExpr.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.set; + +import lombok.Getter; +import org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.AbstractExpectedSQLSegment; + +import javax.xml.bind.annotation.XmlElement; + +/** + * Expected variable expr. Review comment: Please do not use abbreviation, please rename `expr` to `expression` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377102058
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/statement/dal/impl/SetVariableStatementAssert.java
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.integrate.asserts.statement.dal.impl;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+import
org.apache.shardingsphere.sql.parser.integrate.asserts.SQLCaseAssertContext;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal.SetVariableStatementTestCase;
+import
org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.SetStatement;
+
+/**
+ * set variable statement assert.
+ *
+ * @author lujingshang
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SetVariableStatementAssert {
+
+/**
+ * Assert describe statement is correct with expected parser result.
+ *
+ * @param assertContext assert context
+ * @param actual actual describe statement
+ * @param expected expected describe statement test case
Review comment:
Incorrect java doc for `describe statement`, should be `set statement`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377106499 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dal/show.xml ## @@ -50,6 +50,15 @@ + Review comment: Please only keep single blank line. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377101955
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/statement/dal/impl/SetVariableStatementAssert.java
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.integrate.asserts.statement.dal.impl;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+import
org.apache.shardingsphere.sql.parser.integrate.asserts.SQLCaseAssertContext;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal.SetVariableStatementTestCase;
+import
org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.SetStatement;
+
+/**
+ * set variable statement assert.
+ *
+ * @author lujingshang
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SetVariableStatementAssert {
+
+/**
+ * Assert describe statement is correct with expected parser result.
+ *
+ * @param assertContext assert context
+ * @param actual actual describe statement
Review comment:
Incorrect java doc for `describe statement`, should be `set statement`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377098631
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/SetStatement.java
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql;
+
+import org.apache.shardingsphere.sql.parser.sql.statement.dal.DALStatement;
+
+public final class SetStatement extends DALStatement {
Review comment:
Missing java doc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377105583
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal;
+
+import lombok.Getter;
+import lombok.Setter;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.set.ExpectedVariableExpr;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.SQLParserTestCase;
+
+import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * set variable statement test case.
+ *
+ * @author lujingshang
+ */
+@Getter
+@Setter
+public final class SetVariableStatementTestCase extends SQLParserTestCase {
+
+@XmlElement(name = "variable-expr")
Review comment:
Please do not use abbreviation, please rename `variable-expr` to
`variable-expression`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377103958 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/SQLParserTestCases.java ## @@ -258,6 +263,7 @@ putAll(showCreateTableTestCases, result); putAll(showTableStatusTestCases, result); putAll(showIndexTestCases, result); +putAll(setVariableStatementTestCases, result); Review comment: Please do not interrupt `showXXXTestCases`, please move `setVariableStatementTestCases` behind `showTestCases` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377101138
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/statement/dal/DALStatementAssert.java
##
@@ -83,6 +86,8 @@ public static void assertIs(final SQLCaseAssertContext
assertContext, final DALS
ShowTableStatusStatementAssert.assertIs(assertContext,
(ShowTableStatusStatement) actual, (ShowTableStatusStatementTestCase) expected);
} else if (actual instanceof ShowIndexStatement) {
ShowIndexStatementAssert.assertIs(assertContext,
(ShowIndexStatement) actual, (ShowIndexStatementTestCase) expected);
+} else if (actual instanceof SetStatement) {
Review comment:
`SetStatement` is a new type with `ShowXXXStatement`, it should not between
`ShowIndexStatement` and `ShowStatement`, please move `SetStatement` behind
`ShowStatement`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for
setVariable of mysql
URL:
https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377105798
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal;
+
+import lombok.Getter;
+import lombok.Setter;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.segment.impl.set.ExpectedVariableExpr;
+import
org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.SQLParserTestCase;
+
+import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * set variable statement test case.
+ *
+ * @author lujingshang
+ */
+@Getter
+@Setter
+public final class SetVariableStatementTestCase extends SQLParserTestCase {
+
+@XmlElement(name = "variable-expr")
+private final List variableExprs = new
LinkedList<>();
+
+
Review comment:
Please remove unnecessary blank lines.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377104042 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/SQLParserTestCases.java ## @@ -203,6 +205,9 @@ @XmlElement(name = "show-index") private final List showIndexTestCases = new LinkedList<>(); + +@XmlElement(name = "set-variable") +private final List setVariableStatementTestCases = new LinkedList<>(); Review comment: Please do not interrupt `showXXXTestCases`, please move `setVariableStatementTestCases` behind `showTestCases` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql
terrymanu commented on a change in pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#discussion_r377101348 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/statement/dal/impl/SetVariableStatementAssert.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.integrate.asserts.statement.dal.impl; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; +import org.apache.shardingsphere.sql.parser.integrate.asserts.SQLCaseAssertContext; +import org.apache.shardingsphere.sql.parser.integrate.jaxb.domain.statement.dal.SetVariableStatementTestCase; +import org.apache.shardingsphere.sql.parser.sql.statement.dal.dialect.mysql.SetStatement; + +/** + * set variable statement assert. Review comment: First letter of java doc should be upper case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4228: add visitor for setVariable of mysql
tristaZero commented on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584154881 @terrymanu Hi, i guess you are reviewing this PR, so do i need to give it a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #4228: add visitor for setVariable of mysql
tristaZero edited a comment on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584154881 @terrymanu Hi, i guess you are reviewing this PR, so is it necessary for me to give it a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4223: add revoke DCL SQL visitor parse and test unit
tristaZero commented on issue #4223: add revoke DCL SQL visitor parse and test unit URL: https://github.com/apache/incubator-shardingsphere/pull/4223#issuecomment-584149716 Hi @beijing-penguin It is a great PR, which i can see your understanding of Visitor mechanism. Congrats for your grow-up! Other than that, the rule name of `onObjectClause_` should be renamed a `onObjectClause` in its g4 file. You could fix it in another PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4223: add revoke DCL SQL visitor parse and test unit
tristaZero merged pull request #4223: add revoke DCL SQL visitor parse and test unit URL: https://github.com/apache/incubator-shardingsphere/pull/4223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3185: The configuration of RegistryCenter, ConfigCenter, LeafCenter should be split apart or not?
terrymanu closed issue #3185: The configuration of RegistryCenter, ConfigCenter,LeafCenter should be split apart or not? URL: https://github.com/apache/incubator-shardingsphere/issues/3185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4227: Orchestration 5.x
terrymanu merged pull request #4227: Orchestration 5.x URL: https://github.com/apache/incubator-shardingsphere/pull/4227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4228: add visitor for setVariable of mysql
coveralls commented on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584103954 ## Pull Request Test Coverage Report for [Build 9429](https://coveralls.io/builds/28630060) * **0** of **15** **(0.0%)** changed or added relevant lines in **3** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.04%**) to **64.429%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/SetStatement.java](https://coveralls.io/builds/28630060/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FSetStatement.java#L22) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/FromTableSegment.java](https://coveralls.io/builds/28630060/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdal%2FFromTableSegment.java#L39) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28630060/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L130) | 0 | 13 | 0.0% | Totals | [](https://coveralls.io/builds/28630060) | | :-- | --: | | Change from base [Build 9428](https://coveralls.io/builds/28629529): | -0.04% | | Covered Lines: | 10960 | | Relevant Lines: | 17011 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4228: add visitor for setVariable of mysql
codecov-io commented on issue #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228#issuecomment-584101450 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@ec7dde4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4228 +/- ## = Coverage ? 60.53% Complexity? 352 = Files ? 1016 Lines ?17011 Branches ? 3002 = Hits ?10298 Misses? 6061 Partials ? 652 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=footer). Last update [ec7dde4...1690f20](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4228?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4166: refactor orchestration config for apollo.
kimmking commented on a change in pull request #4166: refactor orchestration config for apollo. URL: https://github.com/apache/incubator-shardingsphere/pull/4166#discussion_r377027007 ## File path: sharding-proxy/sharding-proxy-bootstrap/src/main/resources/conf/server.yaml ## @@ -29,11 +29,6 @@ #namespace: orchestration #props: # overwrite: false -# retry-interval-milliseconds: 10 Review comment: why remove? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu opened a new pull request #4228: add visitor for setVariable of mysql
jingshanglu opened a new pull request #4228: add visitor for setVariable of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/4228 Fixes #3914 . Changes proposed in this pull request: - add visitor for setVariable - add visitor for showOther - add test for showColumus, setVariable,showCreateTable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] RainElohim commented on issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy
RainElohim commented on issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy URL: https://github.com/apache/incubator-shardingsphere/issues/4146#issuecomment-584086144 proxy4.0.0 `[2020-02-10 19:28:30,434] [ERROR] [DruidDataSource:2755] ===> create connection SQLException, url: jdbc:mysql://10.16.0.21:3307/sharding_db?serverTimezone=UTC=false=true, errorCode 0, state 08001 java.sql.SQLNonTransientConnectionException: CLIENT_PLUGIN_AUTH is required at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:110) ~[mysql-connector-java-8.0.19.jar:8.0.19] at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97) ~[mysql-connector-java-8.0.19.jar:8.0.19] at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89) ~[mysql-connector-java-8.0.19.jar:8.0.19] at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63) ~[mysql-connector-java-8.0.19.jar:8.0.19]` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #437: Update asf-site
terrymanu merged pull request #437: Update asf-site URL: https://github.com/apache/incubator-shardingsphere-doc/pull/437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4166: refactor orchestration config for apollo.
coveralls edited a comment on issue #4166: refactor orchestration config for apollo. URL: https://github.com/apache/incubator-shardingsphere/pull/4166#issuecomment-584065767 ## Pull Request Test Coverage Report for [Build 9427](https://coveralls.io/builds/28629085) * **45** of **97** **(46.39%)** changed or added relevant lines in **8** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.08%**) to **65.027%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/util/ConfigKeyUtils.java](https://coveralls.io/builds/28629085/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Futil%2FConfigKeyUtils.java#L25) | 3 | 4 | 75.0% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java](https://coveralls.io/builds/28629085/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fnode%2FConfigurationNode.java#L143) | 5 | 6 | 83.33% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28629085/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L60) | 13 | 18 | 72.22% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28629085/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L81) | 1 | 10 | 10.0% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28629085/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L50) | 0 | 36 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28629085/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 2 | 65.63% | | Totals | [](https://coveralls.io/builds/28629085) | | :-- | --: | | Change from base [Build 9423](https://coveralls.io/builds/28627782): | -0.08% | | Covered Lines: | 11013 | | Relevant Lines: | 16936 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4226: copy shardingsphere-doc to shardingsphere/docs
terrymanu merged pull request #4226: copy shardingsphere-doc to shardingsphere/docs URL: https://github.com/apache/incubator-shardingsphere/pull/4226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4166: refactor orchestration config for apollo.
codecov-io commented on issue #4166: refactor orchestration config for apollo. URL: https://github.com/apache/incubator-shardingsphere/pull/4166#issuecomment-584080717 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`orchestration-5.x@e03143c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `60.7%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166?src=pr=tree) ```diff @@ Coverage Diff @@ ## orchestration-5.x #4166 +/- ## === Coverage ? 61.1% Complexity ? 352 === Files?1013 Lines? 16936 Branches ?2981 === Hits ? 10348 Misses ?5933 Partials ? 655 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...core/strategy/route/none/NoneShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9ub25lL05vbmVTaGFyZGluZ1N0cmF0ZWd5LmphdmE=) | `100% <ø> (ø)` | `0 <0> (?)` | | | [.../masterslave/LoadBalanceStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9tYXN0ZXJzbGF2ZS9Mb2FkQmFsYW5jZVN0cmF0ZWd5Q29uZmlndXJhdGlvbi5qYXZh) | `50% <ø> (ø)` | `1 <0> (?)` | | | [...route/time/exception/TimeServiceInitException.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9kYXRhYmFzZS10aW1lLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JvdXRlL3RpbWUvZXhjZXB0aW9uL1RpbWVTZXJ2aWNlSW5pdEV4Y2VwdGlvbi5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...config/common/YamlAuthenticationConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbEF1dGhlbnRpY2F0aW9uQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [...ig/sharding/YamlShardingStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | | | [...core/strategy/route/hint/HintShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9oaW50L0hpbnRTaGFyZGluZ1N0cmF0ZWd5LmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...config/sharding/YamlKeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [...config/sharding/YamlShardingRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sU2hhcmRpbmdSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [.../yaml/config/common/YamlRootRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4166/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbFJvb3RSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | |
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4227: Orchestration 5.x
coveralls commented on issue #4227: Orchestration 5.x URL: https://github.com/apache/incubator-shardingsphere/pull/4227#issuecomment-584074231 ## Pull Request Test Coverage Report for [Build 9425](https://coveralls.io/builds/28628665) * **313** of **430** **(72.79%)** changed or added relevant lines in **36** files are covered. * **5** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.3%**) to **64.824%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/28628665/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationMasterSlaveDataSourceFactory.java#L108) | 1 | 2 | 50.0% | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/28628665/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L108) | 1 | 2 | 50.0% | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/internal/util/YamlInstanceConfigurationSwapperUtil.java](https://coveralls.io/builds/28628665/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Finternal%2Futil%2FYamlInstanceConfigurationSwapperUtil.java#L31) | 6 | 7 | 85.71% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/handler/CuratorZookeeperExceptionHandler.java](https://coveralls.io/builds/28628665/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fhandler%2FCuratorZookeeperExceptionHandler.java#L56) | 0 | 1 | 0.0% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/keygen/LeafSegmentKeyGenerator.java](https://coveralls.io/builds/28628665/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fkeygen%2FLeafSegmentKeyGenerator.java#L108) | 16 | 17 | 94.12% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java](https://coveralls.io/builds/28628665/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FAuthenticationChangedListener.java#L36) | 1 | 2 | 50.0% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java](https://coveralls.io/builds/28628665/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FPropertiesChangedListener.java#L34) | 1 | 2 | 50.0% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/listener/PostShardingRegistryCenterEventListener.java](https://coveralls.io/builds/28628665/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Flistener%2FPostShardingRegistryCenterEventListener.java#L40) | 0 | 1 | 0.0% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java](https://coveralls.io/builds/28628665/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fstate%2Flistener%2FDataSourceStateChangedListener.java#L36) | 0 | 1 | 0.0% |
[GitHub] [incubator-shardingsphere] avalon566 merged pull request #4225: For sharding-scaling check style
avalon566 merged pull request #4225: For sharding-scaling check style URL: https://github.com/apache/incubator-shardingsphere/pull/4225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] RainElohim commented on issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy
RainElohim commented on issue #4146: springboot can not connect mysql 8.0.19 by sharding proxy URL: https://github.com/apache/incubator-shardingsphere/issues/4146#issuecomment-584065569 > You can use mysql-driver with 5.1.47 and retry. it's can't ,too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4226: copy shardingsphere-doc to shardingsphere/docs
coveralls edited a comment on issue #4226: copy shardingsphere-doc to shardingsphere/docs URL: https://github.com/apache/incubator-shardingsphere/pull/4226#issuecomment-584065157 ## Pull Request Test Coverage Report for [Build 1668](https://coveralls.io/builds/28628268) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **64.476%** --- | Totals | [](https://coveralls.io/builds/28628268) | | :-- | --: | | Change from base [Build 810](https://coveralls.io/builds/28626859): | 0.0% | | Covered Lines: | 10961 | | Relevant Lines: | 17000 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4166: refactor orchestration config for apollo.
coveralls commented on issue #4166: refactor orchestration config for apollo. URL: https://github.com/apache/incubator-shardingsphere/pull/4166#issuecomment-584065767 ## Pull Request Test Coverage Report for [Build 1671](https://coveralls.io/builds/28628264) * **45** of **97** **(46.39%)** changed or added relevant lines in **8** files are covered. * **4** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.06%**) to **65.039%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/util/ConfigKeyUtils.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Futil%2FConfigKeyUtils.java#L25) | 3 | 4 | 75.0% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fnode%2FConfigurationNode.java#L143) | 5 | 6 | 83.33% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L60) | 13 | 18 | 72.22% | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L81) | 1 | 10 | 10.0% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L50) | 0 | 36 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 2 | 68.75% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28628264/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/28628264) | | :-- | --: | | Change from base [Build 9423](https://coveralls.io/builds/28627782): | -0.06% | | Covered Lines: | 11015 | | Relevant Lines: | 16936 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4226: copy shardingsphere-doc to shardingsphere/docs
coveralls commented on issue #4226: copy shardingsphere-doc to shardingsphere/docs URL: https://github.com/apache/incubator-shardingsphere/pull/4226#issuecomment-584065157 ## Pull Request Test Coverage Report for [Build 9424](https://coveralls.io/builds/28628223) * **0** of **0** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.006%**) to **64.471%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28628223/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/28628223) | | :-- | --: | | Change from base [Build 810](https://coveralls.io/builds/28626859): | -0.006% | | Covered Lines: | 10960 | | Relevant Lines: | 17000 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beckhampu closed issue #4199: Code Optimization - Add filter classes Constructor to restrict the illegal class to be loaded when unmarshalling yaml as Map
beckhampu closed issue #4199: Code Optimization - Add filter classes Constructor to restrict the illegal class to be loaded when unmarshalling yaml as Map URL: https://github.com/apache/incubator-shardingsphere/issues/4199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yl1935 edited a comment on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed
yl1935 edited a comment on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed URL: https://github.com/apache/incubator-shardingsphere/issues/2712#issuecomment-584040162 我在4.0.0版本中使用了mybatis 在非注册中心配置下没有问题，如果引入了sharding-jdbc-orchestration-spring-boot-starter就会报这个错误，比较了sharding-jdbc-orchestration-spring-boot-starter包中的OrchestrationSpringBootConfiguration.java和sharding-jdbc-spring-boot-starter包中的SpringBootConfiguration.java文件，发现少了@AutoConfigureBefore(DataSourceAutoConfiguration.class)这个注解，感觉是这里影响的。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #4227: Orchestration 5.x
sunbufu opened a new pull request #4227: Orchestration 5.x URL: https://github.com/apache/incubator-shardingsphere/pull/4227 Fixes #3185 . Changes proposed in this pull request: - merge branch orchestration-5.x into branch master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #4226: copy shardingsphere-doc to shardingsphere/docs
tuohai666 opened a new pull request #4226: copy shardingsphere-doc to shardingsphere/docs URL: https://github.com/apache/incubator-shardingsphere/pull/4226 including commit history. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4205: Add class filter Constructor to restrict the illegal class from YAML
kimmking commented on a change in pull request #4205: Add class filter
Constructor to restrict the illegal class from YAML
URL:
https://github.com/apache/incubator-shardingsphere/pull/4205#discussion_r376964251
##
File path:
sharding-core/sharding-core-common/src/test/java/org/apache/shardingsphere/core/yaml/engine/YamlEngineTest.java
##
@@ -38,11 +44,25 @@ public void assertUnmarshal() {
@SuppressWarnings("unchecked")
@Test
public void assertUnmarshalMap() {
-Map actual = (Map)
YamlEngine.unmarshal("password: pwd\nauthorizedSchemas: db1");
+Map actual = (Map)
YamlEngine.unmarshal("password: pwd\nauthorizedSchemas: db1",
Collections.>emptyList());
assertThat(actual.get("password").toString(), is("pwd"));
assertThat(actual.get("authorizedSchemas").toString(), is("db1"));
}
+@Test(expected = ConstructorException.class)
+public void assertUnmarshalMapWithIllegalClasses() {
+YamlEngine.unmarshal("url: !!java.net.URLClassLoader [[!!java.net.URL
[\"http://localhost\"]]];, Collections.>emptyList());
Review comment:
"url: !!java.net.URLClassLoader [[!!java.net.URL [\"http://localhost\"]]];
maybe not enough
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4205: Add class filter Constructor to restrict the illegal class from YAML
kimmking commented on a change in pull request #4205: Add class filter
Constructor to restrict the illegal class from YAML
URL:
https://github.com/apache/incubator-shardingsphere/pull/4205#discussion_r376964187
##
File path:
sharding-core/sharding-core-common/src/test/java/org/apache/shardingsphere/core/yaml/engine/YamlEngineTest.java
##
@@ -38,11 +44,25 @@ public void assertUnmarshal() {
@SuppressWarnings("unchecked")
@Test
public void assertUnmarshalMap() {
-Map actual = (Map)
YamlEngine.unmarshal("password: pwd\nauthorizedSchemas: db1");
+Map actual = (Map)
YamlEngine.unmarshal("password: pwd\nauthorizedSchemas: db1",
Collections.>emptyList());
assertThat(actual.get("password").toString(), is("pwd"));
assertThat(actual.get("authorizedSchemas").toString(), is("db1"));
}
+@Test(expected = ConstructorException.class)
+public void assertUnmarshalMapWithIllegalClasses() {
+YamlEngine.unmarshal("url: !!java.net.URLClassLoader [[!!java.net.URL
[\"http://localhost\"]]];, Collections.>emptyList());
Review comment:
"url: !!java.net.URLClassLoader [[!!java.net.URL [\"http://localhost\"]]];
maybe not enough
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu merged pull request #4221: Orchestration 5.x
sunbufu merged pull request #4221: Orchestration 5.x URL: https://github.com/apache/incubator-shardingsphere/pull/4221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yl1935 commented on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed
yl1935 commented on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed URL: https://github.com/apache/incubator-shardingsphere/issues/2712#issuecomment-584040162 我在4.0.0版本中非注册中心配置没有问题，如果引入了sharding-jdbc-orchestration-spring-boot-starter就会报这个错误，比较了sharding-jdbc-orchestration-spring-boot-starter包中的OrchestrationSpringBootConfiguration.java和sharding-jdbc-spring-boot-starter包中的SpringBootConfiguration.java文件，发现少了@AutoConfigureBefore(DataSourceAutoConfiguration.class)这个注解，感觉是这里影响的。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc edited a comment on issue #4192: insert float type vaule report "10002 - 2Unknown exception"
lklkxcxc edited a comment on issue #4192: insert float type vaule report "10002 - 2Unknown exception" URL: https://github.com/apache/incubator-shardingsphere/issues/4192#issuecomment-584031689 > @lklkxcxc Could you please use the latest version of Sharding-Proxy to try this?And the SQL you provided is wrong. > `insert into test VALUES (907,907,'Biomaterials ,'BIOMATER','2047',5.251)` > should be > `insert into test VALUES (907,907,'Biomaterials','BIOMATER','2047',5.251)` @SteNicholas - Use the latest version of Sharding-Proxy RC3 that mysqldump import is sucess. - I can not find the above two sql different. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc closed issue #4192: insert float type vaule report "10002 - 2Unknown exception"
lklkxcxc closed issue #4192: insert float type vaule report "10002 - 2Unknown exception" URL: https://github.com/apache/incubator-shardingsphere/issues/4192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
