[GitHub] [shardingsphere] coveralls commented on pull request #7340: Fix create table if not exists pre validation error

2020-09-08 Thread GitBox
coveralls commented on pull request #7340: URL: https://github.com/apache/shardingsphere/pull/7340#issuecomment-689315791 ## Pull Request Test Coverage Report for [Build 14582](https://coveralls.io/builds/33322300) * **6** of **6** **(100.0%)** changed or added relevant lines in

[GitHub] [shardingsphere] tuohai666 merged pull request #7346: Move BackendExecutorContext to context package

2020-09-08 Thread GitBox
tuohai666 merged pull request #7346: URL: https://github.com/apache/shardingsphere/pull/7346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[shardingsphere] branch master updated (4fb9c89 -> fe24472)

2020-09-08 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from 4fb9c89 Rename proxy.backend.context package name (#7345) add fe24472 Move

[shardingsphere] branch master updated (f2b383b -> 4fb9c89)

2020-09-08 Thread kimmking
This is an automated email from the ASF dual-hosted git repository. kimmking pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from f2b383b Refactor config center node (#7344) add 4fb9c89 Rename proxy.backend.context package name

[shardingsphere] branch master updated (bf1c2a1 -> f2b383b)

2020-09-08 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from bf1c2a1 Merge pull request #7320 from kimmking/dev add f2b383b Refactor config center node

[GitHub] [shardingsphere] kimmking merged pull request #7345: Rename proxy.backend.context package name

2020-09-08 Thread GitBox
kimmking merged pull request #7345: URL: https://github.com/apache/shardingsphere/pull/7345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu merged pull request #7344: Refactor config center node

2020-09-08 Thread GitBox
terrymanu merged pull request #7344: URL: https://github.com/apache/shardingsphere/pull/7344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu opened a new pull request #7345: Rename proxy.backend.context package name

2020-09-08 Thread GitBox
terrymanu opened a new pull request #7345: URL: https://github.com/apache/shardingsphere/pull/7345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] menghaoranss opened a new pull request #7344: Refactor config center node

2020-09-08 Thread GitBox
menghaoranss opened a new pull request #7344: URL: https://github.com/apache/shardingsphere/pull/7344 For #7325 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shardingsphere] coveralls edited a comment on pull request #7320: refator ShardingSphereMetaData

2020-09-08 Thread GitBox
coveralls edited a comment on pull request #7320: URL: https://github.com/apache/shardingsphere/pull/7320#issuecomment-688797924 ## Pull Request Test Coverage Report for [Build 14578](https://coveralls.io/builds/33321459) * **35** of **45** **(77.78%)** changed or added relevant

[shardingsphere] branch master updated (e51f4e1 -> bf1c2a1)

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from e51f4e1 Move BackendDataSource to communication package (#7341) new 3425efc refator

[shardingsphere] branch master updated (e51f4e1 -> bf1c2a1)

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from e51f4e1 Move BackendDataSource to communication package (#7341) new 3425efc refator

[GitHub] [shardingsphere] kimmking opened a new pull request #7343: extract an abstract class for StatementExecutor

2020-09-08 Thread GitBox
kimmking opened a new pull request #7343: URL: https://github.com/apache/shardingsphere/pull/7343 Fixes #7339 . Changes proposed in this pull request: - extract an abstract class for StatementExecutor This

[GitHub] [shardingsphere] menghaoranss merged pull request #7320: refator ShardingSphereMetaData

2020-09-08 Thread GitBox
menghaoranss merged pull request #7320: URL: https://github.com/apache/shardingsphere/pull/7320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] xbkaishui opened a new issue #7342: Proxy show tables command can't show unConfigured table

2020-09-08 Thread GitBox
xbkaishui opened a new issue #7342: URL: https://github.com/apache/shardingsphere/issues/7342 ## Bug Report When use show tables command in ShardingSphere-Proxy (using sharding database feature) It only show configured table, skiped the unconfigured table Please answer these

[shardingsphere] branch master updated: Move BackendDataSource to communication package (#7341)

2020-09-08 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new e51f4e1 Move BackendDataSource

[GitHub] [shardingsphere] tuohai666 merged pull request #7341: Move BackendDataSource to communication package

2020-09-08 Thread GitBox
tuohai666 merged pull request #7341: URL: https://github.com/apache/shardingsphere/pull/7341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] victorzhangchn commented on pull request #7338: Add test cases for GovernanceBootstrapInitializerTest (#7285)

2020-09-08 Thread GitBox
victorzhangchn commented on pull request #7338: URL: https://github.com/apache/shardingsphere/pull/7338#issuecomment-689285904 > Please fix CI I encounter a problem with this. It works fine on my local env, but it seems that there is a problem with parsing yaml during CI. Do you

[GitHub] [shardingsphere] terrymanu opened a new pull request #7341: Move BackendDataSource to communication package

2020-09-08 Thread GitBox
terrymanu opened a new pull request #7341: URL: https://github.com/apache/shardingsphere/pull/7341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] xbkaishui opened a new pull request #7340: Fix create table if not exists pre validation error

2020-09-08 Thread GitBox
xbkaishui opened a new pull request #7340: URL: https://github.com/apache/shardingsphere/pull/7340 Fixes #7323 Changes proposed in this pull request: - Fix create table if not exists pre validation error. ignore validation when use this

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #7325: [DISCUSS]New design of data structures in config center

2020-09-08 Thread GitBox
menghaoranss edited a comment on issue #7325: URL: https://github.com/apache/shardingsphere/issues/7325#issuecomment-689275286 @dongzl , there is the old data structure: ``` ├─orchestration-name │ ├──config │ │├──authentication │ │├──props │ │├──schema

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #7325: [DISCUSS]New design of data structures in config center

2020-09-08 Thread GitBox
menghaoranss edited a comment on issue #7325: URL: https://github.com/apache/shardingsphere/issues/7325#issuecomment-688720547 The new design of data structure in config center as follow: ``` ├─orchestration-name │ ├──authentication │ ├──props │ ├──schemas

[GitHub] [shardingsphere] dongfangding edited a comment on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
dongfangding edited a comment on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-689273122 Do you mean like this ? ```yaml master-slave-rules: myMaster: load-balance-algorithm-type: round_robin

[GitHub] [shardingsphere] kimmking opened a new issue #7339: extract an abstract class for StatementExecutor

2020-09-08 Thread GitBox
kimmking opened a new issue #7339: URL: https://github.com/apache/shardingsphere/issues/7339 extract an abstract class for StatementExecutor This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] dongfangding edited a comment on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
dongfangding edited a comment on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-689273122 Do you mean like this ? ```yaml master-slave-rules: myMaster: load-balance-algorithm-type: round_robin

[GitHub] [shardingsphere] dongfangding edited a comment on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
dongfangding edited a comment on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-689273122 Do you mean like this ? ```yaml master-slave-rules: myMaster: load-balance-algorithm-type: round_robin

[GitHub] [shardingsphere] menghaoranss commented on issue #7325: [DISCUSS]New design of data structures in config center

2020-09-08 Thread GitBox
menghaoranss commented on issue #7325: URL: https://github.com/apache/shardingsphere/issues/7325#issuecomment-689275286 @dongzl , there is the old data structure: ``` ├─orchestration-name │ ├──config │ │├──authentication │ │├──props │ │├──schema

[GitHub] [shardingsphere] vinceLin054 closed issue #7118: 4.1.1mapper.xml use ognl cause ClassCastException

2020-09-08 Thread GitBox
vinceLin054 closed issue #7118: URL: https://github.com/apache/shardingsphere/issues/7118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] sandynz commented on issue #7321: Add more test cases for ShardingSphere-Proxy

2020-09-08 Thread GitBox
sandynz commented on issue #7321: URL: https://github.com/apache/shardingsphere/issues/7321#issuecomment-689273533 Hi, I'd like to try `shardingsphere-proxy-frontend-postgresql` module: - PostgreSQLProtocolFrontendEngine - PostgreSQLCommandExecutorFactory -

[GitHub] [shardingsphere] dongfangding commented on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
dongfangding commented on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-689273122 Do you mean like this ? ```yaml master-slave-rules: myMaster: load-balance-algorithm-type: round_robin

[shardingsphere] branch master updated (b77a611 -> aea730e)

2020-09-08 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from b77a611 Remove ProxyDataSourceContext (#7337) new dbd4ebc Refactor DALStatement to MySQL, PostgreSQL

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7292: Refactor DALStatement to MySQL, PostgreSQL DALStatement

2020-09-08 Thread GitBox
tristaZero commented on a change in pull request #7292: URL: https://github.com/apache/shardingsphere/pull/7292#discussion_r485311203 ## File path:

[GitHub] [shardingsphere] tristaZero merged pull request #7292: Refactor DALStatement to MySQL, PostgreSQL DALStatement

2020-09-08 Thread GitBox
tristaZero merged pull request #7292: URL: https://github.com/apache/shardingsphere/pull/7292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] tristaZero commented on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
tristaZero commented on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-689269800 > I still have to reiterate my scenario, that is, multiple tables, some tables I want to use master-slave-rule, and other tables, I just want it to implement its own

[GitHub] [shardingsphere] tristaZero commented on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
tristaZero commented on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-689267484 > @tristaZero I am very sorry for the late reply and I think @xbkaishui can do a great job on this issue.  Yep, I believe that. Both of you are the significant

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7292: Refactor DALStatement to MySQL, PostgreSQL DALStatement

2020-09-08 Thread GitBox
tristaZero commented on a change in pull request #7292: URL: https://github.com/apache/shardingsphere/pull/7292#discussion_r485303864 ## File path:

[GitHub] [shardingsphere] dongzl commented on issue #7325: [DISCUSS]New design of data structures in config center

2020-09-08 Thread GitBox
dongzl commented on issue #7325: URL: https://github.com/apache/shardingsphere/issues/7325#issuecomment-689233508 Hi @kimmking , @menghaoranss What’s the difference between the old and new data structure. I suggest if we want to modify the data structure, we should have

[GitHub] [shardingsphere] flycoolman commented on issue #7307: Rename MasterSlave module to ReadWriteSplit

2020-09-08 Thread GitBox
flycoolman commented on issue #7307: URL: https://github.com/apache/shardingsphere/issues/7307#issuecomment-689086951 @tristaZero Thanks for reminding me the difficulty of the task. I understand it will have a massive effect. So I expect stricter review before merge.

[GitHub] [shardingsphere] victorzhangchn opened a new pull request #7338: Add test cases for GovernanceBootstrapInitializerTest (#7285)

2020-09-08 Thread GitBox
victorzhangchn opened a new pull request #7338: URL: https://github.com/apache/shardingsphere/pull/7338 Fixes #7285. Changes proposed in this pull request: - Finish assertProxyConfiguration in GovernanceBootstrapInitializerTest - Add test case for

[shardingsphere] branch master updated: Remove ProxyDataSourceContext (#7337)

2020-09-08 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new b77a611 Remove

[GitHub] [shardingsphere] tuohai666 merged pull request #7337: Remove ProxyDataSourceContext

2020-09-08 Thread GitBox
tuohai666 merged pull request #7337: URL: https://github.com/apache/shardingsphere/pull/7337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu opened a new pull request #7337: Remove ProxyDataSourceContext

2020-09-08 Thread GitBox
terrymanu opened a new pull request #7337: URL: https://github.com/apache/shardingsphere/pull/7337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[shardingsphere] branch master updated: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different (#7330)

2020-09-08 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 2315dda ColumnMetaDataLoader load

[GitHub] [shardingsphere] terrymanu merged pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
terrymanu merged pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu closed issue #7284: ColumnMetaDataLoader load error and proxy cannot start success

2020-09-08 Thread GitBox
terrymanu closed issue #7284: URL: https://github.com/apache/shardingsphere/issues/7284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] yu199195 merged pull request #7336: Fix checkstyle

2020-09-08 Thread GitBox
yu199195 merged pull request #7336: URL: https://github.com/apache/shardingsphere/pull/7336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[shardingsphere] branch master updated: Fix checkstyle (#7336)

2020-09-08 Thread xiaoyu
This is an automated email from the ASF dual-hosted git repository. xiaoyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 9697bc2 Fix checkstyle (#7336) 9697bc2

[GitHub] [shardingsphere] terrymanu opened a new pull request #7336: Fix checkstyle

2020-09-08 Thread GitBox
terrymanu opened a new pull request #7336: URL: https://github.com/apache/shardingsphere/pull/7336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
yu199195 commented on a change in pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330#discussion_r485047257 ## File path:

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
yu199195 commented on a change in pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330#discussion_r485040176 ## File path:

[GitHub] [shardingsphere] terrymanu commented on issue #7331: Add more test cases for ProxySchemaContexts

2020-09-08 Thread GitBox
terrymanu commented on issue #7331: URL: https://github.com/apache/shardingsphere/issues/7331#issuecomment-688984719 I renamed `ProxySchemaContexts` to `ProxyContext` via #7335, so I just modify the issue title and content as well.

[GitHub] [shardingsphere] yu199195 merged pull request #7335: Rename ProxyContext

2020-09-08 Thread GitBox
yu199195 merged pull request #7335: URL: https://github.com/apache/shardingsphere/pull/7335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
yu199195 commented on a change in pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330#discussion_r485040176 ## File path:

[GitHub] [shardingsphere] terrymanu opened a new pull request #7335: Rename ProxyContext

2020-09-08 Thread GitBox
terrymanu opened a new pull request #7335: URL: https://github.com/apache/shardingsphere/pull/7335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
terrymanu commented on a change in pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330#discussion_r485038090 ## File path:

[GitHub] [shardingsphere] coveralls edited a comment on pull request #7292: Refactor DALStatement to MySQL, PostgreSQL DALStatement

2020-09-08 Thread GitBox
coveralls edited a comment on pull request #7292: URL: https://github.com/apache/shardingsphere/pull/7292#issuecomment-688277641 ## Pull Request Test Coverage Report for [Build 14564](https://coveralls.io/builds/33305879) * **2** of **11** **(18.18%)** changed or added relevant

[GitHub] [shardingsphere] coveralls commented on pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
coveralls commented on pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330#issuecomment-688929693 ## Pull Request Test Coverage Report for [Build 14561](https://coveralls.io/builds/33305056) * **14** of **14** **(100.0%)** changed or added relevant lines

[shardingsphere] branch master updated: #6872, remove connection test `SELECT 1` to improve performance

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 7aa2702 #6872, remove connection

[shardingsphere] branch master updated: #6872, use delete instead of truncate to improve performance

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 1b3215d #6872, use delete instead

[shardingsphere] branch master updated: #6872, use delete instead of truncate to improve performance

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 1b3215d #6872, use delete instead

[GitHub] [shardingsphere] menghaoranss merged pull request #7334: #6872, remove connection test `SELECT 1` to improve performance

2020-09-08 Thread GitBox
menghaoranss merged pull request #7334: URL: https://github.com/apache/shardingsphere/pull/7334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] menghaoranss merged pull request #7333: #6872, use delete instead of truncate to improve performance

2020-09-08 Thread GitBox
menghaoranss merged pull request #7333: URL: https://github.com/apache/shardingsphere/pull/7333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] coveralls commented on pull request #7333: #6872, use delete instead of truncate to improve performance

2020-09-08 Thread GitBox
coveralls commented on pull request #7333: URL: https://github.com/apache/shardingsphere/pull/7333#issuecomment-688901229 ## Pull Request Test Coverage Report for [Build 14560](https://coveralls.io/builds/33304048) * **0** of **0** changed or added relevant lines in **0** files

[GitHub] [shardingsphere] strongduanmu commented on pull request #6846: support mysql database create, alter and drop statement

2020-09-08 Thread GitBox
strongduanmu commented on pull request #6846: URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-688895208 > My configuration only configures the mysql view, example: `w_test_v_0` > `w_test_f_0` is not configured but processed by shardingsphere method

[GitHub] [shardingsphere] tuohai666 opened a new pull request #7334: #6872, remove connection test `SELECT 1` to improve performance

2020-09-08 Thread GitBox
tuohai666 opened a new pull request #7334: URL: https://github.com/apache/shardingsphere/pull/7334 For #6872. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] tuohai666 opened a new pull request #7333: #6872, use delete instead of truncate to improve performance

2020-09-08 Thread GitBox
tuohai666 opened a new pull request #7333: URL: https://github.com/apache/shardingsphere/pull/7333 For #6872. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] strongduanmu commented on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
strongduanmu commented on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-688851961 @tristaZero I am very sorry for the late reply and I think @xbkaishui can do a great job on this issue. 

[GitHub] [shardingsphere] gzdzss commented on issue #7321: Add more test cases for ShardingSphere-Proxy

2020-09-08 Thread GitBox
gzdzss commented on issue #7321: URL: https://github.com/apache/shardingsphere/issues/7321#issuecomment-688844154 > I want do this shardingsphere-proxy-frontend-core ShardingSphereProxy FrontendChannelInboundHandler ServerHandlerInitializer > […](#) > ---Original--- From: "Zhang

[GitHub] [shardingsphere] coveralls commented on pull request #7332: fix hint example conf

2020-09-08 Thread GitBox
coveralls commented on pull request #7332: URL: https://github.com/apache/shardingsphere/pull/7332#issuecomment-688843494 ## Pull Request Test Coverage Report for [Build 14555](https://coveralls.io/builds/33302127) * **0** of **0** changed or added relevant lines in **0** files

[GitHub] [shardingsphere] jian365066744 commented on issue #7321: Add more test cases for ShardingSphere-Proxy

2020-09-08 Thread GitBox
jian365066744 commented on issue #7321: URL: https://github.com/apache/shardingsphere/issues/7321#issuecomment-688840067 I want do this shardingsphere-proxy-frontend-core ShardingSphereProxy FrontendChannelInboundHandler ServerHandlerInitializer

[GitHub] [shardingsphere] yu199195 commented on issue #7331: Add more test cases for ProxySchemaContexts

2020-09-08 Thread GitBox
yu199195 commented on issue #7331: URL: https://github.com/apache/shardingsphere/issues/7331#issuecomment-688839006 @xiangtao Welcome to join This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] xbkaishui commented on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
xbkaishui commented on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-688832990 Ok, thanks This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [shardingsphere] yu199195 commented on issue #7284: ColumnMetaDataLoader load error and proxy cannot start success

2020-09-08 Thread GitBox
yu199195 commented on issue #7284: URL: https://github.com/apache/shardingsphere/issues/7284#issuecomment-688831013 @chana71 hi,thanks, you can follow this #7330 will fix it。 This is an automated message from the Apache

[shardingsphere] branch master updated: fix hint example conf

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 744fd19 fix hint example conf

[shardingsphere] branch master updated: fix hint example conf

2020-09-08 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 744fd19 fix hint example conf

[GitHub] [shardingsphere] menghaoranss merged pull request #7332: fix hint example conf

2020-09-08 Thread GitBox
menghaoranss merged pull request #7332: URL: https://github.com/apache/shardingsphere/pull/7332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] tuohai666 opened a new pull request #7332: fix hint example conf

2020-09-08 Thread GitBox
tuohai666 opened a new pull request #7332: URL: https://github.com/apache/shardingsphere/pull/7332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [shardingsphere] xiangtao commented on issue #7331: Add more test cases for ProxySchemaContexts

2020-09-08 Thread GitBox
xiangtao commented on issue #7331: URL: https://github.com/apache/shardingsphere/issues/7331#issuecomment-688816004 hi, it cat assign it to me @terrymanu This is an automated message from the Apache Git Service. To respond

[GitHub] [shardingsphere] terrymanu opened a new issue #7331: Add more test cases for ProxySchemaContexts

2020-09-08 Thread GitBox
terrymanu opened a new issue #7331: URL: https://github.com/apache/shardingsphere/issues/7331 Please add test cases for: - [ ] ProxySchemaContexts.init() - [ ] ProxySchemaContexts.schemaExists() - [ ] ProxySchemaContexts.getSchema() - [ ]

[GitHub] [shardingsphere] tristaZero edited a comment on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
tristaZero edited a comment on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-688811803 @xbkaishui It is not a very easy job for a newbie, but welcome to your initiative. :-) If you need any help, please tell me.

[GitHub] [shardingsphere] tristaZero commented on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
tristaZero commented on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-688811803 @xbkaishui It is not a very easy job for a newbie, but welcome to your initiative! If you need any help, please tell me.

[GitHub] [shardingsphere] coveralls commented on pull request #7320: refator ShardingSphereMetaData

2020-09-08 Thread GitBox
coveralls commented on pull request #7320: URL: https://github.com/apache/shardingsphere/pull/7320#issuecomment-688797924 ## Pull Request Test Coverage Report for [Build 14551](https://coveralls.io/builds/33299928) * **35** of **46** **(76.09%)** changed or added relevant lines

[GitHub] [shardingsphere] chana71 commented on issue #7326: can not find owner from table when select from a,b with where condition

2020-09-08 Thread GitBox
chana71 commented on issue #7326: URL: https://github.com/apache/shardingsphere/issues/7326#issuecomment-688794981 @kimmking sorry I don't figure out which one belongs to my case in your ref. Besides how about this one `select from (subquery)a join (subquery)b on a.id = b.id where

[GitHub] [shardingsphere] terrymanu merged pull request #7327: #6872, do not close thread pool for each test

2020-09-08 Thread GitBox
terrymanu merged pull request #7327: URL: https://github.com/apache/shardingsphere/pull/7327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[shardingsphere] branch master updated (e9bfb3e -> dcb9bd9)

2020-09-08 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from e9bfb3e Merge pull request #7328 from xbkaishui/optimize-startup-time-v2 add dcb9bd9 #6872, do

[GitHub] [shardingsphere] yu199195 opened a new pull request #7330: ColumnMetaDataLoader load error ,when tables match the table pattern and colums different

2020-09-08 Thread GitBox
yu199195 opened a new pull request #7330: URL: https://github.com/apache/shardingsphere/pull/7330 Fixes 7284 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[shardingsphere] branch master updated (55d0ee6 -> e9bfb3e)

2020-09-08 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from 55d0ee6 Merge pull request #7322 from terrymanu/dev new 44ca9d4 Optimize startup time, ignore load

[GitHub] [shardingsphere] tristaZero merged pull request #7328: Optimize startup time, ignore load unConfigured table's column and index

2020-09-08 Thread GitBox
tristaZero merged pull request #7328: URL: https://github.com/apache/shardingsphere/pull/7328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] tristaZero closed issue #6212: Optimize startup time, control which tables can load when startup

2020-09-08 Thread GitBox
tristaZero closed issue #6212: URL: https://github.com/apache/shardingsphere/issues/6212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7328: Optimize startup time, ignore load unConfigured table's column and index

2020-09-08 Thread GitBox
tristaZero commented on a change in pull request #7328: URL: https://github.com/apache/shardingsphere/pull/7328#discussion_r484818640 ## File path: shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/engine/dql/BaseDQLIT.java

[GitHub] [shardingsphere] coveralls commented on pull request #7327: #6872, do not close thread pool for each test

2020-09-08 Thread GitBox
coveralls commented on pull request #7327: URL: https://github.com/apache/shardingsphere/pull/7327#issuecomment-688781332 ## Pull Request Test Coverage Report for [Build 14550](https://coveralls.io/builds/33299174) * **0** of **0** changed or added relevant lines in **0** files

[GitHub] [shardingsphere] dongfangding edited a comment on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
dongfangding edited a comment on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-688773969 I still have to reiterate my scenario, that is, multiple tables, some tables I want to use master-slave-rule, and other tables, I just want it to implement its

[GitHub] [shardingsphere] dongfangding commented on issue #7269: The question about dataSourceNames only taking the last one after master-slave-rules is configured

2020-09-08 Thread GitBox
dongfangding commented on issue #7269: URL: https://github.com/apache/shardingsphere/issues/7269#issuecomment-688773969 I still have to reiterate my scenario, that is, multiple tables, some tables I want to use master-slave-rule, and other tables, I just want it to implement its own

[GitHub] [shardingsphere] coveralls commented on pull request #7328: Optimize startup time, ignore load unConfigured table's column and index

2020-09-08 Thread GitBox
coveralls commented on pull request #7328: URL: https://github.com/apache/shardingsphere/pull/7328#issuecomment-688761210 ## Pull Request Test Coverage Report for [Build 14548](https://coveralls.io/builds/33297948) * **14** of **17** **(82.35%)** changed or added relevant lines

[GitHub] [shardingsphere] Lucas-307 commented on issue #7223: does scaling support resume ?

2020-09-08 Thread GitBox
Lucas-307 commented on issue #7223: URL: https://github.com/apache/shardingsphere/issues/7223#issuecomment-688754327 @dmbj , Scaling support resume from break-point, which depends on zookeeper service. You should setup an zookeeper service and add config.

[GitHub] [shardingsphere] codecov-commenter commented on pull request #7328: Optimize startup time, ignore load unConfigured table's column and index

2020-09-08 Thread GitBox
codecov-commenter commented on pull request #7328: URL: https://github.com/apache/shardingsphere/pull/7328#issuecomment-688752680 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7328?src=pr=h1) Report > Merging

[GitHub] [shardingsphere] xbkaishui commented on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
xbkaishui commented on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-688749613 Please let me try, I am not familiar with the sql parser part. This is an automated message from the

[GitHub] [shardingsphere] tristaZero commented on issue #7323: CREATE TABLE IF NOT EXISTS execute fail

2020-09-08 Thread GitBox
tristaZero commented on issue #7323: URL: https://github.com/apache/shardingsphere/issues/7323#issuecomment-688747591 Hi @xbkaishui Thanks for your feedback. It is unsupported at present, but it is not a difficult one from my perspective. Here is a simple solution from me.

[GitHub] [shardingsphere] xbkaishui commented on pull request #7328: Optimize startup time, ignore load unConfigured table's column and index

2020-09-08 Thread GitBox
xbkaishui commented on pull request #7328: URL: https://github.com/apache/shardingsphere/pull/7328#issuecomment-688742420 @tristaZero Please help to review, Thanks This is an automated message from the Apache Git Service.

[GitHub] [shardingsphere] menghaoranss edited a comment on issue #7325: Consider about adjust data structures in config center

2020-09-08 Thread GitBox
menghaoranss edited a comment on issue #7325: URL: https://github.com/apache/shardingsphere/issues/7325#issuecomment-688720547 The new design of data structure in config center as follow: ``` ├─orchestration-name │ ├──authentication │ ├──props │ ├──schemas

  1   2   >