[GitHub] [shardingsphere] tristaZero opened a new issue #9118: The handling for broadcast in tableMetadata loader is missing

2021-01-20 Thread GitBox


tristaZero opened a new issue #9118:
URL: https://github.com/apache/shardingsphere/issues/9118


   ### How to reproduce?
   
   Remove the comment on these SQL cases below `` in `dql-integration-test-cases.xml` and run `GeneralDQLIT`
   
   ### Cause
   
   The handling for broadcast in tableMetadata loader is missing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about 
this. 
   
   For the preparation work, I would like to do more tasks related to our 
COMDEV-385. I think this will allow me to explore more into the project and 
have a better understanding. 
   
   I'm okay with any of your tasks and suggestions. 
   
   I'll comment in the COMDEV-385.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about 
this. 
   
   For the preparation work, I would like to do more tasks related to our 
COMDEV-385. I think this will allow me to explore more into the project and 
have a better understanding. 
   
   I'm okay with any of your tasks and suggestions. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] lmhmhl commented on issue #9104: More test cases for integration test engine.

2021-01-20 Thread GitBox


lmhmhl commented on issue #9104:
URL: https://github.com/apache/shardingsphere/issues/9104#issuecomment-764442831


   > Hi @lmhmhl ,
   > 
   > Currently, @JiekerTime is taking this one. Do you want to try #9117?
   > Plus, if you like, I can give more intro about this issue to get you in.
   
   Hi @tristaZero .
   Thanks for your comment. You are so nice, may be I am better for another 
issue9117. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] lmhmhl commented on issue #9117: [SQL federation] Add unit test for single table joining sharding table

2021-01-20 Thread GitBox


lmhmhl commented on issue #9117:
URL: https://github.com/apache/shardingsphere/issues/9117#issuecomment-764437426


   > Hi @lmhmhl ,
   > 
   > Would you like to take charge of this one?
   
   I'd like to do this. Thx.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu removed a comment on issue #9027: cant not work on mysql8 with json type

2021-01-20 Thread GitBox


jingshanglu removed a comment on issue #9027:
URL: https://github.com/apache/shardingsphere/issues/9027#issuecomment-764435599


   @lizhuangs Which version do you use?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #9104: More test cases for integration test engine.

2021-01-20 Thread GitBox


tristaZero commented on issue #9104:
URL: https://github.com/apache/shardingsphere/issues/9104#issuecomment-764435630


   Hi @lmhmhl ,
   
   Currently, @JiekerTime is taking this one. Do you want to try #9117? 
   Plus, if you like, I can give more intro about this issue to get you in.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu commented on issue #9027: cant not work on mysql8 with json type

2021-01-20 Thread GitBox


jingshanglu commented on issue #9027:
URL: https://github.com/apache/shardingsphere/issues/9027#issuecomment-764435599


   @lizhuangs Which version do you use?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #9117: [SQL federation] Add unit test for single table joining sharding table

2021-01-20 Thread GitBox


tristaZero commented on issue #9117:
URL: https://github.com/apache/shardingsphere/issues/9117#issuecomment-764434396


   Hi @lmhmhl ,
   
   Would you like to take charge of this one?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero opened a new issue #9117: [SQL federation] Add unit test for single table joining sharding table

2021-01-20 Thread GitBox


tristaZero opened a new issue #9117:
URL: https://github.com/apache/shardingsphere/issues/9117


   Hi, 
   
   #8284 is still underway. This issue is to add a case in 
`CalcitePrepareStatementTest` and `CalciteStatementTest` to verify that a 
`join` SQL with single tables and sharding tables can work well.
   
   The SQL case is like `select sharding_table.*, single_table.*` from 
sharding_table, single_table where single_table.id = sharding_table.id. This is 
just an example, and you can add unit tests with any cases you like. : )
   
   Indeed, it is needed to do some modification on `calcite_data_0.sql`, 
`calcite_data_1.sql`, `config-calcite.yaml`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] qjc1024join opened a new issue #1820: ELASTIC-JOB AND NAOCS

2021-01-20 Thread GitBox


qjc1024join opened a new issue #1820:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1820


   zookeeper Can you and Nacos in  server ?
   
   org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 
'org.apache.shardingsphere.elasticjob.lite.spring.boot.job.ElasticJobBootstrapConfiguration':
 Invocation of init method failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'zookeeperRegistryCenter' defined in class path resource 
[org/apache/shardingsphere/elasticjob/lite/spring/boot/reg/ElasticJobRegistryCenterConfiguration.class]:
 Post-processing of merged bean definition failed; nested exception is 
java.lang.IllegalStateException: Failed to introspect Class 
[org.apache.shardingsphere.elasticjob.reg.zookeeper.ZookeeperRegistryCenter] 
from ClassLoader [sun.misc.Launcher$AppClassLoader@18b4aac2]
at 
org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:160)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:416)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1788)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:595)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:226)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:207)
 ~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.context.support.PostProcessorRegistrationDelegate.registerBeanPostProcessors(PostProcessorRegistrationDelegate.java:241)
 ~[spring-context-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.context.support.AbstractApplicationContext.registerBeanPostProcessors(AbstractApplicationContext.java:723)
 ~[spring-context-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:536)
 ~[spring-context-5.2.7.RELEASE.jar:5.2.7.RELEASE]
at 
org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:143)
 ~[spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
org.springframework.boot.SpringApplication.refresh(SpringApplication.java:758) 
[spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
org.springframework.boot.SpringApplication.refresh(SpringApplication.java:750) 
[spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
 [spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:315) 
[spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1237) 
[spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1226) 
[spring-boot-2.3.1.RELEASE.jar:2.3.1.RELEASE]
at 
com.poteviounion.HlhtServiceElasticJobApplication.main(HlhtServiceElasticJobApplication.java:22)
 [classes/:na]
   Caused by: org.springframework.beans.factory.BeanCreationException: Error 
creating bean with name 'zookeeperRegistryCenter' defined in class path 
resource 
[org/apache/shardingsphere/elasticjob/lite/spring/boot/reg/ElasticJobRegistryCenterConfiguration.class]:
 Post-processing of merged bean definition failed; nested exception is 
java.lang.IllegalStateException: Failed to introspect Class 
[org.apache.shardingsphere.elasticjob.reg.zookeeper.ZookeeperRegistryCenter] 
from ClassLoader [sun.misc.Launcher$AppClassLoader@18b4aac2]
at 

[GitHub] [shardingsphere] tristaZero opened a new pull request #9116: Support single table joinning sharding table

2021-01-20 Thread GitBox


tristaZero opened a new pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116


   Ref #8284



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] huanghao495430759 closed issue #9086: error of SchemaBuilder append remain tables,it doesn't load table columns

2021-01-20 Thread GitBox


huanghao495430759 closed issue #9086:
URL: https://github.com/apache/shardingsphere/issues/9086


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero closed issue #8883: Create unit test for `CalciteJDBCExecutor` to test SQL federation feature

2021-01-20 Thread GitBox


tristaZero closed issue #8883:
URL: https://github.com/apache/shardingsphere/issues/8883


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero closed issue #8965: Create unit test for `CalciteLogicSchemaFactory`

2021-01-20 Thread GitBox


tristaZero closed issue #8965:
URL: https://github.com/apache/shardingsphere/issues/8965


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9108: add agent it with proxy

2021-01-20 Thread GitBox


terrymanu commented on a change in pull request #9108:
URL: https://github.com/apache/shardingsphere/pull/9108#discussion_r561636078



##
File path: 
shardingsphere-test/shardingsphere-agent-test/shardingsphere-agent-test-plugins/src/test/assembly/bin/start.sh
##
@@ -0,0 +1,71 @@
+#!/bin/sh
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SERVER_NAME=ShardingSphere-Proxy
+
+cd `dirname $0`
+cd ..
+DEPLOY_DIR=`pwd`
+
+LOGS_DIR=${DEPLOY_DIR}/logs
+if [ ! -d ${LOGS_DIR} ]; then
+mkdir ${LOGS_DIR}
+fi
+
+STDOUT_FILE=${LOGS_DIR}/stdout.log
+EXT_LIB=${DEPLOY_DIR}/ext-lib
+
+CLASS_PATH=.:${DEPLOY_DIR}/lib/*:${EXT_LIB}/*
+
+JAVA_OPTS=" -Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Xdebug 
-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=3308"
+
+JAVA_MEM_OPTS=" -server -Xmx2g -Xms2g -Xmn1g -Xss256k -XX:+DisableExplicitGC 
-XX:+UseConcMarkSweepGC -XX:+CMSParallelRemarkEnabled 
-XX:LargePageSizeInBytes=128m -XX:+UseFastAccessorMethods 
-XX:+UseCMSInitiatingOccupancyOnly -XX:CMSInitiatingOccupancyFraction=70 "
+
+MAIN_CLASS=org.apache.shardingsphere.proxy.Bootstrap
+
+print_usage() {
+echo "usage: start.sh [port] [config_dir]"
+echo "  port: proxy listen port, default is 3307"
+echo "  config_dir: proxy config directory, default is conf"
+exit 0
+}
+
+if [ "$1" == "-h" ] || [ "$1" == "--help" ] ; then
+print_usage
+fi
+
+echo "Starting the $SERVER_NAME ..."
+
+if [ $# == 1 ]; then
+MAIN_CLASS=${MAIN_CLASS}" "$1
+echo "The port is $1"
+CLASS_PATH=../conf:${CLASS_PATH}
+fi
+
+if [ $# == 2 ]; then
+MAIN_CLASS=${MAIN_CLASS}" "$1" "$2
+echo "The port is $1"
+echo "The configuration path is $DEPLOY_DIR/$2"
+CLASS_PATH=${DEPLOY_DIR}/$2:${CLASS_PATH}
+fi
+
+echo "The classpath is ${CLASS_PATH}"
+
+nohup java ${JAVA_OPTS} ${JAVA_MEM_OPTS} 
-javaagent:../shardingsphere-agent.jar  -classpath ${CLASS_PATH} ${MAIN_CLASS} 
>> ${STDOUT_FILE} 2>&1 &

Review comment:
   No remote debug port added, but the compose service contains it





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] huanghao495430759 commented on issue #8605: table for unconfigured "SELECT t.*, t2.col FROM t LEFT JOIN t2" not work

2021-01-20 Thread GitBox


huanghao495430759 commented on issue #8605:
URL: https://github.com/apache/shardingsphere/issues/8605#issuecomment-764413600


   I see Liang Zhang had fix this issue at 2021-01-18.
   
`org.apache.shardingsphere.driver.jdbc.core.resultset.ShardingSphereResultSetMetaData#getColumnCount
 line 52.`
   
![image](https://user-images.githubusercontent.com/34728144/105297113-fb3a9380-5bf4-11eb-925a-d77162aac642.png)
   
   @tristaZero @iblilife @strongduanmu 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Linliangkung commented on issue #9115: 4.1.1版本 CONNECTION_STRICTLY 模式下死锁

2021-01-20 Thread GitBox


Linliangkung commented on issue #9115:
URL: https://github.com/apache/shardingsphere/issues/9115#issuecomment-764406765


   
我的问题是为什么在CONNECTION_STRICTLY模式下不使用synchronized获取连接,而在MEMORY_STRICTLY模式下会考虑到死锁问题使用synchronized代码块获取连接。在这两个模式下应该都是存在死锁风险。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] sandynz edited a comment on issue #9109: MySQL InnoDB back-end ShardingSphere-Proxy query result of sql without order by clause is not sorted by primary key ascending

2021-01-20 Thread GitBox


sandynz edited a comment on issue #9109:
URL: https://github.com/apache/shardingsphere/issues/9109#issuecomment-764400072


   > 
   > 
   > Hi @sandynz , I understant that the SQL doesn't have `order by`.
   > 
   > `SELECT * FROM t_order WHERE order_id>=1 AND order_id<=10;` will get data 
from `t_order_0` and `t_order_0` and merge the result.
   > 
   > If you want to sort the result, should specify the sort column.
   
   Hi @dongzl , that's true, result ordering is not guaranteed if sql without 
`order by` clause for all RDBMS. But it could be a trival enhancement when 
backend is MySQL InnoDB, respond similar result as MySQL might be a little 
better.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] sandynz commented on issue #9109: MySQL InnoDB back-end ShardingSphere-Proxy query result of sql without order by clause is not sorted by primary key ascending

2021-01-20 Thread GitBox


sandynz commented on issue #9109:
URL: https://github.com/apache/shardingsphere/issues/9109#issuecomment-764400072


   > 
   > 
   > Hi @sandynz , I understant that the SQL doesn't have `order by`.
   > 
   > `SELECT * FROM t_order WHERE order_id>=1 AND order_id<=10;` will get data 
from `t_order_0` and `t_order_0` and merge the result.
   > 
   > If you want to sort the result, should specify the sort column.
   
   Hi @dongzl , that's true, result ordering is not guaranteed if sql without 
`order by` clause. But it could be a trival enhancement when backend is MySQL 
InnoDB, respond similar result as MySQL might be a little better.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-ui] Th1s opened a new issue #75: 安全漏洞提报相关问题咨询

2021-01-20 Thread GitBox


Th1s opened a new issue #75:
URL: https://github.com/apache/shardingsphere-ui/issues/75


   
你好,两个月前我曾经给shardingsphere-ui上报了两个严重安全漏洞,也留过相关issue。我目前比较关注当前该漏洞的修复情况,请问开发团队能给一个回复吗?
   
   如果不方便在issue处讨论,我的微信号是sjc394891083。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Linliangkung opened a new issue #9115: 4.1.1版本 CONNECTION_STRICTLY 模式下死锁

2021-01-20 Thread GitBox


Linliangkung opened a new issue #9115:
URL: https://github.com/apache/shardingsphere/issues/9115


   AbstractConnectionAdapter.createConnections方法(问题描述在代码块注释中)
   ``` java
   private List createConnections(final String dataSourceName, 
final ConnectionMode connectionMode, final DataSource dataSource, final int 
connectionSize) throws SQLException {
   if (1 == connectionSize) {
   Connection connection = createConnection(dataSourceName, 
dataSource);
   replayMethodsInvocation(connection);
   return Collections.singletonList(connection);
   }
   if (ConnectionMode.CONNECTION_STRICTLY == connectionMode) {
   //CONNECTION_STRICTLY 模式下为什么没有加synchronized代码块
  //假设我的connectionSize为2,数据源最大线程数是2
  //现在有两个线程A和线程B同时执行下面的createConnections方法
  //如果线程A和线程B都同时拿到一个连接,然后再去拿第二个连接的时候就会出现占有一个连接,相互等待对方释放连接的情况出现
   return createConnections(dataSourceName, dataSource, 
connectionSize);
   }
   synchronized (dataSource) {
   return createConnections(dataSourceName, dataSource, 
connectionSize);
   }
   } 
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere] branch master updated: Add useServerPrepStmts=true for IT (#9114)

2021-01-20 Thread panjuan
This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new b680bb3  Add useServerPrepStmts=true for IT (#9114)
b680bb3 is described below

commit b680bb36e89041e5233fcc6ae9304d3e746db0db
Author: Liang Zhang 
AuthorDate: Thu Jan 21 13:37:56 2021 +0800

Add useServerPrepStmts=true for IT (#9114)
---
 .../test/integration/env/datasource/DatabaseEnvironment.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/datasource/DatabaseEnvironment.java
 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/datasource/DatabaseEnvironment.java
index 670323c..b363af5 100644
--- 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/datasource/DatabaseEnvironment.java
+++ 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/datasource/DatabaseEnvironment.java
@@ -71,7 +71,7 @@ public final class DatabaseEnvironment {
 case "H2":
 return 
"jdbc:h2:mem:test_db;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MySQL";
 case "MySQL":
-return 
String.format("jdbc:mysql://%s:%s?serverTimezone=UTC=false=true=utf-8",
 host, port);
+return 
String.format("jdbc:mysql://%s:%s?useServerPrepStmts=true=UTC=false=true=utf-8",
 host, port);
 case "PostgreSQL":
 return String.format("jdbc:postgresql://%s:%s/", host, port);
 case "SQLServer":
@@ -94,7 +94,7 @@ public final class DatabaseEnvironment {
 case "H2":
 return 
String.format("jdbc:h2:mem:%s;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MySQL",
 dataSourceName);
 case "MySQL":
-return 
String.format("jdbc:mysql://%s:%s/%s?serverTimezone=UTC=false=true=utf-8",
 host, port, dataSourceName);
+return 
String.format("jdbc:mysql://%s:%s/%s?useServerPrepStmts=true=UTC=false=true=utf-8",
 host, port, dataSourceName);
 case "PostgreSQL":
 return String.format("jdbc:postgresql://%s:%s/%s", host, port, 
dataSourceName);
 case "SQLServer":



[GitHub] [shardingsphere] tristaZero merged pull request #9114: Add useServerPrepStmts=true for IT

2021-01-20 Thread GitBox


tristaZero merged pull request #9114:
URL: https://github.com/apache/shardingsphere/pull/9114


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu opened a new pull request #9114: Add useServerPrepStmts=true for IT

2021-01-20 Thread GitBox


terrymanu opened a new pull request #9114:
URL: https://github.com/apache/shardingsphere/pull/9114


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] lmhmhl removed a comment on issue #9104: More test cases for integration test engine.

2021-01-20 Thread GitBox


lmhmhl removed a comment on issue #9104:
URL: https://github.com/apache/shardingsphere/issues/9104#issuecomment-763606514


   I wanna have a try



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about 
this. 
   
   For the preparation work, is there any other SQL definition other than 
`SELECT/UPDATE/DELETE/INSERT` which requires the same work and steps I need to 
follow as I would need to follow for `SELECT/UPDATE/DELETE/INSERT`? If not, I 
can do other preparation tasks which you assign me to do. 
   
   I'm okay with any of your tasks and suggestions. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] codecov-io commented on pull request #9108: add agent it with proxy

2021-01-20 Thread GitBox


codecov-io commented on pull request #9108:
URL: https://github.com/apache/shardingsphere/pull/9108#issuecomment-764287339


   # 
[Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=h1) 
Report
   > Merging 
[#9108](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=desc) 
(5398f78) into 
[master](https://codecov.io/gh/apache/shardingsphere/commit/cbcb71baf392719125125b03b2a60b0beca386dd?el=desc)
 (cbcb71b) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/shardingsphere/pull/9108/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#9108  +/-   ##
   
   + Coverage 69.74%   69.76%   +0.02% 
 Complexity  657  657  
   
 Files  1648 1648  
 Lines 2664826639   -9 
 Branches   4636 4634   -2 
   
 Hits  1858618586  
   + Misses 6777 6767  -10 
   - Partials   1285 1286   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...phere/governance/core/registry/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/9108/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlci5qYXZh)
 | `44.44% <0.00%> (-2.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...dingsphere/governance/core/lock/node/LockNode.java](https://codecov.io/gh/apache/shardingsphere/pull/9108/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL25vZGUvTG9ja05vZGUuamF2YQ==)
 | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | 
[...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9108/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh)
 | `19.27% <0.00%> (+0.88%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...nce/core/lock/strategy/GovernanceLockStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/9108/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL3N0cmF0ZWd5L0dvdmVybmFuY2VMb2NrU3RyYXRlZ3kuamF2YQ==)
 | `30.76% <0.00%> (+2.19%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...dingsphere/driver/executor/DriverJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/9108/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9Ecml2ZXJKREJDRXhlY3V0b3IuamF2YQ==)
 | `42.85% <0.00%> (+4.39%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...hardingsphere/infra/lock/StandardLockStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/9108/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9sb2NrL1N0YW5kYXJkTG9ja1N0cmF0ZWd5LmphdmE=)
 | `76.92% <0.00%> (+5.49%)` | `0.00% <0.00%> (ø%)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=footer).
 Last update 
[cbcb71b...27afa39](https://codecov.io/gh/apache/shardingsphere/pull/9108?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere] branch master updated: Update doc (#9113)

2021-01-20 Thread panjuan
This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new 215e809  Update doc (#9113)
215e809 is described below

commit 215e80902d8ead0cad86abae5cfc3a4ca2f19bd5
Author: Liang Zhang 
AuthorDate: Thu Jan 21 12:34:49 2021 +0800

Update doc (#9113)
---
 .../content/features/test-engine/integration-test.cn.md| 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/docs/document/content/features/test-engine/integration-test.cn.md 
b/docs/document/content/features/test-engine/integration-test.cn.md
index 785a215..a298b20 100644
--- a/docs/document/content/features/test-engine/integration-test.cn.md
+++ b/docs/document/content/features/test-engine/integration-test.cn.md
@@ -50,9 +50,11 @@ weight = 1
 
 ## 使用指南
 
+模块路径:`shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite`
+
 ### 测试用例配置
 
-SQL 用例在 
`shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test/resources/cases/${SQL-TYPE}/${SQL-TYPE}-integration-test-cases.xml`。
+SQL 用例在 `resources/cases/${SQL-TYPE}/${SQL-TYPE}-integration-test-cases.xml`。
 
 用例文件格式如下:
 
@@ -96,7 +98,7 @@ SQL 用例在 
`shardingsphere-test/shardingsphere-integration-test/shardingspher
 
  Native 环境配置
 
-目录:`shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test/resources/env/${SCENARIO-TYPE}`
+目录:`src/test/resources/env/${SCENARIO-TYPE}`
 
   - `scenario-env.properties`: 数据源配置
   - `rules.yaml`: 规则配置
@@ -107,7 +109,7 @@ SQL 用例在 
`shardingsphere-test/shardingsphere-integration-test/shardingspher
 
  Docker 环境配置
 
-目录:`shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test/resources/docker/${SCENARIO-TYPE}`
+目录:`src/test/resources/docker/${SCENARIO-TYPE}`
 
   - `docker-compose.yml`: Docker-Compose 配置文件,用于 Docker 环境启动
   - `proxy/conf/config-${SCENARIO-TYPE}.yaml`: 规则配置
@@ -118,7 +120,7 @@ SQL 用例在 
`shardingsphere-test/shardingsphere-integration-test/shardingspher
 
  配置测试引擎运行环境
 
-通过配置 
`shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/env/engine-env.properties`
 控制测试引擎。
+通过配置 `src/test/resources/env/engine-env.properties` 控制测试引擎。
 
 所有的属性值都可以通过 Maven 命令行 `-D` 的方式动态注入。
 



[GitHub] [shardingsphere] tristaZero merged pull request #9113: Update IT doc

2021-01-20 Thread GitBox


tristaZero merged pull request #9113:
URL: https://github.com/apache/shardingsphere/pull/9113


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu opened a new pull request #9113: Update IT doc

2021-01-20 Thread GitBox


terrymanu opened a new pull request #9113:
URL: https://github.com/apache/shardingsphere/pull/9113


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu closed pull request #9111: Move docker folder into env

2021-01-20 Thread GitBox


terrymanu closed pull request #9111:
URL: https://github.com/apache/shardingsphere/pull/9111


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu commented on issue #9100: [RDL] enhancement for `CREATE/ALTER SHARDING RULE`

2021-01-20 Thread GitBox


jingshanglu commented on issue #9100:
URL: https://github.com/apache/shardingsphere/issues/9100#issuecomment-764234119


   @terrymanu @tristaZero How about this? 
   `[]` : optional 
   ```
   alter SHARDING RULE (
   modify t_order ['ds_00.t_order_000${0..1}','ds_01.t_order_000${2..3}'] 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   add t_item 'ds_00.t_item_000${0..1}','ds_01.t_item_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   [binding_tables t_order,t_item]
   [default_table_strategy order_id HASH_MOD(xxx=xxx)]
   [broadcast_tables tb1, tb2]
   )
   
   create SHARDING RULE (
   modify t_order 'ds_00.t_order_000${0..1}','ds_01.t_order_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   add t_item 'ds_00.t_item_000${0..1}','ds_01.t_item_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   [binding_tables t_order,t_item]
   [default_table_strategy order_id HASH_MOD(xxx=xxx)]
   [broadcast_tables tb1, tb2]
   )
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu removed a comment on issue #9046: [RDL] Support `Alter ShardingRule`

2021-01-20 Thread GitBox


jingshanglu removed a comment on issue #9046:
URL: https://github.com/apache/shardingsphere/issues/9046#issuecomment-764232091


   @terrymanu @tristaZero How about this? 
   `[]` : optional 
   ```
   alter SHARDING RULE (
   modify t_order ['ds_00.t_order_000${0..1}','ds_01.t_order_000${2..3}'] 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   add t_item 'ds_00.t_item_000${0..1}','ds_01.t_item_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   [binding_tables t_order,t_item]
   [default_table_strategy order_id HASH_MOD(xxx=xxx)]
   [broadcast_tables tb1, tb2]
   )
   
   create SHARDING RULE (
   modify t_order 'ds_00.t_order_000${0..1}','ds_01.t_order_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   add t_item 'ds_00.t_item_000${0..1}','ds_01.t_item_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   [binding_tables t_order,t_item]
   [default_table_strategy order_id HASH_MOD(xxx=xxx)]
   [broadcast_tables tb1, tb2]
   )
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu commented on issue #9046: [RDL] Support `Alter ShardingRule`

2021-01-20 Thread GitBox


jingshanglu commented on issue #9046:
URL: https://github.com/apache/shardingsphere/issues/9046#issuecomment-764232091


   @terrymanu @tristaZero How about this? 
   `[]` : optional 
   ```
   alter SHARDING RULE (
   modify t_order ['ds_00.t_order_000${0..1}','ds_01.t_order_000${2..3}'] 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   add t_item 'ds_00.t_item_000${0..1}','ds_01.t_item_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   [binding_tables t_order,t_item]
   [default_table_strategy order_id HASH_MOD(xxx=xxx)]
   [broadcast_tables tb1, tb2]
   )
   
   create SHARDING RULE (
   modify t_order 'ds_00.t_order_000${0..1}','ds_01.t_order_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   add t_item 'ds_00.t_item_000${0..1}','ds_01.t_item_000${2..3}' 
[TABLESTRATEGY order_id HASH_MOD(xxx=xxx)] [DATABASESTRATEGY order_id 
HASH_MOD(xxx=xxx)]  [KEYGENERATESTRATEGY order_id HASH_MOD(xxx=xxx)],
   [binding_tables t_order,t_item]
   [default_table_strategy order_id HASH_MOD(xxx=xxx)]
   [broadcast_tables tb1, tb2]
   )
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] codecov-io commented on pull request #9112: add support alter sharding rule

2021-01-20 Thread GitBox


codecov-io commented on pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#issuecomment-764222356


   # 
[Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=h1) 
Report
   > Merging 
[#9112](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=desc) 
(c79af69) into 
[master](https://codecov.io/gh/apache/shardingsphere/commit/2523fa0680d6324da7921241b614d52c3a9ca25b?el=desc)
 (2523fa0) will **decrease** coverage by `0.41%`.
   > The diff coverage is `7.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/shardingsphere/pull/9112/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#9112  +/-   ##
   
   - Coverage 69.80%   69.39%   -0.42% 
   + Complexity  660  657   -3 
   
 Files  1643 1649   +6 
 Lines 2660026786 +186 
 Branches   4630 4670  +40 
   
   + Hits  1856918588  +19 
   - Misses 6745 6908 +163 
   - Partials   1286 1290   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...stsql/rdl/AlterReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyUmVwbGljYVF1ZXJ5UnVsZUJhY2tlbmRIYW5kbGVyLmphdmE=)
 | `10.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...t/distsql/rdl/AlterShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh)
 | `85.71% <0.00%> (-6.60%)` | `0.00 <0.00> (ø)` | |
   | 
[...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh)
 | `62.96% <0.00%> (-5.04%)` | `0.00 <0.00> (ø)` | |
   | 
[...ding/converter/ShardingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jb252ZXJ0ZXIvU2hhcmRpbmdSdWxlU3RhdGVtZW50Q29udmVydGVyLmphdmE=)
 | `66.66% <58.82%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rdingsphere/db/protocol/error/CommonErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvZXJyb3IvQ29tbW9uRXJyb3JDb2RlLmphdmE=)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sql/rdl/impl/CreateShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | 

[GitHub] [shardingsphere] tristaZero commented on issue #9066: A question about datasource names

2021-01-20 Thread GitBox


tristaZero commented on issue #9066:
URL: https://github.com/apache/shardingsphere/issues/9066#issuecomment-764217924


   Hi @zhang-j-x ,
   
   You use Sharding-JDBC Datasource with SpringBoot, don't you?
   
   
   Let me iterate your case. Please correct me if something is misunderstood,
   
   - The databases in your MySQL instance are named with `-`
   - You want to configure the `datasource.names`  with the actual database 
names
   - But there is an exception
   
   Actually, ShardingSphere has no such limitation. Could you give SpringBoot 
Configuration a check? I remember some version of `SpringBoot` has terrible 
support for keys with `-`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] dolphin-bear opened a new issue #1819: I developed my own JobListener,but i don't know how

2021-01-20 Thread GitBox


dolphin-bear opened a new issue #1819:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1819


   ## Question
   
   **For English only**, other languages will not accept.
   
   Before asking a question, make sure you have:
   
   - Googled your question.
   - Searched open and closed [GitHub 
issues](https://github.com/apache/shardingsphere-elasticjob/issues).
   - Read documentation: [ElasticJob 
Doc](https://shardingsphere.apache.org/elasticjob/current/en/overview/).
   
   Please pay attention on issues you submitted, because we maybe need more 
details. 
   If no response anymore and we cannot reproduce it on current information, we 
will **close it**.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero edited a comment on issue #9048: shardingsphere-jdbc Actual SQL execution results are incorrect (data should have been returned, but no data was returned)

2021-01-20 Thread GitBox


tristaZero edited a comment on issue #9048:
URL: https://github.com/apache/shardingsphere/issues/9048#issuecomment-764210583


   > "" in the passed parameter causes
   
   Hi @wangwenzhao1 Sorry, I can catch you. Does that mean you locate the 
cause? Is it really a bug? That way, would you like to raise a PR to fix it? 
Thanks.
   
   Still, if you have no willing to fix it,  we are grateful to have you show 
the cause here.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] dolphin-bear commented on issue #1817: 有AbstractDistributeOnceElasticJobListener的使用例子吗?

2021-01-20 Thread GitBox


dolphin-bear commented on issue #1817:
URL: 
https://github.com/apache/shardingsphere-elasticjob/issues/1817#issuecomment-764210824


   how to develop jobListener ?  can you do some example for using that ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #9048: shardingsphere-jdbc Actual SQL execution results are incorrect (data should have been returned, but no data was returned)

2021-01-20 Thread GitBox


tristaZero commented on issue #9048:
URL: https://github.com/apache/shardingsphere/issues/9048#issuecomment-764210583


   > "" in the passed parameter causes
   
   Hi @wangwenzhao1 Sorry, I can catch you. Does that mean you locate the 
cause? Is it really a bug? That way, would you like to raise a PR to fix it?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764209867


   @ThanoshanMV 
   If there is any hints, you can comment on our COMDEV-385.
   Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] duanzonglong commented on issue #6759: SHOW FULL COLUMNS get wrong

2021-01-20 Thread GitBox


duanzonglong commented on issue #6759:
URL: https://github.com/apache/shardingsphere/issues/6759#issuecomment-764208997


   Hi,I have solved this problem.
   the config is:
   defaultDataSourceName: wms_base
   and 
   liquibase.setLiquibaseSchema("wms_base");
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] duanzonglong closed issue #6759: SHOW FULL COLUMNS get wrong

2021-01-20 Thread GitBox


duanzonglong closed issue #6759:
URL: https://github.com/apache/shardingsphere/issues/6759


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #9086: error of SchemaBuilder append remain tables,it doesn't load table columns

2021-01-20 Thread GitBox


tristaZero commented on issue #9086:
URL: https://github.com/apache/shardingsphere/issues/9086#issuecomment-764209044


   Hi @huanghao495430759 ,
   
   Thanks for your comment. If this issue is duplicate to #8605, maybe we can 
move our discussion to that one. Still, I will ping @strongduanmu to give it a 
look since it looks like he is working at your scenario.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu opened a new pull request #9112: add support alter sharding rule

2021-01-20 Thread GitBox


jingshanglu opened a new pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112


   Fixes #9046 .
   
   Changes proposed in this pull request:
   - fix create sharding rule grammar
   - add alter sharding rule grammar
   - add support for alter sharding rule
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Han-Tang edited a comment on issue #9101: create a ShardingProxy *.yaml ,How to not restart the service and take effect

2021-01-20 Thread GitBox


Han-Tang edited a comment on issue #9101:
URL: https://github.com/apache/shardingsphere/issues/9101#issuecomment-764177522


   i used  sharding proxy 4.x @dongzl 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Han-Tang commented on issue #9101: create a ShardingProxy *.yaml ,How to not restart the service and take effect

2021-01-20 Thread GitBox


Han-Tang commented on issue #9101:
URL: https://github.com/apache/shardingsphere/issues/9101#issuecomment-764177522


   i used  sharding proxy 4.x



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] dongzl commented on issue #9101: create a ShardingProxy *.yaml ,How to not restart the service and take effect

2021-01-20 Thread GitBox


dongzl commented on issue #9101:
URL: https://github.com/apache/shardingsphere/issues/9101#issuecomment-764176602


   Hi @Han-Tang , which version do you use?
   
   I understant if you want to add a new yaml config file, you must restart the 
proxy.
   
   But you can add config by ShardingSphere-UI, and doesn't need restart proxy.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] dongzl commented on issue #9109: MySQL InnoDB back-end ShardingSphere-Proxy query result of sql without order by clause is not sorted by primary key ascending

2021-01-20 Thread GitBox


dongzl commented on issue #9109:
URL: https://github.com/apache/shardingsphere/issues/9109#issuecomment-764174295


   Hi @sandynz , I understant that the SQL doesn't have `order by`.
   
   `SELECT * FROM t_order WHERE order_id>=1 AND order_id<=10;`  will get data 
from `t_order_0` and `t_order_0` and merge the result.
   
   If you want to sort the result, should specify the sort column.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] JiekerTime commented on issue #9104: More test cases for integration test engine.

2021-01-20 Thread GitBox


JiekerTime commented on issue #9104:
URL: https://github.com/apache/shardingsphere/issues/9104#issuecomment-764173977


   I will do it! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wgy8283335 closed issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


wgy8283335 closed issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu opened a new pull request #9111: Move docker folder into env

2021-01-20 Thread GitBox


terrymanu opened a new pull request #9111:
URL: https://github.com/apache/shardingsphere/pull/9111


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere] branch master updated: move init.sql into init-sql folder (#9110)

2021-01-20 Thread nicholasjiang
This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new 6841c50  move init.sql into init-sql folder (#9110)
6841c50 is described below

commit 6841c5031a89ad4888f5f01fa2864c54bae24606
Author: Liang Zhang 
AuthorDate: Wed Jan 20 23:32:41 2021 +0800

move init.sql into init-sql folder (#9110)
---
 docs/document/content/features/test-engine/integration-test.cn.md   | 2 +-
 .../org/apache/shardingsphere/test/integration/env/EnvironmentPath.java | 2 +-
 .../src/test/resources/docker/db/docker-compose.yml | 2 +-
 .../test/resources/docker/dbtbl_with_replica_query/docker-compose.yml   | 2 +-
 .../src/test/resources/docker/replica_query/docker-compose.yml  | 2 +-
 .../src/test/resources/docker/tbl/docker-compose.yml| 2 +-
 .../src/test/resources/env/{replica_query => db/init-sql}/h2/init.sql   | 0
 .../src/test/resources/env/db/{ => init-sql}/mysql/init.sql | 0
 .../src/test/resources/env/db/{ => init-sql}/oracle/init.sql| 0
 .../src/test/resources/env/db/{ => init-sql}/postgresql/init.sql| 0
 .../src/test/resources/env/db/{ => init-sql}/sqlserver/init.sql | 0
 .../resources/env/dbtbl_with_replica_query/{ => init-sql}/h2/init.sql   | 0
 .../env/dbtbl_with_replica_query/{ => init-sql}/mysql/init.sql  | 0
 .../env/dbtbl_with_replica_query/{ => init-sql}/oracle/init.sql | 0
 .../env/dbtbl_with_replica_query/{ => init-sql}/postgresql/init.sql | 0
 .../env/dbtbl_with_replica_query/{ => init-sql}/sqlserver/init.sql  | 0
 .../src/test/resources/env/{db => replica_query/init-sql}/h2/init.sql   | 0
 .../src/test/resources/env/replica_query/{ => init-sql}/mysql/init.sql  | 0
 .../src/test/resources/env/replica_query/{ => init-sql}/oracle/init.sql | 0
 .../test/resources/env/replica_query/{ => init-sql}/postgresql/init.sql | 0
 .../test/resources/env/replica_query/{ => init-sql}/sqlserver/init.sql  | 0
 .../src/test/resources/env/tbl/{ => init-sql}/h2/init.sql   | 0
 .../src/test/resources/env/tbl/{ => init-sql}/mysql/init.sql| 0
 .../src/test/resources/env/tbl/{ => init-sql}/oracle/init.sql   | 0
 .../src/test/resources/env/tbl/{ => init-sql}/postgresql/init.sql   | 0
 .../src/test/resources/env/tbl/{ => init-sql}/sqlserver/init.sql| 0
 26 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/document/content/features/test-engine/integration-test.cn.md 
b/docs/document/content/features/test-engine/integration-test.cn.md
index 69c1358..785a215 100644
--- a/docs/document/content/features/test-engine/integration-test.cn.md
+++ b/docs/document/content/features/test-engine/integration-test.cn.md
@@ -102,7 +102,7 @@ SQL 用例在 
`shardingsphere-test/shardingsphere-integration-test/shardingspher
   - `rules.yaml`: 规则配置
   - `databases.xml`: 真实库名称
   - `dataset.xml`: 初始化数据
-  - `${DATABASE-TYPE}\init.sql`: 初始化数据库表结构
+  - `init-sql\${DATABASE-TYPE}\init.sql`: 初始化数据库表结构
   - `authority.xml`: 待补充
 
  Docker 环境配置
diff --git 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/EnvironmentPath.java
 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/EnvironmentPath.java
index 01d8670..540a1b2 100644
--- 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/EnvironmentPath.java
+++ 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/env/EnvironmentPath.java
@@ -113,7 +113,7 @@ public final class EnvironmentPath {
 }
 
 private static String getFile(final DatabaseType databaseType, final 
String scenario, final String fileName) {
-String path = String.join("/", ROOT_PATH, scenario, 
databaseType.getName().toLowerCase(), fileName);
+String path = String.join("/", ROOT_PATH, scenario, "init-sql", 
databaseType.getName().toLowerCase(), fileName);
 URL url = EnvironmentPath.class.getClassLoader().getResource(path);
 assertNotNull(String.format("File `%s` must exist.", path), url);
 return url.getFile();
diff --git 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/docker/db/docker-compose.yml
 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/docker/db/docker-compose.yml
index f710473..56aa302 100644
--- 

[GitHub] [shardingsphere] SteNicholas merged pull request #9110: move init.sql into init-sql folder

2021-01-20 Thread GitBox


SteNicholas merged pull request #9110:
URL: https://github.com/apache/shardingsphere/pull/9110


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu opened a new pull request #9110: move init.sql into init-sql folder

2021-01-20 Thread GitBox


terrymanu opened a new pull request #9110:
URL: https://github.com/apache/shardingsphere/pull/9110


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] zhang-j-x commented on issue #9066: A question about datasource names

2021-01-20 Thread GitBox


zhang-j-x commented on issue #9066:
URL: https://github.com/apache/shardingsphere/issues/9066#issuecomment-763638577


   yes,rename can solve this problem,but it means that it not supports the 
database which name contains '_',   sometimes we can not rename the physical 
database's name.The version i use is 5.0.0-alpha.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] sandynz opened a new issue #9109: MySQL InnoDB back-end ShardingSphere-Proxy query result of sql without order by clause is not sorted by primary key ascending

2021-01-20 Thread GitBox


sandynz opened a new issue #9109:
URL: https://github.com/apache/shardingsphere/issues/9109


   ## Bug Report
   
   ### Which version of ShardingSphere did you use?
   5.0.0-RC1-SNAPSHOT
   
   ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
   ShardingSphere-Proxy with MySQL 5.7.29
   
   ### Expected behavior
   Sort order is the same as MySQL
   
   ### Actual behavior
   Result not sorted
   
   ### Reason analyze (If you can)
   Query sql is not rewritten as `ORDER BY`
   
   ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule 
configuration, when exception occur etc.
   config-sharding.yaml snippet:
   ```
   rules:
   - !SHARDING
tables:
  t_order:
actualDataNodes: ds_${0..1}.t_order_${0..1}
   ```
   table schema:
   ```
   CREATE TABLE `t_order_0 / 1` (
 `order_id` int(11) NOT NULL,
 `user_id` int(11) NOT NULL,
 `status` varchar(45) DEFAULT NULL,
 PRIMARY KEY (`order_id`)
   ) ENGINE=InnoDB;
   ```
   example query result:
   ```
   mysql> SELECT * FROM t_order WHERE order_id>=1 AND order_id<=10;
   +--+-+---+
   | order_id | user_id | status|
   +--+-+---+
   |2 |  94 | inited 2 at 16:47:44.588  |
   |4 |  34 | inited 4 at 16:47:44.607  |
   |6 |  66 | inited 6 at 16:47:44.628  |
   |   10 |  80 | inited 10 at 16:47:44.668 |
   |1 |  20 | inited 1 at 16:47:44.571  |
   |5 |  36 | inited 5 at 16:47:44.619  |
   |7 |  50 | inited 7 at 16:47:44.636  |
   |8 | 101 | inited 8 at 16:47:44.645  |
   |3 |  73 | inited 3 at 16:47:44.598  |
   |9 |  23 | inited 9 at 16:47:44.656  |
   +--+-+---+
   ```
   
   ### Example codes for reproduce this issue (such as a github link).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] lmhmhl commented on issue #9104: More test cases for integration test engine.

2021-01-20 Thread GitBox


lmhmhl commented on issue #9104:
URL: https://github.com/apache/shardingsphere/issues/9104#issuecomment-763606514


   I wanna have a try



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] yu199195 opened a new pull request #9108: add agent it with proxy

2021-01-20 Thread GitBox


yu199195 opened a new pull request #9108:
URL: https://github.com/apache/shardingsphere/pull/9108


   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere-benchmark] branch master updated: update benchmark result

2021-01-20 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository.

zhangyonglun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-benchmark.git


The following commit(s) were added to refs/heads/master by this push:
 new 294ee0d  update benchmark result
294ee0d is described below

commit 294ee0df4245154774a5066bdaaea741991dc457
Author: tuohai666 
AuthorDate: Wed Jan 20 20:44:38 2021 +0800

update benchmark result
---
 .../report/shardingsphere-benchmark-avg.xls | Bin 95232 -> 95744 bytes
 .../resources/report/shardingsphere-benchmark.xls   | Bin 94720 -> 94720 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
index c93903d..0f415f4 100755
Binary files 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
 and 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls
 differ
diff --git 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
index 2fc7703..86b3b2e 100755
Binary files 
a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
 and 
b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls
 differ



[shardingsphere] branch master updated: Merge global lock get & check (#9107)

2021-01-20 Thread xiaoyu
This is an automated email from the ASF dual-hosted git repository.

xiaoyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new 9d4add3  Merge global lock get & check (#9107)
9d4add3 is described below

commit 9d4add3c7bdf650f0a175eb6b5d4adff9ac19ed0
Author: Haoran Meng 
AuthorDate: Wed Jan 20 20:18:54 2021 +0800

Merge global lock get & check (#9107)
---
 .../governance/core/lock/node/LockNode.java   | 15 ++-
 .../core/lock/strategy/GovernanceLockStrategy.java|  5 -
 .../governance/core/registry/RegistryCenter.java  |  9 ++---
 .../governance/core/lock/node/LockNodeTest.java   |  9 +++--
 .../registry/listener/GlobalLockChangedListenerTest.java  |  2 +-
 .../apache/shardingsphere/infra/lock/LockStrategy.java|  7 ---
 .../shardingsphere/infra/lock/StandardLockStrategy.java   |  5 -
 .../infra/lock/fixture/FixtureLockStrategy.java   |  5 -
 .../driver/executor/DriverJDBCExecutor.java   |  7 ---
 .../communication/DatabaseCommunicationEngine.java|  7 ---
 .../scaling/elasticjob/job/FinishedCheckJob.java  |  2 +-
 11 files changed, 25 insertions(+), 48 deletions(-)

diff --git 
a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/node/LockNode.java
 
b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/node/LockNode.java
index ca3c542..8fd72cd 100644
--- 
a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/node/LockNode.java
+++ 
b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/node/LockNode.java
@@ -24,14 +24,27 @@ import com.google.common.base.Joiner;
  */
 public final class LockNode {
 
+private static final String LOCK_NODE_ROOT = "lock";
+
 private static final String GLOBAL_LOCK_NODE = "glock";
 
+private static final String RESOURCE_LOCK_NODE = "rlock";
+
 /**
  * Get global lock node path.
  * 
  * @return global lock node path
  */
 public String getGlobalLockNodePath() {
-return Joiner.on("/").join("", GLOBAL_LOCK_NODE);
+return Joiner.on("/").join("", LOCK_NODE_ROOT, GLOBAL_LOCK_NODE);
+}
+
+/**
+ * Get resource lock node path.
+ * 
+ * @return resource lock node path
+ */
+public String getResourceLockNodePath() {
+return Joiner.on("/").join("", LOCK_NODE_ROOT, RESOURCE_LOCK_NODE);
 }
 }
diff --git 
a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/strategy/GovernanceLockStrategy.java
 
b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/strategy/GovernanceLockStrategy.java
index af3a6aa..c863864 100644
--- 
a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/strategy/GovernanceLockStrategy.java
+++ 
b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/lock/strategy/GovernanceLockStrategy.java
@@ -58,11 +58,6 @@ public final class GovernanceLockStrategy implements 
LockStrategy {
 }
 
 @Override
-public boolean checkLock() {
-return registryCenter.checkLock();
-}
-
-@Override
 public String getType() {
 return LockStrategyType.GOVERNANCE.name();
 }
diff --git 
a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
 
b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
index 88d2102..4d6c6d3 100644
--- 
a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
+++ 
b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
@@ -162,7 +162,7 @@ public final class RegistryCenter {
  * @return true if get the lock, false if not
  */
 public boolean tryGlobalLock(final long timeout, final TimeUnit timeUnit) {
-return repository.tryLock(timeout, timeUnit);
+return repository.tryLock(timeout, timeUnit) && checkLock();
 }
 
 /**
@@ -173,12 +173,7 @@ public final class RegistryCenter {
 repository.delete(lockNode.getGlobalLockNodePath());
 }
 
-/**
- * Check lock state.
- *
- * @return true if all instances were locked, else false
- */
-

[GitHub] [shardingsphere] yu199195 merged pull request #9107: Merge global lock get & check

2021-01-20 Thread GitBox


yu199195 merged pull request #9107:
URL: https://github.com/apache/shardingsphere/pull/9107


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] menghaoranss opened a new pull request #9107: Merge global lock get & check

2021-01-20 Thread GitBox


menghaoranss opened a new pull request #9107:
URL: https://github.com/apache/shardingsphere/pull/9107


   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] dongzl commented on issue #9102: masterRouteOnly changed to primaryRouteOnly ?

2021-01-20 Thread GitBox


dongzl commented on issue #9102:
URL: https://github.com/apache/shardingsphere/issues/9102#issuecomment-763559279


   Hi @jarvisqi , which version do you use?
   
   ShardingSphere-jdbc or ShardingSphere-proxy?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] menghaoranss closed issue #8579: Design and implement the scaling workflow

2021-01-20 Thread GitBox


menghaoranss closed issue #8579:
URL: https://github.com/apache/shardingsphere/issues/8579


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere] branch master updated: prefect shardingsphere jdbc document of datasource (#9106)

2021-01-20 Thread panjuan
This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new 0dd01f3  prefect shardingsphere jdbc document of datasource (#9106)
0dd01f3 is described below

commit 0dd01f31b118e8d76c730a6b90e17ea73d4803cb
Author: Jieker 
AuthorDate: Wed Jan 20 19:00:26 2021 +0800

prefect shardingsphere jdbc document of datasource (#9106)

* prefect document

* prefect document
---
 .../configuration/spring-boot-starter/encrypt.cn.md  |  2 +-
 .../configuration/spring-boot-starter/encrypt.en.md  |  2 +-
 .../configuration/spring-boot-starter/replica-query.cn.md|  2 +-
 .../configuration/spring-boot-starter/replica-query.en.md|  2 +-
 .../configuration/spring-boot-starter/shadow.cn.md   |  2 +-
 .../configuration/spring-boot-starter/shadow.en.md   |  2 +-
 .../configuration/spring-boot-starter/sharding.cn.md |  2 +-
 .../configuration/spring-boot-starter/sharding.en.md |  2 +-
 .../shardingsphere-jdbc/configuration/yaml/encrypt.cn.md |  2 +-
 .../shardingsphere-jdbc/configuration/yaml/encrypt.en.md |  2 +-
 .../configuration/yaml/replica-query.cn.md   |  2 +-
 .../configuration/yaml/replica-query.en.md   |  2 +-
 .../shardingsphere-jdbc/configuration/yaml/shadow.cn.md  |  2 +-
 .../shardingsphere-jdbc/configuration/yaml/shadow.en.md  |  2 +-
 .../shardingsphere-jdbc/configuration/yaml/sharding.cn.md|  2 +-
 .../shardingsphere-jdbc/configuration/yaml/sharding.en.md|  2 +-
 .../shardingsphere-jdbc/usage/sharding/java-api.cn.md| 10 ++
 .../shardingsphere-jdbc/usage/sharding/java-api.en.md| 12 +++-
 .../usage/sharding/spring-boot-starter.cn.md | 10 ++
 .../usage/sharding/spring-boot-starter.en.md | 10 ++
 .../usage/sharding/spring-namespace.cn.md| 10 ++
 .../usage/sharding/spring-namespace.en.md| 10 ++
 .../shardingsphere-jdbc/usage/sharding/yaml.cn.md|  9 +
 .../shardingsphere-jdbc/usage/sharding/yaml.en.md| 10 ++
 24 files changed, 64 insertions(+), 49 deletions(-)

diff --git 
a/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.cn.md
 
b/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.cn.md
index b019edd..1747e22 100644
--- 
a/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.cn.md
+++ 
b/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.cn.md
@@ -6,7 +6,7 @@ weight = 3
 ## 配置项说明
 
 ```properties
-spring.shardingsphere.datasource.names= # 省略数据源配置
+spring.shardingsphere.datasource.names= # 省略数据源配置,请参考使用手册
 
 
spring.shardingsphere.rules.encrypt.tables..columns..cipher-column=
 # 加密列名称
 
spring.shardingsphere.rules.encrypt.tables..columns..assisted-query-column=
 # 查询列名称
diff --git 
a/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.en.md
 
b/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.en.md
index 440f745..5ea0f4c 100644
--- 
a/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.en.md
+++ 
b/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/encrypt.en.md
@@ -6,7 +6,7 @@ weight = 3
 ## Configuration Item Explanation
 
 ```properties
-spring.shardingsphere.datasource.names= # Omit data source configuration
+spring.shardingsphere.datasource.names= # Omit the data source configuration, 
please refer to the usage
 
 
spring.shardingsphere.rules.encrypt.tables..columns..cipher-column=
 # Cipher column name
 
spring.shardingsphere.rules.encrypt.tables..columns..assisted-query-column=
 # Assisted query column name
diff --git 
a/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/replica-query.cn.md
 
b/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/replica-query.cn.md
index ef61350..9a35f6b 100644
--- 
a/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/replica-query.cn.md
+++ 
b/docs/document/content/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/replica-query.cn.md
@@ -6,7 +6,7 @@ weight = 2
 ## 配置项说明
 
 ```properties
-spring.shardingsphere.datasource.names= # 省略数据源配置
+spring.shardingsphere.datasource.names= # 省略数据源配置,请参考使用手册
 
 
spring.shardingsphere.rules.replica-query.data-sources..primary-data-source-name=
 # 主数据源名称
 
spring.shardingsphere.rules.replica-query.data-sources..replica-data-source-names=
 # 从数据源名称,多个从数据源用逗号分隔
diff --git 

[GitHub] [shardingsphere] tristaZero merged pull request #9106: prefect shardingsphere jdbc document of datasource

2021-01-20 Thread GitBox


tristaZero merged pull request #9106:
URL: https://github.com/apache/shardingsphere/pull/9106


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] JiekerTime opened a new pull request #9106: prefect shardingsphere jdbc document of datasource

2021-01-20 Thread GitBox


JiekerTime opened a new pull request #9106:
URL: https://github.com/apache/shardingsphere/pull/9106


   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere] branch master updated: Update IT document (#9105)

2021-01-20 Thread panjuan
This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new 2efec03  Update IT document (#9105)
2efec03 is described below

commit 2efec0394d1010a547a91765b69913c1794c64b5
Author: Liang Zhang 
AuthorDate: Wed Jan 20 18:35:18 2021 +0800

Update IT document (#9105)

* Update index

* Update index

* Update it document
---
 .../content/features/test-engine/_index.cn.md  |   4 +-
 .../features/test-engine/integration-test.cn.md| 221 -
 .../features/test-engine/integration-test.en.md|   2 -
 .../static/img/test-engine/integration-test.jpg| Bin 288085 -> 0 bytes
 4 files changed, 127 insertions(+), 100 deletions(-)

diff --git a/docs/document/content/features/test-engine/_index.cn.md 
b/docs/document/content/features/test-engine/_index.cn.md
index 61e9f3b..c4f6b8f 100644
--- a/docs/document/content/features/test-engine/_index.cn.md
+++ b/docs/document/content/features/test-engine/_index.cn.md
@@ -6,6 +6,6 @@ chapter = true
 +++
 
 Apache ShardingSphere 提供了完善的测试引擎。
-它以 XML 方式定义 SQL,每个引擎分别为MySQL、PostgreSQL、SQLServer 和 Oracle 数据库运行测试用例。
+它以 XML 方式定义 SQL,每个引擎分别为 MySQL、PostgreSQL、SQLServer 和 Oracle 数据库运行测试用例。
 
-为了方便上手,测试引擎不必修改任何 **Java** 代码,只需要修改相应的配置文件即可运行断言。
+为了方便上手,测试引擎无需修改任何 **Java** 代码,只需修改相应的配置文件即可运行断言。
diff --git a/docs/document/content/features/test-engine/integration-test.cn.md 
b/docs/document/content/features/test-engine/integration-test.cn.md
index 4cef504..69c1358 100644
--- a/docs/document/content/features/test-engine/integration-test.cn.md
+++ b/docs/document/content/features/test-engine/integration-test.cn.md
@@ -4,130 +4,159 @@ title = "集成测试"
 weight = 1
 +++
 
-SQL解析单元测试全面覆盖SQL占位符和字面量维度。
-整合测试进一步拆分为策略和JDBC两个维度,策略维度包括分库分表、仅分表、仅分库、读写分离等策略,JDBC维度包括Statement、PreparedStatement。
+## 设计
 
-因此,1条SQL会驱动5种数据库的解析 * 2种参数传递类型 + 5种数据库 * 5种分片策略 * 2 种 JDBC 运行方式 = 
60个测试用例,以达到ShardingSphere对于高质量的追求。
+集成测试包括 3 个模块:测试用例、测试环境以及测试引擎。
 
-## 流程
+### 测试用例
 
-Junit 中的 `Parameterized` 会聚合起所有的测试数据,并将测试数据一一传递给测试方法进行断言。数据处理就像是沙漏中的流沙:
+用于定义待测试的 SQL 以及测试结果的断言数据。
+每个用例定义一条 SQL,SQL 可定义多种数据库执行类型。
 
-![](https://shardingsphere.apache.org/document/current/img/test-engine/integration-test.jpg)
+### 测试环境
 
-### 配置
+用于搭建运行测试用例的数据库和 ShardingSphere-Proxy 环境。
+环境又具体分为环境准备方式,数据库类型和场景。
 
-  - 环境类文件
-- 
/shardingsphere-integration-test-suite/src/test/resources/env-native.properties
-- 
/shardingsphere-integration-test-suite/src/test/resources/env/`SQL-TYPE`/dataset.xml
-- 
/shardingsphere-integration-test-suite/src/test/resources/env/`SQL-TYPE`/schema.xml
-  - 测试用例类文件
-- 
/shardingsphere-integration-test-suite/src/test/resources/cases/`SQL-TYPE`/`SQL-TYPE`-integration-test-cases.xml
-- 
/shardingsphere-integration-test-suite/src/test/resources/cases/`SQL-TYPE`/dataset/`FEATURE-TYPE`/*.xml
-  - sql-case 文件
-- 
/shardingsphere-integration-test-suite/src/main/resources/sql/sharding/`SQL-TYPE`/*.xml
+环境准备方式分为 Native 和 Docker,未来还将增加 Embed 类型的支持。
 
-### 环境配置 
+  - Native 环境用于测试用例直接运行在开发者提供的测试环境中,适于调试场景;
+  - Docker 环境由 Maven 运行 Docker-Compose 插件直接搭建,适用于云编译环境和测试 ShardingSphere-Proxy 
的场景,如:GitHub Action;
+  - Embed 环境由测试框架自动搭建嵌入式 MySQL,适用于 ShardingSphere-JDBC 的本地环境测试。
 
-集成测试需要真实的数据库环境,根据相应的配置文件创建测试环境:
+当前默认采用 Native 环境,使用 ShardingSphere-JDBC + H2 数据库运行测试用例。
+通过 Maven 的 `-P -Pit.env.docker` 参数可以指定 Docker 环境的运行方式。
+未来将采用 Embed 环境的 ShardingSphere-JDBC + MySQL,替换 Native 执行测试用例的默认环境类型。 
 
-首先,修改配置文件 
`/shardingsphere-integration-test-suite/src/test/resources/env-native.properties`
 ,例子如下:
+数据库类型目前支持 MySQL、PostgreSQL、SQLServer 和 Oracle,并且可以支持使用 ShardingSphere-JDBC 
或是使用 ShardingSphere-Proxy 执行测试用例。
 
-```properties
-# 测试主键,并发,column index等的开关
-it.run.additional.cases=false
+场景用于对 ShardingSphere 支持规则进行测试,目前支持数据分片和读写分离的相关场景,未来会不断完善场景的组合。
 
-# 测试场景,可指定多种规则
-it.scenarios=db,tbl,dbtbl_with_replica_query,replica_query
+### 测试引擎
 
-# 要测试的数据库,可以指定多种数据库(H2,MySQL,Oracle,SQLServer,PostgreSQL)
-it.databases=MySQL,PostgreSQL
-
-# MySQL配置
-it.mysql.host=127.0.0.1
-it.mysql.port=13306
-it.mysql.username=root
-it.mysql.password=root
-
-## PostgreSQL配置
-it.postgresql.host=db.psql
-it.postgresql.port=5432
-it.postgresql.username=postgres
-it.postgresql.password=postgres
-
-## SQLServer配置
-it.sqlserver.host=db.mssql
-it.sqlserver.port=1433
-it.sqlserver.username=sa
-it.sqlserver.password=Jdbc1234
-
-## Oracle配置
-it.oracle.host=db.oracle
-it.oracle.port=1521
-it.oracle.username=jdbc
-it.oracle.password=jdbc
-```
+用于批量读取测试用例,并逐条执行和断言测试结果。
 
-其次,修改文件 
`/shardingsphere-integration-test-suite/src/test/resources/env/SQL-TYPE/dataset.xml`
 
-在`dataset.xml`文件中定义元数据和测试数据。例如:
+测试引擎通过将用例和环境进行排列组合,以达到用最少的用例测试尽可能多场景的目的。
 
-```xml
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-```
+每条 SQL 会以`数据库类型 * 接入端类型 * SQL 执行模式 * JDBC 执行模式 * 

[GitHub] [shardingsphere] tristaZero merged pull request #9105: Update IT document

2021-01-20 Thread GitBox


tristaZero merged pull request #9105:
URL: https://github.com/apache/shardingsphere/pull/9105


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu opened a new pull request #9105: Update IT document

2021-01-20 Thread GitBox


terrymanu opened a new pull request #9105:
URL: https://github.com/apache/shardingsphere/pull/9105


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero opened a new issue #9104: More test cases for integration test engine.

2021-01-20 Thread GitBox


tristaZero opened a new issue #9104:
URL: https://github.com/apache/shardingsphere/issues/9104


   More test cases are needed to ensure  integration test engine covers all the 
scenarios as many as it can.
   
   Here is a todo list to add cases,
   
   For tables
   - Broadcast table
   - Single table
   
   For configuration
   - [ ]  Encryption
   - [ ]  Sharding + Encryption
   - [ ]  Encryption + ReplicaQuery
   - [ ]  Sharding + Encryption + ReplicaQuery
   - [ ] Sharding + Encryption + ReplicaQuery + Shadow (Later)
   
   For governance
   - [ ] Zookeeper
   - [ ] DDL
   - [ ] RDL
   - [ ] ETCD (Later)
   
   For databases
   - [ ] PostgreSQL JDBC
   - [ ] PostgreSQL Proxy
   - [ ] Oracle JDBC
   - [ ] SQLServer JDBC
   
   For Shadow
   - [ ] Shadow
   
   Data agent
   - [ ] Frontend: MySQL  Backend: PostgreSQL
   - [ ] Frontend: MySQL  Backend: Oracle/Server
   - [ ] Frontend: PostgreSQL  Backend: MySQL
   - [ ] Frontend: PostgreSQL  Backend: Oracle/Server
   
   
   ### Tips
   - Here is 
[DOC](https://shardingsphere.apache.org/document/current/cn/features/test-engine/integration-test/)
 presenting more details



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] skaic opened a new issue #1818: [Job trace] id-uuid('varchar') in mysql table PRIMARY KEY (`id`) is not a good idea

2021-01-20 Thread GitBox


skaic opened a new issue #1818:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1818


   ## Question
   
   [Job trace] 'varchar'  in mysql table PRIMARY KEY (`id`)  is not a good idea。
   
   e.g.
   
   REATE TABLE `JOB_STATUS_TRACE_LOG` (
 `id` varchar(40) NOT NULL,
 `job_name` varchar(100) NOT NULL,
 `original_task_id` varchar(255) NOT NULL,
 `task_id` varchar(255) NOT NULL,
 `slave_id` varchar(50) NOT NULL,
 `source` varchar(50) NOT NULL,
 `execution_type` varchar(20) NOT NULL,
 `sharding_item` varchar(100) NOT NULL,
 `state` varchar(20) NOT NULL,
 `message` varchar(4000) DEFAULT NULL,
 `creation_time` timestamp NULL DEFAULT NULL,
 PRIMARY KEY (`id`),
 KEY `TASK_ID_STATE_INDEX` (`task_id`(128),`state`)
   ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;
   
   CREATE TABLE `JOB_EXECUTION_LOG` (
 `id` varchar(40) NOT NULL,
 `job_name` varchar(100) NOT NULL,
 `task_id` varchar(255) NOT NULL,
 `hostname` varchar(255) NOT NULL,
 `ip` varchar(50) NOT NULL,
 `sharding_item` int(11) NOT NULL,
 `execution_source` varchar(20) NOT NULL,
 `failure_cause` varchar(4000) DEFAULT NULL,
 `is_success` int(11) NOT NULL,
 `start_time` timestamp NULL DEFAULT NULL,
 `complete_time` timestamp NULL DEFAULT NULL,
 PRIMARY KEY (`id`)
   ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;
   
   Because: 
   1.  Mysql InnoDB table PRIMARY KEY need a auto increment  unique identity.
   2.  We need  to analyze a log in reverse order , use  auto increment  unique 
identity can be fast.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] duanzonglong edited a comment on issue #6759: SHOW FULL COLUMNS get wrong

2021-01-20 Thread GitBox


duanzonglong edited a comment on issue #6759:
URL: https://github.com/apache/shardingsphere/issues/6759#issuecomment-763481518


   Hi,this is the whole yaml.
   I have two tables don't need sharding,how to config?
   
   `
   schemaName: sharding_wms
   
   dataSources:
 wms_base: 
   url: 
jdbc:mysql://172.172.172.213:3360/scms_wms?useUnicode=true=UTF8
   username: root
   password: 
   connectionTimeoutMilliseconds: 3
   idleTimeoutMilliseconds: 6
   maxLifetimeMilliseconds: 180
   maxPoolSize: 65
 wms_sd0:
   url: 
jdbc:mysql://172.172.172.213:3360/wms_sd0?useUnicode=true=UTF8
   username: root
   password: 
   connectionTimeoutMilliseconds: 3
   idleTimeoutMilliseconds: 6
   maxLifetimeMilliseconds: 180
   maxPoolSize: 65
 wms_sd1:
   url: 
jdbc:mysql://172.172.172.213:3360/wms_sd1?useUnicode=true=UTF8
   username: root
   password: 
   connectionTimeoutMilliseconds: 3
   idleTimeoutMilliseconds: 6
   maxLifetimeMilliseconds: 180
   maxPoolSize: 65
   
   shardingRule:
 defaultDatabaseStrategy:
   standard:
 shardingColumn: tenant_id
 preciseAlgorithmClassName: 
com.hrsoft.sharding.strategy.core.DatabaseStrategy
 tables:
   ds_changelog_lock:
 actualDataNodes: wms_base.ds_changelog_lock
 databaseStrategy:
   none:
 tableStrategy:
   none:
   ds_changelog:
 actualDataNodes: wms_base.ds_changelog
 databaseStrategy:
   none:
 tableStrategy:
   none:  
 bindingTables:
   - ds_changelog_lock,ds_changelog
 defaultTableStrategy:
   none:
   `



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] duanzonglong commented on issue #6759: SHOW FULL COLUMNS get wrong

2021-01-20 Thread GitBox


duanzonglong commented on issue #6759:
URL: https://github.com/apache/shardingsphere/issues/6759#issuecomment-763481518


   Hi,this is the whole yaml.
   
   `
   schemaName: sharding_wms
   
   dataSources:
 wms_base: 
   url: 
jdbc:mysql://172.172.172.213:3360/scms_wms?useUnicode=true=UTF8
   username: root
   password: 
   connectionTimeoutMilliseconds: 3
   idleTimeoutMilliseconds: 6
   maxLifetimeMilliseconds: 180
   maxPoolSize: 65
 wms_sd0:
   url: 
jdbc:mysql://172.172.172.213:3360/wms_sd0?useUnicode=true=UTF8
   username: root
   password: 
   connectionTimeoutMilliseconds: 3
   idleTimeoutMilliseconds: 6
   maxLifetimeMilliseconds: 180
   maxPoolSize: 65
 wms_sd1:
   url: 
jdbc:mysql://172.172.172.213:3360/wms_sd1?useUnicode=true=UTF8
   username: root
   password: 
   connectionTimeoutMilliseconds: 3
   idleTimeoutMilliseconds: 6
   maxLifetimeMilliseconds: 180
   maxPoolSize: 65
   
   shardingRule:
 defaultDatabaseStrategy:
   standard:
 shardingColumn: tenant_id
 preciseAlgorithmClassName: 
com.hrsoft.sharding.strategy.core.DatabaseStrategy
 tables:
   ds_changelog_lock:
 actualDataNodes: wms_base.ds_changelog_lock
 databaseStrategy:
   none:
 tableStrategy:
   none:
   ds_changelog:
 actualDataNodes: wms_base.ds_changelog
 databaseStrategy:
   none:
 tableStrategy:
   none:  
 bindingTables:
   - ds_changelog_lock,ds_changelog
 defaultTableStrategy:
   none:
   `



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[shardingsphere] branch master updated: Modify the capitalization of package names and incomplete modules (#9103)

2021-01-20 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
 new c9ca3a7  Modify the capitalization of package names and incomplete 
modules (#9103)
c9ca3a7 is described below

commit c9ca3a7947c7559cf30f486223bd6b33f967aef6
Author: Jieker 
AuthorDate: Wed Jan 20 17:38:59 2021 +0800

Modify the capitalization of package names and incomplete modules (#9103)
---
 examples/pom.xml | 1 +
 .../pom.xml  | 0
 .../org/apache/shardingsphere/example/parser/SQLFormatExampleMain.java   | 0
 .../shardingsphere/example/parser/SQLParameterizedExampleMain.java   | 0
 4 files changed, 1 insertion(+)

diff --git a/examples/pom.xml b/examples/pom.xml
index 86c1f48..7fc502b 100644
--- a/examples/pom.xml
+++ b/examples/pom.xml
@@ -30,6 +30,7 @@
 example-core
 shardingsphere-jdbc-example
 shardingsphere-proxy-example
+shardingsphere-parser-example
 
 
 
diff --git a/examples/Shardingsphere-parser-example/pom.xml 
b/examples/shardingsphere-parser-example/pom.xml
similarity index 100%
rename from examples/Shardingsphere-parser-example/pom.xml
rename to examples/shardingsphere-parser-example/pom.xml
diff --git 
a/examples/Shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLFormatExampleMain.java
 
b/examples/shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLFormatExampleMain.java
similarity index 100%
rename from 
examples/Shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLFormatExampleMain.java
rename to 
examples/shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLFormatExampleMain.java
diff --git 
a/examples/Shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLParameterizedExampleMain.java
 
b/examples/shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLParameterizedExampleMain.java
similarity index 100%
rename from 
examples/Shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLParameterizedExampleMain.java
rename to 
examples/shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/SQLParameterizedExampleMain.java



[GitHub] [shardingsphere] terrymanu merged pull request #9103: Modify the capitalization of package names and incomplete modules

2021-01-20 Thread GitBox


terrymanu merged pull request #9103:
URL: https://github.com/apache/shardingsphere/pull/9103


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] JiekerTime opened a new pull request #9103: Modify the capitalization of package names and incomplete modules

2021-01-20 Thread GitBox


JiekerTime opened a new pull request #9103:
URL: https://github.com/apache/shardingsphere/pull/9103


   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wangwenzhao1 commented on issue #9048: shardingsphere-jdbc Actual SQL execution results are incorrect (data should have been returned, but no data was returned)

2021-01-20 Thread GitBox


wangwenzhao1 commented on issue #9048:
URL: https://github.com/apache/shardingsphere/issues/9048#issuecomment-763456317


   "" in the passed parameter causes



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wangwenzhao1 commented on issue #9047: Search condition is String Cannot return data normally

2021-01-20 Thread GitBox


wangwenzhao1 commented on issue #9047:
URL: https://github.com/apache/shardingsphere/issues/9047#issuecomment-763455290


   > 您好,请详细说明您的问题。
   
   "" in the passed parameter causes



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wangwenzhao1 closed issue #9047: Search condition is String Cannot return data normally

2021-01-20 Thread GitBox


wangwenzhao1 closed issue #9047:
URL: https://github.com/apache/shardingsphere/issues/9047


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wangwenzhao1 commented on issue #9047: Search condition is String Cannot return data normally

2021-01-20 Thread GitBox


wangwenzhao1 commented on issue #9047:
URL: https://github.com/apache/shardingsphere/issues/9047#issuecomment-763455031


   "" in the passed parameter causes



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] JiekerTime commented on issue #9003: 5.0.0-alpha did not delete the datasource.common prop

2021-01-20 Thread GitBox


JiekerTime commented on issue #9003:
URL: https://github.com/apache/shardingsphere/issues/9003#issuecomment-763448269


   @aBoyNicholas In 5.0.0 apha, if your springboot version is 2.x, you really 
need to configure datasourse.common. However, under 2.x, you do not need to 
configure at all.
   The datasourse.common will be removed in the future.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jarvisqi opened a new issue #9102: masterRouteOnly changed to primaryRouteOnly ?

2021-01-20 Thread GitBox


jarvisqi opened a new issue #9102:
URL: https://github.com/apache/shardingsphere/issues/9102


   `java
   public final class HintManager implements AutoCloseable {
   
   private static final ThreadLocal HINT_MANAGER_HOLDER = new 
ThreadLocal<>();
   
   private final Multimap> databaseShardingValues = 
HashMultimap.create();
   
   private final Multimap> tableShardingValues = 
HashMultimap.create();
   
   private boolean databaseShardingOnly;
   
   private boolean primaryRouteOnly;
   
   /**
* Set database operation force route to primary database only.
*/
   public void setPrimaryRouteOnly() {
   primaryRouteOnly = true;
   }
   `
   May I ask which version was changed ?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] JiekerTime commented on issue #9025: table-strategy-inline-sharding-colum = id, Search by name

2021-01-20 Thread GitBox


JiekerTime commented on issue #9025:
URL: https://github.com/apache/shardingsphere/issues/9025#issuecomment-763440533


   Can you describe the problem in more detail ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] JiekerTime commented on issue #9067: a bug in use sharding-proxy

2021-01-20 Thread GitBox


JiekerTime commented on issue #9067:
URL: https://github.com/apache/shardingsphere/issues/9067#issuecomment-763438469


   @AllrenGao Can you show the configuration file of proxy ? This may help us 
find the problem.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Han-Tang opened a new issue #9101: create a ShardingProxy *.yaml ,How to not restart the service and take effect

2021-01-20 Thread GitBox


Han-Tang opened a new issue #9101:
URL: https://github.com/apache/shardingsphere/issues/9101


   i have a question:  how to create a *.yaml file and take effect when not 
restart the service.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1817: 有AbstractDistributeOnceElasticJobListener的使用例子吗?

2021-01-20 Thread GitBox


TeslaCN closed issue #1817:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1817


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1817: 有AbstractDistributeOnceElasticJobListener的使用例子吗?

2021-01-20 Thread GitBox


TeslaCN commented on issue #1817:
URL: 
https://github.com/apache/shardingsphere-elasticjob/issues/1817#issuecomment-763417044


   **For English Only**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob] kamafeel opened a new issue #1817: 有AbstractDistributeOnceElasticJobListener的使用例子吗?

2021-01-20 Thread GitBox


kamafeel opened a new issue #1817:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1817


   在spring boot 下面,总是提示
   java.lang.IllegalArgumentException: Can not find job listener type 
'distributeOnceJobListener'.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org