[GitHub] [shardingsphere] huanghao495430759 commented on issue #10251: [API Change] Move the user configuration to authority rule
huanghao495430759 commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831668970 OK, Can I try it too ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126
tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r624659440
##
File path:
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseTypeTest.java
##
@@ -40,7 +42,7 @@ public void assertGetName() {
@Test
public void assertGetJdbcUrlPrefixes() {
-assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(),
is(Collections.singletonList("jdbc:microsoft:sqlserver:")));
+ assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(new
ArrayList(Arrays.asList("jdbc:microsoft:sqlserver:",
"jdbc:sqlserver:";
Review comment:
Hi, please keep two spaces here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #10251: [API Change] Move the user configuration to authority rule
tristaZero commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831664361 Hi @zhujunx , Glad to see you stepping forward. Which one do you want to try? Or both? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #10214: Support alter database grammar
tristaZero commented on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-831661678 Hi @Liangda-w Please give this one a double-checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere] branch master updated: fix bad rewritten result for foreign key SQL (#10193)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 16aef56 fix bad rewritten result for foreign key SQL (#10193)
16aef56 is described below
commit 16aef56ae33fa71ebd47ef112dbb9e83bf91b47f
Author: Zhengqiang Duan
AuthorDate: Tue May 4 11:24:31 2021 +0800
fix bad rewritten result for foreign key SQL (#10193)
* fix bad rewritten result for foreign key SQL when user config single data
node sharding config
* refactor ShardingTableBroadcastRoutingEngine to support multiple tables
route
* add different type test cases and fix some bug
* fix ci exception
---
.../shardingsphere/sharding/rule/ShardingRule.java | 2 +-
.../sharding/rewrite/token/pojo/TableToken.java| 6 +-
.../ShardingSQLRewriterParameterizedTest.java | 8 ++
.../src/test/resources/sharding/alter.xml | 57 +-
.../resources/yaml/sharding/sharding-rule.yaml | 11 +-
.../engine/type/ShardingRouteEngineFactory.java| 7 +-
.../ShardingTableBroadcastRoutingEngine.java | 49 -
.../complex/ShardingCartesianRoutingEngine.java| 2 +-
.../ShardingStatementValidatorFactory.java | 5 +
.../impl/ShardingAlterTableStatementValidator.java | 69
.../ShardingTableBroadcastRoutingEngineTest.java | 7 +-
.../ShardingAlterTableStatementValidatorTest.java | 121 +
.../infra/route/context/RouteContext.java | 2 +-
13 files changed, 331 insertions(+), 15 deletions(-)
diff --git
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
index 3a5414a..825ea4f 100644
---
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
+++
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
@@ -312,7 +312,7 @@ public final class ShardingRule implements FeatureRule,
SchemaRule, DataNodeCont
if (!singleTableRules.keySet().containsAll(logicTableNames)) {
return false;
}
-return 1 == singleTableRules.values().stream().filter(each ->
logicTableNames.contains(each.getTableName())).collect(Collectors.toSet()).size();
+return 1 == singleTableRules.values().stream().filter(each ->
logicTableNames.contains(each.getTableName())).map(SingleTableRule::getDataSourceName).collect(Collectors.toSet()).size();
}
/**
diff --git
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/TableToken.java
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/TableToken.java
index 0ec8d45..f742589 100644
---
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/TableToken.java
+++
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/TableToken.java
@@ -20,7 +20,6 @@ package org.apache.shardingsphere.sharding.rewrite.token.pojo;
import com.google.common.base.Joiner;
import lombok.Getter;
import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
-import org.apache.shardingsphere.infra.binder.type.TableAvailable;
import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.RouteUnitAware;
import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.SQLToken;
import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.Substitutable;
@@ -33,7 +32,6 @@ import
org.apache.shardingsphere.sql.parser.sql.common.value.identifier.Identifi
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
-import java.util.stream.Collectors;
/**
* Table token.
@@ -72,9 +70,7 @@ public final class TableToken extends SQLToken implements
Substitutable, RouteUn
}
private Map getLogicAndActualTables(final RouteUnit
routeUnit) {
-Collection tableNames = sqlStatementContext instanceof
TableAvailable
-? ((TableAvailable)
sqlStatementContext).getAllTables().stream().map(each ->
each.getTableName().getIdentifier().getValue()).collect(Collectors.toList())
-: sqlStatementContext.getTablesContext().getTableNames();
+Collection tableNames =
[GitHub] [shardingsphere] tristaZero merged pull request #10193: fix bad rewritten result for foreign key SQL
tristaZero merged pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #10171: Bad rewritten result for foreign key SQL
tristaZero closed issue #10171: URL: https://github.com/apache/shardingsphere/issues/10171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere-benchmark] branch master updated: update benchmark result
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new 453a1b1 update benchmark result 453a1b1 is described below commit 453a1b14efea576c7060400c922a2f902d5d3db5 Author: tuohai666 AuthorDate: Tue May 4 08:00:24 2021 +0800 update benchmark result --- .../report/shardingsphere-benchmark-avg.xls| Bin 114176 -> 114176 bytes .../resources/report/shardingsphere-benchmark.xls | Bin 87552 -> 87552 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls index 02d04ba..0506e5c 100755 Binary files a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls and b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark-avg.xls differ diff --git a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls index 174162f..9f6b9eb 100755 Binary files a/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls and b/shardingsphere-benchmark/src/main/resources/report/shardingsphere-benchmark.xls differ
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1887: Update release notes for 3.0.0
TeslaCN merged pull request #1887: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere-elasticjob] branch master updated: Update release notes for 3.0.0 (#1887)
This is an automated email from the ASF dual-hosted git repository. wuweijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git The following commit(s) were added to refs/heads/master by this push: new 1151766 Update release notes for 3.0.0 (#1887) 1151766 is described below commit 115176675b5f1a8e4805fa9c656c23ee78674d0e Author: 吴伟杰 AuthorDate: Tue May 4 00:08:49 2021 +0800 Update release notes for 3.0.0 (#1887) --- RELEASE-NOTES.md | 19 +++ 1 file changed, 19 insertions(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 4cb36eb..7360176 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -1,3 +1,22 @@ +## 3.0.0 + +### Enhancements + +1. Support configuring Mail SMTP SSL trust in elasticjob-error-handler-email + +### Bug Fixes + +1. The failover may not work in distributed deployment +2. ReconcileService is still running after the job shutdown + +### Dependencies + +1. Make the spring-boot-starter-jdbc optional in ElasticJob Spring Boot Starter + +### Change Logs + +1. [MILESTONE 3.0.0](https://github.com/apache/shardingsphere-elasticjob/milestone/4) + ## 3.0.0-RC1 ### API Changes
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1887: Update release notes for 3.0.0
TeslaCN opened a new pull request #1887: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] zhujunxxxxx commented on issue #10251: [API Change] Move the user configuration to authority rule
zhujunx commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831335228 OK，Let me try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #10251: [API Change] Move the user configuration to authority rule
tristaZero commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831205842 Hi guys, @huanghao495430759 @zhujunx Hope you have an enjoyable holiday! I have to say there are two **important and challenging** issues to seek excellent contributors from the community. Based on two of you's great previous contribution and experience, I assume you are eligible to deal with these difficult issues. So please excuse me for occupying you here. :) I just wonder whether you are interested in this issue and #10252 and willing to take charge? Here are some pointers FYI, - #10251 and #10252 have some of the associations. - #10252 is difficult than this one. - Some sub-tasks of #10252 rely on this one. If you are not available, please still tell me so that I can assign these issues to others. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero opened a new issue #10252: [Enhancement] Support authority rule governance through different proxies
tristaZero opened a new issue #10252:
URL: https://github.com/apache/shardingsphere/issues/10252
Hi, community,
This issue is about authority rule governance. I have to say it is
difficult.. But you will perceive how the governance works and how proxies
refresh its metadata to keep consistent! Oh, great challenge!
### Introduction
As you know, the authority module is a new feature for our incoming release.
Authority is about user and privileges' management. Consequently, the authority
rule is to configure users and privilege-loading algorithm, i.e.,
```yaml
# server.yaml
users:
- root@%:root
- sharding@:sharding
rules:
- !AUTHORITY
provider:
type: NATIVE
```
**Notice, #10251 is for merging the user's configuration into authority
rule. Two of the issues are relevant, so please keep an eye on the other one.**
Currently, the proxy has supported authority rule configuration but can not
do authority governance through multiple proxies, which means when there is an
authority rule change, other proxies can receive the modification from a
zookeeper.
So the sub-tasks of this issue are,
1 Synchronize local authority configuration to zookeeper once proxy starts.
2 When authority rule is altered in zookeeper, proxies can receive this
change notification from the zookeeper and refresh its local metadata.
---
Once #10251 finishes, the following tasks are ready to begin.
3 The change of handling `CREATE USER` event
4 Remove the user node and user listener from governance.
From [zookeeper node
distribution](https://shardingsphere.apache.org/document/current/cn/features/governance/management/registry-center/),
we can know the directory tree of metadata in the zookeeper is the following
one. Finally, we aim at removing `users node` and adding a `global rule node`
like the following diagram shows,
```yaml
namespace
├──users # To be removed
├──props
├──rule # To be added
├──metadata
├ ├──${schema_1}
├ ├ ├──datasource
├ ├ ├──rule
├ ├ ├──schema
├ ├──${schema_2}
├ ├ ├──datasource
├ ├ ├──rule
├ ├ ├──schema
```
### How?
Sub-task-1
1 Add `GLOBAL_RULE_NODE` in `RegistryCenterNode` (Refer to `USERS_NODE`).
2 Add and implement `GlobalRuleChangedListener` in
`shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/listener/impl`
(Refer to `PropertiesChangedListener` and `RuleChangedListener`).
3 Modify `initConfigurations(final xx)` of
`GovernanceBootstrapInitializer` and `public void onlineInstance(xx, xx)` to
pass `global authority rule` to governance to persist it into its node.
Sub-task-2
1 Create `RuleConfigurationsChangedEvent` in
`shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/listener/event/rule`
2 Send this `RuleConfigurationsChangedEvent` in `GlobalRuleChangedListener`.
3 Subscribe and handle `RuleConfigurationsChangedEvent` in
`GovernanceMetaDataContexts` (Refer to the handling of
`RuleConfigurationsChangedEvent` and `PropertiesChangedEvent`).
4 Do some tests with the zookeeper to ensure a proxy can receive the event
and refresh its local metadata.
Sub-task-3
1 Rewrite the function of `public synchronized void renew(final
CreateUserStatementEvent event)` in `RegistryCenter`. Instead of persisting
the new info into `user node`, it is expected to create new
`YamlAuthorityRuleConfiguration` and put it into `rule node`.
2 Remove everything concerning `USERS_NODE` in`RegistryCenterNode`
3 Remove `UserChangedListener`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero opened a new issue #10251: [API Change] Move the user configuration to authority rule
tristaZero opened a new issue #10251:
URL: https://github.com/apache/shardingsphere/issues/10251
Hi, community,
This issue is to do API change of `server.yaml` of ShardingProxy. More
precisely to say, we plan to move the `user` configuration to the `authority`
rule module. Hope you can have a try and get .
### Target
Please change the configuration of `server.yaml` from
```yaml
users:
- root@%:root
- sharding@:sharding
rules:
- !AUTHORITY
provider:
type: NATIVE
```
**TO**
```yaml
rules:
- !AUTHORITY
users:
- root@%:root
- sharding@:sharding
provider:
type: NATIVE
```
### How?
There are two necessary sections to achieve it.
The refactoring of Yaml configuration
1 Move `users` from `YamlProxyServerConfiguration` to
`YamlAuthorityRuleConfiguration`
2 Move `YamlUsersConfigurationConverter` handling from
`YamlProxyConfigurationSwapper` to `AuthorityRuleConfigurationYamlSwapper`
3 Move `users` from `ProxyConfiguration` to `AuthorityRuleConfiguration`
4 Remove `persistUsers(users, isOverwrite);` of `RegistryCenter`
5 Move the relevant Unit test classes to corresponding packages.
### The change of User and authority initialization
1 Remove `users`, which has been stored in `AuthorityRuleConfiguration` from
`MetaDataContextsBuilder`
2 Remove `users` from the signature of
`ShardingSphereRulesBuilder.buildGlobalRules()`
3 Put `users` into `AuthorityRule` from `AuthorityRuleConfiguration`
4 Fix the Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #10135: Support governance for JDBC scenario
terrymanu commented on pull request #10135: URL: https://github.com/apache/shardingsphere/pull/10135#issuecomment-831162723 The travis still OOM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #10247: Update doc: Replace readwrite-splitting to replica-query in documents of spring-boot-starter
terrymanu closed pull request #10247: URL: https://github.com/apache/shardingsphere/pull/10247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere] branch master updated (59363a9 -> 79afd7d)
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from 59363a9 Update sysbench documents (#10250) add 79afd7d Complete testcases for PostgreSQLCommandExecuteEngineTest (#10249) No new revisions were added by this update. Summary of changes: .../PostgreSQLCommandExecuteEngineTest.java| 61 -- 1 file changed, 58 insertions(+), 3 deletions(-)
[GitHub] [shardingsphere] terrymanu merged pull request #10249: Complete testcases for PostgreSQLCommandExecuteEngine
terrymanu merged pull request #10249: URL: https://github.com/apache/shardingsphere/pull/10249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[shardingsphere] branch master updated (e75c7fb -> 59363a9)
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from e75c7fb support postgresql json & jsonb operator parse (#10244) add 59363a9 Update sysbench documents (#10250) No new revisions were added by this update. Summary of changes: .../test-engine/performance-test-sysbench.cn.md| 23 -- 1 file changed, 13 insertions(+), 10 deletions(-)
[GitHub] [shardingsphere] terrymanu merged pull request #10250: Update sysbench documents
terrymanu merged pull request #10250: URL: https://github.com/apache/shardingsphere/pull/10250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] TeslaCN opened a new pull request #10250: Update sysbench documents
TeslaCN opened a new pull request #10250: URL: https://github.com/apache/shardingsphere/pull/10250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10249: Complete testcases for PostgreSQLCommandExecuteEngineTest
codecov-commenter commented on pull request #10249: URL: https://github.com/apache/shardingsphere/pull/10249#issuecomment-831137080 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#10249](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3ba2be4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e75c7fbbb8b3900794a0206cf3c9cb8c1600a123?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e75c7fb) will **increase** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #10249 +/- ## + Coverage 67.95% 68.02% +0.06% Complexity 683 683 Files 1703 1703 Lines 2920629206 Branches 5252 5252 + Hits 1984819866 +18 + Misses 7829 7810 -19 - Partials 1529 1530 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...command/query/text/PostgreSQLComQueryExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/10249/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L3RleHQvUG9zdGdyZVNRTENvbVF1ZXJ5RXhlY3V0b3IuamF2YQ==) | `16.00% <0.00%> (+4.00%)` | `0.00% <0.00%> (ø%)` | | | [...gresql/command/PostgreSQLCommandExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10249/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL1Bvc3RncmVTUUxDb21tYW5kRXhlY3V0ZUVuZ2luZS5qYXZh) | `64.51% <0.00%> (+54.83%)` | `0.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [e75c7fb...3ba2be4](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] TeslaCN opened a new pull request #10249: Complete testcases for PostgreSQLCommandExecuteEngineTest
TeslaCN opened a new pull request #10249: URL: https://github.com/apache/shardingsphere/pull/10249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] TeslaCN opened a new issue #10248: Proxy PostgreSQL doesn't support PREPARE & EXECUTE
TeslaCN opened a new issue #10248:
URL: https://github.com/apache/shardingsphere/issues/10248
## Feature Request
### Is your feature request related to a problem?
### Describe the feature you would like.
PostgreSQL
When I use `psql` connect PostgreSQL directly
```
elasticjob=# prepare select_by_ip as select * from job_execution_log where
ip = $1 limit 3;
PREPARE
elasticjob=# execute select_by_ip ('192.168.3.233');
id | job_name |
task_id | hostname| ip |
shard
ing_item | execution_source | failure_cause | is_success | start_time
| complete_time
--+++---+---+--
-+--+---++-+-
3a13b73a-1287-4011-814f-06e72e5e4631 | my-dag-job |
my-dag-job@-@0,1,2,3,4,5,6,7,8,9@-@READY@-@192.168.3.233@-@1951901 |
local-wwj-icu | 192.168.3.233 |
1 | NORMAL_TRIGGER | | t | 2020-09-14
20:18:20.097 | 2020-09-14 20:18:20.098
8448933a-545d-4508-b446-d0a0d565f5ca | simple |
simple@-@0,1,2@-@READY@-@192.168.3.233@-@3501515 |
local-wwj-icu | 192.168.3.233 |
1 | NORMAL_TRIGGER | | t | 2020-09-04
23:17:35.162 | 2020-09-04 23:17:35.174
7150464c-674e-4e81-a43b-b11a7b1099df | simple |
simple@-@0,1,2@-@READY@-@192.168.3.233@-@3501515 |
local-wwj-icu | 192.168.3.233 |
2 | NORMAL_TRIGGER | | t | 2020-09-04
23:17:35.162 | 2020-09-04 23:17:35.174
(3 rows)
```
Proxy PostgreSQL
```
hello_ss=> prepare select_by_user as select * from t_order where user_id =
$1;
ERROR: You have an error in your SQL syntax
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
