[GitHub] [incubator-shardingsphere-doc] KomachiSion closed issue #174: Update JNDI datasource usage and configuration example for spring-boot-starter

2019-05-12 Thread GitBox
KomachiSion closed issue #174: Update JNDI datasource usage and configuration example for spring-boot-starter URL: https://github.com/apache/incubator-shardingsphere-doc/issues/174 This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] Harper0122 opened a new issue #2372: Weekly Report of ShardingSphere (2019.5.6-2019.5.10)

2019-05-12 Thread GitBox
Harper0122 opened a new issue #2372: Weekly Report of ShardingSphere (2019.5.6-2019.5.10) URL: https://github.com/apache/incubator-shardingsphere/issues/2372 This report is to review recent changes and developments of ShardingSphere. ## Basic Data Basic data shows how the

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
AlbertTao edited a comment on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491655240 Actually We have some `Statement` in old projects. So We want to know if there is any optimization

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491655240 Actually We have some `Statement` in old projects. So I want to know if there is any optimization plan for

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
AlbertTao edited a comment on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491190045 Although the document suggests us to use "PrepareStatement", I still think that the "Statement"

[GitHub] [incubator-shardingsphere-example] KevinQian commented on issue #135: sharding-spring-boot-mybatis-example startup failed

2019-05-12 Thread GitBox
KevinQian commented on issue #135: sharding-spring-boot-mybatis-example startup failed URL: https://github.com/apache/incubator-shardingsphere-example/issues/135#issuecomment-491669938 > hi, please 'git checkout 4.0.0-RC1' > or you can clone our

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491690111 please see https://github.com/sharding-sphere/shardingsphere-spi-impl

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2287: Weekly Report of ShardingSphere (2019.4.8 to 2019.4.12)

2019-05-13 Thread GitBox
terrymanu closed issue #2287: Weekly Report of ShardingSphere (2019.4.8 to 2019.4.12) URL: https://github.com/apache/incubator-shardingsphere/issues/2287 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] jasonlong10 commented on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing

2019-05-12 Thread GitBox
jasonlong10 commented on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing URL: https://github.com/apache/incubator-shardingsphere/issues/2368#issuecomment-491664051 This class is not complete ?

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-13 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-13 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-13 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
coveralls commented on issue #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373#issuecomment-491692613 ## Pull Request Test Coverage Report for [Build 8021](https://coveralls.io/builds/23342155) * **15** of **28**

[GitHub] [incubator-shardingsphere] Anricx opened a new issue #2369: Sharding-JDBC 4.0.0-RC1 Compatibility?

2019-05-12 Thread GitBox
Anricx opened a new issue #2369: Sharding-JDBC 4.0.0-RC1 Compatibility? URL: https://github.com/apache/incubator-shardingsphere/issues/2369 I'm trying to upgrade from legacy version 2.0.6 -> `Sharding-JDBC 4.0.0-RC1`, here I have many compatibility issue, such as: - FORCE INDEX will

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2370: refactor Conditions => ParseCondition

2019-05-12 Thread GitBox
terrymanu merged pull request #2370: refactor Conditions => ParseCondition URL: https://github.com/apache/incubator-shardingsphere/pull/2370 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491715108 You can take a look at `org.apache.shardingsphere.core.parse.ShardingSQLParseEngine`

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2341: How to dynamic table in v3.1?

2019-05-12 Thread GitBox
terrymanu commented on issue #2341: How to dynamic table in v3.1? URL: https://github.com/apache/incubator-shardingsphere/issues/2341#issuecomment-491655994 I will close this issue soon if no response any more This is an

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
terrymanu commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491655818 If user use statement, we can assume they don't care about the performance

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2374: Reconstruct SchemaToken and IndexToken

2019-05-13 Thread GitBox
tristaZero opened a new pull request #2374: Reconstruct SchemaToken and IndexToken URL: https://github.com/apache/incubator-shardingsphere/pull/2374 #2275 - [x] Question in EncryptWhereColumnPlaceholder, between should not supported - [x] Should not call SQLUtil.getExactlyValue on

[GitHub] [incubator-shardingsphere-example] KevinQian opened a new issue #138: Can't download sharding-transaction-spring-boot-starter dependency in sharding-proxy-example

2019-05-12 Thread GitBox
KevinQian opened a new issue #138: Can't download sharding-transaction-spring-boot-starter dependency in sharding-proxy-example URL: https://github.com/apache/incubator-shardingsphere-example/issues/138 Hi, cherry. I got shardingsphere and shardingsphere exmaples from github. the version

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
terrymanu merged pull request #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-13 Thread GitBox
AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491701233 Is there an interface to load sql or warm-up parsing engine now?

[GitHub] [incubator-shardingsphere] KevinQian commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
KevinQian commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491701523 > please see https://github.com/sharding-sphere/shardingsphere-spi-impl thanks, cherry. I

[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
cherrylzhao edited a comment on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491703075 we'd like to move it after `sharding-transaction-spring-boot` is statable. currently it

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-13 Thread GitBox
cherrylzhao commented on issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371#issuecomment-491703075 we'd like to move it after `sharding-transaction-spring-boot` is statable. currently id depends

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491666907 > If user use statement, we can assume they don't care about the performance Let's aside from `statement`,

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
AlbertTao commented on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491666994 Let's aside from `statement`, is there any optimization for the first parsing of the Antlr parsing engine in

[GitHub] [incubator-shardingsphere] AlbertTao removed a comment on issue #2365: Will the performance of sharding-jdbc be optimized?

2019-05-12 Thread GitBox
AlbertTao removed a comment on issue #2365: Will the performance of sharding-jdbc be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/2365#issuecomment-491666907 > If user use statement, we can assume they don't care about the performance Let's aside from

[GitHub] [incubator-shardingsphere] KevinQian opened a new issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-12 Thread GitBox
KevinQian opened a new issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371 Hi, guys. I got shardingsphere and shardingsphere exmaples from github. the version is 4.0.0.RC1. But when I ran

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
tristaZero opened a new pull request #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373 #2275 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing

2019-05-12 Thread GitBox
terrymanu commented on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing URL: https://github.com/apache/incubator-shardingsphere/issues/2368#issuecomment-491667729 We are change distributed key's api, please read document first

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing

2019-05-12 Thread GitBox
terrymanu closed issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing URL: https://github.com/apache/incubator-shardingsphere/issues/2368 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
tristaZero edited a comment on issue #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373#issuecomment-491688473 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x]

[GitHub] [incubator-shardingsphere] jasonlong10 opened a new issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing

2019-05-12 Thread GitBox
jasonlong10 opened a new issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing URL: https://github.com/apache/incubator-shardingsphere/issues/2368 In current dev branch, method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing.

[GitHub] [incubator-shardingsphere] jasonlong10 commented on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing

2019-05-12 Thread GitBox
jasonlong10 commented on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing URL: https://github.com/apache/incubator-shardingsphere/issues/2368#issuecomment-491661384 Method "SnowflakeShardingKeyGenerator.setMaxTolerateTimeDifferenceMilliseconds" is also

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2369: Sharding-JDBC 4.0.0-RC1 Compatibility?

2019-05-12 Thread GitBox
terrymanu commented on issue #2369: Sharding-JDBC 4.0.0-RC1 Compatibility? URL: https://github.com/apache/incubator-shardingsphere/issues/2369#issuecomment-491668051 And all test cases are passed. If some SQL cannot pass, could you provide the SQL to let us add to test case?

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing

2019-05-12 Thread GitBox
terrymanu edited a comment on issue #2368: Method "SnowflakeShardingKeyGenerator.setWorkerId()" is missing URL: https://github.com/apache/incubator-shardingsphere/issues/2368#issuecomment-491667729 We just changed distributed key's api, please read document first

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #2370: refactor Conditions => ParseCondition

2019-05-12 Thread GitBox
cherrylzhao opened a new pull request #2370: refactor Conditions => ParseCondition URL: https://github.com/apache/incubator-shardingsphere/pull/2370 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2363: #2191 MySQL encrypt test

2019-05-13 Thread GitBox
coveralls commented on issue #2363: #2191 MySQL encrypt test URL: https://github.com/apache/incubator-shardingsphere/pull/2363#issuecomment-491697869 ## Pull Request Test Coverage Report for [Build 8022](https://coveralls.io/builds/23342503) * **0** of **6** **(0.0%)** changed

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2373: Optimize all the rewrite engines

2019-05-13 Thread GitBox
tristaZero edited a comment on issue #2373: Optimize all the rewrite engines URL: https://github.com/apache/incubator-shardingsphere/pull/2373#issuecomment-491688473 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x]

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #2389: sharding-proxy fail to handle '0000-00-00 00:00:00' Timestamp result

2019-05-16 Thread GitBox
tuohai666 closed issue #2389: sharding-proxy fail to handle '-00-00 00:00:00' Timestamp result URL: https://github.com/apache/incubator-shardingsphere/issues/2389 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] haj8888888 opened a new issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of

2019-05-15 Thread GitBox
haj888 opened a new issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391 Code screenshot:

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #2105: `java.io.NotSerializableException` occurred when setting parameters into PreparedStatement

2019-05-15 Thread GitBox
tuohai666 closed issue #2105: `java.io.NotSerializableException` occurred when setting parameters into PreparedStatement URL: https://github.com/apache/incubator-shardingsphere/issues/2105 This is an automated message from

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2105: `java.io.NotSerializableException` occurred when setting parameters into PreparedStatement

2019-05-15 Thread GitBox
tuohai666 commented on issue #2105: `java.io.NotSerializableException` occurred when setting parameters into PreparedStatement URL: https://github.com/apache/incubator-shardingsphere/issues/2105#issuecomment-492892572 Fixed via https://github.com/apache/incubator-shardingsphere/pull/2388.

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2181: java.io.NotSerializableException: java.io.StringReader

2019-05-15 Thread GitBox
tuohai666 commented on issue #2181: java.io.NotSerializableException: java.io.StringReader URL: https://github.com/apache/incubator-shardingsphere/issues/2181#issuecomment-492892528 Fixed via https://github.com/apache/incubator-shardingsphere/pull/2388.

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #2181: java.io.NotSerializableException: java.io.StringReader

2019-05-15 Thread GitBox
tuohai666 closed issue #2181: java.io.NotSerializableException: java.io.StringReader URL: https://github.com/apache/incubator-shardingsphere/issues/2181 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] 799983050 closed issue #2359: shardingproxy 4.0.0-RC2:insert no field grammar execution error

2019-05-15 Thread GitBox
799983050 closed issue #2359: shardingproxy 4.0.0-RC2:insert no field grammar execution error URL: https://github.com/apache/incubator-shardingsphere/issues/2359 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2390: shading-jdbc does not support multiline sql execution

2019-05-15 Thread GitBox
terrymanu commented on issue #2390: shading-jdbc does not support multiline sql execution URL: https://github.com/apache/incubator-shardingsphere/issues/2390#issuecomment-492900233 Execute multiple SQL with different sharding key is too complicated, the performance is not good too.

[GitHub] [incubator-shardingsphere] Li-Turing commented on issue #2394: too slow when application running, version:4.0.0-RC1

2019-05-15 Thread GitBox
Li-Turing commented on issue #2394: too slow when application running,version:4.0.0-RC1 URL: https://github.com/apache/incubator-shardingsphere/issues/2394#issuecomment-492900078 @tristaZero This is an automated message

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2390: shading-jdbc does not support multiline sql execution

2019-05-15 Thread GitBox
terrymanu closed issue #2390: shading-jdbc does not support multiline sql execution URL: https://github.com/apache/incubator-shardingsphere/issues/2390 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] DaC1989 commented on issue #2392: can I not use sql parse?

2019-05-15 Thread GitBox
DaC1989 commented on issue #2392: can I not use sql parse? URL: https://github.com/apache/incubator-shardingsphere/issues/2392#issuecomment-492903698 Maybe it's not a customized requirement. When sharding-jdbc can't support any sql, we can pass sql parse. But now, I have to write

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2335: Support distributed transaction by integrating seata.

2019-05-15 Thread GitBox
cherrylzhao commented on issue #2335: Support distributed transaction by integrating seata. URL: https://github.com/apache/incubator-shardingsphere/issues/2335#issuecomment-492922354 we have made a design for `using Seata AT transaction in ShardingSphere`

[GitHub] [incubator-shardingsphere] haj8888888 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of

2019-05-16 Thread GitBox
haj888 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492929219 >

[GitHub] [incubator-shardingsphere] Li-Turing opened a new issue #2394: slow

2019-05-15 Thread GitBox
Li-Turing opened a new issue #2394: slow URL: https://github.com/apache/incubator-shardingsphere/issues/2394 application run slowly when i use default-datasource-name shardingsphere will load shardingContext and connect to db,why do this? there is much tables and colums, when

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of r

2019-05-15 Thread GitBox
tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492914167

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2395: Move appendedIndexAndParameters to local parameter

2019-05-15 Thread GitBox
terrymanu merged pull request #2395: Move appendedIndexAndParameters to local parameter URL: https://github.com/apache/incubator-shardingsphere/pull/2395 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of r

2019-05-15 Thread GitBox
tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492917394

[GitHub] [incubator-shardingsphere] DaC1989 opened a new issue #2392: can I not use sql parse?

2019-05-15 Thread GitBox
DaC1989 opened a new issue #2392: can I not use sql parse? URL: https://github.com/apache/incubator-shardingsphere/issues/2392 ## Question sometimes sql parse do not support my sql: `org.apache.shardingsphere.core.parse.exception.SQLParsingUnsupportedException: Unsupported SQL of

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2359: shardingproxy 4.0.0-RC2:insert no field grammar execution error

2019-05-15 Thread GitBox
terrymanu commented on issue #2359: shardingproxy 4.0.0-RC2:insert no field grammar execution error URL: https://github.com/apache/incubator-shardingsphere/issues/2359#issuecomment-492901829 Closed by issue creator and cloud not provide necessary information, I just set the issue as

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2392: can I not use sql parse?

2019-05-15 Thread GitBox
terrymanu commented on issue #2392: can I not use sql parse? URL: https://github.com/apache/incubator-shardingsphere/issues/2392#issuecomment-49290 How to sharding if pass sql parse? This is an automated message from the

[GitHub] [incubator-shardingsphere] haj8888888 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of

2019-05-16 Thread GitBox
haj888 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492930599 >

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2389: sharding-proxy fail to handle '0000-00-00 00:00:00' Timestamp result

2019-05-15 Thread GitBox
tuohai666 commented on issue #2389: sharding-proxy fail to handle '-00-00 00:00:00' Timestamp result URL: https://github.com/apache/incubator-shardingsphere/issues/2389#issuecomment-492896031 I can't reproduce:

[GitHub] [incubator-shardingsphere] haj8888888 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of

2019-05-15 Thread GitBox
haj888 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492916239 >

[GitHub] [incubator-shardingsphere-doc] Harper0122 opened a new pull request #178: Orchestration

2019-05-16 Thread GitBox
Harper0122 opened a new pull request #178: Orchestration URL: https://github.com/apache/incubator-shardingsphere-doc/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] softwbc opened a new issue #2393: Error when use "spring.jpa.hibernate.naming.physical-strategy"

2019-05-15 Thread GitBox
softwbc opened a new issue #2393: Error when use "spring.jpa.hibernate.naming.physical-strategy" URL: https://github.com/apache/incubator-shardingsphere/issues/2393 sharding-jdbc-spring-boot-starter 3.1.0 spring-boot-starter-parent 2.0.4.RELEASE application.properties:

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #176: Read-write Split

2019-05-15 Thread GitBox
terrymanu merged pull request #176: Read-write Split URL: https://github.com/apache/incubator-shardingsphere-doc/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2371: where is the sharding-transaction-spring-boot-starter module?

2019-05-15 Thread GitBox
terrymanu closed issue #2371: where is the sharding-transaction-spring-boot-starter module? URL: https://github.com/apache/incubator-shardingsphere/issues/2371 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2359: shardingproxy 4.0.0-RC2:insert no field grammar execution error

2019-05-15 Thread GitBox
terrymanu commented on issue #2359: shardingproxy 4.0.0-RC2:insert no field grammar execution error URL: https://github.com/apache/incubator-shardingsphere/issues/2359#issuecomment-492899392 Hi, can you follow template which can provide more necessary information to help us understand

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2361: about 11000000 data insertion,just find 21000data success,there is no any errors i could find.

2019-05-15 Thread GitBox
terrymanu closed issue #2361: about 1100 data insertion,just find 21000data success,there is no any errors i could find. URL: https://github.com/apache/incubator-shardingsphere/issues/2361 This is an automated message

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #2395: Move appendedIndexAndParameters to local parameter

2019-05-15 Thread GitBox
tristaZero opened a new pull request #2395: Move appendedIndexAndParameters to local parameter URL: https://github.com/apache/incubator-shardingsphere/pull/2395 Ref #2386 This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of r

2019-05-15 Thread GitBox
tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492915643 I

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of r

2019-05-15 Thread GitBox
tuohai666 commented on issue #2391: After using the sharding-proxy sub-table to sub-table, use the PageHelper plug-in to query one-to-many data, and the number of returned records is incorrect. URL: https://github.com/apache/incubator-shardingsphere/issues/2391#issuecomment-492918163 1.

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #2398: Wrong result set for `select between and` when using encrypt data source

2019-05-16 Thread GitBox
tristaZero opened a new issue #2398: Wrong result set for `select between and` when using encrypt data source URL: https://github.com/apache/incubator-shardingsphere/issues/2398 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2397: MasterSlaveDatasource and shardingDatasource could be used together in shardingproxy?

2019-05-17 Thread GitBox
terrymanu commented on issue #2397: MasterSlaveDatasource and shardingDatasource could be used together in shardingproxy? URL: https://github.com/apache/incubator-shardingsphere/issues/2397#issuecomment-493484029 Can you take a look on the document?

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2346: mysql client can't get the proxy configuration dynamically.

2019-05-17 Thread GitBox
tristaZero commented on issue #2346: mysql client can't get the proxy configuration dynamically. URL: https://github.com/apache/incubator-shardingsphere/issues/2346#issuecomment-493424441 Thanks for your pictures to make this issue clearer, can you use 4.0.0-RC1 or 3.1.0 to test this

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2452: force index primary

2019-05-27 Thread GitBox
terrymanu commented on issue #2452: force index primary URL: https://github.com/apache/incubator-shardingsphere/issues/2452#issuecomment-496214582 Another information I want to update is ShardingSphere don't change index for MySQL, it only change index name for PostgreSQL and Oracle

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2452: force index primary

2019-05-27 Thread GitBox
terrymanu commented on issue #2452: force index primary URL: https://github.com/apache/incubator-shardingsphere/issues/2452#issuecomment-496213534 I never try to with MariaDB. But I think maybe we don't support MariaDB now.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2454: How to set dynamic workerId

2019-05-27 Thread GitBox
terrymanu commented on issue #2454: How to set dynamic workerId URL: https://github.com/apache/incubator-shardingsphere/issues/2454#issuecomment-496215512 Hi, your issue do not include any context, can you provide more necessary information follow by template blow? ## Bug Report

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2406: select Range determination of dynamic tables

2019-05-27 Thread GitBox
terrymanu closed issue #2406: select Range determination of dynamic tables URL: https://github.com/apache/incubator-shardingsphere/issues/2406 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2406: select Range determination of dynamic tables

2019-05-27 Thread GitBox
terrymanu commented on issue #2406: select Range determination of dynamic tables URL: https://github.com/apache/incubator-shardingsphere/issues/2406#issuecomment-496215799 No update any more, I just close this issue This is

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #2418: saga transaction error

2019-05-24 Thread GitBox
cherrylzhao commented on issue #2418: saga transaction error URL: https://github.com/apache/incubator-shardingsphere/issues/2418#issuecomment-495804036 any feedback for this issue,can you close it? This is an automated

[GitHub] [incubator-shardingsphere] HanWang945 commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)

2019-05-24 Thread GitBox
HanWang945 commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-495827807 百果园 http://www.pagoda.com.cn/水果零售企业

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2446: Added additional Unit Tests to increase code coverage

2019-05-24 Thread GitBox
terrymanu commented on issue #2446: Added additional Unit Tests to increase code coverage URL: https://github.com/apache/incubator-shardingsphere/pull/2446#issuecomment-495822468 Unfortunately, we just refactor the target class of this test case, which cause the new test cases compile

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2439: springboot2.0 demo???

2019-05-24 Thread GitBox
terrymanu commented on issue #2439: springboot2.0 demo??? URL: https://github.com/apache/incubator-shardingsphere/issues/2439#issuecomment-495821949 @edidada Thank you, the pull request can be to https://github.com/apache/incubator-shardingsphere-example/issues We have already spring

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2442: '-Long.MAX_VALUE' in assertSetWorkerIdFailureWhenTooMuch() method is not reasonable

2019-05-24 Thread GitBox
terrymanu closed issue #2442: '-Long.MAX_VALUE' in assertSetWorkerIdFailureWhenTooMuch() method is not reasonable URL: https://github.com/apache/incubator-shardingsphere/issues/2442 This is an automated message from the

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2446: Added additional Unit Tests to increase code coverage

2019-05-27 Thread GitBox
coveralls commented on issue #2446: Added additional Unit Tests to increase code coverage URL: https://github.com/apache/incubator-shardingsphere/pull/2446#issuecomment-496277060 ## Pull Request Test Coverage Report for [Build 8245](https://coveralls.io/builds/23633546) * **0** of

[GitHub] [incubator-shardingsphere] TheRealHaui commented on issue #2446: Added additional Unit Tests to increase code coverage

2019-05-27 Thread GitBox
TheRealHaui commented on issue #2446: Added additional Unit Tests to increase code coverage URL: https://github.com/apache/incubator-shardingsphere/pull/2446#issuecomment-496272361 @terrymanu, no problem. This is an

[GitHub] [incubator-shardingsphere] baisijian opened a new issue #2447: Question about ORDER_BY_DERIVED_xxx

2019-05-25 Thread GitBox
baisijian opened a new issue #2447: Question about ORDER_BY_DERIVED_xxx URL: https://github.com/apache/incubator-shardingsphere/issues/2447 ## Question sharding-jdbc will add some colum into sql, eg:ORDER_BY_DERIVED_xx I want to know why? and how can i get rid of them? **For

[GitHub] [incubator-shardingsphere] piantoutongyang opened a new issue #2448: 使用springboot2项目+官方的配置,启动报错。

2019-05-25 Thread GitBox
piantoutongyang opened a new issue #2448: 使用springboot2项目+官方的配置,启动报错。 URL: https://github.com/apache/incubator-shardingsphere/issues/2448 错误提示: org.springframework.beans.factory.support.BeanDefinitionOverrideException: Invalid bean definition with name 'dataSource' defined in class path

[GitHub] [incubator-shardingsphere] wgy8283335 opened a new pull request #2449: Add new key generator "LeafSegmentKeyGenerator" and related functions.

2019-05-25 Thread GitBox
wgy8283335 opened a new pull request #2449: Add new key generator "LeafSegmentKeyGenerator" and related functions. URL: https://github.com/apache/incubator-shardingsphere/pull/2449 Fixes #1775. Changes proposed in this pull request: - Add new key generator

[GitHub] [incubator-shardingsphere] finnlee87 opened a new issue #2459: can sharding-proxy use on production env?

2019-05-28 Thread GitBox
finnlee87 opened a new issue #2459: can sharding-proxy use on production env? URL: https://github.com/apache/incubator-shardingsphere/issues/2459 Can sharding-proxy use on production env? This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2449: Add new key generator "LeafSegmentKeyGenerator" and related functions.

2019-05-27 Thread GitBox
terrymanu commented on issue #2449: Add new key generator "LeafSegmentKeyGenerator" and related functions. URL: https://github.com/apache/incubator-shardingsphere/pull/2449#issuecomment-496350340 Nice work, thank you. Let @tristaZero to review it.

[GitHub] [incubator-shardingsphere] zhouchangjiang commented on issue #2132: ResultSetMetaData for Encrypt ResultSet

2019-05-27 Thread GitBox
zhouchangjiang commented on issue #2132: ResultSetMetaData for Encrypt ResultSet URL: https://github.com/apache/incubator-shardingsphere/issues/2132#issuecomment-496326992 hello @tristaZero , @terrymanu I have a question about this issues. When the following SQL statement is

  1   2   3   4   5   6   7   8   9   10   >