[GitHub] [shardingsphere] tristaZero merged pull request #10235: Rename module name from read-write-splitting to readwrite-splitting

2021-05-01 Thread GitBox
tristaZero merged pull request #10235: URL: https://github.com/apache/shardingsphere/pull/10235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10234: Correct transaction state when PostgreSQL ready for query

2021-05-01 Thread GitBox
codecov-commenter commented on pull request #10234: URL: https://github.com/apache/shardingsphere/pull/10234#issuecomment-830625790 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10234: Correct transaction state when PostgreSQL ready for query

2021-05-01 Thread GitBox
codecov-commenter edited a comment on pull request #10234: URL: https://github.com/apache/shardingsphere/pull/10234#issuecomment-830625790 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] terrymanu opened a new pull request #10236: Rename read-write to readwrite

2021-05-01 Thread GitBox
terrymanu opened a new pull request #10236: URL: https://github.com/apache/shardingsphere/pull/10236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] TeslaCN merged pull request #10236: Rename read-write to readwrite

2021-05-01 Thread GitBox
TeslaCN merged pull request #10236: URL: https://github.com/apache/shardingsphere/pull/10236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] TeslaCN opened a new issue #10237: PostgreSQLComBindPacket read data length more than actual column length

2021-05-01 Thread GitBox
TeslaCN opened a new issue #10237: URL: https://github.com/apache/shardingsphere/issues/10237 ## Bug Report ### Which version of ShardingSphere did you use? master ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy? Proxy ### Expected behavi

[GitHub] [shardingsphere] terrymanu opened a new pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

2021-05-01 Thread GitBox
terrymanu opened a new pull request #10238: URL: https://github.com/apache/shardingsphere/pull/10238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

2021-05-01 Thread GitBox
codecov-commenter commented on pull request #10238: URL: https://github.com/apache/shardingsphere/pull/10238#issuecomment-830684473 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #10214: Support alter database grammar

2021-05-01 Thread GitBox
Liangda-w commented on a change in pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#discussion_r624573866 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/BaseRule.g4

[GitHub] [shardingsphere] TeslaCN commented on pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

2021-05-01 Thread GitBox
TeslaCN commented on pull request #10238: URL: https://github.com/apache/shardingsphere/pull/10238#issuecomment-830730635 ![image](https://user-images.githubusercontent.com/20503072/116800433-a2ec2980-ab33-11eb-896f-64e1b0666d79.png) ![image](https://user-images.githubusercontent.co

[GitHub] [shardingsphere] tristaZero opened a new pull request #10239: Instead of save() with two interfaces.

2021-05-01 Thread GitBox
tristaZero opened a new pull request #10239: URL: https://github.com/apache/shardingsphere/pull/10239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere] terrymanu commented on pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

2021-05-01 Thread GitBox
terrymanu commented on pull request #10238: URL: https://github.com/apache/shardingsphere/pull/10238#issuecomment-830740710 > The client send a 3-byte integer and `UnsupportedOperationException` occurred. The exception comes from text format, I will fix it at next pr -- This is an

[GitHub] [shardingsphere] terrymanu merged pull request #10239: Instead of save() with two interfaces.

2021-05-01 Thread GitBox
terrymanu merged pull request #10239: URL: https://github.com/apache/shardingsphere/pull/10239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] TeslaCN merged pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

2021-05-01 Thread GitBox
TeslaCN merged pull request #10238: URL: https://github.com/apache/shardingsphere/pull/10238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] terrymanu opened a new pull request #10240: Support text parameter with bind for PostgreSQL

2021-05-01 Thread GitBox
terrymanu opened a new pull request #10240: URL: https://github.com/apache/shardingsphere/pull/10240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] TeslaCN commented on pull request #10240: Support text parameter with bind for PostgreSQL

2021-05-01 Thread GitBox
TeslaCN commented on pull request #10240: URL: https://github.com/apache/shardingsphere/pull/10240#issuecomment-830756359 ``` [ERROR] 13:58:08.027 [pool-5-thread-1] o.a.s.p.f.c.CommandExecutorTask - Exception occur: groovy.lang.MissingMethodException: No signature of method: java.la

[GitHub] [shardingsphere] tristaZero opened a new pull request #10241: Fix the hostname of grantee after proxy test

2021-05-01 Thread GitBox
tristaZero opened a new pull request #10241: URL: https://github.com/apache/shardingsphere/pull/10241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere] TeslaCN merged pull request #10240: Support text parameter with bind for PostgreSQL

2021-05-01 Thread GitBox
TeslaCN merged pull request #10240: URL: https://github.com/apache/shardingsphere/pull/10240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] terrymanu merged pull request #10241: Fix the hostname of grantee after proxy test

2021-05-01 Thread GitBox
terrymanu merged pull request #10241: URL: https://github.com/apache/shardingsphere/pull/10241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10242: Write and flush ReadyForQuery once received sync

2021-05-01 Thread GitBox
TeslaCN opened a new pull request #10242: URL: https://github.com/apache/shardingsphere/pull/10242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] terrymanu merged pull request #10242: Write and flush ReadyForQuery once received sync

2021-05-02 Thread GitBox
terrymanu merged pull request #10242: URL: https://github.com/apache/shardingsphere/pull/10242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] TeslaCN closed issue #10237: PostgreSQLComBindPacket read data length more than actual column length

2021-05-02 Thread GitBox
TeslaCN closed issue #10237: URL: https://github.com/apache/shardingsphere/issues/10237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [shardingsphere] terrymanu opened a new pull request #10243: Force true with transaction process for PostgreSQLReadyForQueryPacket

2021-05-02 Thread GitBox
terrymanu opened a new pull request #10243: URL: https://github.com/apache/shardingsphere/pull/10243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] TeslaCN merged pull request #10243: Force true with transaction process for PostgreSQLReadyForQueryPacket

2021-05-02 Thread GitBox
TeslaCN merged pull request #10243: URL: https://github.com/apache/shardingsphere/pull/10243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

2021-05-02 Thread GitBox
tristaZero commented on a change in pull request #10217: URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r624659438 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseT

[GitHub] [shardingsphere] tristaZero commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-05-02 Thread GitBox
tristaZero commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-830776202 Hi, `sub query` is supported better from the 5.x release, could you try the 5.0.0-alpha? -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [shardingsphere] tristaZero commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-05-02 Thread GitBox
tristaZero commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-830776498 Thanks @huanghao495430759, @wangkang09 @huanghao495430759 tries the 5.0.0-alpha with your case, and everything works well. Please provide more details here.

[GitHub] [shardingsphere] tristaZero commented on pull request #10193: fix bad rewritten result for foreign key SQL

2021-05-02 Thread GitBox
tristaZero commented on pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#issuecomment-830776710 Hi , so could we merge this PR for more supported cases? But the CI is still failing. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [shardingsphere] strongduanmu commented on pull request #10193: fix bad rewritten result for foreign key SQL

2021-05-02 Thread GitBox
strongduanmu commented on pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#issuecomment-830777676 > Hi , so could we merge this PR for more supported cases? But the CI is still failing. @tristaZero OK, I will fix the ci exception. -- This is an automat

[GitHub] [shardingsphere] terrymanu commented on pull request #9967: Issue#9948 refactor TablesContext

2021-05-02 Thread GitBox
terrymanu commented on pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-830778141 > Any suggestion or question ? @tristaZero @terrymanu Hi, What is variable name `seen` mean? -- This is an automated message from the Apache Git Service. To res

[GitHub] [shardingsphere] TeslaCN commented on pull request #10234: Correct transaction state when PostgreSQL ready for query

2021-05-02 Thread GitBox
TeslaCN commented on pull request #10234: URL: https://github.com/apache/shardingsphere/pull/10234#issuecomment-830778168 I'll do this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [shardingsphere] TeslaCN closed pull request #10234: Correct transaction state when PostgreSQL ready for query

2021-05-02 Thread GitBox
TeslaCN closed pull request #10234: URL: https://github.com/apache/shardingsphere/pull/10234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10193: fix bad rewritten result for foreign key SQL

2021-05-02 Thread GitBox
codecov-commenter edited a comment on pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#issuecomment-826483708 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] zhujunxxxxx commented on a change in pull request #10214: Support alter database grammar

2021-05-02 Thread GitBox
zhujunx commented on a change in pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#discussion_r624684883 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/BaseRule.g

[GitHub] [shardingsphere] codecov-commenter commented on pull request #9934: Query optimization for federated SQL query

2021-05-02 Thread GitBox
codecov-commenter commented on pull request #9934: URL: https://github.com/apache/shardingsphere/pull/9934#issuecomment-830816603 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[GitHub] [shardingsphere] strongduanmu opened a new pull request #10244: support postgresql json & jsonb operator parse

2021-05-02 Thread GitBox
strongduanmu opened a new pull request #10244: URL: https://github.com/apache/shardingsphere/pull/10244 Fixes #7951. Ref #10089. Changes proposed in this pull request: - support postgresql json & jsonb operator parse - add postgresql json & jsonb operator parse test case

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10214: Support alter database grammar

2021-05-02 Thread GitBox
codecov-commenter edited a comment on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-828546318 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10244: support postgresql json & jsonb operator parse

2021-05-02 Thread GitBox
codecov-commenter commented on pull request #10244: URL: https://github.com/apache/shardingsphere/pull/10244#issuecomment-830830128 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10245: Fix ReadyForQuery may be missing when Simple Query

2021-05-02 Thread GitBox
TeslaCN opened a new pull request #10245: URL: https://github.com/apache/shardingsphere/pull/10245 I've tested it by sysbench and simplily tested it by psql. I don't think some FATAL about transaction is related to this PR. ``` sysbench 1.0.20 (using bundled LuaJIT 2.1.0-beta2

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10245: Fix ReadyForQuery may be missing when Simple Query

2021-05-02 Thread GitBox
codecov-commenter commented on pull request #10245: URL: https://github.com/apache/shardingsphere/pull/10245#issuecomment-830859896 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] weiyue888999 opened a new pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency

2021-05-02 Thread GitBox
weiyue888999 opened a new pull request #10246: URL: https://github.com/apache/shardingsphere/pull/10246 Fixes #ISSUSE_ID. Changes proposed in this pull request: 解决example模块下,缺乏shardingsphere-read-write-splitting-api依赖的问题 -- This is an automated message from the Apache Git Se

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency

2021-05-02 Thread GitBox
codecov-commenter commented on pull request #10246: URL: https://github.com/apache/shardingsphere/pull/10246#issuecomment-830999831 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] terrymanu merged pull request #10245: Fix ReadyForQuery may be missing when Simple Query

2021-05-02 Thread GitBox
terrymanu merged pull request #10245: URL: https://github.com/apache/shardingsphere/pull/10245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency

2021-05-02 Thread GitBox
terrymanu commented on a change in pull request #10246: URL: https://github.com/apache/shardingsphere/pull/10246#discussion_r624865069 ## File path: examples/pom.xml ## @@ -167,6 +167,11 @@ shardingsphere-infra-common ${shardingsphere.version}

[GitHub] [shardingsphere] terrymanu merged pull request #10244: support postgresql json & jsonb operator parse

2021-05-02 Thread GitBox
terrymanu merged pull request #10244: URL: https://github.com/apache/shardingsphere/pull/10244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu closed issue #7951: Not support json for PostgreSQL

2021-05-02 Thread GitBox
terrymanu closed issue #7951: URL: https://github.com/apache/shardingsphere/issues/7951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10214: Support alter database grammar

2021-05-02 Thread GitBox
codecov-commenter edited a comment on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-828546318 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] Switch-vov opened a new pull request #10247: Replace readwrite-splitting to replica-query in documents of spring-boot-starter

2021-05-02 Thread GitBox
Switch-vov opened a new pull request #10247: URL: https://github.com/apache/shardingsphere/pull/10247 Changes proposed in this pull request: - Replace readwrite-splitting to replica-query in documents of spring-boot-starter -- This is an automated message from the Apache Git Service.

[GitHub] [shardingsphere] Switch-vov commented on pull request #10247: Replace readwrite-splitting to replica-query in documents of spring-boot-starter

2021-05-02 Thread GitBox
Switch-vov commented on pull request #10247: URL: https://github.com/apache/shardingsphere/pull/10247#issuecomment-831015517 When i read the [读写分离](https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-jdbc/configuration/spring-boot-starter/readwrite-splitting/).

[GitHub] [shardingsphere] weiyue888999 closed pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency

2021-05-02 Thread GitBox
weiyue888999 closed pull request #10246: URL: https://github.com/apache/shardingsphere/pull/10246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [shardingsphere] weiyue888999 commented on a change in pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency

2021-05-02 Thread GitBox
weiyue888999 commented on a change in pull request #10246: URL: https://github.com/apache/shardingsphere/pull/10246#discussion_r624874420 ## File path: examples/pom.xml ## @@ -167,6 +167,11 @@ shardingsphere-infra-common ${shardingsphere.versio

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10247: Update doc: Replace readwrite-splitting to replica-query in documents of spring-boot-starter

2021-05-02 Thread GitBox
codecov-commenter commented on pull request #10247: URL: https://github.com/apache/shardingsphere/pull/10247#issuecomment-831029661 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] TeslaCN opened a new issue #10248: Proxy PostgreSQL doesn't support PREPARE & EXECUTE

2021-05-03 Thread GitBox
TeslaCN opened a new issue #10248: URL: https://github.com/apache/shardingsphere/issues/10248 ## Feature Request ### Is your feature request related to a problem? ### Describe the feature you would like. PostgreSQL When I use `psql` connect PostgreSQL directl

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10249: Complete testcases for PostgreSQLCommandExecuteEngineTest

2021-05-03 Thread GitBox
TeslaCN opened a new pull request #10249: URL: https://github.com/apache/shardingsphere/pull/10249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10249: Complete testcases for PostgreSQLCommandExecuteEngineTest

2021-05-03 Thread GitBox
codecov-commenter commented on pull request #10249: URL: https://github.com/apache/shardingsphere/pull/10249#issuecomment-831137080 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10250: Update sysbench documents

2021-05-03 Thread GitBox
TeslaCN opened a new pull request #10250: URL: https://github.com/apache/shardingsphere/pull/10250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] terrymanu merged pull request #10250: Update sysbench documents

2021-05-03 Thread GitBox
terrymanu merged pull request #10250: URL: https://github.com/apache/shardingsphere/pull/10250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu merged pull request #10249: Complete testcases for PostgreSQLCommandExecuteEngine

2021-05-03 Thread GitBox
terrymanu merged pull request #10249: URL: https://github.com/apache/shardingsphere/pull/10249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu closed pull request #10247: Update doc: Replace readwrite-splitting to replica-query in documents of spring-boot-starter

2021-05-03 Thread GitBox
terrymanu closed pull request #10247: URL: https://github.com/apache/shardingsphere/pull/10247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu commented on pull request #10135: Support governance for JDBC scenario

2021-05-03 Thread GitBox
terrymanu commented on pull request #10135: URL: https://github.com/apache/shardingsphere/pull/10135#issuecomment-831162723 The travis still OOM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [shardingsphere] tristaZero opened a new issue #10251: [API Change] Move the user configuration to authority rule

2021-05-03 Thread GitBox
tristaZero opened a new issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251 Hi, community, This issue is to do API change of `server.yaml` of ShardingProxy. More precisely to say, we plan to move the `user` configuration to the `authority` rule module. Hope you

[GitHub] [shardingsphere] tristaZero opened a new issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-03 Thread GitBox
tristaZero opened a new issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252 Hi, community, This issue is about authority rule governance. I have to say it is difficult.. But you will perceive how the governance works and how proxies refresh its metadata to keep

[GitHub] [shardingsphere] tristaZero commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-03 Thread GitBox
tristaZero commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831205842 Hi guys, @huanghao495430759 @zhujunx Hope you have an enjoyable holiday! I have to say there are two **important and challenging** issues to seek excel

[GitHub] [shardingsphere] zhujunxxxxx commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-03 Thread GitBox
zhujunx commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831335228 OK,Let me try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1887: Update release notes for 3.0.0

2021-05-03 Thread GitBox
TeslaCN opened a new pull request #1887: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1887: Update release notes for 3.0.0

2021-05-03 Thread GitBox
TeslaCN merged pull request #1887: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere] tristaZero closed issue #10171: Bad rewritten result for foreign key SQL

2021-05-03 Thread GitBox
tristaZero closed issue #10171: URL: https://github.com/apache/shardingsphere/issues/10171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10193: fix bad rewritten result for foreign key SQL

2021-05-03 Thread GitBox
tristaZero merged pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero commented on pull request #10214: Support alter database grammar

2021-05-03 Thread GitBox
tristaZero commented on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-831661678 Hi @Liangda-w Please give this one a double-checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [shardingsphere] tristaZero commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-03 Thread GitBox
tristaZero commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831664361 Hi @zhujunx , Glad to see you stepping forward. Which one do you want to try? Or both? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

2021-05-03 Thread GitBox
tristaZero commented on a change in pull request #10217: URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r624659440 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseT

[GitHub] [shardingsphere] huanghao495430759 commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-03 Thread GitBox
huanghao495430759 commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831668970 OK, Can I try it too ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [shardingsphere] zhujunxxxxx commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-04 Thread GitBox
zhujunx commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831755519 I want to try #10251. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [shardingsphere] tristaZero commented on issue #10251: [API Change] Move the user configuration to authority rule

2021-05-04 Thread GitBox
tristaZero commented on issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251#issuecomment-831764599 @zhujunx Hey, welcome. @huanghao495430759 I will assign #10252 to you. Since you have done something to do with that, I suppose that issue will become simpler for

[GitHub] [shardingsphere] tristaZero commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-04 Thread GitBox
tristaZero commented on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-831764894 @huanghao495430759 Hey, could you comment something here so that I can assign this one for you. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [shardingsphere] huanghao495430759 commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-04 Thread GitBox
huanghao495430759 commented on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-831800710 > @huanghao495430759 Hey, could you comment something here so that I can assign this one for you. OK, Let me try this issue. -- This is an automated mess

[GitHub] [shardingsphere] Liangda-w commented on pull request #10214: Support alter database grammar

2021-05-04 Thread GitBox
Liangda-w commented on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-831856366 > Hi @Liangda-w Please give this one a double-checking. Looks good👍 it's time to merge -- This is an automated message from the Apache Git Service. To respond

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-04 Thread GitBox
ThanoshanMV opened a new pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253 relates #10111 Hi @tristaZero, @wgy8283335. I've added SQL definition for [ALTER SYSTEM](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-SYSTEM.html#GUID-

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-04 Thread GitBox
codecov-commenter commented on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-832413337 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10253?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] tristaZero merged pull request #10214: Support alter database grammar

2021-05-05 Thread GitBox
tristaZero merged pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero commented on pull request #10214: Support alter database grammar

2021-05-05 Thread GitBox
tristaZero commented on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-832526653 Hi Great, guys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [shardingsphere] tristaZero commented on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-05 Thread GitBox
tristaZero commented on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-832528099 Hi @ThanoshanMV Looks there are some conflicts to fix, which may be caused by #10214. Sorry for that. -- This is an automated message from the Apache Git Service.

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-05 Thread GitBox
ThanoshanMV commented on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-832540158 I'll resolve those conflicts @tristaZero -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [shardingsphere] EverZxq opened a new issue #10254: ParameterMarkerValue cannot be cast to ExpressionSegment

2021-05-05 Thread GitBox
EverZxq opened a new issue #10254: URL: https://github.com/apache/shardingsphere/issues/10254 shielding Fuzzy query is not ok, but annotation like is ok。 Error context: SELECT COUNT( * ) FROM PROCESS_TASKS WHERE (TASK_TYPE = ? AND CURRENT_REVIEWER LIKE ?) java.lang.Cla

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1888: Update FAQ

2021-05-05 Thread GitBox
TeslaCN opened a new pull request #1888: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1888: Update FAQ

2021-05-05 Thread GitBox
codecov-commenter commented on pull request #1888: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1888#issuecomment-832667442 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1888?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&u

[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1888: Update FAQ

2021-05-05 Thread GitBox
codecov-commenter edited a comment on pull request #1888: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1888#issuecomment-832667442 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1888?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=co

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-05 Thread GitBox
codecov-commenter edited a comment on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-832413337 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10253?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-05 Thread GitBox
wgy8283335 commented on a change in pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#discussion_r627002039 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatemen

[GitHub] [shardingsphere] strongduanmu commented on issue #10254: ParameterMarkerValue cannot be cast to ExpressionSegment

2021-05-05 Thread GitBox
strongduanmu commented on issue #10254: URL: https://github.com/apache/shardingsphere/issues/10254#issuecomment-833152790 @EverZxq Thank you very much for using version `5.0.0-alpha`, this is a parse exception, and we will fix this issue later. -- This is an automated message from t

[GitHub] [shardingsphere] zhoubonet commented on issue #10138: Transaction not rolled back

2021-05-05 Thread GitBox
zhoubonet commented on issue #10138: URL: https://github.com/apache/shardingsphere/issues/10138#issuecomment-833157578 existence -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [shardingsphere-elasticjob] keepmeup commented on issue #667: 1单次任务执行后删除自己发生异常2.大量任务同时执行,偶尔会有一条任务没有触发

2021-05-05 Thread GitBox
keepmeup commented on issue #667: URL: https://github.com/apache/shardingsphere-elasticjob/issues/667#issuecomment-833158274 这个问题有结果了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [shardingsphere] cilfm commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

2021-05-05 Thread GitBox
cilfm commented on a change in pull request #10217: URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r627020589 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseTypeTe

[GitHub] [shardingsphere-elasticjob] aboluo-gy commented on issue #667: 1单次任务执行后删除自己发生异常2.大量任务同时执行,偶尔会有一条任务没有触发

2021-05-05 Thread GitBox
aboluo-gy commented on issue #667: URL: https://github.com/apache/shardingsphere-elasticjob/issues/667#issuecomment-833163245 亮哥后面回复过让用英文重新issue,就把这个关了,比较忙就没有重新提交,问题应该没有解决,我后面使用其他定时任务框架了。 阿波罗 ***@***.*** 签名由 网易邮箱大师 定制 在2021年05月06日 09:27,keepmeup 写道: 这个问题有结果了吗 — You are receiving this beca

[GitHub] [shardingsphere] hanxu00920 commented on issue #10216: ShardingSphere-JDBC orchestration for Spring boot not available

2021-05-05 Thread GitBox
hanxu00920 commented on issue #10216: URL: https://github.com/apache/shardingsphere/issues/10216#issuecomment-833183576 > @hanxu00920 Concise description. > Your configuration is based on [Configurations](https://shardingsphere.apache.org/document/legacy/4.x/document/cn/manual/sharding-

[GitHub] [shardingsphere] wangkang09 commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-05-05 Thread GitBox
wangkang09 commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-833231405 @tristaZero @huanghao495430759 https://github.com/wangkang09/sharding-test.git this is my test project~~ -- This is an automated message from the Apache Git Service.

[GitHub] [shardingsphere] wangkang09 commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-05-05 Thread GitBox
wangkang09 commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-833236416 @tristaZero @huanghao495430759i found if i use mybatis it works well, but if i use mybatis-plus,that problem is appear -- This is an automated message from the Apache

[GitHub] [shardingsphere] EverZxq commented on issue #10254: ParameterMarkerValue cannot be cast to ExpressionSegment

2021-05-05 Thread GitBox
EverZxq commented on issue #10254: URL: https://github.com/apache/shardingsphere/issues/10254#issuecomment-833239665 > @EverZxq非常感谢您使用version `5.0.0-alpha`,这是一个解析异常,我们将在以后解决此问题。 When is the next version? Since our project has encountered this problem and cannot be solved, can we rev

[GitHub] [shardingsphere] strongduanmu opened a new pull request #10255: fix oracle & sql92 like query parse exception

2021-05-05 Thread GitBox
strongduanmu opened a new pull request #10255: URL: https://github.com/apache/shardingsphere/pull/10255 Fixes #10254. Changes proposed in this pull request: - fix oracle & sql92 like query parse exception -- This is an automated message from the Apache Git Service. To respon

[GitHub] [shardingsphere] strongduanmu commented on issue #10254: ParameterMarkerValue cannot be cast to ExpressionSegment

2021-05-05 Thread GitBox
strongduanmu commented on issue #10254: URL: https://github.com/apache/shardingsphere/issues/10254#issuecomment-833257279 @EverZxq It will take some time before the `5.0.0-beta` version is released. Please be patient and wait for the good news. You can temporarily use the following SQL:

<    1   2   3   4   5   6   7   8   9   10   >