[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2826: Ability to define behaviour when sharding column is not present in the SQL

2019-08-08 Thread GitBox
terrymanu commented on issue #2826: Ability to define behaviour when sharding 
column is not present in the SQL
URL: 
https://github.com/apache/incubator-shardingsphere/issues/2826#issuecomment-519403676
 
 
   I prefer support multi-tenants to high level of Sharding-JDBC, which can 
make ShardingSphere as a infrastructure of data-sharding.
   
   How about add a new module to handle multi-tenants upper of basic sharding 
feature?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2826: Ability to define behaviour when sharding column is not present in the SQL

2019-08-08 Thread GitBox
terrymanu commented on issue #2826: Ability to define behaviour when sharding 
column is not present in the SQL
URL: 
https://github.com/apache/incubator-shardingsphere/issues/2826#issuecomment-519402839
 
 
   Beside Sharding-JDBC, ShardingSphere also include Sharding-Proxy, we want 
make same behavior with those 2 products except different access layer (JDBC or 
database protocol).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2826: Ability to define behaviour when sharding column is not present in the SQL

2019-08-08 Thread GitBox
terrymanu commented on issue #2826: Ability to define behaviour when sharding 
column is not present in the SQL
URL: 
https://github.com/apache/incubator-shardingsphere/issues/2826#issuecomment-519383999
 
 
   hi, @rimal 
   This is a good suggestion, but consider about ShardingSphere as a database, 
we maybe should not expose such complicated feature to end users.
   
   We want discuss that maybe we have some new way to do this better.
   
   We plan do SQL examine and verify feature in future, which can permit end 
user config verification rule to determine which SQL can be executed. `Sharding 
without sharding-cloumn` should one of rule for verification rule.
   
   How do you think?
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services