[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966887 > this is a constraint in spring side, you can try to PR for it to become our new contributor Ok, I will This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966318 @KomachiSion @cherrylzhao Thank you very much for your answer. My problem is solved. -- > If you want to use ShardingSphere XA, you need to exclude JtaTransactionManager. Because JtaTransactionManager will shutdown the Transaction control of ShardingSphere. In addition, I think you need to update your official documents on this point. Right here: https://shardingsphere.apache.org/document/current/en/manual/sharding-jdbc/usage/transaction/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575961548 Wish you a happy Spring Festival in advance ! Can someone solve my doubts? It’s very important for me. I still have a production problem to solve.  @KomachiSion @terrymanu @cherrylzhao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575546746 After debugging, I found that excluding or not excluding JtaAutoConfiguration made a big difference. **Don’t exclude JtaAutoConfiguration, use JtaTransactionManager.** When commit： 1、org.springframework.transaction.support.AbstractPlatformTransactionManager#commit 2、org.springframework.transaction.jta.JtaTransactionManager#doCommit 3、com.atomikos.icatch.jta.UserTransactionManager#commit **Exclude JtaAutoConfiguration, use DataSourceTransactionManager.** When commit： 1、org.apache.shardingsphere.shardingjdbc.jdbc.core.connection.ShardingConnection#commit 2、org.apache.shardingsphere.transaction.xa.XAShardingTransactionManager#commit 3、com.atomikos.icatch.jta.UserTransactionManager#commit Does this mean that JtaAutoConfiguration must be excluded to ensure that sharding-jdbc controls the commit or rollback ? @cherrylzhao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575505389 > hi, you should exclude the `JtaAutoConfiguration ` in your project like this > > ``` > @SpringBootApplication(exclude = JtaAutoConfiguration.class) > ``` > > aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself As for your statement that "@ShardingTransactionType doesn't work without sharding-transaction-jdbc-spring dependency", which version will be merged? Currently, do we have to develop the @ShardingTransactionType aspect by ourselves? Like this? https://github.com/OpenSharding/shardingsphere-spi-impl/blob/4.0.0-RC2/sharding-spring/sharding-transaction-spring/sharding-transaction-jdbc-spring/src/main/java/io/shardingsphere/transaction/aspect/ShardingTransactionJDBCAspect.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575496502 > hi, you should exclude the `JtaAutoConfiguration ` in your project like this > > ``` > @SpringBootApplication(exclude = JtaAutoConfiguration.class) > ``` > > aslo @ShardingTransactionType doesn't work without [sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter) dependency. we haven't merge it to ShardingSphere now, you should deploy it by yourself Thank you for your patient reply. It finally worked When I excluded JtaAutoConfiguration from my project. The solution is to Use DataSourceTransactionManager by default After excluded JtaAutoConfiguration ? The second question is, whether XA transactions can be used after JtaAutoConfiguration is excluded? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575486520 Thank you for your patient reply. It finally worked When I excluded JtaAutoConfiguration from my project. The solution is to Use DataSourceTransactionManager by default After excluded JtaAutoConfiguration ? The second question is, whether XA transactions can be used after JtaAutoConfiguration is excluded? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
