[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521883965 OK. I understand what you said. The current situation is : - The highest Op

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere throws an Exce

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere throws an Exce

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-10 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-520160038 @tuohai666 should I add SkywalkingTracer as default implement? -