[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.

2020-01-18 Thread GitBox
cherrylzhao commented on issue #4002: Transactions cannot be rolled back 
properly when using local transaction.
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966690
 
 
   this is a constraint in spring side, you can try to PR for it to become our 
new contributor


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.

2020-01-18 Thread GitBox
cherrylzhao commented on issue #4002: Transactions cannot be rolled back 
properly when using local transaction.
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966099
 
 
   ShardingSphere use local transaction interface to integrate distributed 
transaction(XA and BASE). 
   from the spring perspective we only compatible with 
`DataSourceTransactionManager`,so JTA
   TransactionMananger will conflict with us. @ShardingTransactionType is a 
customer annotation, it should be handled by aspect class, you can use our code 
of  SPI project or develop by yourself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.

2020-01-16 Thread GitBox
cherrylzhao commented on issue #4002: Transactions cannot be rolled back 
properly when using local transaction.
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575463054
 
 
   hi, you should exclude the `JtaAutoConfiguration ` in your project like this
   ```
   @SpringBootApplication(exclude = JtaAutoConfiguration.class)
   ```
   aslo @ShardingTransactionType doesn't work without 
[sharding-transaction-jdbc-spring](https://github.com/OpenSharding/shardingsphere-spi-impl/tree/4.0.0-RC2/sharding-spring/sharding-transaction-spring-boot-starter/sharding-transaction-jdbc-spring-boot-starter)
 dependency. we haven't merge it to ShardingSphere now, you should deploy it by 
yourself


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services