[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-494653578 Some suggestions: 1. Remove SQLRewriteEngine.originalSQL, use sqlStatement.getLogicSQL() 2. For EncryptRule with

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [x] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [x] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2275: Reconstruct rewriting module

terrymanu edited a comment on issue #2275: Reconstruct rewriting module URL: https://github.com/apache/incubator-shardingsphere/issues/2275#issuecomment-491602194 Some code review suggestion: - [ ] XXXSQLRewriteEngine move to new package name as `engine` - [ ] XXXSQLRewriteEngine