carlvine500 commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386783712
@candyleer nice work !
This is an automated message from the Apache Git Service.
T
wu-sheng closed pull request #995: Collector table description for develop
guide.
URL: https://github.com/apache/incubator-skywalking/pull/995
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As th
coveralls commented on issue #995: Collector table description for develop
guide.
URL:
https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122
[](https://coveralls.io/builds/16845946)
Coverage
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386772477
Thanks everyone. Before and during release vote, feel free to open question.
Especially for @liuhaoyang about .NET CORE related features
ascrutae opened a new issue #167: The format about exception stack is irregular
URL: https://github.com/apache/incubator-skywalking-ui/issues/167
Here is the screen snapshot:
](https://coveralls.io/builds/16837307
coveralls commented on issue #995: Collector table description for develop
guide.
URL:
https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122
[](https://coveralls.io/builds/16836711)
Coverage
wu-sheng commented on issue #995: Collector table description for develop guide.
URL:
https://github.com/apache/incubator-skywalking/pull/995#issuecomment-386622696
Please add link into the doc readme.
This is an automated me
coveralls commented on issue #1173: Do not get alarm metric for overview and
application topology.
URL:
https://github.com/apache/incubator-skywalking/pull/1173#issuecomment-386621150
[](https://coveralls.io/builds/16836111
wu-sheng commented on issue #1160: Add unknown node image 404 error handler
URL:
https://github.com/apache/incubator-skywalking/issues/1160#issuecomment-386613720
This feature moves into beta2. And ask community contributor to help. FYI
@liuhaoyang
---
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386613235
@ascrutae @liuhaoyang @candyleer Maybe we should run second round test
again.
@ascrutae If your local test is OK, please consid
peng-yongsheng opened a new pull request #1173: Do not get alarm metric for
overview and application topology.
URL: https://github.com/apache/incubator-skywalking/pull/1173
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910
# ~~Report @ 2018/05/04[Ignored]~~
## Issue
### Topology
* ~~**[COLLECTOR]** the server alarm value is incorrect. Ex
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386303917
## ~~Report @ 2018/05/03[Fixed]~~
* [UI]
](https://coveralls.io/builds/16834110)
Coverage remained the same at 2
hanahmily opened a new pull request #1171: Submodule/skywalking ui
URL: https://github.com/apache/incubator-skywalking/pull/1171
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve
coveralls commented on issue #1170: Fix protobuf dirname for
apm-remote-grpc-provider
URL:
https://github.com/apache/incubator-skywalking/pull/1170#issuecomment-386570135
[](https://coveralls.io/builds/16833185)
Cove
brucewu-fly opened a new pull request #1170: Fix protobuf dirname for
apm-remote-grpc-provider
URL: https://github.com/apache/incubator-skywalking/pull/1170
The directory should be
`apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf`
rather than
coveralls commented on issue #995: Collector table description for develop
guide.
URL:
https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122
[](https://coveralls.io/builds/16832558)
Coverage
coveralls commented on issue #1169: Remove components define that cannot be
supported
URL:
https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386558445
[](https://coveralls.io/builds/16832337)
Cove
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910
# Report @ 2018/05/04
## Issue
### Topology
* **[COLLECTOR]** the server alarm value is incorrect. Except is 1, but
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910
# Report @ 2018/05/04
## Issue
### Topology
* **[COLLECTOR]** the server alarm value is incorrect. Except is 1, but
peng-yongsheng closed pull request #1168: JDK 9 compile.
URL: https://github.com/apache/incubator-skywalking/pull/1168
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull requ
liuhaoyang closed pull request #1169: Remove components define that cannot be
supported
URL: https://github.com/apache/incubator-skywalking/pull/1169
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
coveralls commented on issue #1168: JDK 9 compile.
URL:
https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386553512
[](https://coveralls.io/builds/16831980)
Coverage remained the same at 23.363% wh
liuhaoyang commented on issue #1169: Remove components define that cannot be
supported
URL:
https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386553431
You're right. It is not appropriate to remove existing IDS.
-
wu-sheng commented on issue #1169: Remove components define that cannot be
supported
URL:
https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552128
Cannot support for now or forever? From my perspective, removing some
existed IDs is a very dangerous and un-recommende
wu-sheng commented on issue #1169: Remove components define that cannot be
supported
URL:
https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552511
`sqlite` is a difference component compared with `EntityFrameworkCore's
in-memory database`. Right? So, you don't want
liuhaoyang commented on issue #1169: Remove components define that cannot be
supported
URL:
https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552033
@wu-sheng EntityFrameworkCore's in-memory database does not have built-in
diagostics api, and a better way is to use
wu-sheng commented on issue #1169: Remove components define that cannot be
supported
URL:
https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386550279
what do you mean cannot support?
This is an automated
liuhaoyang opened a new pull request #1169: Remove components define that
cannot be supported
URL: https://github.com/apache/incubator-skywalking/pull/1169
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New featu
liuhaoyang commented on issue #1168: JDK 9 compile.
URL:
https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386547217
yes. I just use JDK9 to test.
This is an automated message from the Apache Git Service.
wu-sheng commented on issue #1168: JDK 9 compile.
URL:
https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386546604
@liuhaoyang FYI, we didn't add jdk9 and jdk10 compile in CI. These cost too
much. I still recommend to compile in JDK8.
--
peng-yongsheng opened a new pull request #1168: JDK 9 compile.
URL: https://github.com/apache/incubator-skywalking/pull/1168
Please answer these questions before submitting pull request
- Why submit this pull request?
- [X] New feature provided
___
### New feature or improvem
wu-sheng opened a new issue #1167: Refactor the plugin component name to real
library name
URL: https://github.com/apache/incubator-skywalking/issues/1167
Since the component mapping has provided in collector side, please refactor
all existed component plugins to their real component libra
wu-sheng opened a new issue #1166: Optimize topology query
URL: https://github.com/apache/incubator-skywalking/issues/1166
Add a new column for group query, in order to reduce the query cost.
This is an automated message from
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386199704
# Report @ 2018/05/03
the prefix description of Issue:
|prefix|description|
|:---|:---|
|**[AGENT]** | This prefix repres
coveralls commented on issue #995: Collector table description for develop
guide.
URL:
https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122
[](https://coveralls.io/builds/16831128)
Coverage
wu-sheng closed pull request #1165: Get conjectural node component name from
component server name.
URL: https://github.com/apache/incubator-skywalking/pull/1165
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
coveralls commented on issue #1165: Get conjectural node component name from
component server name.
URL:
https://github.com/apache/incubator-skywalking/pull/1165#issuecomment-386533059
[](https://coveralls.io/builds/1683096
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus /
OpenZipkin
URL:
https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882
> apm-collector-thirdparty-agent
I didn't like the `agent` part, even we are using this in existed collector
modu
peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus /
OpenZipkin
URL:
https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517155
1. We need to support ZipKin and Jaeger agent. Suggest those to be maven
third party module's submodule, but also
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386530116
@liuhaoyang #1165 should fix your server type issue, but need your test case
to recheck.
--
peng-yongsheng opened a new pull request #1165: Get conjectural node component
name from component server name.
URL: https://github.com/apache/incubator-skywalking/pull/1165
Please answer these questions before submitting pull request
- Why submit this pull request?
- [X] Bug fix
wu-sheng closed pull request #1164: Fix Average time zero
URL: https://github.com/apache/incubator-skywalking/pull/1164
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull re
coveralls commented on issue #1164: Fix Average time zero
URL:
https://github.com/apache/incubator-skywalking/pull/1164#issuecomment-386524932
[](https://coveralls.io/builds/16830508)
Coverage remained the same at 23
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386199704
# Report @ 2018/05/03
the prefix description of Issue:
|prefix|description|
|:---|:---|
|**[AGENT]** | This prefix repres
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386309060
## ~~Report @ 2018/05/03 [Fixed]~~
* ~~[Collector] 0 maybe not correct~~
