[GitHub] wu-sheng commented on issue #1997: Print traceId to log4j2 failed

2018-12-07 Thread GitBox
wu-sheng commented on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-445439912 > it does not depend on anything in tookit activation. If not, I prefer a new optional plugin in

[GitHub] JaredTan95 commented on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
JaredTan95 commented on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-445434033 @wu-sheng Yep, I'd be glad to test this

[GitHub] coveralls edited a comment on issue #2021: Support overwrite tag

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2021: Support overwrite tag URL: https://github.com/apache/incubator-skywalking/pull/2021#issuecomment-445433736 [![Coverage Status](https://coveralls.io/builds/20523008/badge)](https://coveralls.io/builds/20523008) Coverage increased

[GitHub] coveralls edited a comment on issue #2021: Support overwrite tag

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2021: Support overwrite tag URL: https://github.com/apache/incubator-skywalking/pull/2021#issuecomment-445433736 [![Coverage Status](https://coveralls.io/builds/20523086/badge)](https://coveralls.io/builds/20523086) Coverage increased

[GitHub] coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-439678030 [![Coverage

[GitHub] wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#discussion_r239994825 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#discussion_r239994792 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#discussion_r239994833 ## File path:

[GitHub] coveralls commented on issue #2021: Support overwrite tag

2018-12-07 Thread GitBox
coveralls commented on issue #2021: Support overwrite tag URL: https://github.com/apache/incubator-skywalking/pull/2021#issuecomment-445433736 [![Coverage Status](https://coveralls.io/builds/20522805/badge)](https://coveralls.io/builds/20522805) Coverage increased (+0.009%) to

[GitHub] wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
wu-sheng commented on a change in pull request #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#discussion_r239994853 ## File path:

[GitHub] coveralls commented on issue #2020: Update Supported-list.md

2018-12-07 Thread GitBox
coveralls commented on issue #2020: Update Supported-list.md URL: https://github.com/apache/incubator-skywalking/pull/2020#issuecomment-445433382 [![Coverage Status](https://coveralls.io/builds/20522265/badge)](https://coveralls.io/builds/20522265) Coverage decreased (-0.005%)

[GitHub] coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-439678030 [![Coverage

[GitHub] JaredTan95 commented on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
JaredTan95 commented on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-445432268 @Liu-XinYuan Add some documents about

[GitHub] coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-439678030 [![Coverage

[GitHub] coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-439678030 [![Coverage

[GitHub] coveralls commented on issue #2013: fix agent-logs-typo.

2018-12-07 Thread GitBox
coveralls commented on issue #2013: fix agent-logs-typo. URL: https://github.com/apache/incubator-skywalking/pull/2013#issuecomment-445430835 [![Coverage Status](https://coveralls.io/builds/20488573/badge)](https://coveralls.io/builds/20488573) Coverage increased (+0.002%) to

[GitHub] coveralls commented on issue #2013: fix agent-logs-typo.

2018-12-07 Thread GitBox
coveralls commented on issue #2013: fix agent-logs-typo. URL: https://github.com/apache/incubator-skywalking/pull/2013#issuecomment-445430769 [![Coverage Status](https://coveralls.io/builds/20488029/badge)](https://coveralls.io/builds/20488029) Coverage remained the same at

[GitHub] coveralls edited a comment on issue #2016: fix classloader dead lock in jdk7+

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2016: fix classloader dead lock in jdk7+ URL: https://github.com/apache/incubator-skywalking/pull/2016#issuecomment-445428313 [![Coverage Status](https://coveralls.io/builds/20503720/badge)](https://coveralls.io/builds/20503720) Coverage

[GitHub] coveralls edited a comment on issue #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444237630 [![Coverage Status](https://coveralls.io/builds/20508560/badge)](https://coveralls.io/builds/20508560) Coverage increased

[GitHub] coveralls commented on issue #2015: OAL tool module established

2018-12-07 Thread GitBox
coveralls commented on issue #2015: OAL tool module established URL: https://github.com/apache/incubator-skywalking/pull/2015#issuecomment-44542 [![Coverage Status](https://coveralls.io/builds/20491154/badge)](https://coveralls.io/builds/20491154) Coverage increased (+2.3%)

[GitHub] coveralls commented on issue #2014: Zookeeper implementation of cluster module provide name space setting.

2018-12-07 Thread GitBox
coveralls commented on issue #2014: Zookeeper implementation of cluster module provide name space setting. URL: https://github.com/apache/incubator-skywalking/pull/2014#issuecomment-445428998 [![Coverage

[GitHub] coveralls commented on issue #2016: fix classloader dead lock in jdk7+

2018-12-07 Thread GitBox
coveralls commented on issue #2016: fix classloader dead lock in jdk7+ URL: https://github.com/apache/incubator-skywalking/pull/2016#issuecomment-445428313 [![Coverage Status](https://coveralls.io/builds/20503724/badge)](https://coveralls.io/builds/20503724) Coverage remained

[GitHub] coveralls edited a comment on issue #1985: Fix the NPE about elasticsearch plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1985: Fix the NPE about elasticsearch plugin URL: https://github.com/apache/incubator-skywalking/pull/1985#issuecomment-443260915 [![Coverage Status](https://coveralls.io/builds/20511622/badge)](https://coveralls.io/builds/20511622)

[GitHub] coveralls edited a comment on issue #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444237630 [![Coverage Status](https://coveralls.io/builds/20483865/badge)](https://coveralls.io/builds/20483865) Coverage remained the

[GitHub] coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-439678030 [![Coverage

[incubator-skywalking] branch master updated: Update Supported-list.md (#2020)

2018-12-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new a38c128 Update

[GitHub] wu-sheng closed pull request #2020: Update Supported-list.md

2018-12-07 Thread GitBox
wu-sheng closed pull request #2020: Update Supported-list.md URL: https://github.com/apache/incubator-skywalking/pull/2020 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] coveralls edited a comment on issue #2005: Remove unused Debug Switches

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2005: Remove unused Debug Switches URL: https://github.com/apache/incubator-skywalking/pull/2005#issuecomment-445423179 [![Coverage Status](https://coveralls.io/builds/20482829/badge)](https://coveralls.io/builds/20482829) Coverage decreased

[GitHub] coveralls commented on issue #2006: [OAL refactor step 1]Refactor dispatcher manager

2018-12-07 Thread GitBox
coveralls commented on issue #2006: [OAL refactor step 1]Refactor dispatcher manager URL: https://github.com/apache/incubator-skywalking/pull/2006#issuecomment-445423903 [![Coverage Status](https://coveralls.io/builds/20482540/badge)](https://coveralls.io/builds/20482540)

[GitHub] coveralls commented on issue #2005: Remove unused Debug Switches

2018-12-07 Thread GitBox
coveralls commented on issue #2005: Remove unused Debug Switches URL: https://github.com/apache/incubator-skywalking/pull/2005#issuecomment-445423179 [![Coverage Status](https://coveralls.io/builds/20481106/badge)](https://coveralls.io/builds/20481106) Coverage increased

[GitHub] ascrutae opened a new pull request #2021: Support overwrite tag

2018-12-07 Thread GitBox
ascrutae opened a new pull request #2021: Support overwrite tag URL: https://github.com/apache/incubator-skywalking/pull/2021 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve

[GitHub] coveralls commented on issue #2004: Create backend-upgrade.md

2018-12-07 Thread GitBox
coveralls commented on issue #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004#issuecomment-445421261 [![Coverage Status](https://coveralls.io/builds/20470133/badge)](https://coveralls.io/builds/20470133) Coverage decreased (-0.002%)

[GitHub] coveralls edited a comment on issue #1981: add system env for trace ignore plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1981: add system env for trace ignore plugin URL: https://github.com/apache/incubator-skywalking/pull/1981#issuecomment-443089146 [![Coverage Status](https://coveralls.io/builds/20483276/badge)](https://coveralls.io/builds/20483276)

[GitHub] coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1929: Agent metadata clear to trigger re-register action for avoid restart agent when backend server metadata was mistakenly deleted URL: https://github.com/apache/incubator-skywalking/pull/1929#issuecomment-439678030 [![Coverage

[GitHub] WithLin opened a new pull request #2020: Update Supported-list.md

2018-12-07 Thread GitBox
WithLin opened a new pull request #2020: Update Supported-list.md URL: https://github.com/apache/incubator-skywalking/pull/2020 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] coveralls edited a comment on issue #1981: add system env for trace ignore plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #1981: add system env for trace ignore plugin URL: https://github.com/apache/incubator-skywalking/pull/1981#issuecomment-443089146 [![Coverage Status](https://coveralls.io/builds/20483229/badge)](https://coveralls.io/builds/20483229)

[GitHub] coveralls edited a comment on issue #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444237630 [![Coverage Status](https://coveralls.io/builds/20467511/badge)](https://coveralls.io/builds/20467511) Coverage increased

[GitHub] wu-sheng closed issue #1953: Exception::InstMethodsInter : class[class org.elasticsearch.client.transport.TransportProxyClient] before method[execute] intercept failure java.lang.NullPointerE

2018-12-07 Thread GitBox
wu-sheng closed issue #1953: Exception::InstMethodsInter : class[class org.elasticsearch.client.transport.TransportProxyClient] before method[execute] intercept failure java.lang.NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/1953

[incubator-skywalking] branch master updated: Fix the NPE about elasticsearch plugin (#1985)

2018-12-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new aa9a7c4 Fix the NPE about

[GitHub] wu-sheng commented on issue #1953: Exception::InstMethodsInter : class[class org.elasticsearch.client.transport.TransportProxyClient] before method[execute] intercept failure java.lang.NullPo

2018-12-07 Thread GitBox
wu-sheng commented on issue #1953: Exception::InstMethodsInter : class[class org.elasticsearch.client.transport.TransportProxyClient] before method[execute] intercept failure java.lang.NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/1953#issuecomment-445256700

[GitHub] wu-sheng closed pull request #1985: Fix the NPE about elasticsearch plugin

2018-12-07 Thread GitBox
wu-sheng closed pull request #1985: Fix the NPE about elasticsearch plugin URL: https://github.com/apache/incubator-skywalking/pull/1985 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] SkyWalkingRobot commented on issue #1985: Fix the NPE about elasticsearch plugin

2018-12-07 Thread GitBox
SkyWalkingRobot commented on issue #1985: Fix the NPE about elasticsearch plugin URL: https://github.com/apache/incubator-skywalking/pull/1985#issuecomment-445246062 Here is the [test

[GitHub] SkyWalkingRobot commented on issue #1985: Fix the NPE about elasticsearch plugin

2018-12-07 Thread GitBox
SkyWalkingRobot commented on issue #1985: Fix the NPE about elasticsearch plugin URL: https://github.com/apache/incubator-skywalking/pull/1985#issuecomment-445236045 Here is the [test

[GitHub] wu-sheng closed pull request #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
wu-sheng closed pull request #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-skywalking] branch master updated: Support rabbitmq plugin (#2000)

2018-12-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 45f4454 Support rabbitmq plugin

[GitHub] SkyWalkingRobot commented on issue #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
SkyWalkingRobot commented on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-445229802 Here is the [test

[GitHub] coveralls edited a comment on issue #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444237630 [![Coverage Status](https://coveralls.io/builds/20465909/badge)](https://coveralls.io/builds/20465909) Coverage increased

[GitHub] coveralls edited a comment on issue #2000: Support rabbitmq plugin

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444237630 [![Coverage Status](https://coveralls.io/builds/20465964/badge)](https://coveralls.io/builds/20465964) Coverage increased

[GitHub] wu-sheng commented on issue #2019: project cant startup

2018-12-07 Thread GitBox
wu-sheng commented on issue #2019: project cant startup URL: https://github.com/apache/incubator-skywalking/issues/2019#issuecomment-445199471 The logs look like good. Nothing special. This is an automated message from the

[GitHub] wu-sheng commented on issue #1744: trace topology is sometimes incorrect.

2018-12-07 Thread GitBox
wu-sheng commented on issue #1744: trace topology is sometimes incorrect. URL: https://github.com/apache/incubator-skywalking/issues/1744#issuecomment-445197022 > can you tell me how to configure span created and closed right ? This is based on plugin. You need to be sure, each

[GitHub] WentHao commented on issue #1744: trace topology is sometimes incorrect.

2018-12-07 Thread GitBox
WentHao commented on issue #1744: trace topology is sometimes incorrect. URL: https://github.com/apache/incubator-skywalking/issues/1744#issuecomment-445187544 mark. the same question with 5.0.0-GA This is an automated

[GitHub] WentHao opened a new issue #2019: project cant startup

2018-12-07 Thread GitBox
WentHao opened a new issue #2019: project cant startup URL: https://github.com/apache/incubator-skywalking/issues/2019 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [x] Bug - [ ] Requirement - [

[incubator-skywalking] branch 5.x updated: fix classloader dead lock in jdk7+ - 5.x (#2018)

2018-12-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch 5.x in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/5.x by this push: new d494457 fix classloader dead lock in

[GitHub] wu-sheng closed pull request #2018: fix classloader dead lock in jdk7+ - 5.x

2018-12-07 Thread GitBox
wu-sheng closed pull request #2018: fix classloader dead lock in jdk7+ - 5.x URL: https://github.com/apache/incubator-skywalking/pull/2018 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coveralls edited a comment on issue #2003: Fix the alarm being started too many times.

2018-12-07 Thread GitBox
coveralls edited a comment on issue #2003: Fix the alarm being started too many times. URL: https://github.com/apache/incubator-skywalking/pull/2003#issuecomment-445046029 [![Coverage Status](https://coveralls.io/builds/20465109/badge)](https://coveralls.io/builds/20465109)