[GitHub] WithLin commented on issue #2090: Support Gson Plugin

2018-12-29 Thread GitBox
WithLin commented on issue #2090: Support Gson Plugin URL: https://github.com/apache/incubator-skywalking/pull/2090#issuecomment-450540073 ok, i will fix it . This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1684: When is the support for reactor netty HttpClient?

2018-12-29 Thread GitBox
wu-sheng commented on issue #1684: When is the support for reactor netty HttpClient? URL: https://github.com/apache/incubator-skywalking/issues/1684#issuecomment-450495488 @JaredTan95 Which version should we set? GA or 6.1? I noticed different milestones in issue and pr.

[GitHub] wu-sheng commented on issue #1968: The Collector has an exception when querying Trace data.

2018-12-29 Thread GitBox
wu-sheng commented on issue #1968: The Collector has an exception when querying Trace data. URL: https://github.com/apache/incubator-skywalking/issues/1968#issuecomment-450495305 @TinyAllen We need to set a paging condition, no matter which page size the user choose, don't let user go to

[GitHub] JaredTan95 closed pull request #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
JaredTan95 closed pull request #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-skywalking] branch master updated: fix incorrect version in apm-checkstyle. (#2102)

2018-12-29 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 2ed1e94 fix incorrect version

[GitHub] coveralls edited a comment on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
coveralls edited a comment on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450483026 [![Coverage Status](https://coveralls.io/builds/20835274/badge)](https://coveralls.io/builds/20835274)

[GitHub] coveralls edited a comment on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
coveralls edited a comment on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450483026 [![Coverage Status](https://coveralls.io/builds/20835168/badge)](https://coveralls.io/builds/20835168)

[GitHub] coveralls edited a comment on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
coveralls edited a comment on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450483026 [![Coverage Status](https://coveralls.io/builds/20835158/badge)](https://coveralls.io/builds/20835158)

[GitHub] coveralls commented on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
coveralls commented on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450483026 [![Coverage Status](https://coveralls.io/builds/20835152/badge)](https://coveralls.io/builds/20835152) Coverage

[incubator-skywalking] branch master updated: Provide cn doc translation about concept and design parts (#2056)

2018-12-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 7a6c26b Provide cn doc

[GitHub] JaredTan95 opened a new pull request #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
JaredTan95 opened a new pull request #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature

[GitHub] JaredTan95 commented on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
JaredTan95 commented on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450481288 > Please set it. I will @hanahmily mischange this in releasw process. ok~

[GitHub] JaredTan95 closed pull request #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
JaredTan95 closed pull request #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] wu-sheng commented on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
wu-sheng commented on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450481246 Please set it. I will @hanahmily mischange this in releasw process.

[GitHub] JaredTan95 commented on issue #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
JaredTan95 commented on issue #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102#issuecomment-450481183 I doubt that why the CI didn't point it? :-P This is an

[GitHub] JaredTan95 opened a new pull request #2102: fix incorrect version in apm-checkstyle.

2018-12-29 Thread GitBox
JaredTan95 opened a new pull request #2102: fix incorrect version in apm-checkstyle. URL: https://github.com/apache/incubator-skywalking/pull/2102 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature

[GitHub] bomee commented on issue #2101: Could I pass argument to java agent?

2018-12-29 Thread GitBox
bomee commented on issue #2101: Could I pass argument to java agent? URL: https://github.com/apache/incubator-skywalking/issues/2101#issuecomment-450475713 Good!This is what I want. This is an automated message from the

[GitHub] wu-sheng commented on issue #2101: Could I pass argument to java agent?

2018-12-29 Thread GitBox
wu-sheng commented on issue #2101: Could I pass argument to java agent? URL: https://github.com/apache/incubator-skywalking/issues/2101#issuecomment-450475116 We have very detailed documents. Again, please read document.

[GitHub] bomee edited a comment on issue #2101: Could I pass argument to java agent?

2018-12-29 Thread GitBox
bomee edited a comment on issue #2101: Could I pass argument to java agent? URL: https://github.com/apache/incubator-skywalking/issues/2101#issuecomment-450474516 @wu-sheng I think the config file loading in the same folder at runtime. so I need copy agent folder for each app, is that

[GitHub] bomee commented on issue #2101: Could I pass argument to java agent?

2018-12-29 Thread GitBox
bomee commented on issue #2101: Could I pass argument to java agent? URL: https://github.com/apache/incubator-skywalking/issues/2101#issuecomment-450474516 @wu-sheng I think the config file loading in the same folder at runtime. so I need copy agent folder for each app, is that right?