[GitHub] wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-06 Thread GitBox
wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451850529 Hostname is based on your OS hostname, agent just collect it.

[GitHub] wu-sheng closed issue #2127: how to set a unique name for each service instance nodes?

2019-01-06 Thread GitBox
wu-sheng closed issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127 This is an automated message from the Apache Git Service. To respond to

[GitHub] foxracle opened a new issue #2127: how to set a unique name for each service instance nodes?

2019-01-06 Thread GitBox
foxracle opened a new issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion

[GitHub] wu-sheng commented on issue #2073: Set a telemetry module for backend, and provide Prometheus as default implementation

2019-01-06 Thread GitBox
wu-sheng commented on issue #2073: Set a telemetry module for backend, and provide Prometheus as default implementation URL: https://github.com/apache/incubator-skywalking/issues/2073#issuecomment-451839650 Default lable = instance id ## Metric related 1. Cluster size of each

[GitHub] ascrutae edited a comment on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis

2019-01-06 Thread GitBox
ascrutae edited a comment on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis URL: https://github.com/apache/incubator-skywalking/issues/1805#issuecomment-451804156 This idea is fine. but I think this demand is not worth do this currently. Here

[GitHub] wu-sheng commented on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis

2019-01-06 Thread GitBox
wu-sheng commented on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis URL: https://github.com/apache/incubator-skywalking/issues/1805#issuecomment-451829430 OK. Then I am tagging this as `help wanted` and no milestone.

[GitHub] ascrutae edited a comment on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis

2019-01-06 Thread GitBox
ascrutae edited a comment on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis URL: https://github.com/apache/incubator-skywalking/issues/1805#issuecomment-451804156 This idea is fine. but I think this demand is not worth do this currently. Here

[incubator-skywalking-website] branch asf-site updated (e4969ee -> 1654636)

2019-01-06 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard e4969ee Update asf-site new 1654636 Update asf-site This update added new

[incubator-skywalking-website] branch master updated: Update zh main page

2019-01-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 4277501 Update zh

[GitHub] ascrutae commented on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis

2019-01-06 Thread GitBox
ascrutae commented on issue #1805: Support peer in MQ consumer side plugin, backend support that in entry analysis URL: https://github.com/apache/incubator-skywalking/issues/1805#issuecomment-451804156 I think this demand is not worth doing for three reasons. First, the user installs the

[GitHub] wu-sheng closed pull request #2123: Set telemetry module and APIs

2019-01-06 Thread GitBox
wu-sheng closed pull request #2123: Set telemetry module and APIs URL: https://github.com/apache/incubator-skywalking/pull/2123 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-skywalking] branch self-telemetry deleted (was 0b39ddb)

2019-01-06 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch self-telemetry in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 0b39ddb Merge branch 'master' into self-telemetry The revisions that were on this branch

[incubator-skywalking] branch master updated: Set telemetry module and APIs (#2123)

2019-01-06 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new aaa403e Set telemetry module

[GitHub] coveralls edited a comment on issue #2123: Set telemetry module and APIs

2019-01-06 Thread GitBox
coveralls edited a comment on issue #2123: Set telemetry module and APIs URL: https://github.com/apache/incubator-skywalking/pull/2123#issuecomment-451473440 [![Coverage Status](https://coveralls.io/builds/20931492/badge)](https://coveralls.io/builds/20931492) Coverage

[incubator-skywalking] branch self-telemetry updated (bd09876 -> 0b39ddb)

2019-01-06 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch self-telemetry in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from bd09876 Merge branch 'master' into self-telemetry add 745e104 Fix ClassCastException

[GitHub] wu-sheng commented on issue #2097: Runtime Exception:: while loading JDBC at startup

2019-01-06 Thread GitBox
wu-sheng commented on issue #2097: Runtime Exception:: while loading JDBC at startup URL: https://github.com/apache/incubator-skywalking/issues/2097#issuecomment-451742800 @ychandu We also need a demo to reproduce the issue.

[GitHub] dio closed pull request #2: WIP: Hydrate .Command in common.proto

2019-01-06 Thread GitBox
dio closed pull request #2: WIP: Hydrate .Command in common.proto URL: https://github.com/apache/incubator-skywalking-data-collect-protocol/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dio commented on issue #2: WIP: Hydrate .Command in common.proto

2019-01-06 Thread GitBox
dio commented on issue #2: WIP: Hydrate .Command in common.proto URL: https://github.com/apache/incubator-skywalking-data-collect-protocol/pull/2#issuecomment-451739906 This is not necessary, my bad. This is an automated

[GitHub] wu-sheng commented on issue #2110: Exception::org.apache.skywalking.apm.plugin.elasticsearch.v5.ElasticSearchEnhanceInfo.transportAddresses

2019-01-06 Thread GitBox
wu-sheng commented on issue #2110: Exception::org.apache.skywalking.apm.plugin.elasticsearch.v5.ElasticSearchEnhanceInfo.transportAddresses URL: https://github.com/apache/incubator-skywalking/issues/2110#issuecomment-451739065 @ychandu Any demo codes could help us to locate this issue?

[GitHub] wu-sheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families.

2019-01-06 Thread GitBox
wu-sheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families. URL: https://github.com/apache/incubator-skywalking/issues/2039#issuecomment-451736992 From our last discussion, this feature is uncertain, so I put this as

[GitHub] wu-sheng commented on issue #2091: HystrixGatewayFilterFactory$RouteHystrixCommand cannot be cast to EnhancedInstance

2019-01-06 Thread GitBox
wu-sheng commented on issue #2091: HystrixGatewayFilterFactory$RouteHystrixCommand cannot be cast to EnhancedInstance URL: https://github.com/apache/incubator-skywalking/issues/2091#issuecomment-451727503 Trace may break, we don't verify yet. Feedback are welcome.

[GitHub] wu-sheng closed issue #2091: HystrixGatewayFilterFactory$RouteHystrixCommand cannot be cast to EnhancedInstance

2019-01-06 Thread GitBox
wu-sheng closed issue #2091: HystrixGatewayFilterFactory$RouteHystrixCommand cannot be cast to EnhancedInstance URL: https://github.com/apache/incubator-skywalking/issues/2091 This is an automated message from the Apache

[GitHub] ascrutae commented on issue #2091: HystrixGatewayFilterFactory$RouteHystrixCommand cannot be cast to EnhancedInstance

2019-01-06 Thread GitBox
ascrutae commented on issue #2091: HystrixGatewayFilterFactory$RouteHystrixCommand cannot be cast to EnhancedInstance URL: https://github.com/apache/incubator-skywalking/issues/2091#issuecomment-451727418 @xiaoxing598 Let's fix this issue first, This is just a temporary solution. And

[incubator-skywalking] branch master updated: Fix ClassCastException (#2125)

2019-01-06 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 745e104 Fix ClassCastException

[GitHub] wu-sheng closed pull request #2125: Fix ClassCastException

2019-01-06 Thread GitBox
wu-sheng closed pull request #2125: Fix ClassCastException URL: https://github.com/apache/incubator-skywalking/pull/2125 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ascrutae commented on issue #2125: Fix ClassCastException

2019-01-06 Thread GitBox
ascrutae commented on issue #2125: Fix ClassCastException URL: https://github.com/apache/incubator-skywalking/pull/2125#issuecomment-451727104 Ref #2126 This is an automated message from the Apache Git Service. To respond

[GitHub] ascrutae opened a new issue #2126: Attempt to Support Spring gateway

2019-01-06 Thread GitBox
ascrutae opened a new issue #2126: Attempt to Support Spring gateway URL: https://github.com/apache/incubator-skywalking/issues/2126 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] coveralls commented on issue #2125: Fix ClassCastException

2019-01-06 Thread GitBox
coveralls commented on issue #2125: Fix ClassCastException URL: https://github.com/apache/incubator-skywalking/pull/2125#issuecomment-451726059 [![Coverage Status](https://coveralls.io/builds/20925178/badge)](https://coveralls.io/builds/20925178) Coverage decreased (-0.004%) to

[GitHub] ascrutae opened a new pull request #2125: Fix ClassCastException

2019-01-06 Thread GitBox
ascrutae opened a new pull request #2125: Fix ClassCastException URL: https://github.com/apache/incubator-skywalking/pull/2125 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve