[GitHub] [incubator-skywalking] wu-sheng commented on issue #2369: Update powered-by.md

2019-03-15 Thread GitBox
wu-sheng commented on issue #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369#issuecomment-473498992 Ref #443 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-skywalking] SkyWalkingRobot commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME configuration

2019-03-15 Thread GitBox
SkyWalkingRobot commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME configuration URL: https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473496392 Here is the [test

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
wu-sheng commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473489258 > does the order of ContextManager.continued and asyncFinish make any difference? Nothing related.

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473488678 @wu-sheng, everything makes sense when you say it :P. I've added the local span back. I think the last question I have before I repeat this

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472757225 [![Coverage Status](https://coveralls.io/builds/22216950/badge)](https://coveralls.io/builds/22216950) Coverage

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472757225 [![Coverage Status](https://coveralls.io/builds/22216640/badge)](https://coveralls.io/builds/22216640) Coverage

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472757225 [![Coverage Status](https://coveralls.io/builds/22216645/badge)](https://coveralls.io/builds/22216645) Coverage

[incubator-skywalking] branch master updated: Update powered-by.md (#2369)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new e819a80 Update powered-by.md

[incubator-skywalking] branch async-context updated: Update powered-by.md (#2369)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch async-context in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/async-context by this push: new e819a80 Update

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2369: Update powered-by.md

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369#issuecomment-473353845 [![Coverage Status](https://coveralls.io/builds/22216591/badge)](https://coveralls.io/builds/22216591) Coverage increased

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2369: Update powered-by.md

2019-03-15 Thread GitBox
wu-sheng merged pull request #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2369: Update powered-by.md

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369#issuecomment-473353845 [![Coverage Status](https://coveralls.io/builds/22216583/badge)](https://coveralls.io/builds/22216583) Coverage remained the same

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2369: Update powered-by.md

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369#issuecomment-473353845 [![Coverage Status](https://coveralls.io/builds/22216569/badge)](https://coveralls.io/builds/22216569) Coverage remained the same

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME configuration

2019-03-15 Thread GitBox
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME configuration URL: https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473480693 @ascrutae What is the status of the test case PR for this? I hope we could finish that and merge both of them.

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
wu-sheng commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473480457 I am glad we are almost done:) This is an automated message from the Apache

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
wu-sheng commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473480344 > Is that still the case when using the asynchronous functionality? If so, what is the order of events I should be taking? First open the

[GitHub] [incubator-skywalking] BFergerson edited a comment on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
BFergerson edited a comment on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results: ![Screenshot from 2019-03-15

[GitHub] [incubator-skywalking] BFergerson edited a comment on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
BFergerson edited a comment on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results: ![Screenshot from 2019-03-15

[incubator-skywalking] branch async-context updated: Update Trace-Data-Protocol-v2.md (#2367)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch async-context in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/async-context by this push: new 14db2ed Update

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
wu-sheng commented on issue #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-473479514 @BFergerson Yes. `isInAsyncMode` should be set in that way. Merged your change.

[GitHub] [incubator-skywalking] BFergerson edited a comment on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
BFergerson edited a comment on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results: ![Screenshot from 2019-03-15

[GitHub] [incubator-skywalking] BFergerson edited a comment on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
BFergerson edited a comment on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results: ![Screenshot from 2019-03-15

[incubator-skywalking] branch async-context updated: Update apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch async-context in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/async-context by this push: new ad37589 Update

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

2019-03-15 Thread GitBox
BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results: ![Screenshot from 2019-03-15

[GitHub] [incubator-skywalking] BFergerson commented on a change in pull request #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
BFergerson commented on a change in pull request #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#discussion_r266177717 ## File path:

[GitHub] [incubator-skywalking] BFergerson commented on a change in pull request #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
BFergerson commented on a change in pull request #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#discussion_r266177717 ## File path:

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2368: Support Exporter in core

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2368: Support Exporter in core URL: https://github.com/apache/incubator-skywalking/pull/2368#issuecomment-473300660 [![Coverage Status](https://coveralls.io/builds/22208727/badge)](https://coveralls.io/builds/22208727) Coverage decreased

[GitHub] [incubator-skywalking] coveralls commented on issue #2369: Update powered-by.md

2019-03-15 Thread GitBox
coveralls commented on issue #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369#issuecomment-473353845 [![Coverage Status](https://coveralls.io/builds/22207588/badge)](https://coveralls.io/builds/22207588) Coverage increased (+0.002%) to

[incubator-skywalking] branch exporter updated (076be13 -> d3111ec)

2019-03-15 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a change to branch exporter in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from 076be13 Finish the base of exporter. new 05b0498 extract immutable object to reduce garbages

[GitHub] [incubator-skywalking] zouyx opened a new pull request #2369: Update powered-by.md

2019-03-15 Thread GitBox
zouyx opened a new pull request #2369: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2369 update power-by.md Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature

[GitHub] [incubator-skywalking] coveralls commented on issue #2368: Support Exporter in core

2019-03-15 Thread GitBox
coveralls commented on issue #2368: Support Exporter in core URL: https://github.com/apache/incubator-skywalking/pull/2368#issuecomment-473300660 [![Coverage Status](https://coveralls.io/builds/22204534/badge)](https://coveralls.io/builds/22204534) Coverage decreased (-0.006%)

[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2368: Support Exporter in core

2019-03-15 Thread GitBox
wu-sheng opened a new pull request #2368: Support Exporter in core URL: https://github.com/apache/incubator-skywalking/pull/2368 Provide the core bridge to support **exporter** module. I will add implementations later. 1. OC Metric API integration 1. gRPC service our own formats

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2365: Support dubbo 2.7.x

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2365: Support dubbo 2.7.x URL: https://github.com/apache/incubator-skywalking/pull/2365#issuecomment-473178386 [![Coverage Status](https://coveralls.io/builds/22202305/badge)](https://coveralls.io/builds/22202305) Coverage increased (+0.03%)

[GitHub] [incubator-skywalking-website] thebouv commented on issue #42: Fix three minor typos

2019-03-15 Thread GitBox
thebouv commented on issue #42: Fix three minor typos URL: https://github.com/apache/incubator-skywalking-website/pull/42#issuecomment-473263684 My pleasure. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2366: nested exception is java.io.FileNotFoundException: class path resource [com/dangdang/ddframe/job/api/simple/SimpleJob.class] cannot b

2019-03-15 Thread GitBox
wu-sheng commented on issue #2366: nested exception is java.io.FileNotFoundException: class path resource [com/dangdang/ddframe/job/api/simple/SimpleJob.class] cannot be opened because it does not exist URL: https://github.com/apache/incubator-skywalking/issues/2366#issuecomment-473263129

[GitHub] [incubator-skywalking] SkyWalkingRobot commented on issue #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
SkyWalkingRobot commented on issue #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-473251115 Here is the [test

[incubator-skywalking] branch master updated: Update Trace-Data-Protocol-v2.md (#2367)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 14db2ed Update

[incubator-skywalking] branch wu-sheng-patch-1 deleted (was f68047c)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was f68047c Update Trace-Data-Protocol-v2.md The revisions that were on this branch are still

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2367: Doc wrong link

2019-03-15 Thread GitBox
wu-sheng merged pull request #2367: Doc wrong link URL: https://github.com/apache/incubator-skywalking/pull/2367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-skywalking] branch exporter updated: Finish the base of exporter.

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch exporter in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/exporter by this push: new 076be13 Finish the base of

[GitHub] [incubator-skywalking] coveralls commented on issue #2367: Doc wrong link

2019-03-15 Thread GitBox
coveralls commented on issue #2367: Doc wrong link URL: https://github.com/apache/incubator-skywalking/pull/2367#issuecomment-473220147 [![Coverage Status](https://coveralls.io/builds/22199753/badge)](https://coveralls.io/builds/22199753) Coverage increased (+0.002%) to 14.115%

[incubator-skywalking] 01/01: Rename ALarmSupported to WithMetadata

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch exporter in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 6a35309db049150225dbb0f5aea8bedfbc21d577 Author: Wu Sheng AuthorDate: Fri Mar 15 17:27:41 2019 +0800

[incubator-skywalking] branch exporter created (now 6a35309)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch exporter in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at 6a35309 Rename ALarmSupported to WithMetadata This branch includes the following new commits:

[GitHub] [incubator-skywalking] yeerpeng edited a comment on issue #2359: Elasticsearch stores elasticsearch for indexes with history deletion …

2019-03-15 Thread GitBox
yeerpeng edited a comment on issue #2359: Elasticsearch stores elasticsearch for indexes with history deletion … URL: https://github.com/apache/incubator-skywalking/pull/2359#issuecomment-473151743 > Each module provider has its own config. TTL is nothing about you want to build the

[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2367: Doc wrong link

2019-03-15 Thread GitBox
wu-sheng opened a new pull request #2367: Doc wrong link URL: https://github.com/apache/incubator-skywalking/pull/2367 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-skywalking] branch wu-sheng-patch-1 created (now f68047c)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at f68047c Update Trace-Data-Protocol-v2.md This branch includes the following new commits:

[incubator-skywalking] 01/01: Update Trace-Data-Protocol-v2.md

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit f68047c392c274bfa4842716775d07c9ac2e8ea8 Author: 吴晟 Wu Sheng AuthorDate: Fri Mar 15 16:46:04

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2360: Async core APIs in java agent

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2360: Async core APIs in java agent URL: https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472757225 [![Coverage Status](https://coveralls.io/builds/22198994/badge)](https://coveralls.io/builds/22198994) Coverage

[GitHub] [incubator-skywalking] song90625 opened a new issue #2366: nested exception is java.io.FileNotFoundException: class path resource [com/dangdang/ddframe/job/api/simple/SimpleJob.class] cannot

2019-03-15 Thread GitBox
song90625 opened a new issue #2366: nested exception is java.io.FileNotFoundException: class path resource [com/dangdang/ddframe/job/api/simple/SimpleJob.class] cannot be opened because it does not exist URL: https://github.com/apache/incubator-skywalking/issues/2366 Please answer these

[incubator-skywalking] branch async-context updated (5a2b223 -> a48dab5)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch async-context in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from 5a2b223 Merge branch 'async-context' of https://github.com/apache/incubator-skywalking into

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2363: trace not work once the agent trace buffer was full

2019-03-15 Thread GitBox
wu-sheng commented on issue #2363: trace not work once the agent trace buffer was full URL: https://github.com/apache/incubator-skywalking/issues/2363#issuecomment-473179154 If data is in ES, there should be never wrong. Query is very easy, you could simple debug by yourself. Focus on

[GitHub] [incubator-skywalking] zhang98722 commented on issue #2363: trace not work once the agent trace buffer was full

2019-03-15 Thread GitBox
zhang98722 commented on issue #2363: trace not work once the agent trace buffer was full URL: https://github.com/apache/incubator-skywalking/issues/2363#issuecomment-473178673 > > once the agent meet the buffer limit and starting abandon segment like: > > This is our design, it

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2365: Support dubbo 2.7.x

2019-03-15 Thread GitBox
coveralls edited a comment on issue #2365: Support dubbo 2.7.x URL: https://github.com/apache/incubator-skywalking/pull/2365#issuecomment-473178386 [![Coverage Status](https://coveralls.io/builds/22197776/badge)](https://coveralls.io/builds/22197776) Coverage increased (+0.03%)

[GitHub] [incubator-skywalking] coveralls commented on issue #2365: Support dubbo 2.7.x

2019-03-15 Thread GitBox
coveralls commented on issue #2365: Support dubbo 2.7.x URL: https://github.com/apache/incubator-skywalking/pull/2365#issuecomment-473178386 [![Coverage Status](https://coveralls.io/builds/22197769/badge)](https://coveralls.io/builds/22197769) Coverage increased (+0.03%) to

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2365: Support dubbo 2.7.x

2019-03-15 Thread GitBox
wu-sheng commented on issue #2365: Support dubbo 2.7.x URL: https://github.com/apache/incubator-skywalking/pull/2365#issuecomment-473176166 That is an interesting repo to cover our automatical tests dialy. This is an

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2365: Support dubbo 2.7.x

2019-03-15 Thread GitBox
wu-sheng commented on issue #2365: Support dubbo 2.7.x URL: https://github.com/apache/incubator-skywalking/pull/2365#issuecomment-473176084 Please submit tests to here https://github.com/SkyAPMTest/agent-auto-integration-testcases . You could find the document there, and run/check

[incubator-skywalking] branch master updated: extract immutable object to reduce garbages (#2364)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 05b0498 extract immutable

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2364: extract immutable object to reduce garbages

2019-03-15 Thread GitBox
wu-sheng merged pull request #2364: extract immutable object to reduce garbages URL: https://github.com/apache/incubator-skywalking/pull/2364 This is an automated message from the Apache Git Service. To respond to the

[incubator-skywalking-website] branch asf-site updated (6fb0e14 -> f8c7847)

2019-03-15 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard 6fb0e14 Update asf-site new f8c7847 Update asf-site This update added new

[GitHub] [incubator-skywalking] kezhenxu94 opened a new pull request #2365: Support dubbo 2.7.x

2019-03-15 Thread GitBox
kezhenxu94 opened a new pull request #2365: Support dubbo 2.7.x URL: https://github.com/apache/incubator-skywalking/pull/2365 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve

[incubator-skywalking-website] branch master updated: Fix three minor typos (#42)

2019-03-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 649790d Fix three

[GitHub] [incubator-skywalking-website] wu-sheng merged pull request #42: Fix three minor typos

2019-03-15 Thread GitBox
wu-sheng merged pull request #42: Fix three minor typos URL: https://github.com/apache/incubator-skywalking-website/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-skywalking-website] wu-sheng commented on issue #42: Fix three minor typos

2019-03-15 Thread GitBox
wu-sheng commented on issue #42: Fix three minor typos URL: https://github.com/apache/incubator-skywalking-website/pull/42#issuecomment-473169035 Thanks for fixing these typos. This is an automated message from the Apache

[GitHub] [incubator-skywalking] coveralls commented on issue #2364: extract immutable object to reduce garbages

2019-03-15 Thread GitBox
coveralls commented on issue #2364: extract immutable object to reduce garbages URL: https://github.com/apache/incubator-skywalking/pull/2364#issuecomment-473168907 [![Coverage Status](https://coveralls.io/builds/22197299/badge)](https://coveralls.io/builds/22197299) Coverage