[GitHub] [incubator-skywalking] wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin

2019-03-22 Thread GitBox
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-475841883 > I'm able to detect whether the message is going over the wire or being routed locally pretty easily If you can detect that, so you should

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin

2019-03-22 Thread GitBox
coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474659408 [![Coverage Status](https://coveralls.io/builds/22358722/badge)](https://coveralls.io/builds/22358722) Coverage decreased (-0.00

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2395: Support gRPC metric exporter

2019-03-22 Thread GitBox
coveralls edited a comment on issue #2395: Support gRPC metric exporter URL: https://github.com/apache/incubator-skywalking/pull/2395#issuecomment-475410184 [![Coverage Status](https://coveralls.io/builds/22358699/badge)](https://coveralls.io/builds/22358699) Coverage remained t

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin

2019-03-22 Thread GitBox
coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474659408 [![Coverage Status](https://coveralls.io/builds/22358559/badge)](https://coveralls.io/builds/22358559) Coverage decreased (-0.00

[GitHub] [incubator-skywalking] BFergerson commented on issue #2386: Vert.x Core 3.x Plugin

2019-03-22 Thread GitBox
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-475834936 @wu-sheng, why do you think it will be hard to tell whether or not to make an exit span vs a local span? I'm able to detect whether the message i

[incubator-skywalking] branch exporter-impl updated: Wrong host name. (#2397)

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch exporter-impl in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/exporter-impl by this push: new cea04f3 Wrong host

[incubator-skywalking-website] branch asf-site updated (49956c2 -> d519178)

2019-03-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard 49956c2 Update asf-site new d519178 Update asf-site This update added new revisions

[incubator-skywalking] branch wrong-inst-name deleted (was bd05e33)

2019-03-22 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch wrong-inst-name in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was bd05e33 Wrong host name. The revisions that were on this branch are still contained in ot

[GitHub] [incubator-skywalking] hanahmily merged pull request #2397: Mesh bug fix.

2019-03-22 Thread GitBox
hanahmily merged pull request #2397: Mesh bug fix. URL: https://github.com/apache/incubator-skywalking/pull/2397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-skywalking] branch master updated: Wrong host name. (#2397)

2019-03-22 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new cea04f3 Wrong host name. (#239

[incubator-skywalking-website] branch master updated: Use https instead http

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 1e5c5bd Use https inste

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin

2019-03-22 Thread GitBox
coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474659408 [![Coverage Status](https://coveralls.io/builds/22358344/badge)](https://coveralls.io/builds/22358344) Coverage decreased (-0.00

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin

2019-03-22 Thread GitBox
coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474659408 [![Coverage Status](https://coveralls.io/builds/22358146/badge)](https://coveralls.io/builds/22358146) Coverage increased (+0.00

[GitHub] [incubator-skywalking] coveralls commented on issue #2397: Mesh bug fix.

2019-03-22 Thread GitBox
coveralls commented on issue #2397: Mesh bug fix. URL: https://github.com/apache/incubator-skywalking/pull/2397#issuecomment-475828185 [![Coverage Status](https://coveralls.io/builds/22358074/badge)](https://coveralls.io/builds/22358074) Coverage remained the same at 13.763% whe

[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2397: Mesh bug fix.

2019-03-22 Thread GitBox
wu-sheng opened a new pull request #2397: Mesh bug fix. URL: https://github.com/apache/incubator-skywalking/pull/2397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[incubator-skywalking] branch wrong-inst-name created (now bd05e33)

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wrong-inst-name in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at bd05e33 Wrong host name. This branch includes the following new commits: new bd05e33

[incubator-skywalking] 01/01: Wrong host name.

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wrong-inst-name in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit bd05e33f4f5e47435b6014aee7889cd73674fcc1 Author: Wu Sheng AuthorDate: Fri Mar 22 17:50:51 2019 -

[incubator-skywalking-website] branch asf-site updated (4b801c4 -> 49956c2)

2019-03-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard 4b801c4 Update asf-site new 49956c2 Update asf-site This update added new revisions

[incubator-skywalking-website] branch master updated: Remove s

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 3c86b0f Remove s 3c86b0

[incubator-skywalking-website] branch asf-site updated (7bb9421 -> 4b801c4)

2019-03-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard 7bb9421 Update asf-site new 4b801c4 Update asf-site This update added new revisions

[incubator-skywalking-website] branch master updated: Update links

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 1e73733 Update links 1e

[incubator-skywalking-website] branch asf-site updated (f8c7847 -> 7bb9421)

2019-03-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard f8c7847 Update asf-site new 7bb9421 Update asf-site This update added new revisions

[incubator-skywalking-website] branch master updated: Make the latest release highlight.

2019-03-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new ee12cc9 Make the latest

[GitHub] [incubator-skywalking] wu-sheng closed issue #2381: oap docker file error

2019-03-22 Thread GitBox
wu-sheng closed issue #2381: oap docker file error URL: https://github.com/apache/incubator-skywalking/issues/2381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2381: oap docker file error

2019-03-22 Thread GitBox
wu-sheng commented on issue #2381: oap docker file error URL: https://github.com/apache/incubator-skywalking/issues/2381#issuecomment-475786315 I think you should take our k8s config as an example, https://github.com/apache/incubator-skywalking-kubernetes/blob/master/6/6.0.0-GA/oap/03-depl

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2316: agent 6.0.0GA is not compatible with tomcat 7.0.42

2019-03-22 Thread GitBox
wu-sheng commented on issue #2316: agent 6.0.0GA is not compatible with tomcat 7.0.42 URL: https://github.com/apache/incubator-skywalking/issues/2316#issuecomment-475707866 @candyleer From https://github.com/raphw/byte-buddy/issues/629#issuecomment-474058254, I think the safe action we s

[GitHub] [incubator-skywalking] wu-sheng closed issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
wu-sheng closed issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-skywalking] guyukou commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
guyukou commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475550393 > this issue looks like #1947 ,and i found you use LoadBalanced mode,this version of skywalking is not support multihos

[GitHub] [incubator-skywalking] dsc6636926 commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
dsc6636926 commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475536783 this issue looks like #1947 ,and i found you use LoadBalanced mode,this version of skywalking is not support multiho

[GitHub] [incubator-skywalking] guyukou edited a comment on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
guyukou edited a comment on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475528861 ![image](https://user-images.githubusercontent.com/15632270/54808966-c5f15180-4cbc-11e9-8edd-63934ae844ab.png)

[GitHub] [incubator-skywalking] guyukou commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
guyukou commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475528861 ![image](https://user-images.githubusercontent.com/15632270/54808966-c5f15180-4cbc-11e9-8edd-63934ae844ab.png) This

[GitHub] [incubator-skywalking] ascrutae commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
ascrutae commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475526921 If this JDBC4Connection is a proxy object, it could not be enhanced by Skywalking. -

[GitHub] [incubator-skywalking] dsc6636926 commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
dsc6636926 commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475525694 Which version of SkyWalking do you use? JDBC4Connection is subclass of com.mysql.jdbc.ConnectionImpl , and com.mysql

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2380: Downstream command protocol example.

2019-03-22 Thread GitBox
coveralls edited a comment on issue #2380: Downstream command protocol example. URL: https://github.com/apache/incubator-skywalking/pull/2380#issuecomment-474296537 [![Coverage Status](https://coveralls.io/builds/22339157/badge)](https://coveralls.io/builds/22339157) Coverage de

[GitHub] [incubator-skywalking] guyukou commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
guyukou commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475519676 > @guyukou Which driver class of MySQL JDBC did you used in your project? if the driver class is not in enhance list, t

[GitHub] [incubator-skywalking] ascrutae commented on issue #2396: Why JDBC4Connection implements EnhancedInstance?

2019-03-22 Thread GitBox
ascrutae commented on issue #2396: Why JDBC4Connection implements EnhancedInstance? URL: https://github.com/apache/incubator-skywalking/issues/2396#issuecomment-475514463 @guyukou Which driver class of MySQL JDBC did you used in your project? if the driver class is not in enhance list, t