[GitHub] [skywalking] maxiaolong commented on issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet

2019-08-19 Thread GitBox
maxiaolong commented on issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet URL: https://github.com/apache/skywalking/issues/3204#issuecomment-522865770 when i upgrade byte-buddy to the lastest version, the question disappears

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522862073 /run-ci This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522857624 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522857624 /run e2e This is an automated message from the Apache Git Service. To respond to the

[skywalking-website] branch asf-site updated (b33f06f -> aab2232)

2019-08-19 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard b33f06f Update asf-site new aab2232 Update asf-site This update added new revisions after

[skywalking-website] branch master updated: Update README.md

2019-08-19 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new f58c749 Update README.md f58c749

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848882 /run e2e This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848699 /run e2e This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848882 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848699 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
wu-sheng commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522843323 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
wu-sheng commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522842261 Which xml file? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522841657 > @kezhenxu94 What happens in e2e? Strange error saying "premature end of file", perhaps some xml files are broken on some machines

[GitHub] [skywalking] wu-sheng commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
wu-sheng commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522841468 Look like it keeps failing. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522840617 /run e2e This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
wu-sheng commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522840741 @kezhenxu94 What happens in e2e? This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522840617 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng opened a new pull request #3292: Fix TTL issue.

2019-08-19 Thread GitBox
wu-sheng opened a new pull request #3292: Fix TTL issue. URL: https://github.com/apache/skywalking/pull/3292 Description in #3263, I am adding new TTL Calculators for record type, in ES and MySQL storages. W/ this, the TTL should work well in delete record.

[skywalking] 01/01: Fix TTL issue.

2019-08-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch record-ttl in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 27ca9e04c3f1a9ffee6c3d06cfa1bb484bb91979 Author: Wu Sheng AuthorDate: Tue Aug 20 11:29:23 2019 +0800 Fix

[skywalking] branch record-ttl created (now 27ca9e0)

2019-08-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch record-ttl in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 27ca9e0 Fix TTL issue. This branch includes the following new commits: new 27ca9e0 Fix TTL issue.

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522836438 /run e2e This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522836438 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] kezhenxu94 commented on issue #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522833591 Moving the log directory to `tmp` is necessary because the `skywalking-api.log` may still be opened and cannot be deleted at the end of test

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3291: Stabilize unit test

2019-08-19 Thread GitBox
kezhenxu94 opened a new pull request #3291: Stabilize unit test URL: https://github.com/apache/skywalking/pull/3291 The FileWriterTest creates files in the source directory(failed to delete them due to a bug in the `deleteDir` method), making them being checked by checkstyle plugin

[GitHub] [skywalking] wu-sheng closed issue #3289: ui doesn't show dashboard

2019-08-19 Thread GitBox
wu-sheng closed issue #3289: ui doesn't show dashboard URL: https://github.com/apache/skywalking/issues/3289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] wu-sheng commented on issue #3289: ui doesn't show dashboard

2019-08-19 Thread GitBox
wu-sheng commented on issue #3289: ui doesn't show dashboard URL: https://github.com/apache/skywalking/issues/3289#issuecomment-522827968 This error log is not clear. This could be many things. Check all the thing by following the quick start, and test locally.

[skywalking] branch master updated: Add bootstrap-plugin/toolkit-activation to import check list (#3290)

2019-08-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new ca80e45 Add

[GitHub] [skywalking] wu-sheng merged pull request #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
wu-sheng merged pull request #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290 This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522818797 > > > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
kezhenxu94 edited a comment on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522817167 > > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the

[GitHub] [skywalking] kezhenxu94 commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522817167 > > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522816754 > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the modification of

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522815822 /run ci This is an automated message from

[GitHub] [skywalking] kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522815822 /run ci This is an automated message from the

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522815442 > At today, provide a static writer pointer may be safe for now. I am not sure about the future yet. Do you face any real issue about this? Actually not.

[GitHub] [skywalking] kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522814771 /run ci This is an automated message from the

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522814771 /run ci This is an automated message from

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522813284 /run ci This is an automated message from

[GitHub] [skywalking] kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522813284 /run ci This is an automated message from the

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3290: Add bootstrap-plugin/toolkit-activation to import check list

2019-08-19 Thread GitBox
kezhenxu94 opened a new pull request #3290: Add bootstrap-plugin/toolkit-activation to import check list URL: https://github.com/apache/skywalking/pull/3290 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] liudingnet opened a new issue #3289: ui doesn't show dashboard

2019-08-19 Thread GitBox
liudingnet opened a new issue #3289: ui doesn't show dashboard URL: https://github.com/apache/skywalking/issues/3289 skywalking6.2.0 & 6.3.0 ui doesn't show the dashaboard, seeing the screen capture.

[GitHub] [skywalking] zhaoyuguang commented on issue #2720: Provide plugin for kafka-v2-plugin

2019-08-19 Thread GitBox
zhaoyuguang commented on issue #2720: Provide plugin for kafka-v2-plugin URL: https://github.com/apache/skywalking/issues/2720#issuecomment-522783474 I haven't do it yet. Welcome to contribute. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #2720: Provide plugin for kafka-v2-plugin

2019-08-19 Thread GitBox
wu-sheng commented on issue #2720: Provide plugin for kafka-v2-plugin URL: https://github.com/apache/skywalking/issues/2720#issuecomment-522639844 I think he hasn't. Welcome to do. FYI @zhaoyuguang This is an automated

[GitHub] [skywalking] dmsolr commented on issue #2720: Provide plugin for kafka-v2-plugin

2019-08-19 Thread GitBox
dmsolr commented on issue #2720: Provide plugin for kafka-v2-plugin URL: https://github.com/apache/skywalking/issues/2720#issuecomment-522636563 @zhaoyuguang Do you work in progress that? May I join in? This is an automated

[GitHub] [skywalking] dmsolr commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported

2019-08-19 Thread GitBox
dmsolr commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported URL: https://github.com/apache/skywalking/pull/3284#discussion_r315261513 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3207: Support play 2.x

2019-08-19 Thread GitBox
wu-sheng commented on issue #3207: Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#issuecomment-522617896 @aiyanbo Update? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng closed issue #3288: Is there any plan for the C++ client ?

2019-08-19 Thread GitBox
wu-sheng closed issue #3288: Is there any plan for the C++ client ? URL: https://github.com/apache/skywalking/issues/3288 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on issue #3288: Is there any plan for the C++ client ?

2019-08-19 Thread GitBox
wu-sheng commented on issue #3288: Is there any plan for the C++ client ? URL: https://github.com/apache/skywalking/issues/3288#issuecomment-522604744 We don't have core maintainer in C++. Are you interested in this? Duplicated #2443

[GitHub] [skywalking] wu-sheng commented on issue #3273: Support Zookeeper ACL

2019-08-19 Thread GitBox
wu-sheng commented on issue #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#issuecomment-522594992 @dmsolr One mode is good for me. Make sure it is clear at document. This is an automated

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported

2019-08-19 Thread GitBox
kezhenxu94 commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported URL: https://github.com/apache/skywalking/pull/3284#discussion_r315231688 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported

2019-08-19 Thread GitBox
wu-sheng commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported URL: https://github.com/apache/skywalking/pull/3284#discussion_r315229140 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wu-sheng commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522588336 At today, provide a static writer pointer may be safe for now. I am not sure about the future yet. Do you face any real issue about this?

[GitHub] [skywalking] kezhenxu94 merged pull request #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 merged pull request #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking] branch master updated (8888029 -> fd7044e)

2019-08-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 029 Module config set override is not working (#3283) new 8024bea Add cluster etcd config to

[GitHub] [skywalking] BinWu1989 opened a new issue #3288: Is there any plan for the C++ client ?

2019-08-19 Thread GitBox
BinWu1989 opened a new issue #3288: Is there any plan for the C++ client ? URL: https://github.com/apache/skywalking/issues/3288 @wu-sheng Dear WuSheng , As the official document, currently skywalking doesn't have an client for C++ ,Is there any plan to support C++ in the near

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported

2019-08-19 Thread GitBox
kezhenxu94 commented on a change in pull request #3284: Log4j2 support AsyncRoot print tid. All versions above 2.0 supported URL: https://github.com/apache/skywalking/pull/3284#discussion_r315179642 ## File path:

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522527542 /run ci This is an automated message from the Apache Git Service.

[GitHub] [skywalking] kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522527542 /run ci This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522524368 /run ci This is an automated message from the Apache Git Service.

[GitHub] [skywalking] kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522524368 /run ci This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] spurtAndy commented on issue #3285: How to do agent hot loading

2019-08-19 Thread GitBox
spurtAndy commented on issue #3285: How to do agent hot loading URL: https://github.com/apache/skywalking/issues/3285#issuecomment-522506904 3Q This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522499651 /run ci This is an automated message from the Apache Git Service.

[GitHub] [skywalking] kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522499651 /run ci This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wayilau opened a new pull request #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau opened a new pull request #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improve performance

[GitHub] [skywalking] wayilau commented on a change in pull request #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
wayilau commented on a change in pull request #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#discussion_r315094753 ## File path: docs/en/setup/backend/backend-cluster.md ## @@ -90,4 +90,17 @@ cluster: serviceName:

[GitHub] [skywalking] wayilau commented on a change in pull request #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
wayilau commented on a change in pull request #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#discussion_r315092504 ## File path: docs/en/setup/backend/backend-cluster.md ## @@ -90,4 +90,17 @@ cluster: serviceName:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
kezhenxu94 commented on a change in pull request #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286#discussion_r315090002 ## File path: docs/en/setup/backend/backend-cluster.md ## @@ -90,4 +90,17 @@ cluster: serviceName:

[GitHub] [skywalking] kezhenxu94 closed issue #3285: How to do agent hot loading

2019-08-19 Thread GitBox
kezhenxu94 closed issue #3285: How to do agent hot loading URL: https://github.com/apache/skywalking/issues/3285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] kezhenxu94 commented on issue #3285: How to do agent hot loading

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3285: How to do agent hot loading URL: https://github.com/apache/skywalking/issues/3285#issuecomment-522462980 We don't support this This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wayilau opened a new pull request #3286: Add cluster etcd config to cluster.md.

2019-08-19 Thread GitBox
wayilau opened a new pull request #3286: Add cluster etcd config to cluster.md. URL: https://github.com/apache/skywalking/pull/3286 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ]

[GitHub] [skywalking] spurtAndy opened a new issue #3285: The agent thermal loading

2019-08-19 Thread GitBox
spurtAndy opened a new issue #3285: The agent thermal loading URL: https://github.com/apache/skywalking/issues/3285 as title This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] dmsolr commented on issue #3273: Support Zookeeper ACL

2019-08-19 Thread GitBox
dmsolr commented on issue #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#issuecomment-522436839 How do you think? @wu-sheng @kezhenxu94 This is an automated message from the Apache Git

[GitHub] [skywalking] dmsolr commented on issue #3273: Support Zookeeper ACL

2019-08-19 Thread GitBox
dmsolr commented on issue #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#issuecomment-522436577 I think whether we support `digest` only. Because `digest` is more widely used, and it is more clear.

[GitHub] [skywalking] dmsolr commented on issue #3273: Support Zookeeper ACL

2019-08-19 Thread GitBox
dmsolr commented on issue #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#issuecomment-522430444 We use Zookeeper ACL that has 2 steps, 1. set ACL for `zNode`. 2. authorization, like `login`. `IP` schema, we need not `authorization` step. But I